)]}'
{"id":"openstack%2Fpython-cinderclient~444591","triplet_id":"openstack%2Fpython-cinderclient~master~I65108576493e7fa28c0bf459129b6cc0999cf373","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1670123","hashtags":[],"change_id":"I65108576493e7fa28c0bf459129b6cc0999cf373","subject":"delete bash_completion in subcommand","status":"ABANDONED","created":"2017-03-11 15:45:49.000000000","updated":"2018-02-12 20:29:22.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ccb7ab01d092e6ee92d4769f03b6268aada8a53a","_number":444591,"virtual_id_number":444591,"owner":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-09-08 16:29:07.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2017-03-11 16:51:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"date":"2017-05-27 08:36:44.000000000","_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-05-25 17:37:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":-1,"date":"2017-06-15 19:44:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-11 16:51:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-25 17:37:44.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2017-06-15 19:44:22.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2017-09-08 16:29:07.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"271b890555837e9a739f6ea66b416887fcb70cbe","author":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"date":"2017-03-11 15:45:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e0be0a257b0ad9415684529d025eba15bdbf86bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-11 16:51:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/91/444591/1/check/gate-python-cinderclient-docs-ubuntu-xenial/a5635ee//doc/build/html/ : SUCCESS in 3m 31s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/91/444591/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/c75d2c9/ : SUCCESS in 2m 23s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/91/444591/1/check/gate-python-cinderclient-python27-ubuntu-xenial/d60d35e/ : SUCCESS in 3m 33s\n- gate-python-cinderclient-python35 http://logs.openstack.org/91/444591/1/check/gate-python-cinderclient-python35/87fe83e/ : SUCCESS in 2m 04s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/91/444591/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/64572cf/ : SUCCESS in 1h 05m 51s\n- gate-python-cinderclient-pypy http://logs.openstack.org/91/444591/1/check/gate-python-cinderclient-pypy/8173c3a/ : SUCCESS in 2m 33s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/91/444591/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/d6745b2/ : FAILURE in 17m 47s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/91/444591/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/9bf90b3/ : FAILURE in 17m 37s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/91/444591/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/dca6c09/ : SUCCESS in 3m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"81f2cf9aefe8c535b23de8a3cdf27992f63a1685","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-05-25 17:37:44.000000000","message":"Patch Set 1: Code-Review-1\n\n\u0027cinder bash_completion\u0027 works just as \u0027cinder bash-completion\u0027 does. This is the common pattern for optional paramaters, to include both the dash and underline versions.\nI\u0027m not sure that is safe for all users to delete this.","accounts_in_message":[],"_revision_number":1},{"id":"f1aa22df0fddf38eb9e66e71480a896332a9d9e1","author":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"date":"2017-05-27 08:36:44.000000000","message":"Patch Set 1:\n\n\u003e \u0027cinder bash_completion\u0027 works just as \u0027cinder bash-completion\u0027\n \u003e does. This is the common pattern for optional paramaters, to\n \u003e include both the dash and underline versions.\n \u003e I\u0027m not sure that is safe for all users to delete this.\n\nbut i cannot find \"bash_completion\" in help information. and \n\n \u003e \u0027cinder bash_completion\u0027 works just as \u0027cinder bash-completion\u0027\n \u003e does. This is the common pattern for optional paramaters, to\n \u003e include both the dash and underline versions.\n \u003e I\u0027m not sure that is safe for all users to delete this.\n\nbash_completion cannot be found in cinder\u0027s help, and bash_complrtion call entry is code-written, but bash-completion call entry and help information are created automatically according to the \"do_\" rule. In order to better promote bash-completion and its rational use, i think the bash_completion should be deleted.","accounts_in_message":[],"_revision_number":1},{"id":"e8b8ace9617b8f9185ea545eeee6718a3ea93e63","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-06-05 13:15:20.000000000","message":"Patch Set 1:\n\nEven if something is undocumented in the help, someone may be using it.\nWe cannot just remove something without deprecation.\nIF you\u0027d like, you could add the missing help entry.\nAlso, you could re-factor the code so that it worked like other commands that have both dash and underline versions.","accounts_in_message":[],"_revision_number":1},{"id":"eeac2b6e3d3991ab12faefe89877a134a8a619f3","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-06-15 19:44:22.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8de66cf87fd078d985edbb41d5afba13ee9a493b","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-06-15 19:45:04.000000000","message":"Patch Set 1:\n\nAnd, \"bash_completion\" is not in the help on purpose.  It\u0027s not an end-user command, and we don\u0027t need to list both bash-completion and bash_completion in help.","accounts_in_message":[],"_revision_number":1},{"id":"4129c34709fa49cd11929709b99dc7309ad92206","author":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"date":"2017-07-04 01:12:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0aa9f01f5a757a2f57e90a5f28c1c31caeaa3251","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-09-08 16:29:07.000000000","message":"Patch Set 1:\n\nAny updates?","accounts_in_message":[],"_revision_number":1},{"id":"9739b79c87abcd12c9f8abf87e54dec43e83fcd0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-02-12 20:29:22.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"109cb2612214cf73e1fb57aacb15c170e2bbe47b","revisions":{"109cb2612214cf73e1fb57aacb15c170e2bbe47b":{"kind":"REWORK","_number":1,"created":"2017-03-11 15:45:49.000000000","uploader":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"ref":"refs/changes/91/444591/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/91/444591/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/91/444591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/91/444591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/91/444591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/91/444591/1"}}},"commit":{"parents":[{"commit":"6c499cc6a5dcb663bdc6ba7246114afcc21aface","subject":"Merge \"Make V3 the default and fixup version reporting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6c499cc6a5dcb663bdc6ba7246114afcc21aface"}]}],"author":{"name":"ForestLee","email":"lichl@hotmail.com","date":"2017-03-11 15:44:35.000000000","tz":480},"committer":{"name":"ForestLee","email":"lichl@hotmail.com","date":"2017-03-11 15:45:45.000000000","tz":480},"subject":"delete bash_completion in subcommand","message":"delete bash_completion in subcommand\n\nThere are two \"completion\" in the subcommand table: bash-completion\nand bash_completion. but \"bash_completion\" is useless, so delete\nit and extra code.\n\nChange-Id: I65108576493e7fa28c0bf459129b6cc0999cf373\nCloses-Bug: #1670123\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/109cb2612214cf73e1fb57aacb15c170e2bbe47b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/109cb2612214cf73e1fb57aacb15c170e2bbe47b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}