)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1210e46af177b62ecdaf500acfc26e9aca99c450","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-14 15:14:17 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update README.rst to remain consistent with python-cinderclient."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id81eb1c6b0723667bb725b6dabbe7a886a6c7f03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a22e58a_aee8f617","line":8,"updated":"2017-03-14 09:29:10.000000000","message":"Could you add some description about what you change in this patch?  That will help reviewers to understand what this patch want to do. Thanks","commit_id":"f296abb7dc2de61919eb6da3f75113d71fc0ede8"},{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"b6cbb72a7cb362757e1d0d5962f0da096cfc4b32","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update README.rst to remain consistent with python-cinderclient."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The latest python-cinderclient version is 2.0.0, but the content of"},{"line_number":10,"context_line":"project README file is out-of-date. So update README.rst to remain"},{"line_number":11,"context_line":"consistent with python-cinderclient. The changes are as follows:"},{"line_number":12,"context_line":"1. Update OS_AUTH_URL to use Keystone url."},{"line_number":13,"context_line":"2. Modify OS_VOLUME_API_VERSION to 3(Since API V2 is offical deprecated)."},{"line_number":14,"context_line":"3. Update \"cinder help\" output."},{"line_number":15,"context_line":"4. Update python api usage."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id81eb1c6b0723667bb725b6dabbe7a886a6c7f03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a22e58a_64345fde","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":27},"updated":"2017-03-14 10:06:22.000000000","message":"Add more details about this patch.","commit_id":"05b73d86000cabdde6582b341082b999707d1d3d"}],"README.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e12b90910e02069d6da1db0e915d030396a85c97","unresolved":false,"context_lines":[{"line_number":81,"context_line":"and the version of the API with ``--os-volume-api-version``. Or set them as"},{"line_number":82,"context_line":"environment variables as well. Since Block Storage API V2 is officially"},{"line_number":83,"context_line":"deprecated, you can set ``OS_VOLUME_API_VERSION\u003d3``. If you are using Keystone,"},{"line_number":84,"context_line":"you need to set the ``OS_AUTH_URL`` to the keystone endpoint. For the ``admin``"},{"line_number":85,"context_line":"user in the Identity service, set::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    export OS_AUTH_URL\u003dhttp://controller:35357/v3"},{"line_number":88,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"For the ``demo`` user (non-admin user) in the Identity service, set::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    export OS_AUTH_URL\u003dhttp://controller.com:5000/v3"},{"line_number":93,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Since Keystone can return multiple regions in the Service Catalog, you"},{"line_number":96,"context_line":"can specify the one you want with ``--os-region-name`` (or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a22e58a_a255671e","line":93,"range":{"start_line":84,"start_character":0,"end_line":93,"end_character":34},"updated":"2017-03-14 11:05:45.000000000","message":"-1: I believe on V3 both could be using port 5000/v3","commit_id":"05b73d86000cabdde6582b341082b999707d1d3d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"682ec38af4cdc352a15920fd2f6127df14d37740","unresolved":false,"context_lines":[{"line_number":81,"context_line":"and the version of the API with ``--os-volume-api-version``. Or set them as"},{"line_number":82,"context_line":"environment variables as well. Since Block Storage API V2 is officially"},{"line_number":83,"context_line":"deprecated, you can set ``OS_VOLUME_API_VERSION\u003d3``. If you are using Keystone,"},{"line_number":84,"context_line":"you need to set the ``OS_AUTH_URL`` to the keystone endpoint. For the ``admin``"},{"line_number":85,"context_line":"user in the Identity service, set::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    export OS_AUTH_URL\u003dhttp://controller:35357/v3"},{"line_number":88,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"For the ``demo`` user (non-admin user) in the Identity service, set::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    export OS_AUTH_URL\u003dhttp://controller.com:5000/v3"},{"line_number":93,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Since Keystone can return multiple regions in the Service Catalog, you"},{"line_number":96,"context_line":"can specify the one you want with ``--os-region-name`` (or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_b923bc04","line":93,"range":{"start_line":84,"start_character":0,"end_line":93,"end_character":34},"in_reply_to":"3a1ff146_70096e31","updated":"2017-03-15 12:19:44.000000000","message":"You are using a V3 urls in both cases, therefore you don\u0027t care about the V2 having different REST API entrypoints available on each port.  We should use 5000 directly when using v3.","commit_id":"05b73d86000cabdde6582b341082b999707d1d3d"},{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"45e97e82529176308b105284711b661e5c415eba","unresolved":false,"context_lines":[{"line_number":81,"context_line":"and the version of the API with ``--os-volume-api-version``. Or set them as"},{"line_number":82,"context_line":"environment variables as well. Since Block Storage API V2 is officially"},{"line_number":83,"context_line":"deprecated, you can set ``OS_VOLUME_API_VERSION\u003d3``. If you are using Keystone,"},{"line_number":84,"context_line":"you need to set the ``OS_AUTH_URL`` to the keystone endpoint. For the ``admin``"},{"line_number":85,"context_line":"user in the Identity service, set::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    export OS_AUTH_URL\u003dhttp://controller:35357/v3"},{"line_number":88,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"For the ``demo`` user (non-admin user) in the Identity service, set::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    export OS_AUTH_URL\u003dhttp://controller.com:5000/v3"},{"line_number":93,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Since Keystone can return multiple regions in the Service Catalog, you"},{"line_number":96,"context_line":"can specify the one you want with ``--os-region-name`` (or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_8c506460","line":93,"range":{"start_line":84,"start_character":0,"end_line":93,"end_character":34},"in_reply_to":"3a1ff146_b923bc04","updated":"2017-03-15 23:35:21.000000000","message":"OK, I will modify the port as your suggestion. Thank you! :)","commit_id":"05b73d86000cabdde6582b341082b999707d1d3d"},{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"188f4a78be70dccb1233cabd6907ef4ae2373452","unresolved":false,"context_lines":[{"line_number":81,"context_line":"and the version of the API with ``--os-volume-api-version``. Or set them as"},{"line_number":82,"context_line":"environment variables as well. Since Block Storage API V2 is officially"},{"line_number":83,"context_line":"deprecated, you can set ``OS_VOLUME_API_VERSION\u003d3``. If you are using Keystone,"},{"line_number":84,"context_line":"you need to set the ``OS_AUTH_URL`` to the keystone endpoint. For the ``admin``"},{"line_number":85,"context_line":"user in the Identity service, set::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    export OS_AUTH_URL\u003dhttp://controller:35357/v3"},{"line_number":88,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"For the ``demo`` user (non-admin user) in the Identity service, set::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    export OS_AUTH_URL\u003dhttp://controller.com:5000/v3"},{"line_number":93,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Since Keystone can return multiple regions in the Service Catalog, you"},{"line_number":96,"context_line":"can specify the one you want with ``--os-region-name`` (or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_90e50aaa","line":93,"range":{"start_line":84,"start_character":0,"end_line":93,"end_character":34},"in_reply_to":"5a22e58a_a255671e","updated":"2017-03-14 23:57:33.000000000","message":"Firstly, thank you for reviewing my patch. Do you mean keystone v3 api both use 5000/v3, or cinder api v3? If you talk about keystone api, according to OpenStack Installation Tutorial(https://docs.openstack.org/ocata/install-guide-rdo/keystone.html), adminitrator account use 35357/v3, and non-admin account use 5000/v3.","commit_id":"05b73d86000cabdde6582b341082b999707d1d3d"},{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"cad869a8f5be9bcba43651dd7d9302bb49289e02","unresolved":false,"context_lines":[{"line_number":81,"context_line":"and the version of the API with ``--os-volume-api-version``. Or set them as"},{"line_number":82,"context_line":"environment variables as well. Since Block Storage API V2 is officially"},{"line_number":83,"context_line":"deprecated, you can set ``OS_VOLUME_API_VERSION\u003d3``. If you are using Keystone,"},{"line_number":84,"context_line":"you need to set the ``OS_AUTH_URL`` to the keystone endpoint. For the ``admin``"},{"line_number":85,"context_line":"user in the Identity service, set::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    export OS_AUTH_URL\u003dhttp://controller:35357/v3"},{"line_number":88,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"For the ``demo`` user (non-admin user) in the Identity service, set::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    export OS_AUTH_URL\u003dhttp://controller.com:5000/v3"},{"line_number":93,"context_line":"    export OS_VOLUME_API_VERSION\u003d3"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Since Keystone can return multiple regions in the Service Catalog, you"},{"line_number":96,"context_line":"can specify the one you want with ``--os-region-name`` (or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_70096e31","line":93,"range":{"start_line":84,"start_character":0,"end_line":93,"end_character":34},"in_reply_to":"5a22e58a_a255671e","updated":"2017-03-15 01:21:54.000000000","message":"Indeed in keystone v3 both ports offer the same functions. Since v2 listens on 2 ports, I think it\u0027s better to distinguish the two ports useage till v2 is removed fully. May be my description in the patch is not accurate. It should be \"administrator role\" use 35357/v3, and \"member role\" use 5000/v3. Dear Gorka, what do you think?   :)","commit_id":"05b73d86000cabdde6582b341082b999707d1d3d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62666881691fe1c692f9fb978d5764be01e86e9c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"You\u0027ll find complete documentation on the shell by running"},{"line_number":95,"context_line":"``cinder help``::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    usage: cinder [--version] [-d] [--os-auth-system \u003cauth-system\u003e]"},{"line_number":98,"context_line":"                  [--service-type \u003cservice-type\u003e] [--service-name \u003cservice-name\u003e]"},{"line_number":99,"context_line":"                  [--volume-service-name \u003cvolume-service-name\u003e]"},{"line_number":100,"context_line":"                  [--os-endpoint-type \u003cos-endpoint-type\u003e]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_24d0ebf5","line":97,"updated":"2017-03-22 14:43:42.000000000","message":"I wonder if we should just remove the help output from here. It\u0027s bound to get out of date again, and the latest can always be found by actually running \"cinder help\".\n\nGood for now though.","commit_id":"31a7ba7b3cfea1778a7240e8789c4ea5b7de061e"}]}