)]}'
{"id":"openstack%2Fpython-cinderclient~449776","triplet_id":"openstack%2Fpython-cinderclient~master~I1bd2b7657ec577b9775eacd163cfdf6eb6b6eab2","project":"openstack/python-cinderclient","branch":"master","hashtags":[],"change_id":"I1bd2b7657ec577b9775eacd163cfdf6eb6b6eab2","subject":"Handle dashes in encryption-type-create arguments","status":"MERGED","created":"2017-03-24 18:31:05.000000000","updated":"2017-05-24 15:46:56.000000000","submitted":"2017-05-24 15:46:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e59816c0307c41222d2296661bccc4ec68fae6b9","_number":449776,"virtual_id_number":449776,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":2,"date":"2017-05-24 15:46:56.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-05-24 13:52:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-05-24 13:09:57.000000000","_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-05-24 13:52:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-30 09:58:19.000000000","updated_by":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"reviewer":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"state":"REVIEWER"},{"updated":"2017-05-23 14:30:23.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2017-05-24 08:35:15.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2017-05-24 13:09:57.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2017-05-24 13:52:12.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-05-24 15:46:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"62a90b103dbe6a1513f2b88f02b6f77c003f8e75","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-03-24 18:31:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8580951e07e7317da9877e037327e1344a6d8862","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-24 19:47:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/449776/1/check/gate-python-cinderclient-docs-ubuntu-xenial/4c2b8e1//doc/build/html/ : SUCCESS in 4m 15s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/76/449776/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/c814b1c/ : SUCCESS in 4m 45s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/76/449776/1/check/gate-python-cinderclient-python27-ubuntu-xenial/56487df/ : SUCCESS in 4m 45s\n- gate-python-cinderclient-python35 http://logs.openstack.org/76/449776/1/check/gate-python-cinderclient-python35/8b23397/ : SUCCESS in 4m 27s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/76/449776/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/a55fd88/ : SUCCESS in 1h 10m 44s\n- gate-python-cinderclient-pypy http://logs.openstack.org/76/449776/1/check/gate-python-cinderclient-pypy/5b3939c/ : SUCCESS in 4m 23s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/76/449776/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/6ad03b6/ : SUCCESS in 27m 03s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/76/449776/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/b673290/ : SUCCESS in 17m 15s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/76/449776/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/4db67d3/ : SUCCESS in 3m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a47f70715f3b64d435e9445491d92e6ceeda1d93","author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"date":"2017-03-30 09:58:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThe patch seems ok, but tests)","accounts_in_message":[],"_revision_number":1},{"id":"c9dbe1239d6d937fbdefdc2a3f9fd8e1daa7e217","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-04-10 19:36:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c5143675b1d6a2fbaef1e6441428fb4d7c3f959d","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-05-01 13:43:45.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"838f439b4134eb8d965ee353ae42861c6c19c602","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-05-01 13:44:12.000000000","message":"Topic 449775 removed","accounts_in_message":[],"_revision_number":2},{"id":"70ec64c6a41928548e3034ef7e2e5c89daa36b91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-01 14:59:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/449776/2/check/gate-python-cinderclient-docs-ubuntu-xenial/ffc4093//doc/build/html/ : SUCCESS in 2m 43s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/76/449776/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/92c174b/ : SUCCESS in 4m 26s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/76/449776/2/check/gate-python-cinderclient-python27-ubuntu-xenial/bddf26e/ : SUCCESS in 4m 44s\n- gate-python-cinderclient-python35 http://logs.openstack.org/76/449776/2/check/gate-python-cinderclient-python35/b32568f/ : SUCCESS in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/76/449776/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/f9937b3/ : SUCCESS in 1h 11m 41s\n- gate-python-cinderclient-pypy http://logs.openstack.org/76/449776/2/check/gate-python-cinderclient-pypy/94f4fc6/ : SUCCESS in 2m 34s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/76/449776/2/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/fd21482/ : FAILURE in 25m 42s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/76/449776/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/2c0438e/ : FAILURE in 23m 51s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/76/449776/2/check/gate-python-cinderclient-pylint-ubuntu-xenial/7f8a3b6/ : SUCCESS in 3m 56s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d065598dbbad94c1ea3248defe654e29b01f39d8","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-05-19 21:08:12.000000000","message":"Patch Set 2: Code-Review+2\n\nI do think ddt could be used, but that\u0027s a minor optimization. I\u0027d rather see this get in, so I\u0027m fine with it as is unless there\u0027s a reason to update for something else.","accounts_in_message":[],"_revision_number":2},{"id":"c2368b5d60cc9d2f757e7c04cbdcd19041f44669","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-05-24 08:35:15.000000000","message":"Patch Set 2: Code-Review+1\n\nI agree that this is a perfect case for using ddt and we would decrease our test code while making it more clear that the expected result is the same regardless of the argument keys used.","accounts_in_message":[],"_revision_number":2},{"id":"b34a59ffe97b49448263af4bbdd421582b7f027f","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-05-24 13:05:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2143373916e85db998174881a3abf53109f4c047","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-05-24 13:06:13.000000000","message":"Topic 449776 removed","accounts_in_message":[],"_revision_number":3},{"id":"d8735188c5039d47d25870a78db101d199c6a501","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-05-24 13:09:57.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"043fea5ec033240c62881d8554613957ea07fd29","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-05-24 13:52:12.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"80360bbca8ce3104af65eadf39e34575f2c34567","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 14:24:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/449776/3/check/gate-python-cinderclient-docs-ubuntu-xenial/81aae2f//doc/build/html/ : SUCCESS in 2m 42s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/76/449776/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/5838488/ : SUCCESS in 2m 43s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/76/449776/3/check/gate-python-cinderclient-python27-ubuntu-xenial/d7693ac/ : SUCCESS in 2m 17s\n- gate-python-cinderclient-python35 http://logs.openstack.org/76/449776/3/check/gate-python-cinderclient-python35/2ee0183/ : SUCCESS in 3m 23s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/76/449776/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/6e899a6/ : SUCCESS in 1h 17m 17s\n- gate-python-cinderclient-pypy http://logs.openstack.org/76/449776/3/check/gate-python-cinderclient-pypy/03c14b6/ : SUCCESS in 4m 33s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/76/449776/3/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/eb3414f/ : FAILURE in 30m 55s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/76/449776/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/abaf0dc/ : FAILURE in 27m 00s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/76/449776/3/check/gate-python-cinderclient-pylint-ubuntu-xenial/0c6920c/ : SUCCESS in 3m 55s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"81c4dfa9b49df772ba9be9cfbf98a5dddf803950","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 14:24:58.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"645762619fc40bebfdd41011a92a9198a79e51ff","date":"2017-05-24 15:46:56.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"e59816c0307c41222d2296661bccc4ec68fae6b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 15:46:56.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/449776/3/gate/gate-python-cinderclient-docs-ubuntu-xenial/6f54901//doc/build/html/ : SUCCESS in 3m 21s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/76/449776/3/gate/gate-python-cinderclient-pep8-ubuntu-xenial/36cd015/ : SUCCESS in 4m 48s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/76/449776/3/gate/gate-python-cinderclient-python27-ubuntu-xenial/7b9fe1d/ : SUCCESS in 3m 34s\n- gate-python-cinderclient-python35 http://logs.openstack.org/76/449776/3/gate/gate-python-cinderclient-python35/682e9b9/ : SUCCESS in 3m 26s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/76/449776/3/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/17e7c6c/ : SUCCESS in 1h 20m 52s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"69f0090b65be88c93691f89dc1cd3e9f8e2a5ee0","revisions":{"542304226af1e4b29ad6b7a5836be191dba1ac0a":{"kind":"REWORK","_number":1,"created":"2017-03-24 18:31:05.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/76/449776/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/76/449776/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/1"}}},"commit":{"parents":[{"commit":"ed91b14d8d899a0d252d6f2438c8b53d717eba2b","subject":"Tests: Add info to assert_called failure message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/ed91b14d8d899a0d252d6f2438c8b53d717eba2b"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2017-03-24 17:39:56.000000000","tz":-240},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2017-03-24 18:33:46.000000000","tz":-240},"subject":"Handle dashes in encryption-type-create arguments","message":"Handle dashes in encryption-type-create arguments\n\nencryption-type-create currently takes args \"--key_size\"\nand \"--control_location\".\n\nOur standard is to use dashes rather than underscores for\narguments like this, because it\u0027s easier to type them.\n\nAdditionally, encryption-type-update already uses\n\"--key-size\" and \"--control-location\" for the same args.\n\nThis adds the dashed versions to the CLI and makes them the\ndefault shown in the help.  The underscore versions are\nretained for compatibility.\n\nAlso removes redundant \"(Optional)\" text for arguments listed\nunder \"Optional Arguments\".  This matches other commands.\n\nChange-Id: I1bd2b7657ec577b9775eacd163cfdf6eb6b6eab2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/542304226af1e4b29ad6b7a5836be191dba1ac0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/542304226af1e4b29ad6b7a5836be191dba1ac0a"}]},"branch":"refs/heads/master"},"077221c7e536cc28c8ccd1c6c165d9b32947c199":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-05-01 13:43:45.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/76/449776/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/76/449776/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/2"}}},"commit":{"parents":[{"commit":"371831ae7d1e8c6377d17b9ab8e3ae37e09366bb","subject":"Tests: Add info to assert_called failure message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/371831ae7d1e8c6377d17b9ab8e3ae37e09366bb"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2017-03-24 17:39:56.000000000","tz":-240},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2017-05-01 13:42:41.000000000","tz":-240},"subject":"Handle dashes in encryption-type-create arguments","message":"Handle dashes in encryption-type-create arguments\n\nencryption-type-create currently takes args \"--key_size\"\nand \"--control_location\".\n\nOur standard is to use dashes rather than underscores for\narguments like this, because it\u0027s easier to type them.\n\nAdditionally, encryption-type-update already uses\n\"--key-size\" and \"--control-location\" for the same args.\n\nThis adds the dashed versions to the CLI and makes them the\ndefault shown in the help.  The underscore versions are\nretained for compatibility.\n\nAlso removes redundant \"(Optional)\" text for arguments listed\nunder \"Optional Arguments\".  This matches other commands.\n\nChange-Id: I1bd2b7657ec577b9775eacd163cfdf6eb6b6eab2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/077221c7e536cc28c8ccd1c6c165d9b32947c199"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/077221c7e536cc28c8ccd1c6c165d9b32947c199"}]},"branch":"refs/heads/master"},"69f0090b65be88c93691f89dc1cd3e9f8e2a5ee0":{"kind":"REWORK","_number":3,"created":"2017-05-24 13:05:53.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/76/449776/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/76/449776/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/76/449776/3"}}},"commit":{"parents":[{"commit":"371831ae7d1e8c6377d17b9ab8e3ae37e09366bb","subject":"Tests: Add info to assert_called failure message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/371831ae7d1e8c6377d17b9ab8e3ae37e09366bb"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2017-03-24 17:39:56.000000000","tz":-240},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2017-05-24 13:04:50.000000000","tz":-240},"subject":"Handle dashes in encryption-type-create arguments","message":"Handle dashes in encryption-type-create arguments\n\nencryption-type-create currently takes args \"--key_size\"\nand \"--control_location\".\n\nOur standard is to use dashes rather than underscores for\narguments like this, because it\u0027s easier to type them.\n\nAdditionally, encryption-type-update already uses\n\"--key-size\" and \"--control-location\" for the same args.\n\nThis adds the dashed versions to the CLI and makes them the\ndefault shown in the help.  The underscore versions are\nretained for compatibility.\n\nAlso removes redundant \"(Optional)\" text for arguments listed\nunder \"Optional Arguments\".  This matches other commands.\n\nChange-Id: I1bd2b7657ec577b9775eacd163cfdf6eb6b6eab2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/69f0090b65be88c93691f89dc1cd3e9f8e2a5ee0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/69f0090b65be88c93691f89dc1cd3e9f8e2a5ee0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}