)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"fix them step by step. Based our current API design"},{"line_number":11,"context_line":"in cinder [1] and irc conversation [2] the \u0027instance_uuid\u0027"},{"line_number":12,"context_line":"is required, also change the name from \u0027instance_uuid\u0027 to"},{"line_number":13,"context_line":"\u0027server_uuid\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]"},{"line_number":16,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/api/v3/attachments.py#L152"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffe62b97_f0a60254","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":12},"updated":"2017-03-30 14:18:41.000000000","message":"s/uuid/id/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6c0680ad9898337fb3bfb5152c8871278c2c5f37","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[2]"},{"line_number":18,"context_line":"http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2017-03-24.log.html#t2017-03-24T13:32:03"},{"line_number":19,"context_line":"Change-Id: Ia819d04800a0f9cbd46e844895729126edc77ed9"},{"line_number":20,"context_line":"Depends-On: 8eac3b071cb7cca8f8b11952c95476fa57daffc0"},{"line_number":21,"context_line":"Closes-Bug: #1675975"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dfeb2761_ce7a1d23","line":20,"updated":"2017-03-31 21:49:03.000000000","message":"Which gerrit URL is this one?  I couldn\u0027t find it.","commit_id":"a513e8bb49b3711371778297bc06e801f422141a"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"84bdd7a6575a3583393ea3d724f7bf3aa9365879","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"@utils.arg(\u0027volume\u0027,"},{"line_number":1386,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1387,"context_line":"           help\u003d\u0027Name or ID of volume or volumes to attach.\u0027)"},{"line_number":1388,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":1389,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":1390,"context_line":"           help\u003d\u0027UUID of Instance attaching to.\u0027)"},{"line_number":1391,"context_line":"@utils.arg(\u0027--connect\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_4491a1f0","line":1388,"range":{"start_line":1388,"start_character":0,"end_line":1388,"end_character":22},"updated":"2017-03-29 14:58:19.000000000","message":"we need to change this to server-uuid, Nova has switched to using \"server\" instead of Instance;\n\nIt\u0027s also more general for non-nova consumers to use server-uuid.\n\nI\u0027ve been picky abou tthe xxx-id vs xx-uuid because one of my pet peaves is we expect/require a uuid that should be reflected in the name.  If we\u0027re  going to allow a uuid OR something else (again the case of non-nova) then we can use just \u0027id\u0027 but we need to note it clearly and make absolutely certain that code further along the line doesn\u0027t put the oslo isuuid like check on it and fail.","commit_id":"c191103d29f8c66742bb45e1114cdd231b76839e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"                                      marker\u003dargs.marker,"},{"line_number":1356,"context_line":"                                      limit\u003dargs.limit,"},{"line_number":1357,"context_line":"                                      sort\u003dargs.sort)"},{"line_number":1358,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Volume ID\u0027, \u0027Status\u0027, \u0027Server UUID\u0027]"},{"line_number":1359,"context_line":"    if args.sort:"},{"line_number":1360,"context_line":"        sortby_index \u003d None"},{"line_number":1361,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_f043a2ae","line":1358,"range":{"start_line":1358,"start_character":52,"end_line":1358,"end_character":56},"updated":"2017-03-30 14:18:41.000000000","message":"We don\u0027t necessarily want to restrict this to be UUID, let\u0027s change this to ID.","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"@utils.arg(\u0027volume\u0027,"},{"line_number":1386,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1387,"context_line":"           help\u003d\u0027Name or ID of volume or volumes to attach.\u0027)"},{"line_number":1388,"context_line":"@utils.arg(\u0027server_uuid\u0027,"},{"line_number":1389,"context_line":"           metavar\u003d\u0027\u003cserver_uuid\u003e\u0027,"},{"line_number":1390,"context_line":"           help\u003d\u0027UUID of server attaching to.\u0027)"},{"line_number":1391,"context_line":"@utils.arg(\u0027--connect\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_d0ee5e8a","line":1388,"range":{"start_line":1388,"start_character":19,"end_line":1388,"end_character":23},"updated":"2017-03-30 14:18:41.000000000","message":"s/uuid/id/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":1386,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1387,"context_line":"           help\u003d\u0027Name or ID of volume or volumes to attach.\u0027)"},{"line_number":1388,"context_line":"@utils.arg(\u0027server_uuid\u0027,"},{"line_number":1389,"context_line":"           metavar\u003d\u0027\u003cserver_uuid\u003e\u0027,"},{"line_number":1390,"context_line":"           help\u003d\u0027UUID of server attaching to.\u0027)"},{"line_number":1391,"context_line":"@utils.arg(\u0027--connect\u0027,"},{"line_number":1392,"context_line":"           metavar\u003d\u0027\u003cconnect\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_d0777e08","line":1389,"range":{"start_line":1389,"start_character":28,"end_line":1389,"end_character":33},"updated":"2017-03-30 14:18:41.000000000","message":"s/uuid/id/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"           help\u003d\u0027Name or ID of volume or volumes to attach.\u0027)"},{"line_number":1388,"context_line":"@utils.arg(\u0027server_uuid\u0027,"},{"line_number":1389,"context_line":"           metavar\u003d\u0027\u003cserver_uuid\u003e\u0027,"},{"line_number":1390,"context_line":"           help\u003d\u0027UUID of server attaching to.\u0027)"},{"line_number":1391,"context_line":"@utils.arg(\u0027--connect\u0027,"},{"line_number":1392,"context_line":"           metavar\u003d\u0027\u003cconnect\u003e\u0027,"},{"line_number":1393,"context_line":"           default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_708672de","line":1390,"range":{"start_line":1390,"start_character":17,"end_line":1390,"end_character":21},"updated":"2017-03-30 14:18:41.000000000","message":"s/UUID/ID/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"                     \u0027mountpoint\u0027: args.mountpoint}"},{"line_number":1437,"context_line":"    attachment \u003d cs.attachments.create(args.volume,"},{"line_number":1438,"context_line":"                                       connector,"},{"line_number":1439,"context_line":"                                       args.server_uuid)"},{"line_number":1440,"context_line":"    connector_dict \u003d attachment.pop(\u0027connection_info\u0027, None)"},{"line_number":1441,"context_line":"    utils.print_dict(attachment)"},{"line_number":1442,"context_line":"    if connector_dict:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_f071620e","line":1439,"range":{"start_line":1439,"start_character":51,"end_line":1439,"end_character":55},"updated":"2017-03-30 14:18:41.000000000","message":"s/uuid/id/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"}],"releasenotes/notes/bug-1675975-ad91a7a34e0esywc.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a9b9debbcde62526dc53a59ec43a627344e9ca4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The \u0027instance\u0027 is a required parameter at the server side,"},{"line_number":5,"context_line":"    change the behaviour at the client side correspondingly."},{"line_number":6,"context_line":"    [Bug `1675975 \u003chttps://bugs.launchpad.net/bugs/1675975\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_6b962df3","line":3,"updated":"2017-03-27 12:00:12.000000000","message":"Doesn\u0027t seem like a deprecation. I would put this under the fixes too and say something like \"The instance was marked as an optional parameter when creating an attachment but is now required.\"\n\nActually, not even really sure this needs a release note as it was just broken before, but in either case, it\u0027s not a deprecation.","commit_id":"bae8bd017e30425295e03d13b39202a81e923c3e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"07d7b1f2816a32465b4ce4297dfb419937a9d49e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- ---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"- The \u0027instance\u0027 is now a required parameter when creating an"},{"line_number":4,"context_line":"  attachment, all because this is required at the server side."},{"line_number":5,"context_line":"  [Bug `1675975 \u003chttps://bugs.launchpad.net/bugs/1675975\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ffe62b97_9103dfb8","line":3,"range":{"start_line":3,"start_character":6,"end_line":3,"end_character":44},"updated":"2017-03-27 13:31:32.000000000","message":"From behavior perspective not much changed as it was always required on the server side.\n\nI think from the client\u0027s perspective what needs to be mentioned here is that the instance-id is a positional argument now, which changes how the attachment-create call is invoked. Add an example maybe?","commit_id":"0f4df14530b3def1ff46a9a22d12e0765ec7bb93"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"- The \u0027server_uuid\u0027 is now a required parameter when creating an"},{"line_number":4,"context_line":"  attachment, that means we should create an attachment with"},{"line_number":5,"context_line":"  a command like, \u0027cinder attachment-create \u003cvolume\u003e \u003cserver_uuid\u003e\u0027."},{"line_number":6,"context_line":"  [Bug `1675975 \u003chttps://bugs.launchpad.net/bugs/1675975\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffe62b97_30ffca35","line":3,"range":{"start_line":3,"start_character":14,"end_line":3,"end_character":18},"updated":"2017-03-30 14:18:41.000000000","message":"s/uuid/id/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b9d08ebecb28e8eaa3e827423e3f905aa8b62a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"- The \u0027server_uuid\u0027 is now a required parameter when creating an"},{"line_number":4,"context_line":"  attachment, that means we should create an attachment with"},{"line_number":5,"context_line":"  a command like, \u0027cinder attachment-create \u003cvolume\u003e \u003cserver_uuid\u003e\u0027."},{"line_number":6,"context_line":"  [Bug `1675975 \u003chttps://bugs.launchpad.net/bugs/1675975\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffe62b97_f0f8424a","line":5,"range":{"start_line":5,"start_character":61,"end_line":5,"end_character":65},"updated":"2017-03-30 14:18:41.000000000","message":"s/uuid/id/","commit_id":"0ef764c5a5f544c110e9f9b6309f949a7bfb2b5e"}]}