)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"289e7cef0e25765c389144a06b8ac1556d1d2574","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The output of \"cinder get-capabilities\" command returns unicoded response."},{"line_number":10,"context_line":"As a refactoring effort added formatters to return non-unicode response."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added formatters\u003dsorted(prop.keys()) as suggested by the reviewer, to avoid tying server"},{"line_number":13,"context_line":"knowledge to the client and also any update on the server side would easily reflect here."},{"line_number":14,"context_line":"*Fixed pep8 issues"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f96bb07_bf625ad7","line":12,"updated":"2018-01-23 11:24:42.000000000","message":"For future reference, limit line length to within 72 characters.","commit_id":"8672eb66b96115efc3e794863b54ceeb0966708d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"289e7cef0e25765c389144a06b8ac1556d1d2574","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added formatters\u003dsorted(prop.keys()) as suggested by the reviewer, to avoid tying server"},{"line_number":13,"context_line":"knowledge to the client and also any update on the server side would easily reflect here."},{"line_number":14,"context_line":"*Fixed pep8 issues"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1680444"},{"line_number":17,"context_line":"Change-Id: Ie38236db364d59ddab42cb925d0435777b0ffe86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f96bb07_3f596afd","line":14,"updated":"2018-01-23 11:24:42.000000000","message":"There were not existing pep8 issues, this can be removed.","commit_id":"8672eb66b96115efc3e794863b54ceeb0966708d"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fa632d522cb32a4ae453456b30e8092400b1886b","unresolved":false,"context_lines":[{"line_number":2348,"context_line":"                     formatters\u003d[\u0027compression\u0027,"},{"line_number":2349,"context_line":"                                 \u0027qos\u0027,"},{"line_number":2350,"context_line":"                                 \u0027replication_enabled\u0027,"},{"line_number":2351,"context_line":"                                 \u0027thin_provisioning\u0027])"},{"line_number":2352,"context_line":""},{"line_number":2353,"context_line":""},{"line_number":2354,"context_line":"@utils.arg(\u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_d99b8f70","line":2351,"updated":"2017-06-02 15:47:05.000000000","message":"Listing these four fields here explicitly is tying server knowledge into the client that shouldn\u0027t be here.\n\nThis should be something more like formatters\u003dsort(prop.keys()) so that other fields show up if we add them on the server-side.","commit_id":"b57e2c9987dbc9cbffd64d6665a31b85e5093c97"}]}