)]}'
{"cinderclient/client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"81559a58a43a2e6f59467665a933b4ea1c2421d3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":130,"context_line":"        self.api_version \u003d kwargs.pop(\u0027api_version\u0027, None)"},{"line_number":131,"context_line":"        self.api_version \u003d self.api_version or api_versions.APIVersion()"},{"line_number":132,"context_line":"        self.retries \u003d kwargs.pop(\u0027retries\u0027, 0) or 0"},{"line_number":133,"context_line":"        self._logger \u003d logging.getLogger(__name__)"},{"line_number":134,"context_line":"        super(SessionClient, self).__init__(*args, **kwargs)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_f5af7e27","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":46},"updated":"2017-04-20 11:46:08.000000000","message":"The second parameter to pop() is the default to return if the requested key is not present. So this is not correct. Your error must have come from somewhere else, because this code as it was will result with self.retries being 0.","commit_id":"a86623633018970d8607c9a883b1a386bdff9759"},{"author":{"_account_id":19265,"name":"Georgy Dyuldin","email":"gdyuldin@mirantis.com","username":"1tush"},"change_message_id":"3915450e83646782ed9b2362fbe15a613425f80d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":130,"context_line":"        self.api_version \u003d kwargs.pop(\u0027api_version\u0027, None)"},{"line_number":131,"context_line":"        self.api_version \u003d self.api_version or api_versions.APIVersion()"},{"line_number":132,"context_line":"        self.retries \u003d kwargs.pop(\u0027retries\u0027, 0) or 0"},{"line_number":133,"context_line":"        self._logger \u003d logging.getLogger(__name__)"},{"line_number":134,"context_line":"        super(SessionClient, self).__init__(*args, **kwargs)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_d819597a","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":46},"in_reply_to":"7ffa3b31_f5af7e27","updated":"2017-04-20 11:51:17.000000000","message":"I know. But if kwargs looks like {..., \u0027retries\u0027: None, ...} pop returns None (not 0). And here\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/client.py#L118\n`retries` default value is None","commit_id":"a86623633018970d8607c9a883b1a386bdff9759"}]}