)]}'
{"id":"openstack%2Fpython-cinderclient~458869","triplet_id":"openstack%2Fpython-cinderclient~master~If82ee8674b2166ec66c2a978827a203786fabec7","project":"openstack/python-cinderclient","branch":"master","topic":"ksa-requests","hashtags":[],"change_id":"If82ee8674b2166ec66c2a978827a203786fabec7","subject":"Remove direct dependency on requests","status":"MERGED","created":"2017-04-21 15:04:35.000000000","updated":"2017-05-02 17:34:34.000000000","submitted":"2017-05-02 17:34:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b117c55d49e5e10cc4fe65df6248a53ff5c0ca62","_number":458869,"virtual_id_number":458869,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2017-05-02 17:34:34.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-05-02 16:13:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-04-24 20:34:54.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-05-02 16:13:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-04-21 15:22:53.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-21 15:22:53.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2017-04-24 20:34:54.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2017-05-02 16:13:50.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-05-02 17:34:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b0c335454fdaf260eb2b6d4ae75a8b824caf9138","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2017-04-21 15:04:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bced0bbf762b618b9de35528514bca5dd6f3c3b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-21 16:09:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/458869/1/check/gate-python-cinderclient-docs-ubuntu-xenial/06da208//doc/build/html/ : SUCCESS in 2m 13s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/69/458869/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/85dff8c/ : SUCCESS in 4m 30s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/69/458869/1/check/gate-python-cinderclient-python27-ubuntu-xenial/ec4ae82/ : SUCCESS in 6m 13s\n- gate-python-cinderclient-python35 http://logs.openstack.org/69/458869/1/check/gate-python-cinderclient-python35/309c780/ : SUCCESS in 3m 32s\n- gate-python-cinderclient-requirements http://logs.openstack.org/69/458869/1/check/gate-python-cinderclient-requirements/e0ca2b4/ : SUCCESS in 3m 08s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/69/458869/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/e41a54d/ : SUCCESS in 1h 02m 58s\n- gate-python-cinderclient-pypy http://logs.openstack.org/69/458869/1/check/gate-python-cinderclient-pypy/26e0837/ : SUCCESS in 4m 38s (non-voting)\n- gate-python-cinderclient-releasenotes http://docs-draft.openstack.org/69/458869/1/check/gate-python-cinderclient-releasenotes/07ec812//releasenotes/build/html/ : SUCCESS in 2m 12s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/69/458869/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/a9f207d/ : SUCCESS in 24m 33s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/69/458869/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f33f79d/ : SUCCESS in 24m 45s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/69/458869/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/e8688ff/ : SUCCESS in 3m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"62e999350c81c2d53e8989cf1a2e80ecf0ec8370","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-04-21 17:10:03.000000000","message":"Patch Set 1:\n\nShouldn\u0027t we be tracking this dep somewhere, since it\u0027s a direct depenency of cinderclient?","accounts_in_message":[],"_revision_number":1},{"id":"e06e6a2f66a4d347f67e29f421c056ec757286a9","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2017-04-24 19:29:19.000000000","message":"Patch Set 1:\n\nWouldn\u0027t this philosophy indicate that we should not be importing requests in any of the cinderclient code but going through keystoneauth module instead?  I realize that Global Requirements are kind of funky when it comes to clients (since we don\u0027t cap things like keystonauth and they might be newer and now disagree).\n\nThat would be pretty awful in my opinion.  Anyway, also unclear where the conflict comes into play since we don\u0027t cap, or is the problem more like \"keystoneauth caps requests and we don\u0027t\"?\n\nSorry, just want to make sure I follow this clearly.","accounts_in_message":[],"_revision_number":1},{"id":"61ead6a2c79ebc9956dd9629c5b372b630ed8ef9","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2017-04-24 20:34:54.000000000","message":"Patch Set 1: Code-Review+2\n\nyeah, I get it... clients are a special and sometimes strange case.  I\u0027m good with this.","accounts_in_message":[],"_revision_number":1},{"id":"aeb386f2d9f07370dbd0ec1aad60a6c0a2a52c54","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-05-02 16:13:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nStill seems a little odd to me, but it all works out in the end.","accounts_in_message":[],"_revision_number":1},{"id":"1f1c2a24f910d1670242a628dd9e8230cfbbe48e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-02 16:14:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4b10ca5859f60fd3b5e622204ba220f324afd524","date":"2017-05-02 17:34:34.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"dc9b64ccf64f2ea4f158093e06d1644eec79bf06","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-02 17:34:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/458869/1/gate/gate-python-cinderclient-docs-ubuntu-xenial/73dd225//doc/build/html/ : SUCCESS in 2m 38s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/69/458869/1/gate/gate-python-cinderclient-pep8-ubuntu-xenial/4609cd3/ : SUCCESS in 5m 33s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/69/458869/1/gate/gate-python-cinderclient-python27-ubuntu-xenial/c490dd2/ : SUCCESS in 3m 38s\n- gate-python-cinderclient-python35 http://logs.openstack.org/69/458869/1/gate/gate-python-cinderclient-python35/bfaabce/ : SUCCESS in 2m 53s\n- gate-python-cinderclient-requirements http://logs.openstack.org/69/458869/1/gate/gate-python-cinderclient-requirements/ecb9fff/ : SUCCESS in 2m 15s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/69/458869/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/f501b59/ : SUCCESS in 1h 05m 54s\n- gate-python-cinderclient-releasenotes http://docs-draft.openstack.org/69/458869/1/gate/gate-python-cinderclient-releasenotes/3508fcb//releasenotes/build/html/ : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c38497554f3e5e7e3ea9dced5351bea0e41a9c9c","revisions":{"c38497554f3e5e7e3ea9dced5351bea0e41a9c9c":{"kind":"REWORK","_number":1,"created":"2017-04-21 15:04:35.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/69/458869/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/69/458869/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/69/458869/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/69/458869/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/69/458869/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/69/458869/1"}}},"commit":{"parents":[{"commit":"51f6668e482b35896018b26d24f8baf05441005f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/51f6668e482b35896018b26d24f8baf05441005f"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-04-21 15:04:01.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-04-21 15:04:11.000000000","tz":-300},"subject":"Remove direct dependency on requests","message":"Remove direct dependency on requests\n\nkeystoneauth is the library that pulls in requests. If we have client\nlibraries also depend directly on requests, we can get into situations\nfor end users in installations where, because of sequencing of client\nlibrary releases there are conflicting versions of requests needed and\npkg_resources/entrypoints break.\n\nRemove the direct depend and let keystoneauth pull it in for us.\n\nChange-Id: If82ee8674b2166ec66c2a978827a203786fabec7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c38497554f3e5e7e3ea9dced5351bea0e41a9c9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c38497554f3e5e7e3ea9dced5351bea0e41a9c9c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}