)]}'
{"id":"openstack%2Fpython-cinderclient~465159","triplet_id":"openstack%2Fpython-cinderclient~master~I9a6f446b680dadedccd14ba49efdef7f5ef0a58a","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1691229","hashtags":[],"change_id":"I9a6f446b680dadedccd14ba49efdef7f5ef0a58a","subject":"Add pagination for snapshots, backups","status":"MERGED","created":"2017-05-16 19:31:29.000000000","updated":"2017-07-12 17:59:19.000000000","submitted":"2017-07-12 17:59:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b72f7e718a595125afb48bd82a3f66078780b8a9","_number":465159,"virtual_id_number":465159,"owner":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-12 17:59:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},{"value":2,"date":"2017-06-29 07:57:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":1,"date":"2017-07-05 07:51:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2017-07-12 15:36:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2017-07-12 15:36:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-16 19:40:35.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2017-05-25 09:26:05.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2017-06-29 07:57:26.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2017-07-05 07:51:16.000000000","updated_by":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"reviewer":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"state":"REVIEWER"},{"updated":"2017-07-12 15:36:39.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2017-07-12 17:59:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f38feefc57af519d0ed2344c12eb3ad60ecbeba3","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-16 19:31:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8027e88e96621b0330ccb5d3da03a4e308d89e1f","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-16 19:39:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"db68ee0baeca6e3a8f8601d580d6d09231047cde","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-16 21:04:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/465159/2/check/gate-python-cinderclient-docs-ubuntu-xenial/381686e//doc/build/html/ : SUCCESS in 2m 30s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/465159/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/1a43b36/ : SUCCESS in 2m 39s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/465159/2/check/gate-python-cinderclient-python27-ubuntu-xenial/99ce3bc/ : SUCCESS in 2m 56s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/465159/2/check/gate-python-cinderclient-python35/d0bbcac/ : SUCCESS in 2m 53s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/465159/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/293d0b6/ : SUCCESS in 1h 22m 02s\n- gate-python-cinderclient-pypy http://logs.openstack.org/59/465159/2/check/gate-python-cinderclient-pypy/0c72ff2/ : SUCCESS in 3m 56s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/465159/2/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/d86fb49/ : FAILURE in 23m 34s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/465159/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/65bc1b4/ : FAILURE in 14m 46s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/465159/2/check/gate-python-cinderclient-pylint-ubuntu-xenial/4164295/ : SUCCESS in 2m 25s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d250dcc1ee3e734a68db363b6988206e9e2f468a","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2017-05-17 18:01:44.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks ok to me.  Good to get a more generic implementation in place.","accounts_in_message":[],"_revision_number":2},{"id":"27c38cb343413fd2d43bf5c120877a41d1bb3491","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-05-18 09:38:26.000000000","message":"Patch Set 2: Code-Review-1\n\nThe code looks good, but we need unit tests","accounts_in_message":[],"_revision_number":2},{"id":"3f2df8a6ebb59c746f409b90cf8628fb6b1a7cef","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-19 07:51:30.000000000","message":"Patch Set 2:\n\nIt\u0027s tricky not to interfere with the other unit tests, but I\u0027m working on it.","accounts_in_message":[],"_revision_number":2},{"id":"92d5e4edd3120090805c48d190b8ce29f6c4d7a4","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-23 07:43:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5d540afb70b01c827e7b5700998669bf7efe0723","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-23 08:19:14.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/465159/3/check/gate-python-cinderclient-docs-ubuntu-xenial/f260565//doc/build/html/ : SUCCESS in 2m 06s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/3bf9e65/ : SUCCESS in 2m 39s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-python27-ubuntu-xenial/c660302/ : SUCCESS in 5m 03s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-python35/2d7953a/ : SUCCESS in 3m 33s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/4b4a0f0/ : FAILURE in 31m 16s\n- gate-python-cinderclient-pypy http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-pypy/14185fb/ : SUCCESS in 2m 43s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/465159/3/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/0c498ba/ : FAILURE in 16m 11s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/465159/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/8d73ef1/ : FAILURE in 16m 10s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-pylint-ubuntu-xenial/1ab1f8e/ : SUCCESS in 2m 27s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"331f50e335b682168d5dbef25de6bb0ac39c52a4","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-23 19:00:41.000000000","message":"Patch Set 3:\n\nrecheck https://bugs.launchpad.net/oslo.i18n/+bug/1692773","accounts_in_message":[],"_revision_number":3},{"id":"d2296e3fef19f91e97a4ffb1c0edbb9dd2f215ad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-23 20:53:56.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/465159/3/check/gate-python-cinderclient-docs-ubuntu-xenial/1a5d48a//doc/build/html/ : SUCCESS in 3m 37s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/b923e4f/ : SUCCESS in 5m 40s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-python27-ubuntu-xenial/462cc1b/ : SUCCESS in 5m 01s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-python35/2a740f1/ : SUCCESS in 4m 19s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/23bcb3e/ : POST_FAILURE in 1h 50m 10s\n- gate-python-cinderclient-pypy http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-pypy/caeeb03/ : SUCCESS in 4m 02s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/465159/3/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/ac37389/ : FAILURE in 27m 52s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/465159/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/24d8450/ : FAILURE in 25m 00s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/465159/3/check/gate-python-cinderclient-pylint-ubuntu-xenial/55e3374/ : SUCCESS in 4m 04s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6edfb117590b3923d12369edb405c86a6cad0045","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-24 10:49:55.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"ec39414b0bda3973acc731ca604029cd4213e5dc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 12:17:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/465159/4/check/gate-python-cinderclient-docs-ubuntu-xenial/fca2b3f//doc/build/html/ : SUCCESS in 2m 13s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/465159/4/check/gate-python-cinderclient-pep8-ubuntu-xenial/eb91360/ : SUCCESS in 4m 32s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/465159/4/check/gate-python-cinderclient-python27-ubuntu-xenial/baae496/ : SUCCESS in 2m 18s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/465159/4/check/gate-python-cinderclient-python35/158d7e3/ : SUCCESS in 2m 24s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/465159/4/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/2c37b8b/ : SUCCESS in 1h 26m 06s\n- gate-python-cinderclient-pypy http://logs.openstack.org/59/465159/4/check/gate-python-cinderclient-pypy/5cc6f24/ : SUCCESS in 2m 53s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/465159/4/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/af3c578/ : FAILURE in 24m 20s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/465159/4/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/72b0da7/ : FAILURE in 17m 00s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/465159/4/check/gate-python-cinderclient-pylint-ubuntu-xenial/c7b60ca/ : SUCCESS in 4m 11s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"907fa6ed574604c941facb5551c004637882b508","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2017-05-24 22:50:13.000000000","message":"Patch Set 4: Code-Review+2\n\nThanks for adding UT.","accounts_in_message":[],"_revision_number":4},{"id":"0f3a1f41cf6a80b8d4fc0e45e843cb422f94a256","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-05-25 09:26:05.000000000","message":"Patch Set 4: Code-Review-1\n\nSorry, I am totally against doing unit tests this way, we should be using mocks not reinventing the wheel with new fakes and additional checking methods that mocks already have.  Also the pagination test method on base does more than 1 test, which is not good practice.","accounts_in_message":[],"_revision_number":4},{"id":"69c9b0bae3bba17f5aa2d9601e4beea4394ffa65","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-05-25 17:48:55.000000000","message":"Patch Set 4:\n\nNo need to be sorry; any feedback on improving quality is welcome.\n\nI\u0027ll rewrite this into multiple unit tests using mocks (with mock.call_count). Can you give me a pointer to the other wheel I\u0027m reinventing?","accounts_in_message":[],"_revision_number":4},{"id":"77b6734825e17a7423d243f51ad934e44b9611a0","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-05-30 07:37:54.000000000","message":"Patch Set 4:\n\nSome useful methods in mocks:\n\n- assert_not_called\n- assert_called_once_with\n- assert_has_calls([mock.call(param1, keyparam\u003dkeyvalue), mock.calll...])","accounts_in_message":[],"_revision_number":4},{"id":"cb8f2213124dd34d7b91581ef3aff5f2089a2e5f","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2017-05-31 20:56:26.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"6c64893563201d80f41402631b4f0ebc555b739e","author":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"date":"2017-06-06 08:02:39.000000000","message":"Patch Set 4:\n\nSorry, I cannot find the time to learn the test framework. Is there anyone who can finish this change?","accounts_in_message":[],"_revision_number":4},{"id":"d1941ffb4790d122f642699abc19c16ef196416b","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-06-06 08:14:39.000000000","message":"Patch Set 4:\n\nSince you\u0027ve already done most of the work I can just fix these little nits for your.","accounts_in_message":[],"_revision_number":4},{"id":"5f3baa0556fc0d460bf608531a8f69170bd817d6","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-06-22 17:07:41.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"363847c106f769d278c7a519ac9ce7719b73f844","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-22 18:21:47.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/465159/5/check/gate-python-cinderclient-docs-ubuntu-xenial/268f0a6//doc/build/html/ : SUCCESS in 2m 52s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/465159/5/check/gate-python-cinderclient-pep8-ubuntu-xenial/ee76860/ : SUCCESS in 4m 17s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/465159/5/check/gate-python-cinderclient-python27-ubuntu-xenial/70d6d81/ : SUCCESS in 2m 24s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/465159/5/check/gate-python-cinderclient-python35/a57470d/ : SUCCESS in 5m 08s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/465159/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/af4fc8d/ : SUCCESS in 1h 12m 26s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/465159/5/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/2ce088c/ : SUCCESS in 29m 43s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/465159/5/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/038e991/ : SUCCESS in 14m 46s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/465159/5/check/gate-python-cinderclient-pylint-ubuntu-xenial/302f974/ : SUCCESS in 2m 41s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"6f370c0473abd1d09354f4f38ee327df5ea677eb","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2017-06-29 07:57:26.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"bea37dcdb8428e8b230c2b4a2a8e48acb9437967","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2017-07-05 07:51:16.000000000","message":"Patch Set 5: Code-Review+1\n\nLGTM.","accounts_in_message":[],"_revision_number":5},{"id":"12a6d195e56f8d9484eec43a38a509f0ae75fdaf","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2017-07-12 15:36:39.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nThis looks good to me.  Thanks!","accounts_in_message":[],"_revision_number":5},{"id":"ef9f6dfa8e0080a7ed482693b654c3862d9a21ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-12 15:36:50.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"f5e591ce7fede24a2d8e69fb171d6856c452283c","date":"2017-07-12 17:59:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"0bc70887baee9600ce30f58c271972cf8dd9c951","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-12 17:59:19.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/465159/5/gate/gate-python-cinderclient-docs-ubuntu-xenial/9427aca//doc/build/html/ : SUCCESS in 8m 48s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/465159/5/gate/gate-python-cinderclient-pep8-ubuntu-xenial/bb4b3e6/ : SUCCESS in 9m 32s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/465159/5/gate/gate-python-cinderclient-python27-ubuntu-xenial/7ba62f7/ : SUCCESS in 9m 18s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/465159/5/gate/gate-python-cinderclient-python35/c360f14/ : SUCCESS in 6m 17s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/465159/5/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/51eab7f/ : SUCCESS in 2h 21m 50s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"d11b1059a44501a76b4c604f30c9e17b437dce4b","revisions":{"cbb19568e8e85a537fdce81c4786a51fa05335bf":{"kind":"REWORK","_number":1,"created":"2017-05-16 19:31:29.000000000","uploader":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"ref":"refs/changes/59/465159/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/465159/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/1"}}},"commit":{"parents":[{"commit":"16af9f72b6ff7eba91258e71cf05504de5ba6f7f","subject":"Pretty print \u0027extra_specs\u0027 and \u0027group_specs\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/16af9f72b6ff7eba91258e71cf05504de5ba6f7f"}]}],"author":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:03:48.000000000","tz":120},"committer":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:30:45.000000000","tz":120},"subject":"Add pagination for snapshots, backups","message":"Add pagination for snapshots, backups\n\nAllow cinderclient to retrieve more than osapi_max_limit\n(default 1000) snapshots, backups, etc.\n\nCinder pagination support has been added to the API quite some\ntime ago.  Client support was only implemented for volumes.\n\nThis commit allows other resources to be paginated as well.\n\nChange-Id: I9a6f446b680dadedccd14ba49efdef7f5ef0a58a\nCloses-Bug: #1691229\nSigned-off-by: Gerhard Muntingh \u003cgerhard@qux.nl\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cbb19568e8e85a537fdce81c4786a51fa05335bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cbb19568e8e85a537fdce81c4786a51fa05335bf"}]},"branch":"refs/heads/master"},"64af08c6384faa6170d57cc124664de80e37ce8b":{"kind":"REWORK","_number":2,"created":"2017-05-16 19:39:58.000000000","uploader":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"ref":"refs/changes/59/465159/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/465159/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/2"}}},"commit":{"parents":[{"commit":"16af9f72b6ff7eba91258e71cf05504de5ba6f7f","subject":"Pretty print \u0027extra_specs\u0027 and \u0027group_specs\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/16af9f72b6ff7eba91258e71cf05504de5ba6f7f"}]}],"author":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:03:48.000000000","tz":120},"committer":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:38:46.000000000","tz":120},"subject":"Add pagination for snapshots, backups","message":"Add pagination for snapshots, backups\n\nAllow cinderclient to retrieve more than osapi_max_limit\n(default 1000) snapshots, backups, etc.\n\nCinder pagination support has been added to the API quite some\ntime ago.  Client support was only implemented for volumes.\n\nThis commit allows other resources to be paginated as well.\n\nChange-Id: I9a6f446b680dadedccd14ba49efdef7f5ef0a58a\nCloses-Bug: #1691229\nSigned-off-by: Gerhard Muntingh \u003cgerhard@qux.nl\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/64af08c6384faa6170d57cc124664de80e37ce8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/64af08c6384faa6170d57cc124664de80e37ce8b"}]},"branch":"refs/heads/master"},"acef0c279f9eb149a3e4caef41d4a10a78f823d1":{"kind":"REWORK","_number":3,"created":"2017-05-23 07:43:58.000000000","uploader":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"ref":"refs/changes/59/465159/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/465159/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/3"}}},"commit":{"parents":[{"commit":"08f65c1225bbaae499f29cd877993c376914bf40","subject":"Merge \"Add doc for noauth usage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/08f65c1225bbaae499f29cd877993c376914bf40"}]}],"author":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:03:48.000000000","tz":120},"committer":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-23 07:41:45.000000000","tz":120},"subject":"Add pagination for snapshots, backups","message":"Add pagination for snapshots, backups\n\nAllow cinderclient to retrieve more than osapi_max_limit\n(default 1000) snapshots, backups, etc.\n\nCinder pagination support has been added to the API quite some\ntime ago.  Client support was only implemented for volumes.\n\nThis commit allows other resources to be paginated as well.\n\nChange-Id: I9a6f446b680dadedccd14ba49efdef7f5ef0a58a\nCloses-Bug: #1691229\nSigned-off-by: Gerhard Muntingh \u003cgerhard@qux.nl\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/acef0c279f9eb149a3e4caef41d4a10a78f823d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/acef0c279f9eb149a3e4caef41d4a10a78f823d1"}]},"branch":"refs/heads/master"},"2ca1b4e227d0c6be9c76618ee62be6c3497276ad":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2017-05-24 10:49:55.000000000","uploader":{"_account_id":16278,"name":"Gerhard Muntingh","email":"gerhard@qux.nl","username":"gerhardqux"},"ref":"refs/changes/59/465159/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/465159/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/4"}}},"commit":{"parents":[{"commit":"0470ec8c518e496e1402180c17bf5b006bef54dc","subject":"Merge \"Cinder client reset-state improvements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0470ec8c518e496e1402180c17bf5b006bef54dc"}]}],"author":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:03:48.000000000","tz":120},"committer":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-24 10:49:55.000000000","tz":0},"subject":"Add pagination for snapshots, backups","message":"Add pagination for snapshots, backups\n\nAllow cinderclient to retrieve more than osapi_max_limit\n(default 1000) snapshots, backups, etc.\n\nCinder pagination support has been added to the API quite some\ntime ago.  Client support was only implemented for volumes.\n\nThis commit allows other resources to be paginated as well.\n\nChange-Id: I9a6f446b680dadedccd14ba49efdef7f5ef0a58a\nCloses-Bug: #1691229\nSigned-off-by: Gerhard Muntingh \u003cgerhard@qux.nl\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2ca1b4e227d0c6be9c76618ee62be6c3497276ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2ca1b4e227d0c6be9c76618ee62be6c3497276ad"}]},"branch":"refs/heads/master"},"d11b1059a44501a76b4c604f30c9e17b437dce4b":{"kind":"REWORK","_number":5,"created":"2017-06-22 17:07:41.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/59/465159/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/465159/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/465159/5"}}},"commit":{"parents":[{"commit":"b910f5bea33cbccca25b008b3b03dc5dce27245a","subject":"Unicode value support for \"--filters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b910f5bea33cbccca25b008b3b03dc5dce27245a"}]}],"author":{"name":"Gerhard Muntingh","email":"gerhard@qux.nl","date":"2017-05-16 19:03:48.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2017-06-22 17:06:48.000000000","tz":120},"subject":"Add pagination for snapshots, backups","message":"Add pagination for snapshots, backups\n\nAllow cinderclient to retrieve more than osapi_max_limit\n(default 1000) snapshots, backups, etc.\n\nCinder pagination support has been added to the API quite some\ntime ago.  Client support was only implemented for volumes.\n\nThis commit allows other resources to be paginated as well.\n\nChange-Id: I9a6f446b680dadedccd14ba49efdef7f5ef0a58a\nCloses-Bug: #1691229\nCo-Authored-By: Gorka Eguileor \u003cgeguileo@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d11b1059a44501a76b4c604f30c9e17b437dce4b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d11b1059a44501a76b4c604f30c9e17b437dce4b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}