)]}'
{"cinderclient/v2/shell.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"143435fe2e0e09d4230bf8693908888061db7888","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"           default\u003dFalse)"},{"line_number":1177,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1178,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":1179,"context_line":"           help\u003d\u0027Allow to back up an in-use volume.\u0027,"},{"line_number":1180,"context_line":"           default\u003dFalse)"},{"line_number":1181,"context_line":"@utils.arg(\u0027--snapshot-id\u0027,"},{"line_number":1182,"context_line":"           metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_1d049449","line":1179,"updated":"2017-05-17 07:29:55.000000000","message":"The convention is to have the default spec in the help text. For example see the help text for description and incremental above.\nAlso, why remove the information that forced backup is crash consistent? Is it incorrect?","commit_id":"6388f268101676e2a02f0740929b8cbd06c040bb"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"28c0365e265e05f046df6a7a17ff45dc1ff48a29","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"           default\u003dFalse)"},{"line_number":1177,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1178,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":1179,"context_line":"           help\u003d\u0027Allow to back up an in-use volume.\u0027,"},{"line_number":1180,"context_line":"           default\u003dFalse)"},{"line_number":1181,"context_line":"@utils.arg(\u0027--snapshot-id\u0027,"},{"line_number":1182,"context_line":"           metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_780846d8","line":1179,"in_reply_to":"1f013ff3_1d049449","updated":"2017-05-17 07:54:21.000000000","message":"The help text may misleading user to transfer wrong parameters, user can not create backup with \u0027--force\u003dTrue\u0027, by the way, please refer to this: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v2/backup.py#L66","commit_id":"6388f268101676e2a02f0740929b8cbd06c040bb"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"143435fe2e0e09d4230bf8693908888061db7888","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1290,"context_line":"           action\u003d\"store_true\","},{"line_number":1291,"context_line":"           help\u003d\u0027Allow delete in state other than error or available.\u0027)"},{"line_number":1292,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1293,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1294,"context_line":"def do_backup_delete(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_dd4f4cbb","line":1291,"updated":"2017-05-17 07:29:55.000000000","message":"Default spec is removed here also.","commit_id":"6388f268101676e2a02f0740929b8cbd06c040bb"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"28c0365e265e05f046df6a7a17ff45dc1ff48a29","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1290,"context_line":"           action\u003d\"store_true\","},{"line_number":1291,"context_line":"           help\u003d\u0027Allow delete in state other than error or available.\u0027)"},{"line_number":1292,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1293,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1294,"context_line":"def do_backup_delete(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_b84a4ea9","line":1291,"in_reply_to":"1f013ff3_dd4f4cbb","updated":"2017-05-17 07:54:21.000000000","message":"Default value should be False here, see my new patchset please.","commit_id":"6388f268101676e2a02f0740929b8cbd06c040bb"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"deaa65f2772dcd9393006a04f8e5d458042fc9b3","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"           default\u003dFalse)"},{"line_number":1177,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1178,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":1179,"context_line":"           help\u003d\u0027Allow to back up an in-use volume.\u0027,"},{"line_number":1180,"context_line":"           default\u003dFalse)"},{"line_number":1181,"context_line":"@utils.arg(\u0027--snapshot-id\u0027,"},{"line_number":1182,"context_line":"           metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_d31bbd18","line":1179,"range":{"start_line":1179,"start_character":17,"end_line":1179,"end_character":52},"updated":"2017-05-17 08:13:05.000000000","message":"I reckon the end users are more aware of the possibility of data loss with the previous help text.","commit_id":"5a0a1ce97f68aafd3b9d72654cdd668cf4ad3252"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"deaa65f2772dcd9393006a04f8e5d458042fc9b3","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1290,"context_line":"           action\u003d\"store_true\","},{"line_number":1291,"context_line":"           help\u003d\u0027Allow delete in state other than error or available.\u0027,"},{"line_number":1292,"context_line":"           default\u003dFalse)"},{"line_number":1293,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1294,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1295,"context_line":"def do_backup_delete(cs, args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_33b9c1e8","line":1292,"range":{"start_line":1292,"start_character":11,"end_line":1292,"end_character":25},"updated":"2017-05-17 08:13:05.000000000","message":"This is not a help text.","commit_id":"5a0a1ce97f68aafd3b9d72654cdd668cf4ad3252"}]}