)]}'
{"id":"openstack%2Fpython-cinderclient~465884","triplet_id":"openstack%2Fpython-cinderclient~master~I1559fa215d08a5b705b60a073df510b2785de7c7","project":"openstack/python-cinderclient","branch":"master","hashtags":[],"change_id":"I1559fa215d08a5b705b60a073df510b2785de7c7","subject":"Move the keys methods of volume type to manager","status":"ABANDONED","created":"2017-05-18 09:06:57.000000000","updated":"2018-05-10 20:59:33.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"47d7ece81438bf0e11ddf0d142c871bae4ab6904","_number":465884,"virtual_id_number":465884,"owner":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2018-05-10 20:59:33.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":1,"date":"2017-05-18 10:40:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":-1,"date":"2017-05-22 15:21:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-18 10:40:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-22 15:21:58.000000000","updated_by":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"reviewer":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"state":"REVIEWER"},{"updated":"2018-05-10 20:59:33.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"29b98b4611b9327054d7683dbcf1e80be00e2a68","author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"date":"2017-05-18 09:06:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5ad2e7c4491ec8a172bea603237d300362c67e93","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-18 10:40:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/465884/1/check/gate-python-cinderclient-docs-ubuntu-xenial/bcc3a99//doc/build/html/ : SUCCESS in 2m 40s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/84/465884/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/f74eaa0/ : SUCCESS in 3m 42s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/84/465884/1/check/gate-python-cinderclient-python27-ubuntu-xenial/170012d/ : SUCCESS in 3m 02s\n- gate-python-cinderclient-python35 http://logs.openstack.org/84/465884/1/check/gate-python-cinderclient-python35/08e7abb/ : SUCCESS in 4m 10s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/84/465884/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/edbe611/ : SUCCESS in 1h 28m 47s\n- gate-python-cinderclient-pypy http://logs.openstack.org/84/465884/1/check/gate-python-cinderclient-pypy/906f5e0/ : SUCCESS in 4m 08s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/84/465884/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/7becedb/ : FAILURE in 22m 51s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/84/465884/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/5338518/ : FAILURE in 22m 50s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/84/465884/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/b0fef4d/ : FAILURE in 2m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"28cc4a115095c6ac3a06463d7e4700af01ec21c1","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-05-19 21:22:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ebfbcb490b8340447f62303ed83c2772df1c7b83","author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"date":"2017-05-22 15:21:58.000000000","message":"Patch Set 1: Code-Review-1\n\nWhat actually the idea of this patch? I can understand it if using this methods we can get rid of code duplication. But in v2/v3 api code, actually the same. Could we somehow solve this problem?\n\nAnd if we move code from VolumeType class to VolumeTypeManager class I think we need to change tests either. Or add them if we don\u0027t have it","accounts_in_message":[],"_revision_number":1},{"id":"47d7ece81438bf0e11ddf0d142c871bae4ab6904","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-05-10 20:59:33.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Zuul the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"74abc75494d3ac7f978262a862b8414b3cd35c36","revisions":{"74abc75494d3ac7f978262a862b8414b3cd35c36":{"kind":"REWORK","_number":1,"created":"2017-05-18 09:06:57.000000000","uploader":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"ref":"refs/changes/84/465884/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/84/465884/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/84/465884/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/84/465884/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/84/465884/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/84/465884/1"}}},"commit":{"parents":[{"commit":"16af9f72b6ff7eba91258e71cf05504de5ba6f7f","subject":"Pretty print \u0027extra_specs\u0027 and \u0027group_specs\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/16af9f72b6ff7eba91258e71cf05504de5ba6f7f"}]}],"author":{"name":"chenhb","email":"chen.haibing1@zte.com.cn","date":"2017-06-18 08:35:43.000000000","tz":480},"committer":{"name":"chenhb","email":"chen.haibing1@zte.com.cn","date":"2017-06-18 08:48:28.000000000","tz":480},"subject":"Move the keys methods of volume type to manager","message":"Move the keys methods of volume type to manager\n\nWe can move these methods to manager, and provide\nthe unify interfaces as other mentods.\n\nChange-Id: I1559fa215d08a5b705b60a073df510b2785de7c7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/74abc75494d3ac7f978262a862b8414b3cd35c36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/74abc75494d3ac7f978262a862b8414b3cd35c36"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}