)]}'
{"id":"openstack%2Fpython-cinderclient~469545","triplet_id":"openstack%2Fpython-cinderclient~master~I2266999df6332b8c5fb0ec808db69bcc847effb0","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1694739","hashtags":[],"change_id":"I2266999df6332b8c5fb0ec808db69bcc847effb0","subject":"Handle AttributeError in _get_server_version_range","status":"MERGED","created":"2017-05-31 15:56:56.000000000","updated":"2017-07-26 00:37:52.000000000","submitted":"2017-07-26 00:37:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"77280bb78987eec1a19382a9d402d4fd6e2874e1","_number":469545,"virtual_id_number":469545,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":2,"date":"2017-07-26 00:37:52.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-07-25 23:18:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2017-06-08 10:14:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-06-07 22:08:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":2,"date":"2017-07-25 10:04:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-07-25 23:18:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2017-06-14 15:39:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-07 22:08:22.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"},{"updated":"2017-06-08 10:14:46.000000000","updated_by":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"reviewer":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"state":"REVIEWER"},{"updated":"2017-06-14 15:39:05.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2017-07-25 10:04:46.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2017-07-25 23:18:54.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-07-26 00:37:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"32d7a17970bf6ad450268d615a2bbc43e672074c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-05-31 15:56:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7f079ad11526a9e1639bcddf7550abeace18ecee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-31 17:08:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/469545/1/check/gate-python-cinderclient-docs-ubuntu-xenial/0c94494//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/45/469545/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/bb8b52c/ : SUCCESS in 5m 10s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/45/469545/1/check/gate-python-cinderclient-python27-ubuntu-xenial/b70d02f/ : SUCCESS in 3m 30s\n- gate-python-cinderclient-python35 http://logs.openstack.org/45/469545/1/check/gate-python-cinderclient-python35/b456d89/ : SUCCESS in 6m 20s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/45/469545/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/4815d14/ : SUCCESS in 1h 10m 12s\n- gate-python-cinderclient-pypy http://logs.openstack.org/45/469545/1/check/gate-python-cinderclient-pypy/4bf12d6/ : FAILURE in 4m 12s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/45/469545/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/004b2e0/ : FAILURE in 24m 13s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/45/469545/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/2c8a248/ : FAILURE in 23m 12s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/45/469545/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/2723555/ : SUCCESS in 3m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b451601d32303c186412b88e0b5ce4ea9508c47a","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2017-06-07 22:08:22.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks fine to me. Thanks for cleaning up this bug Matt.","accounts_in_message":[],"_revision_number":1},{"id":"fcf1cf323213377a10e958b446ef23ae2fee5778","author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"date":"2017-06-08 10:14:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"fc7d56621f865295b79587637583f818d15fc1ad","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2017-07-25 10:04:46.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, thanks for the fix, Matt","accounts_in_message":[],"_revision_number":1},{"id":"b8c3667f7c86e7a625b221bcb03c3329d42f96ec","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-25 23:18:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"893c3b6d030a3338198a73d6cea41ccebbd1309d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-25 23:19:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a3caaa012a0b1c707c86940cef518510cbd2f59a","date":"2017-07-26 00:37:52.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"ec7b40d8aca502ea1f545230de5349a6826ed6ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 00:37:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/469545/1/gate/gate-python-cinderclient-docs-ubuntu-xenial/4b4b4a7//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/45/469545/1/gate/gate-python-cinderclient-pep8-ubuntu-xenial/8e251d2/ : SUCCESS in 3m 35s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/45/469545/1/gate/gate-python-cinderclient-python27-ubuntu-xenial/562673f/ : SUCCESS in 3m 38s\n- gate-python-cinderclient-python35 http://logs.openstack.org/45/469545/1/gate/gate-python-cinderclient-python35/a2d8a4c/ : SUCCESS in 3m 07s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/45/469545/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/e078dce/ : SUCCESS in 1h 17m 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e90503cba2db8aea03164f0cbaabd1c49bcc4a46","revisions":{"e90503cba2db8aea03164f0cbaabd1c49bcc4a46":{"kind":"REWORK","_number":1,"created":"2017-05-31 15:56:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/45/469545/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/45/469545/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/45/469545/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/45/469545/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/45/469545/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/45/469545/1"}}},"commit":{"parents":[{"commit":"b9a968f96dc0ac2a819d14149c57e6e4fad557fa","subject":"Merge \"Support generalized resource filter in client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b9a968f96dc0ac2a819d14149c57e6e4fad557fa"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-05-31 15:54:48.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-05-31 15:57:05.000000000","tz":-240},"subject":"Handle AttributeError in _get_server_version_range","message":"Handle AttributeError in _get_server_version_range\n\n_get_server_version_range only supports a v3 client object\nbecause ServiceManager.server_api_version() is only implemented\nfor the v3 client code. If you\u0027re trying to call this with a\nv1 or v2 client object, it will raise an AttributeError which\nis unhelpful for the end python API client.\n\nThis change handles the AttributeError and returns a more useful\nerror with an explanation of how the client code is wrong.\n\nWe could alternatively set versions \u003d None and let it return two\nempty APIVersion objects, but that seems confusing. This change\nopts to be explicit about the failure.\n\nChange-Id: I2266999df6332b8c5fb0ec808db69bcc847effb0\nCloses-Bug: #1694739\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e90503cba2db8aea03164f0cbaabd1c49bcc4a46"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e90503cba2db8aea03164f0cbaabd1c49bcc4a46"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}