)]}'
{"id":"openstack%2Fpython-cinderclient~474411","triplet_id":"openstack%2Fpython-cinderclient~master~I2a29a2d04836fd1261d45e404341bb1aa657417b","project":"openstack/python-cinderclient","branch":"master","topic":"opt/give_more_time_to_wait","hashtags":[],"change_id":"I2a29a2d04836fd1261d45e404341bb1aa657417b","subject":"[Optimize] Adds interval and increase waiting time","status":"MERGED","created":"2017-06-15 01:53:11.000000000","updated":"2017-07-28 11:31:48.000000000","submitted":"2017-07-28 10:05:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8be29021633cfc4a3fadaf22181d61fb82ea39c1","_number":474411,"virtual_id_number":474411,"owner":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-07-28 10:05:03.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-07-26 20:13:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-07-24 18:06:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":2,"date":"2017-07-28 08:24:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":1,"date":"2017-07-28 08:24:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-24 18:06:54.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"},{"updated":"2017-07-26 20:13:54.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-07-28 08:24:22.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2017-07-28 10:05:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"07a096bf567ed8d073443a8fc62cb5b3035480ce","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2017-06-15 01:53:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b4d5045bd734473c2033b83fd54775681b173430","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-15 03:22:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/474411/1/check/gate-python-cinderclient-docs-ubuntu-xenial/4ab593e//doc/build/html/ : SUCCESS in 3m 14s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/11/474411/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/d1d3fbe/ : SUCCESS in 4m 09s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/11/474411/1/check/gate-python-cinderclient-python27-ubuntu-xenial/a5ce17a/ : SUCCESS in 3m 46s\n- gate-python-cinderclient-python35 http://logs.openstack.org/11/474411/1/check/gate-python-cinderclient-python35/aa0ff58/ : SUCCESS in 3m 57s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/11/474411/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/a62082f/ : SUCCESS in 1h 24m 30s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/11/474411/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/5297212/ : SUCCESS in 25m 49s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/11/474411/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/c63dd0a/ : SUCCESS in 25m 03s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/11/474411/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/39f4861/ : SUCCESS in 4m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8ef04a01d501bb000d2560ff09131b3e0b4e5463","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-06-15 15:17:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"232006417667ad7819ae6ddf3f308e62ff61fedf","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2017-06-16 02:32:48.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c3a08d157d3b3ef809057d3f9fe512ef880c38e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-16 03:48:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/474411/2/check/gate-python-cinderclient-docs-ubuntu-xenial/9136e7d//doc/build/html/ : SUCCESS in 2m 08s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/11/474411/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/a4ab735/ : SUCCESS in 3m 03s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/11/474411/2/check/gate-python-cinderclient-python27-ubuntu-xenial/f2ab9c0/ : SUCCESS in 2m 24s\n- gate-python-cinderclient-python35 http://logs.openstack.org/11/474411/2/check/gate-python-cinderclient-python35/3c06b72/ : SUCCESS in 3m 09s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/11/474411/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/edf9123/ : SUCCESS in 1h 14m 38s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/11/474411/2/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/6c4d4ad/ : SUCCESS in 16m 07s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/11/474411/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/165afb7/ : SUCCESS in 15m 15s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/11/474411/2/check/gate-python-cinderclient-pylint-ubuntu-xenial/28b3be7/ : SUCCESS in 3m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4c036e478142d870ddc9b5faaa2fabf971c09a7f","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-06-21 09:06:17.000000000","message":"Patch Set 2:\n\nLGTM, although maybe we should have a way to configure this value instead of having a magic number in there.","accounts_in_message":[],"_revision_number":2},{"id":"3d52fe448d0743324d296c4f6d2a7036f14afd9e","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2017-07-24 18:06:54.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks fine to me, though I agree with Gorka\u0027s musing that there is probably a better way of doing it.","accounts_in_message":[],"_revision_number":2},{"id":"767458f45a4a786dfe8814c366e7bd9061ebd69e","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-26 20:13:54.000000000","message":"Patch Set 2: Code-Review+2\n\nGorka, any more detail on the approach you are thinking of?\n\nI think this is fine for now at least.","accounts_in_message":[],"_revision_number":2},{"id":"7e0f4d307036a0ee3e719b4fc29f0171142cc500","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-28 08:23:05.000000000","message":"Patch Set 1:\n\n@Sean, I\u0027m not thinking of a different approach, I meant that saying what the patch does without the reason behind the change seems insufficient to me.   It is easy to image operations taking more than 60 seconds (a full backup) and in those cases polling every second is an overkill, since you already know it\u0027s going to take a long time you don\u0027t need to poll every second, as a couple of seconds delay in detecting the status change will be insignificant compared to the operation\u0027s execution time.","accounts_in_message":[],"_revision_number":1},{"id":"0ab85651c273262f13a3e38836e9ede596e674d6","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-28 08:24:22.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks for updating the commit message.","accounts_in_message":[],"_revision_number":2},{"id":"26e149d6728a420b91c6a1b0951b695c0cfaccf5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-28 08:24:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"34902818bffbc899a377a340cbc3e50f87968fbb","date":"2017-07-28 10:05:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"441e76287ffdab7667b7c704dec96a37d7c31032","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-28 10:05:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/474411/2/gate/gate-python-cinderclient-docs-ubuntu-xenial/6dc1754//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/11/474411/2/gate/gate-python-cinderclient-pep8-ubuntu-xenial/e0c5453/ : SUCCESS in 4m 16s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/11/474411/2/gate/gate-python-cinderclient-python27-ubuntu-xenial/57ad7b3/ : SUCCESS in 3m 34s\n- gate-python-cinderclient-python35 http://logs.openstack.org/11/474411/2/gate/gate-python-cinderclient-python35/349f472/ : SUCCESS in 3m 18s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/11/474411/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/54cbf63/ : SUCCESS in 1h 40m 11s","accounts_in_message":[],"_revision_number":2},{"id":"991ad11ae332924e741381714fcf3246b7682c40","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-28 11:31:48.000000000","message":"Patch Set 2:\n\nAh, I see - thanks Gorka. I think at least this gives us the option where we could pass in different values in the places where we know we need to wait longer/less or change the frequency between checks. That will require some more work though.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"afa10404bc6d94596b1b9c3c69d85c46e67b2d34","revisions":{"7eefb94e8029b3f801c3f5bc852a3633e0ef684b":{"kind":"REWORK","_number":1,"created":"2017-06-15 01:53:11.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/11/474411/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/11/474411/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/1"}}},"commit":{"parents":[{"commit":"728e13442d4c57fc26eb81f884c3951f01767613","subject":"Merge \"Add description for function do_list_extensions in cinderclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/728e13442d4c57fc26eb81f884c3951f01767613"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-06-15 01:31:00.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-06-15 01:31:00.000000000","tz":480},"subject":"[Optimize] Increase time to wait and add interval","message":"[Optimize] Increase time to wait and add interval\n\nGives more time to wait resource\u0027s status to change\nand adds default interval for operation.\n\nChange-Id: I2a29a2d04836fd1261d45e404341bb1aa657417b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7eefb94e8029b3f801c3f5bc852a3633e0ef684b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7eefb94e8029b3f801c3f5bc852a3633e0ef684b"}]},"branch":"refs/heads/master"},"afa10404bc6d94596b1b9c3c69d85c46e67b2d34":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-06-16 02:32:48.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/11/474411/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/11/474411/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/11/474411/2"}}},"commit":{"parents":[{"commit":"728e13442d4c57fc26eb81f884c3951f01767613","subject":"Merge \"Add description for function do_list_extensions in cinderclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/728e13442d4c57fc26eb81f884c3951f01767613"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-06-15 01:31:00.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-06-16 02:27:35.000000000","tz":480},"subject":"[Optimize] Adds interval and increase waiting time","message":"[Optimize] Adds interval and increase waiting time\n\nGives more time to wait resource\u0027s status to change\nin functional testcases and adds default interval\nto reduce query amount.\n\nChange-Id: I2a29a2d04836fd1261d45e404341bb1aa657417b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/afa10404bc6d94596b1b9c3c69d85c46e67b2d34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/afa10404bc6d94596b1b9c3c69d85c46e67b2d34"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}