)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"282a20c42ead461026b662631be4304c29c380df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nidhimittalhada \u003cnidhimittal19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-26 10:40:14 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"python-cinderclient doc unclear on Volume.attach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In \u0027attach\u0027 method, documentation vaguely says \"Set attachment metadata.\""},{"line_number":10,"context_line":"Actually, this method should not be called directly by API users when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff346bd7_71ce1283","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2017-07-26 15:36:15.000000000","message":"This is not really necessary since this is a commit in the python-cinderclient repo.","commit_id":"4760157375819d689a9f3dc5c1e69e48ba23e546"}],"cinderclient/v2/volumes.py":[{"author":{"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},"change_message_id":"107e517e898dba45732f5b339a37d028ac101417","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return self.manager.update(self, **kwargs)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def attach(self, instance_uuid, mountpoint, mode\u003d\u0027rw\u0027, host_name\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Inform cinder that this volume is attached to the given instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance_uuid: uuid of the attaching instance."},{"line_number":39,"context_line":"        :param mountpoint: mountpoint on the attaching instance or host."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_52d4dce8","line":36,"updated":"2017-07-06 03:53:41.000000000","message":"I still think the text I originally proposed is better:\n\nInform Cinder that the given volume is attached to the given instance. If the volume is not actually attached to the given instance, inconsistent data will result.\nThis is not the correct way to attach a volume to an instance.","commit_id":"39c34b0ae636410791a420140efc033df9f4c506"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6b6cadc56dc5acc062512f53f1a34c9683741621","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return self.manager.update(self, **kwargs)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def attach(self, instance_uuid, mountpoint, mode\u003d\u0027rw\u0027, host_name\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Inform cinder that this volume is attached to the given instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance_uuid: uuid of the attaching instance."},{"line_number":39,"context_line":"        :param mountpoint: mountpoint on the attaching instance or host."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_c8491b61","line":36,"in_reply_to":"3f1d235d_52d4dce8","updated":"2017-07-12 11:00:29.000000000","message":"-1: Since this method is not exposed on the CLI and it\u0027s only meant for users of the library, we should explain the right flow of calls as they are intended:\n\n 1- call reserve\n 2- call initialize_connection\n 3- call attach\n\nAnd we should also update those other methods with this information.\n\nIn the same manner we should update the detach intended flow on the detaching methods.","commit_id":"39c34b0ae636410791a420140efc033df9f4c506"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"109a837141eca0963c4f32446173667b164ef17d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return self.manager.update(self, **kwargs)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def attach(self, instance_uuid, mountpoint, mode\u003d\u0027rw\u0027, host_name\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Inform Cinder that the given volume is attached to the given"},{"line_number":37,"context_line":"        instance. If the volume is not actually attached to the given instance,"},{"line_number":38,"context_line":"        inconsistent data will result. This is not the correct way to attach a"},{"line_number":39,"context_line":"        volume to an instance. The right flow of calls is :"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_9bd549e8","line":36,"updated":"2017-07-25 11:25:35.000000000","message":"-1: First line should not be formatted like this [1].\n\n[1]: https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"87784fc3b429c3000a052945e796192ab1f0b8b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"109a837141eca0963c4f32446173667b164ef17d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def attach(self, instance_uuid, mountpoint, mode\u003d\u0027rw\u0027, host_name\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Inform Cinder that the given volume is attached to the given"},{"line_number":37,"context_line":"        instance. If the volume is not actually attached to the given instance,"},{"line_number":38,"context_line":"        inconsistent data will result. This is not the correct way to attach a"},{"line_number":39,"context_line":"        volume to an instance. The right flow of calls is :"},{"line_number":40,"context_line":"        1- call reserve"},{"line_number":41,"context_line":"        2- call initialize_connection"},{"line_number":42,"context_line":"        3- call attach"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_fbf9f57f","line":39,"range":{"start_line":38,"start_character":39,"end_line":39,"end_character":30},"updated":"2017-07-25 11:25:35.000000000","message":"nit: I think this could be clearer: \"Calling this method will not actually ask Cinder to attach a volume, but to mark it on the DB as attached.\"","commit_id":"87784fc3b429c3000a052945e796192ab1f0b8b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"109a837141eca0963c4f32446173667b164ef17d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                                   host_name)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def detach(self):"},{"line_number":53,"context_line":"        \"\"\"Inform Cinder that the given volume is detached from the given"},{"line_number":54,"context_line":"        instance. If the volume is not actually detached from the given"},{"line_number":55,"context_line":"        instance, inconsistent data will result. This is not the correct way to"},{"line_number":56,"context_line":"        detach a volume from an instance. The right flow of calls is :"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_3b353d47","line":53,"updated":"2017-07-25 11:25:35.000000000","message":"-1: First line, same as above.","commit_id":"87784fc3b429c3000a052945e796192ab1f0b8b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"109a837141eca0963c4f32446173667b164ef17d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def detach(self):"},{"line_number":53,"context_line":"        \"\"\"Inform Cinder that the given volume is detached from the given"},{"line_number":54,"context_line":"        instance. If the volume is not actually detached from the given"},{"line_number":55,"context_line":"        instance, inconsistent data will result. This is not the correct way to"},{"line_number":56,"context_line":"        detach a volume from an instance. The right flow of calls is :"},{"line_number":57,"context_line":"        1- call reserve"},{"line_number":58,"context_line":"        2- call initialize_connection"},{"line_number":59,"context_line":"        3- call detach"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_7b9505e4","line":56,"range":{"start_line":55,"start_character":49,"end_line":56,"end_character":40},"updated":"2017-07-25 11:25:35.000000000","message":"nit: similar to above","commit_id":"87784fc3b429c3000a052945e796192ab1f0b8b0"}]}