)]}'
{"id":"openstack%2Fpython-cinderclient~479759","triplet_id":"openstack%2Fpython-cinderclient~master~I34af39f857b6b918de1129f5d210326b3e84d8e1","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1611613","hashtags":[],"change_id":"I34af39f857b6b918de1129f5d210326b3e84d8e1","subject":"python-cinderclient doc unclear on Volume.attach","status":"MERGED","created":"2017-07-03 09:23:27.000000000","updated":"2017-07-26 17:05:52.000000000","submitted":"2017-07-26 17:05:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"acf8a7181266c553d1cfdc184ed9985901b0bd58","_number":479759,"virtual_id_number":479759,"owner":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-07-26 17:05:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-07-26 15:36:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":2,"date":"2017-07-26 15:45:00.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":1,"date":"2017-07-26 15:45:00.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-06 03:53:41.000000000","updated_by":{"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},"reviewer":{"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"reviewer":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"reviewer":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"state":"REVIEWER"},{"updated":"2017-07-12 04:25:27.000000000","updated_by":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"reviewer":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"state":"REVIEWER"},{"updated":"2017-07-12 15:28:00.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2017-07-25 11:25:35.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2017-07-26 15:36:15.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-07-26 15:45:00.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2017-07-26 17:05:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9732da586daa0a5a65cce479a16f4823e2ad5eae","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-03 09:23:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f3ede01dc60e00d33054b34980b09d7fd7bcba5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-03 10:44:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/479759/1/check/gate-python-cinderclient-docs-ubuntu-xenial/52b37f3//doc/build/html/ : SUCCESS in 2m 02s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/479759/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/b0b60bb/ : SUCCESS in 2m 38s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/479759/1/check/gate-python-cinderclient-python27-ubuntu-xenial/eb72195/ : SUCCESS in 2m 11s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/479759/1/check/gate-python-cinderclient-python35/738ab08/ : SUCCESS in 2m 21s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/479759/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/b557e5e/ : SUCCESS in 1h 19m 31s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/479759/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/793fd54/ : SUCCESS in 17m 32s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/479759/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/495d9d2/ : SUCCESS in 24m 12s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/479759/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/af86f8e/ : SUCCESS in 2m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dc02e6214aa5dac8d51a4887cd9bfd5ee6b9feb8","author":{"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},"date":"2017-07-03 16:36:08.000000000","message":"Patch Set 1: Code-Review-1\n\nThis corrects the doc text (sort of), but does nothing about the (far worse) problem that this dangerous API is callable by unprivileged users.\nSolving the wrong problem.","accounts_in_message":[],"_revision_number":1},{"id":"161ae8b51482ca74d4bdf293a3d7dc1ab162b04c","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-04 07:21:20.000000000","message":"Patch Set 1:\n\n\u003e This corrects the doc text (sort of), but does nothing about the\n \u003e (far worse) problem that this dangerous API is callable by\n \u003e unprivileged users.\n \u003e Solving the wrong problem.\n\nHi Matthew,\n\nHow do i ensure that the caller of the function is normal user or nova?\nAny code example where such thing is done will be helpful for reference.\n\nand should we accept doc change in this bug .. and raise another bug for ownership check of caller?\n\nokay ?","accounts_in_message":[],"_revision_number":1},{"id":"107e517e898dba45732f5b339a37d028ac101417","author":{"_account_id":8905,"name":"Matthew S","email":"matthew.sanderson.au@gmail.com","username":"mattsanu"},"date":"2017-07-06 03:53:41.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6b6cadc56dc5acc062512f53f1a34c9683741621","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-12 11:00:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThe change is OK in itself, I just think that if we are going to change it we should improve it with even more detail.","accounts_in_message":[],"_revision_number":1},{"id":"4e0b7d639334786594ad1a4377d5d6e84d29055e","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2017-07-12 15:28:00.000000000","message":"Patch Set 1: Code-Review-1\n\nAgree with Gorka that this needs more work.  Should add more info to the attach and improve detach.","accounts_in_message":[],"_revision_number":1},{"id":"1c108680fc2b1e3d8e0e87b1a4943d9554d2a129","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-13 04:22:13.000000000","message":"Patch Set 1:\n\nThanks for review, coming back with a patch","accounts_in_message":[],"_revision_number":1},{"id":"7db84bc061147a40b051eb591f8b2d9be87775ae","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-24 05:35:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fc60dbbfb6854ef5d3397e4eb1cda2ae984bc20a","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-24 05:41:55.000000000","message":"Patch Set 2:\n\nWorked as per suggestion. Patch submitted.","accounts_in_message":[],"_revision_number":2},{"id":"92371f04dbe6aa56c7729a61324459f937da3c96","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-24 07:01:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/479759/2/check/gate-python-cinderclient-docs-ubuntu-xenial/a1e0d7d//doc/build/html/ : SUCCESS in 4m 57s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/479759/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/b150947/ : SUCCESS in 3m 04s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/479759/2/check/gate-python-cinderclient-python27-ubuntu-xenial/3ad183f/ : SUCCESS in 5m 04s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/479759/2/check/gate-python-cinderclient-python35/6163a51/ : SUCCESS in 5m 52s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/479759/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/cdc73b8/ : SUCCESS in 1h 25m 47s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/479759/2/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/3af7c14/ : SUCCESS in 15m 37s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/479759/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/76b44be/ : SUCCESS in 22m 38s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/479759/2/check/gate-python-cinderclient-pylint-ubuntu-xenial/1d9d783/ : SUCCESS in 2m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c4556626cb800ebdc5b5347a4f0d3a65aa8eccf1","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-24 10:25:43.000000000","message":"Patch Set 2:\n\nWaiting for review please","accounts_in_message":[],"_revision_number":2},{"id":"6cfeec59741094f08d0b773f9d13aeb631353906","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-25 05:23:34.000000000","message":"Patch Set 2:\n\nCan someone please review it ?","accounts_in_message":[],"_revision_number":2},{"id":"109a837141eca0963c4f32446173667b164ef17d","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-25 11:25:35.000000000","message":"Patch Set 2: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"79f10abc034be2bede3bc8290b0e74d8276384d3","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-26 05:11:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a518dcf626d25ea8580fc412f553e899fec33e00","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-26 05:11:40.000000000","message":"Patch Set 3:\n\nSubmitted a new patch as per Gorka\u0027s suggestion kindly see.","accounts_in_message":[],"_revision_number":3},{"id":"d5292a285366ec3826a32bbd1399f17d7efabd85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 06:45:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/479759/3/check/gate-python-cinderclient-docs-ubuntu-xenial/a498afb//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/479759/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/521b056/ : SUCCESS in 3m 28s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/479759/3/check/gate-python-cinderclient-python27-ubuntu-xenial/fdfa081/ : SUCCESS in 2m 19s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/479759/3/check/gate-python-cinderclient-python35/fb09681/ : SUCCESS in 4m 48s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/479759/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/ea19b2a/ : SUCCESS in 1h 33m 19s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/59/479759/3/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/34c25d3/ : SUCCESS in 26m 48s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/59/479759/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/55966c8/ : SUCCESS in 16m 05s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/59/479759/3/check/gate-python-cinderclient-pylint-ubuntu-xenial/9c6d9ac/ : SUCCESS in 3m 26s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"0c5bda60ab79039f89724ab16a95a81bb0575188","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-26 07:00:30.000000000","message":"Patch Set 3:\n\nCan someone please review it ?","accounts_in_message":[],"_revision_number":3},{"id":"282a20c42ead461026b662631be4304c29c380df","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-26 15:36:15.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)\n\nLooks good.\n\nPlease do not keep posting asking for reviews. Patches will get reviewed when reviewers are able to do so. There is no need to keep asking.","accounts_in_message":[],"_revision_number":3},{"id":"709affb9435ca345b00129eb954b8ddc51508040","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2017-07-26 15:45:00.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"9a7e749b10dac60dad8555f674098811e32e83c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 15:45:10.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c4b83f0ea5cf7ea1619856e0a3617068eccb72db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 17:05:51.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/479759/3/gate/gate-python-cinderclient-docs-ubuntu-xenial/f5d5181//doc/build/html/ : SUCCESS in 9m 28s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/59/479759/3/gate/gate-python-cinderclient-pep8-ubuntu-xenial/05c9da0/ : SUCCESS in 7m 29s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/59/479759/3/gate/gate-python-cinderclient-python27-ubuntu-xenial/bf30353/ : SUCCESS in 8m 40s\n- gate-python-cinderclient-python35 http://logs.openstack.org/59/479759/3/gate/gate-python-cinderclient-python35/c50f1de/ : SUCCESS in 8m 31s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/59/479759/3/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/2195301/ : SUCCESS in 1h 19m 25s","accounts_in_message":[],"_revision_number":3},{"id":"e1a27611b4eca3a6ce027a691dd00180c3640aff","date":"2017-07-26 17:05:52.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4760157375819d689a9f3dc5c1e69e48ba23e546","revisions":{"39c34b0ae636410791a420140efc033df9f4c506":{"kind":"REWORK","_number":1,"created":"2017-07-03 09:23:27.000000000","uploader":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"ref":"refs/changes/59/479759/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/479759/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/1"}}},"commit":{"parents":[{"commit":"44e650a4ed183af9fa977af192355450afd4f1b7","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/44e650a4ed183af9fa977af192355450afd4f1b7"}]}],"author":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-07-03 09:12:41.000000000","tz":330},"committer":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-07-03 09:22:56.000000000","tz":330},"subject":"python-cinderclient doc unclear on Volume.attach","message":"python-cinderclient doc unclear on Volume.attach\n\nIn \u0027attach\u0027 method, documentation vaguely says \"Set attachment metadata.\"\nActually, this method should not be called directly by API users when\nattempting to attach a Cinder volume to a Nova instance, else the Nova\nand Cinder databases will become inconsistent.\n\nInstead attach function exists solely for use by consumers of Cinder\nservices such as Nova, so that they can inform Cinder that they\u0027re\nnow using one of Cinder\u0027s volumes.\n\nHence correcting the doc text for attach function.\n\nChange-Id: I34af39f857b6b918de1129f5d210326b3e84d8e1\nCloses-Bug: #1611613\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/39c34b0ae636410791a420140efc033df9f4c506"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/39c34b0ae636410791a420140efc033df9f4c506"}]},"branch":"refs/heads/master"},"87784fc3b429c3000a052945e796192ab1f0b8b0":{"kind":"REWORK","_number":2,"created":"2017-07-24 05:35:00.000000000","uploader":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"ref":"refs/changes/59/479759/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/479759/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/2"}}},"commit":{"parents":[{"commit":"44e650a4ed183af9fa977af192355450afd4f1b7","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/44e650a4ed183af9fa977af192355450afd4f1b7"}]}],"author":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-07-03 09:12:41.000000000","tz":330},"committer":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-07-24 05:34:36.000000000","tz":330},"subject":"python-cinderclient doc unclear on Volume.attach","message":"python-cinderclient doc unclear on Volume.attach\n\nIn \u0027attach\u0027 method, documentation vaguely says \"Set attachment metadata.\"\nActually, this method should not be called directly by API users when\nattempting to attach a Cinder volume to a Nova instance, else the Nova\nand Cinder databases will become inconsistent.\n\nInstead attach function exists solely for use by consumers of Cinder\nservices such as Nova, so that they can inform Cinder that they\u0027re\nnow using one of Cinder\u0027s volumes.\n\nHence correcting the doc text for attach function.\n\nChange-Id: I34af39f857b6b918de1129f5d210326b3e84d8e1\nCloses-Bug: #1611613\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/87784fc3b429c3000a052945e796192ab1f0b8b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/87784fc3b429c3000a052945e796192ab1f0b8b0"}]},"branch":"refs/heads/master"},"4760157375819d689a9f3dc5c1e69e48ba23e546":{"kind":"REWORK","_number":3,"created":"2017-07-26 05:11:16.000000000","uploader":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"ref":"refs/changes/59/479759/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/479759/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/479759/3"}}},"commit":{"parents":[{"commit":"44e650a4ed183af9fa977af192355450afd4f1b7","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/44e650a4ed183af9fa977af192355450afd4f1b7"}]}],"author":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-07-03 09:12:41.000000000","tz":330},"committer":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-07-26 05:10:14.000000000","tz":330},"subject":"python-cinderclient doc unclear on Volume.attach","message":"python-cinderclient doc unclear on Volume.attach\n\nIn \u0027attach\u0027 method, documentation vaguely says \"Set attachment metadata.\"\nActually, this method should not be called directly by API users when\nattempting to attach a Cinder volume to a Nova instance, else the Nova\nand Cinder databases will become inconsistent.\n\nInstead attach function exists solely for use by consumers of Cinder\nservices such as Nova, so that they can inform Cinder that they\u0027re\nnow using one of Cinder\u0027s volumes.\n\nHence correcting the doc text for attach function.\n\nChange-Id: I34af39f857b6b918de1129f5d210326b3e84d8e1\nCloses-Bug: #1611613\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4760157375819d689a9f3dc5c1e69e48ba23e546"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4760157375819d689a9f3dc5c1e69e48ba23e546"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}