)]}'
{"id":"openstack%2Fpython-cinderclient~485198","triplet_id":"openstack%2Fpython-cinderclient~master~Ica4d718b3de31c31da047f07c5154b242e122596","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1705093","hashtags":[],"change_id":"Ica4d718b3de31c31da047f07c5154b242e122596","subject":"Fix highest version supported by client and server","status":"MERGED","created":"2017-07-19 12:50:45.000000000","updated":"2017-07-20 19:27:18.000000000","submitted":"2017-07-20 17:45:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"17207d0c68314bfc88764748ac8ca72f3ca12f5b","_number":485198,"virtual_id_number":485198,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-20 17:45:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"date":"2017-07-20 19:27:18.000000000","post_submit":true,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-19 15:14:10.000000000","_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2017-07-19 13:23:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"value":2,"date":"2017-07-19 17:12:27.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-07-19 19:02:07.000000000","_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-19 13:23:10.000000000","updated_by":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"reviewer":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"state":"REVIEWER"},{"updated":"2017-07-19 17:12:27.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2017-07-19 19:02:07.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2017-07-20 17:45:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-20 19:27:18.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"2d69900a60f403f56ba711254409dff0c5cc55b0","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-19 12:50:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d0bb73db377a24224ff6f720bfc2b97af6f96d00","author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"date":"2017-07-19 13:23:10.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good. I ran this change with the nova and attachment_create using v3.27 now works correctly.","accounts_in_message":[],"_revision_number":1},{"id":"94571479d90cc791c7d18e50d521b7a3af744d17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-19 14:03:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/98/485198/1/check/gate-python-cinderclient-docs-ubuntu-xenial/f33edae//doc/build/html/ : SUCCESS in 3m 44s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/98/485198/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/6307525/ : SUCCESS in 4m 44s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/98/485198/1/check/gate-python-cinderclient-python27-ubuntu-xenial/201dbed/ : SUCCESS in 4m 36s\n- gate-python-cinderclient-python35 http://logs.openstack.org/98/485198/1/check/gate-python-cinderclient-python35/d81c502/ : SUCCESS in 3m 08s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/98/485198/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/808ead7/ : SUCCESS in 1h 10m 40s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/98/485198/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/e5ac2fd/ : SUCCESS in 32m 38s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/98/485198/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/a70c7de/ : SUCCESS in 17m 08s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/98/485198/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/2711304/ : SUCCESS in 5m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"613234eb3bc039b9f001a552e4ef0db63da7aaa1","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-07-19 15:14:10.000000000","message":"Patch Set 1: Code-Review+2\n\nThis looks good. But Nova will need to change, this will break the current implementation. Should there be a dependent Nova patch?","accounts_in_message":[],"_revision_number":1},{"id":"12924702619779c5cb6ee93c17d2a37b8a21e084","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-19 16:12:56.000000000","message":"Patch Set 1:\n\nI don\u0027t think this will break Nova at all, and according to Steve this works just fine","accounts_in_message":[],"_revision_number":1},{"id":"1d162feb072a1d64adb7ce82df8abdc6edb4f27b","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2017-07-19 17:12:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d4bd056c5b381d63ddd19b7032b3d4e7bd68bcdf","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-07-19 17:51:21.000000000","message":"Patch Set 1:\n\nYes, you are right, it won\u0027t break Nova. They are just casting a string to a string, so no problem.\nThey might want to change the code, but it doesn\u0027t look necessary:\nhttps://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L71","accounts_in_message":[],"_revision_number":1},{"id":"325f3d26da2570d857b1063f18d68118c5833347","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-07-19 19:02:07.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7e8f96bd5dc110a58c778c611cdff97d571d40c1","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-20 12:38:20.000000000","message":"Patch Set 1:\n\nYeah, I commented that on the bug report, but they can only do that once the minimum cinderclient version is the one this patch is released in.","accounts_in_message":[],"_revision_number":1},{"id":"70db0dfd65e5c9ef9e21205f4b123ac42d48c915","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-20 12:40:46.000000000","message":"Patch Set 1:\n\nThis patch is dependent on a unit test fix [1] and it won\u0027t merge until the other does.\n\nThe test bug is an issue with our caching of reset state methods that I encountered when running the tests for this one.  It\u0027s one of those that only appear on specific test run orders.\n\n\n[1] https://review.openstack.org/485197","accounts_in_message":[],"_revision_number":1},{"id":"6a8da868a3000601077ab0efeef5e73533dc5677","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-20 16:09:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0950480597b580a10a12929e01f1ee0f17795564","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-20 17:45:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/98/485198/1/gate/gate-python-cinderclient-docs-ubuntu-xenial/e238d51//doc/build/html/ : SUCCESS in 3m 58s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/98/485198/1/gate/gate-python-cinderclient-pep8-ubuntu-xenial/51e4234/ : SUCCESS in 4m 32s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/98/485198/1/gate/gate-python-cinderclient-python27-ubuntu-xenial/985d56a/ : SUCCESS in 4m 35s\n- gate-python-cinderclient-python35 http://logs.openstack.org/98/485198/1/gate/gate-python-cinderclient-python35/51265f7/ : SUCCESS in 11m 35s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/98/485198/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/9927832/ : SUCCESS in 1h 34m 59s","accounts_in_message":[],"_revision_number":1},{"id":"56683cbcf5f2de69e1013c2fc5c8491e9612920e","date":"2017-07-20 17:45:31.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"f04f90318c158b93650638b4973f8052ddb73e6a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-07-20 19:27:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"52cc5c6cb3856dcddd455122742a5bf8de0fe834","revisions":{"52cc5c6cb3856dcddd455122742a5bf8de0fe834":{"kind":"REWORK","_number":1,"created":"2017-07-19 12:50:45.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/98/485198/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/98/485198/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/485198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/485198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/485198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/98/485198/1"}}},"commit":{"parents":[{"commit":"83230498eb75ce080de4fe6806b8079b0b87b144","subject":"Fix reset state v3 unit tests failures","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/83230498eb75ce080de4fe6806b8079b0b87b144"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2017-07-19 12:45:13.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2017-07-19 12:45:13.000000000","tz":120},"subject":"Fix highest version supported by client and server","message":"Fix highest version supported by client and server\n\nCurrent code mistakenly thinks that 3.40 is older than 3.27, because\nit\u0027s treating 3.40 as 3.4, thus returning the wrong maximum supported\nversion by both server and client.\n\nIt is also returning a 3.40 version as 3.4 because it\u0027s returning it as\na float.\n\nThis patch fixes both issues by not using float conversion but using the\nAPIVersion object to do the comparison and by changing returned type to\na string so it can be used to instantiate a client.\n\nChange-Id: Ica4d718b3de31c31da047f07c5154b242e122596\nCloses-Bug: #1705093\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/52cc5c6cb3856dcddd455122742a5bf8de0fe834"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/52cc5c6cb3856dcddd455122742a5bf8de0fe834"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}