)]}'
{"id":"openstack%2Fpython-cinderclient~485805","triplet_id":"openstack%2Fpython-cinderclient~master~I6a35d0451b1e144e7fc4a03c55b72709f0851041","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1705093","hashtags":[],"change_id":"I6a35d0451b1e144e7fc4a03c55b72709f0851041","subject":"Make get_highest_client_server_version return a float again","status":"ABANDONED","created":"2017-07-20 20:12:34.000000000","updated":"2017-07-21 08:25:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2c51c23dab54da7752b7eb9bf81639ebca5962d8","_number":485805,"virtual_id_number":485805,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"date":"2017-07-20 20:14:04.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"all":[{"value":-2,"date":"2017-07-20 20:17:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2017-07-20 20:13:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-20 20:13:47.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2017-07-20 20:17:33.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"}],"messages":[{"id":"008c4f62b1d57bb955b66a04f1d063551647dcb0","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-07-20 20:12:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cb2e33ead2cc2a0be2884732834f32c78aba1a05","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-07-20 20:14:04.000000000","message":"Patch Set 1:\n\nAlternatively, we leave it the way it is now (returning a string), and just add a release note.","accounts_in_message":[],"_revision_number":1},{"id":"d4578d6b42f9a198eedaf93458891ce0e38414f3","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2017-07-20 20:17:33.000000000","message":"Patch Set 1: Code-Review-2\n\nReturning  float cause 3.40 to be evaluated as 3.4","accounts_in_message":[],"_revision_number":1},{"id":"528b5539e842d44045b2be2830a49af6b825c5ea","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-07-20 20:20:02.000000000","message":"Patch Set 1:\n\n\u003e Returning float cause 3.40 to be evaluated as 3.4\n\nThe eval is already done before we cast to a float, otherwise the test would be failing, yes?","accounts_in_message":[],"_revision_number":1},{"id":"4033976488eda6c3d325d1b9ed5785cc9c9265a1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-07-20 20:40:32.000000000","message":"Abandoned\n\nI\u0027ve got it sorted out now. The problem was never that the cinderclient method was returning the wrong thing, it was that when Nova cast it to a str, it turned a 3.40 float into a 3.4 string:\n\nhttp://paste.openstack.org/show/616084/\n\nSo the commit message in Gorka\u0027s change was really confusing because it wasn\u0027t the cinderclient code\u0027s fault really. So I\u0027ll drop this and just push a release note for the API change.","accounts_in_message":[],"_revision_number":1},{"id":"a1723291133199ce99634e8f8ff11ad5082d197a","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-07-21 08:25:18.000000000","message":"Patch Set 1:\n\nThe commit message is correct, and it was cinderclient\u0027s fault, as I say in the commit message:\n\n It is also returning a 3.40 version as 3.4 because it\u0027s returning it \n as a float.\n\nIf the method returns a float instead of a string then it will have the same representation for different values, for example in a float 3.40 equals 3.4\n\nAlso, since we were doing a float conversion when we compared versions, then we have the case were 3.40 becomes 3.4 and when compared to 3.27 it would be considered as the minimum of both.  So the minimum version of 3.40 to 3.27 results in 3.4.\n\nIn summary, doing float comparison bad, returning float bad.  This is properly explained in the bug as well as in my commit message.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ae5148958ed9aa3f1301d9e3079c61a8350443c9","revisions":{"ae5148958ed9aa3f1301d9e3079c61a8350443c9":{"kind":"REWORK","_number":1,"created":"2017-07-20 20:12:34.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/05/485805/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/05/485805/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/05/485805/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/05/485805/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/05/485805/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/05/485805/1"}}},"commit":{"parents":[{"commit":"52cc5c6cb3856dcddd455122742a5bf8de0fe834","subject":"Fix highest version supported by client and server","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/52cc5c6cb3856dcddd455122742a5bf8de0fe834"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-07-20 20:10:54.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-07-20 20:10:54.000000000","tz":-240},"subject":"Make get_highest_client_server_version return a float again","message":"Make get_highest_client_server_version return a float again\n\nChange Ica4d718b3de31c31da047f07c5154b242e122596 changed\nget_highest_client_server_version to return a string\nrather than a float for no apparent reason. Nova is using\nthis public API method and already casts the float to a\nstring, but it seems like an unnecessary change anyway.\n\nGiven this type of thing means we need a major version bump\nand likely a release note, it\u0027s simpler to just change it\nback to the return type that it used before.\n\nChange-Id: I6a35d0451b1e144e7fc4a03c55b72709f0851041\nRelated-Bug: #1705093\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/ae5148958ed9aa3f1301d9e3079c61a8350443c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/ae5148958ed9aa3f1301d9e3079c61a8350443c9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}