)]}'
{"cinderclient/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7b76d97ec2e2fcfc04650c272df61d00aa8b9f58","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        # get_volume_api_version_from_endpoint if an iaasgateway is being used."},{"line_number":457,"context_line":"        # This allows a user to override the check by setting the API version"},{"line_number":458,"context_line":"        # in the environment."},{"line_number":459,"context_line":"        if \"OS_VOLUME_API_VERSION\" in os.environ:"},{"line_number":460,"context_line":"            version \u003d os.environ.get(\"OS_VOLUME_API_VERSION\", None)"},{"line_number":461,"context_line":"            endpoint_api_version \u003d \"v%s\" % version"},{"line_number":462,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FzTg%3D","line":459,"updated":"2013-10-09 16:15:07.000000000","message":"More straightforward (EAFP) as:\n\nversion \u003d os.environ.get(\"OS_VOLUME_API_VERSION\", None)\nif version is not None:\n   ...","commit_id":"ea3ecc617057db6f4bab605dbb60f4228545a2fe"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e5ffd5100d4140c8443a2d9aaf7e9e8b6bff1b47","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        # get_volume_api_version_from_endpoint if an iaasgateway is being used."},{"line_number":457,"context_line":"        # This allows a user to override the check by setting the API version"},{"line_number":458,"context_line":"        # in the environment."},{"line_number":459,"context_line":"        if \"OS_VOLUME_API_VERSION\" in os.environ:"},{"line_number":460,"context_line":"            version \u003d os.environ.get(\"OS_VOLUME_API_VERSION\", None)"},{"line_number":461,"context_line":"            endpoint_api_version \u003d \"v%s\" % version"},{"line_number":462,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FyfA%3D","line":459,"in_reply_to":"AAAATH%2F%2FzTg%3D","updated":"2013-10-09 19:51:40.000000000","message":"Done","commit_id":"ea3ecc617057db6f4bab605dbb60f4228545a2fe"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"eef92ffe1fd19cbb680c8bf384880c1600f5566a","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                               \"specified version: %s\" %"},{"line_number":483,"context_line":"                               endpoint_api_version)"},{"line_number":484,"context_line":"            else:"},{"line_number":485,"context_line":"                logger.warn(\"Unable to determine the API version from \""},{"line_number":486,"context_line":"                            \"endpoint URL or user input.  Falling back to \""},{"line_number":487,"context_line":"                            \"default API version: %s\" % endpoint_api_version)"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FXu8%3D","line":485,"updated":"2013-10-17 03:16:11.000000000","message":"logger.warning instead of logger.warn\n\nThe semantics of the old logger.warn are deprecated and aren\u0027t compatible with 3.x versions.  Not sure if the distinction here was intentional or not?","commit_id":"b0904cf647fc5fc0907d9e296dd9525db7d79f06"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2cb4514a114c02d8474a20d5c445c51d1e01a9b7","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                               \"specified version: %s\" %"},{"line_number":483,"context_line":"                               endpoint_api_version)"},{"line_number":484,"context_line":"            else:"},{"line_number":485,"context_line":"                logger.warn(\"Unable to determine the API version from \""},{"line_number":486,"context_line":"                            \"endpoint URL or user input.  Falling back to \""},{"line_number":487,"context_line":"                            \"default API version: %s\" % endpoint_api_version)"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FUeI%3D","line":485,"in_reply_to":"AAAATH%2F%2FXu8%3D","updated":"2013-10-17 19:48:27.000000000","message":"Thanks for catching that.  I had seen that logger.warn was deprecated and that was why I used logger.warning. Meant to do that for both.  :-)","commit_id":"b0904cf647fc5fc0907d9e296dd9525db7d79f06"}]}
