)]}'
{"cinderclient/api_versions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"11026fbc53e9abf159a62a97ea827e6a9acc3d64","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# key is a deprecated version and value is an alternative version."},{"line_number":30,"context_line":"DEPRECATED_VERSIONS \u003d {\"1\": \"2\"}"},{"line_number":31,"context_line":"DEPRECATED_VERSION \u003d \"2.0\""},{"line_number":32,"context_line":"MAX_VERSION \u003d \"3.44\""},{"line_number":33,"context_line":"MIN_VERSION \u003d \"3.0\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_SUBSTITUTIONS \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f1a89e78","line":32,"updated":"2017-09-07 17:08:33.000000000","message":"You skip microversions? What if someone requests 3.41 or 3.43?","commit_id":"b7d34684607bbc0d8c507970661d0b1d3bed7843"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf85e94b23cee93644fb69c16bd101d33016301d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# key is a deprecated version and value is an alternative version."},{"line_number":30,"context_line":"DEPRECATED_VERSIONS \u003d {\"1\": \"2\"}"},{"line_number":31,"context_line":"DEPRECATED_VERSION \u003d \"2.0\""},{"line_number":32,"context_line":"MAX_VERSION \u003d \"3.44\""},{"line_number":33,"context_line":"MIN_VERSION \u003d \"3.0\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_SUBSTITUTIONS \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f773ee4c","line":32,"in_reply_to":"7f287b81_f1a89e78","updated":"2017-09-07 18:17:38.000000000","message":"FWIW, novaclient has a unit test that checks for CLI decorated methods for new microversions and we can skip ones that we don\u0027t implement in the client like this:\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L3088\n\nIt at least helps to remember if we\u0027re doing them in order.\n\nMaybe add a note next to this variable that these numbers should go in order so people reviewing this in the future don\u0027t forget about it.","commit_id":"b7d34684607bbc0d8c507970661d0b1d3bed7843"}],"cinderclient/v3/attachments.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce13924e17781e38977c1b0ae892c0d82f2b6629","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        return self.resource_class(self, resp[\u0027attachment\u0027], loaded\u003dTrue,"},{"line_number":68,"context_line":"                                   resp\u003dresp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def complete(self, attachment):"},{"line_number":71,"context_line":"        \"\"\"Mark the attachment as completed.\"\"\""},{"line_number":72,"context_line":"        resp, body \u003d self._action_return_resp_and_body(\u0027os-complete\u0027,"},{"line_number":73,"context_line":"                                                       attachment,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_cc73c44d","line":70,"updated":"2017-09-07 19:35:29.000000000","message":"This should be using the cinderclient.api_version.wraps decorator since it\u0027s only valid to use at 3.44 and above.","commit_id":"b7d34684607bbc0d8c507970661d0b1d3bed7843"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4fc9878e77a5d83aff4aa778a4988deaf4718818","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        return self.resource_class(self, resp[\u0027attachment\u0027], loaded\u003dTrue,"},{"line_number":68,"context_line":"                                   resp\u003dresp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def complete(self, attachment):"},{"line_number":71,"context_line":"        \"\"\"Mark the attachment as completed.\"\"\""},{"line_number":72,"context_line":"        resp, body \u003d self._action_return_resp_and_body(\u0027os-complete\u0027,"},{"line_number":73,"context_line":"                                                       attachment,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_0cdb0ced","line":70,"in_reply_to":"7f287b81_cc73c44d","updated":"2017-09-07 19:43:28.000000000","message":"bug 1715732","commit_id":"b7d34684607bbc0d8c507970661d0b1d3bed7843"}]}