)]}'
{"id":"openstack%2Fpython-cinderclient~494978","triplet_id":"openstack%2Fpython-cinderclient~master~Ic1a743ce36a087f369703f10313d51b79b5cab9c","project":"openstack/python-cinderclient","branch":"master","topic":"opt/remove_class_name","hashtags":[],"change_id":"Ic1a743ce36a087f369703f10313d51b79b5cab9c","subject":"Remove unused attribute when updating quota_class","status":"MERGED","created":"2017-08-18 07:20:43.000000000","updated":"2017-11-02 07:56:21.000000000","submitted":"2017-11-02 07:56:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"494978-1509609381313-a94d6b6c","meta_rev_id":"c91d3e3baab9c31b8307ef847a11c327974a3f22","_number":494978,"virtual_id_number":494978,"owner":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2017-10-11 17:28:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2017-11-02 03:52:55.000000000","_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":2,"date":"2017-11-02 07:56:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-09-08 16:44:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-24 01:28:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":2,"date":"2017-10-11 15:57:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":1,"date":"2017-10-11 15:57:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-24 01:28:03.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"},{"updated":"2017-09-08 16:44:27.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-10-11 15:57:03.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2017-10-11 17:28:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-11-02 07:56:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d6f68a852afcd3b3c577befb668778afeafcaf1","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2017-08-18 07:20:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95026f6a8046bffc706411ad5e87b67298b24e3f","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2017-08-18 07:26:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6ea2a37f9fa5115b5108ded147843a90d3571230","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-18 10:19:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/78/494978/2/check/gate-python-cinderclient-docs-ubuntu-xenial/22f5dbe//doc/build/html/ : SUCCESS in 5m 44s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/78/494978/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/c7fe769/ : SUCCESS in 4m 35s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/78/494978/2/check/gate-python-cinderclient-python27-ubuntu-xenial/5a64e73/ : SUCCESS in 3m 58s\n- gate-python-cinderclient-python35 http://logs.openstack.org/78/494978/2/check/gate-python-cinderclient-python35/fc3c00e/ : SUCCESS in 5m 53s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/78/494978/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/aeae10c/ : SUCCESS in 1h 08m 51s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/78/494978/2/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/4e39064/ : SUCCESS in 26m 17s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/78/494978/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/8651290/ : SUCCESS in 30m 28s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/78/494978/2/check/gate-python-cinderclient-pylint-ubuntu-xenial/44b6a7f/ : SUCCESS in 5m 33s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5a3606d3d4d872b818cb9394d8460c097df3a35a","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2017-08-24 01:28:03.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks fine to me. Thanks for cleaning this up.","accounts_in_message":[],"_revision_number":2},{"id":"07c00184bae8ef10860bb6747b4356ee2ca021e3","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-09-08 16:44:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9bb3dbfcb87d09c8fd4ccf93c62c790b6e00483e","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2017-10-11 15:57:03.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"65cba8ffe8de20b6419b8d79e1ec82d1f22778de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 15:57:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"511d8a0e93b918ab21adf76f40b3bf84759cb9bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 17:28:50.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/78/494978/2/gate/gate-python-cinderclient-docs-ubuntu-xenial/bfce9b1//doc/build/html/ : SUCCESS in 3m 20s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/78/494978/2/gate/gate-python-cinderclient-pep8-ubuntu-xenial/96eae88/ : FAILURE in 1m 29s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/78/494978/2/gate/gate-python-cinderclient-python27-ubuntu-xenial/650a708/ : FAILURE in 2m 00s\n- gate-python-cinderclient-python35 http://logs.openstack.org/78/494978/2/gate/gate-python-cinderclient-python35/8a8c639/ : FAILURE in 2m 03s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/78/494978/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/27ae69f/ : SUCCESS in 1h 07m 07s","accounts_in_message":[],"_revision_number":2},{"id":"2970f200455e17818cc34b11d29565b7fa000e7d","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-10-16 00:45:29.000000000","message":"Removed Verified-2 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":2},{"id":"dc7738b4d9c508216b38b1a426fd46a239b8e482","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2017-11-02 03:52:55.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"a1b07c8edfae2e65c9be876480a92bf15ff504b5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 05:14:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/78/494978/2/check/openstack-tox-pep8/c19f793/ : SUCCESS in 4m 26s\n- openstack-tox-py27 http://logs.openstack.org/78/494978/2/check/openstack-tox-py27/8ef21ea/ : SUCCESS in 4m 39s\n- openstack-tox-py35 http://logs.openstack.org/78/494978/2/check/openstack-tox-py35/e4316f4/ : SUCCESS in 4m 02s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/494978/2/check/build-openstack-sphinx-docs/2ceaf76/html/ : SUCCESS in 4m 57s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/78/494978/2/check/legacy-tempest-dsvm-neutron-src/7414318/ : SUCCESS in 1h 16m 10s\n- legacy-cinderclient-dsvm-functional http://logs.openstack.org/78/494978/2/check/legacy-cinderclient-dsvm-functional/176c0c6/ : FAILURE in 26m 46s (non-voting)\n- legacy-cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/78/494978/2/check/legacy-cinderclient-dsvm-functional-identity-v3-only/b1d1d1e/ : FAILURE in 27m 24s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/78/494978/2/check/openstack-tox-pylint/dfee2cb/ : SUCCESS in 4m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f457294858440443396158e28adb60d9690451eb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 05:14:59.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b30da05bce2421368a79cdafcbe7fcc003f7029b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 07:56:20.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/78/494978/2/gate/openstack-tox-pep8/7b60315/ : SUCCESS in 4m 07s\n- openstack-tox-py27 http://logs.openstack.org/78/494978/2/gate/openstack-tox-py27/9f76eec/ : SUCCESS in 5m 06s\n- openstack-tox-py35 http://logs.openstack.org/78/494978/2/gate/openstack-tox-py35/e0c8f78/ : SUCCESS in 4m 19s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/494978/2/gate/build-openstack-sphinx-docs/a18147a/html/ : SUCCESS in 4m 33s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/78/494978/2/gate/legacy-tempest-dsvm-neutron-src/ae41b57/ : SUCCESS in 1h 16m 09s","accounts_in_message":[],"_revision_number":2},{"id":"599e6a974d0b3651a331a17ebd7af3acc657de1b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 07:56:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2c05b83a8c9445cee06a890789f1e0727cf479be","revisions":{"a9be2d25950c6fa5b3422b1e3b7c830b74313cff":{"kind":"REWORK","_number":1,"created":"2017-08-18 07:20:43.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/78/494978/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/78/494978/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/1"}}},"commit":{"parents":[{"commit":"b7d34684607bbc0d8c507970661d0b1d3bed7843","subject":"Add an attachment_complete API call","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b7d34684607bbc0d8c507970661d0b1d3bed7843"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-08-18 07:12:23.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-08-18 07:18:15.000000000","tz":480},"subject":"Remove unused attribute when updating quota_class","message":"Remove unused attribute when updating quota_class\n\nWhen updating quota class, attribute \u0027class_name\u0027 is\nneither used in the request nor the response [1].\n\n[1]:\nhttps://github.com/openstack/cinder/blob/master/cinder/api/contrib/quota_classes.py#L56\n\nChange-Id: Ic1a743ce36a087f369703f10313d51b79b5cab9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a9be2d25950c6fa5b3422b1e3b7c830b74313cff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a9be2d25950c6fa5b3422b1e3b7c830b74313cff"}]},"branch":"refs/heads/master"},"2c05b83a8c9445cee06a890789f1e0727cf479be":{"kind":"REWORK","_number":2,"created":"2017-08-18 07:26:43.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/78/494978/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/78/494978/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/78/494978/2"}}},"commit":{"parents":[{"commit":"b7d34684607bbc0d8c507970661d0b1d3bed7843","subject":"Add an attachment_complete API call","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b7d34684607bbc0d8c507970661d0b1d3bed7843"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-08-18 07:12:23.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2017-08-18 07:25:30.000000000","tz":480},"subject":"Remove unused attribute when updating quota_class","message":"Remove unused attribute when updating quota_class\n\nWhen updating quota class, attribute \u0027class_name\u0027 is\nneither used in the request nor the response [1].\n\n[1]:\nhttps://github.com/openstack/cinder/blob/master/cinder/api/contrib/quota_classes.py#L56\n\nChange-Id: Ic1a743ce36a087f369703f10313d51b79b5cab9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2c05b83a8c9445cee06a890789f1e0727cf479be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2c05b83a8c9445cee06a890789f1e0727cf479be"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}