)]}'
{"id":"openstack%2Fpython-cinderclient~498055","triplet_id":"openstack%2Fpython-cinderclient~master~I9ec36af5dd460d03d786aeeb3cc36a869c19ff62","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1713082","hashtags":[],"change_id":"I9ec36af5dd460d03d786aeeb3cc36a869c19ff62","subject":"Fix attachment_id returned by create and show volume","status":"MERGED","created":"2017-08-25 18:33:08.000000000","updated":"2017-08-28 22:25:02.000000000","submitted":"2017-08-28 22:25:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6231591d94970f4b9aeaedd02c163f9ca244858f","_number":498055,"virtual_id_number":498055,"owner":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2017-08-28 22:25:02.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":2,"date":"2017-08-28 21:03:14.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-28 13:50:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":2,"date":"2017-08-28 17:29:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":1,"date":"2017-08-28 21:03:14.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-28 13:50:47.000000000","updated_by":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"reviewer":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"state":"REVIEWER"},{"updated":"2017-08-28 17:29:54.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2017-08-28 21:03:14.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2017-08-28 22:25:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"76e1a9876fe6562e0624952491764a4af9ac9d1a","author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"date":"2017-08-25 18:33:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e528db501bedcd29a7751364afd6ecc6510788b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-25 20:00:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/498055/1/check/gate-python-cinderclient-docs-ubuntu-xenial/7b7b6ea//doc/build/html/ : SUCCESS in 7m 01s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/498055/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/cd40e7f/ : SUCCESS in 3m 46s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/498055/1/check/gate-python-cinderclient-python27-ubuntu-xenial/bfb6ea7/ : SUCCESS in 3m 09s\n- gate-python-cinderclient-python35 http://logs.openstack.org/55/498055/1/check/gate-python-cinderclient-python35/d1a4408/ : SUCCESS in 3m 27s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/55/498055/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/4c6cbcf/ : SUCCESS in 1h 21m 52s\n- gate-python-cinderclient-releasenotes http://docs-draft.openstack.org/55/498055/1/check/gate-python-cinderclient-releasenotes/902c855//releasenotes/build/html/ : SUCCESS in 3m 09s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/55/498055/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/9941090/ : SUCCESS in 23m 21s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/55/498055/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/cb271a7/ : SUCCESS in 26m 25s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/55/498055/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/1feea7d/ : SUCCESS in 3m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7846c80a9bc74f94baaafb1748286f1520a34898","author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"date":"2017-08-25 20:13:37.000000000","message":"Patch Set 1:\n\nThanks for the fix Steve, it looks good to me.\n\nThe only nit is to please add the bug number to the commit message too.\n\nBest Regards,\nIldikó","accounts_in_message":[],"_revision_number":1},{"id":"b7f58f7d72216bc06b73493c8cd781c02293b4be","author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"date":"2017-08-28 12:37:44.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"147f5a015284e39fa0442358ea18440fe3a738b0","author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"date":"2017-08-28 13:50:47.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6e9021c844ebbf4804e35bfa6ad8ffe8103ac59c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-28 14:00:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/498055/2/check/gate-python-cinderclient-docs-ubuntu-xenial/e6f2680//doc/build/html/ : SUCCESS in 3m 13s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/498055/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/f7a4dfc/ : SUCCESS in 3m 16s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/498055/2/check/gate-python-cinderclient-python27-ubuntu-xenial/3484412/ : SUCCESS in 3m 29s\n- gate-python-cinderclient-python35 http://logs.openstack.org/55/498055/2/check/gate-python-cinderclient-python35/50cb583/ : SUCCESS in 4m 24s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/55/498055/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/b93205a/ : SUCCESS in 1h 20m 28s\n- gate-python-cinderclient-releasenotes http://docs-draft.openstack.org/55/498055/2/check/gate-python-cinderclient-releasenotes/457ad51//releasenotes/build/html/ : SUCCESS in 3m 43s\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/55/498055/2/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/f5f9deb/ : SUCCESS in 26m 42s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/55/498055/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1a1b3da/ : SUCCESS in 24m 20s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/55/498055/2/check/gate-python-cinderclient-pylint-ubuntu-xenial/01c6df3/ : SUCCESS in 3m 49s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"dd14f8a42506f859bbd02a07fb28668e89531f25","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2017-08-28 17:29:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"375dcfde5853a9de84970c4f2289c944ee6aa19d","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2017-08-28 21:03:14.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"86d3673f87b7ae1e7ef57d9c092b9d84c8892b98","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-28 21:03:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2736a45f8b29ad0458cc7cef07ac9d494a5b956f","date":"2017-08-28 22:25:02.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"00d8ebafd74157e99a75489b0b718005881c7f02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-28 22:25:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/498055/2/gate/gate-python-cinderclient-docs-ubuntu-xenial/4b671f7//doc/build/html/ : SUCCESS in 3m 53s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/498055/2/gate/gate-python-cinderclient-pep8-ubuntu-xenial/f1ced9f/ : SUCCESS in 4m 52s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/498055/2/gate/gate-python-cinderclient-python27-ubuntu-xenial/79c9308/ : SUCCESS in 3m 39s\n- gate-python-cinderclient-python35 http://logs.openstack.org/55/498055/2/gate/gate-python-cinderclient-python35/386c232/ : SUCCESS in 4m 29s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/55/498055/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/98639bc/ : SUCCESS in 1h 21m 06s\n- gate-python-cinderclient-releasenotes http://docs-draft.openstack.org/55/498055/2/gate/gate-python-cinderclient-releasenotes/da9f718//releasenotes/build/html/ : SUCCESS in 4m 03s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aab7a587b6a10a964ca79d7e81a4563a143fcf12","revisions":{"4c6ab740c33b6a2c9bd662caaea457a02ddfc306":{"kind":"REWORK","_number":1,"created":"2017-08-25 18:33:08.000000000","uploader":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"ref":"refs/changes/55/498055/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/55/498055/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/1"}}},"commit":{"parents":[{"commit":"e3e2f4d397f7176e5be8add3e1edd824520a028a","subject":"Fix method/module redefinition errors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e3e2f4d397f7176e5be8add3e1edd824520a028a"}]}],"author":{"name":"Steve Noyes","email":"steve.noyes@oracle.com","date":"2017-08-25 18:23:18.000000000","tz":-240},"committer":{"name":"Steve Noyes","email":"steve.noyes@oracle.com","date":"2017-08-25 18:28:10.000000000","tz":-240},"subject":"Fix attachment_id returned by create and show volume","message":"Fix attachment_id returned by create and show volume\n\nThe attachment_ids in the volume info returned by show volume\nwere incorrect. It was showing the volume_id, not the actual\nattachment_id. This fix changes the attachment_ids returned by show\nvolume to correctly reflect the attachment_id.\n\nAlso, added a unit test for this, and added an attachment_id\nto the fake volume so that other tests wouldn\u0027t now fail.\n\nChange-Id: I9ec36af5dd460d03d786aeeb3cc36a869c19ff62\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4c6ab740c33b6a2c9bd662caaea457a02ddfc306"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4c6ab740c33b6a2c9bd662caaea457a02ddfc306"}]},"branch":"refs/heads/master"},"aab7a587b6a10a964ca79d7e81a4563a143fcf12":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-08-28 12:37:44.000000000","uploader":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"ref":"refs/changes/55/498055/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/55/498055/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/55/498055/2"}}},"commit":{"parents":[{"commit":"e3e2f4d397f7176e5be8add3e1edd824520a028a","subject":"Fix method/module redefinition errors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e3e2f4d397f7176e5be8add3e1edd824520a028a"}]}],"author":{"name":"Steve Noyes","email":"steve.noyes@oracle.com","date":"2017-08-25 18:23:18.000000000","tz":-240},"committer":{"name":"Steve Noyes","email":"steve.noyes@oracle.com","date":"2017-08-28 12:36:12.000000000","tz":-240},"subject":"Fix attachment_id returned by create and show volume","message":"Fix attachment_id returned by create and show volume\n\nThe attachment_ids in the volume info returned by show volume\nwere incorrect. It was showing the volume_id, not the actual\nattachment_id. This fix changes the attachment_ids returned by show\nvolume to correctly reflect the attachment_id.\n\nAlso, added a unit test for this, and added an attachment_id\nto the fake volume so that other tests wouldn\u0027t now fail.\n\nCloses-Bug: #1713082\nChange-Id: I9ec36af5dd460d03d786aeeb3cc36a869c19ff62\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/aab7a587b6a10a964ca79d7e81a4563a143fcf12"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/aab7a587b6a10a964ca79d7e81a4563a143fcf12"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}