)]}'
{"cinderclient/client.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"2fb94dca2964db076b33a5eac4580022a4bdf86a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":157,"context_line":"        apiver \u003d kwargs.pop(\u0027api_version\u0027, None) or api_versions.APIVersion()"},{"line_number":158,"context_line":"        if isinstance(apiver, str):"},{"line_number":159,"context_line":"            apiver \u003d api_versions.APIVersion(apiver)"},{"line_number":160,"context_line":"        if apiver.ver_minor !\u003d 0:"},{"line_number":161,"context_line":"            kwargs[\u0027default_microversion\u0027] \u003d apiver.get_string()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_230c8b3f","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":35},"updated":"2017-09-28 20:22:31.000000000","message":"Ok, nit pickiness on my part:  Do we want to use isinstance here as opposed to letting the pop above with a default of None do it\u0027s thing and then cast it into a string?  What I mean is that if a float rep of a valid version makes it\u0027s way here it would sure be swell if we were like \"ok\"","commit_id":"8b04a21537f319e964834f556dd834e1a182c71e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a4a5ae67f63cc9d95d5ad71f0e890aed763caf52","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":157,"context_line":"        apiver \u003d kwargs.pop(\u0027api_version\u0027, None) or api_versions.APIVersion()"},{"line_number":158,"context_line":"        if isinstance(apiver, str):"},{"line_number":159,"context_line":"            apiver \u003d api_versions.APIVersion(apiver)"},{"line_number":160,"context_line":"        if apiver.ver_minor !\u003d 0:"},{"line_number":161,"context_line":"            kwargs[\u0027default_microversion\u0027] \u003d apiver.get_string()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_de535038","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":35},"in_reply_to":"7f515b1d_230c8b3f","updated":"2017-09-28 20:53:37.000000000","message":"I was actually accounting for the fact that we sometimes seem to get an APIVersion here, and sometimes a string.  (Which is weird, cause I can\u0027t see how the old code ever worked for string.)  But you\u0027re right; this would be better as:\n\n if not isinstance(apiver, api_versions.APIVersion):\n     apiver \u003d api_versions.APIVersion(str(apiver))","commit_id":"8b04a21537f319e964834f556dd834e1a182c71e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1fff2a2148784cdc7ad5e1410513958ce0b11db8","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":157,"context_line":"        apiver \u003d kwargs.pop(\u0027api_version\u0027, None) or api_versions.APIVersion()"},{"line_number":158,"context_line":"        if not isinstance(apiver, api_versions.APIVersion):"},{"line_number":159,"context_line":"            apiver \u003d api_versions.APIVersion(str(apiver))"},{"line_number":160,"context_line":"        if apiver.ver_minor !\u003d 0:"},{"line_number":161,"context_line":"            kwargs[\u0027default_microversion\u0027] \u003d apiver.get_string()"},{"line_number":162,"context_line":"        self.retries \u003d kwargs.pop(\u0027retries\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_3905de46","line":159,"range":{"start_line":158,"start_character":8,"end_line":159,"end_character":57},"updated":"2017-09-28 21:34:45.000000000","message":"Awesome, that\u0027s even better!  Thanks!","commit_id":"571e5d8c4d089b8082782c13ec83861b7e59364c"}]}