)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ea69906f49989189d875ba3946cd8be6e92d379","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This form of multiattach was never fully supported and is now being"},{"line_number":10,"context_line":"replaced by the new mutliattach workflow with Nova. As part of this,"},{"line_number":11,"context_line":"volume type extra specs will be used to indicate multiattach ability"},{"line_number":12,"context_line":"and will allow retying between volume types to change the flag after"},{"line_number":13,"context_line":"creation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"That work is still in progress and has some potential to change. But"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_432b7193","line":12,"range":{"start_line":12,"start_character":15,"end_line":12,"end_character":22},"updated":"2017-12-21 21:41:25.000000000","message":"retyping","commit_id":"0077bf962ccfd7bb6b10257bf4a222b5ecfce4a0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aed8456ec32fb70480c8175be7a68c491bc16d0c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This form of multiattach was never fully supported and is now being"},{"line_number":10,"context_line":"replaced by the new mutliattach workflow with Nova. As part of this,"},{"line_number":11,"context_line":"volume type extra specs will be used to indicate multiattach ability"},{"line_number":12,"context_line":"and will allow retying between volume types to change the flag after"},{"line_number":13,"context_line":"creation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"That work is still in progress and has some potential to change. But"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_46329ff3","line":12,"range":{"start_line":12,"start_character":15,"end_line":12,"end_character":22},"in_reply_to":"bf8cb3f7_432b7193","updated":"2017-12-28 19:49:28.000000000","message":"Done","commit_id":"0077bf962ccfd7bb6b10257bf4a222b5ecfce4a0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"589fd8fecefe190e0a603e71ae12e6d3f94fb1be","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This form of multiattach was never fully supported and is now being"},{"line_number":10,"context_line":"replaced by the new mutliattach workflow with Nova. As part of this,"},{"line_number":11,"context_line":"volume type extra specs will be used to indicate multiattach ability"},{"line_number":12,"context_line":"and will allow retyping between volume types to change the flag after"},{"line_number":13,"context_line":"creation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"That work is still in progress and has some potential to change. But"},{"line_number":16,"context_line":"we know we are not going to support this old style, so we should get"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf8cb3f7_e60413c9","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":9},"updated":"2017-12-21 22:01:53.000000000","message":"This spec specifically says you can\u0027t retype an in-use multiattach volume. Do you want to clarify that here to set expectations?","commit_id":"5149c324525f8ee30fc4738ccdad26a3d7de21f3"}],"cinderclient/v2/volumes.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"589fd8fecefe190e0a603e71ae12e6d3f94fb1be","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            volume_metadata \u003d metadata"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        if multiattach:"},{"line_number":273,"context_line":"            warnings.warn(\u0027The ``multiattach`` volume create flag is \u0027"},{"line_number":274,"context_line":"                          \u0027deprecated and will be removed in a future \u0027"},{"line_number":275,"context_line":"                          \u0027release. Multiattach capability is now controlled \u0027"},{"line_number":276,"context_line":"                          \u0027using volume type extra specs.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_46ffffa9","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":25},"updated":"2017-12-21 22:01:53.000000000","message":"This defaults to UserWarning, but I think you want to use DeprecationWarning?\n\nhttps://docs.python.org/2/library/warnings.html#warnings.warn","commit_id":"5149c324525f8ee30fc4738ccdad26a3d7de21f3"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ea69906f49989189d875ba3946cd8be6e92d379","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                               metadata\u003dvolume_metadata,"},{"line_number":612,"context_line":"                               scheduler_hints\u003dhints,"},{"line_number":613,"context_line":"                               source_replica\u003dargs.source_replica,"},{"line_number":614,"context_line":"                               multiattach\u003dargs.multiattach,"},{"line_number":615,"context_line":"                               backup_id\u003dbackup_id)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    info \u003d dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_630d553d","line":614,"range":{"start_line":614,"start_character":31,"end_line":614,"end_character":59},"updated":"2017-12-21 21:41:25.000000000","message":"What if someone is using the python API bindings directly instead of the CLI? They won\u0027t see the warning. Probably need to use the warnings module in the actual API binding code if multiattach is specified in kwargs (unless it defaults to False and you can\u0027t tell...).","commit_id":"0077bf962ccfd7bb6b10257bf4a222b5ecfce4a0"}],"releasenotes/notes/deprecate-allow-multiattach-2213a100c65a95c1.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"87e4346259303599b0e76812ca80276834ba4b87","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``--allow-multiattach`` flag on volume creation has now been marked"},{"line_number":5,"context_line":"    deprecated and will be removed in a future release. Cinder multiattach is"},{"line_number":6,"context_line":"    now supported through volume type extra-specs that will allow retype."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf8cb3f7_c33f81d4","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"updated":"2017-12-21 21:38:53.000000000","message":"Is it? Or is that dependent on some changes in the server?","commit_id":"0077bf962ccfd7bb6b10257bf4a222b5ecfce4a0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aed8456ec32fb70480c8175be7a68c491bc16d0c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``--allow-multiattach`` flag on volume creation has now been marked"},{"line_number":5,"context_line":"    deprecated and will be removed in a future release. Cinder multiattach is"},{"line_number":6,"context_line":"    now supported through volume type extra-specs that will allow retype."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf8cb3f7_26351bdb","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"in_reply_to":"bf8cb3f7_c33f81d4","updated":"2017-12-28 19:49:28.000000000","message":"Maybe a little optimistic/forward looking statement, but that will be the way this is supported going forward.","commit_id":"0077bf962ccfd7bb6b10257bf4a222b5ecfce4a0"}]}