)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"ca3704f6d9a29531a913056cc9db35f1798a9492","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix offset"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"offset can be 0, so I set that offset is not None."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0928e12eb7fa33271680ccc0b4af5d4060dcfc88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_948ff1cb","line":10,"updated":"2018-01-09 02:37:46.000000000","message":"Commit message should be improved [1].\n\n[1]: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"cfe6008d9ac3573a67e1d3b583ac3509b8f62714"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"1e46372058bc50268ef39b94bd0bd53ec737684f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhengyin \u003czhengyin@chinac.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-09 11:15:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify offset judgment conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"offset can be 0, if judgment condition is \"if offset\","},{"line_number":10,"context_line":"then zero does not meet the conditions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_77310f5a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2018-01-09 03:32:05.000000000","message":"This is not clear, should be something like \"Fix offset 0 in _build_list_url.\"","commit_id":"8ccddbb3c5b5f030dc009803968cb532b80d5bb1"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"1e46372058bc50268ef39b94bd0bd53ec737684f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify offset judgment conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"offset can be 0, if judgment condition is \"if offset\","},{"line_number":10,"context_line":"then zero does not meet the conditions."},{"line_number":11,"context_line":"So I set \"if offset is not None\", zero can meet conditions"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0928e12eb7fa33271680ccc0b4af5d4060dcfc88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_3785c7cf","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":57},"updated":"2018-01-09 03:32:05.000000000","message":"Something like \"When offset is 0, _build_list_url will failed to build query_params. Just test wheter offset is not a None instead.\"?","commit_id":"8ccddbb3c5b5f030dc009803968cb532b80d5bb1"}],"cinderclient/base.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"ca3704f6d9a29531a913056cc9db35f1798a9492","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                query_params[\u0027sort_dir\u0027] \u003d self._format_sort_dir_param("},{"line_number":169,"context_line":"                    sort_dir)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if offset is not None:"},{"line_number":172,"context_line":"            query_params[\u0027offset\u0027] \u003d offset"},{"line_number":173,"context_line":"        query_params \u003d utils.unicode_key_value_to_string(query_params)"},{"line_number":174,"context_line":"        # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_34baa56d","line":171,"updated":"2018-01-09 02:37:46.000000000","message":"Need a new unittest for this fix.","commit_id":"cfe6008d9ac3573a67e1d3b583ac3509b8f62714"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"1e46372058bc50268ef39b94bd0bd53ec737684f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                query_params[\u0027sort_dir\u0027] \u003d self._format_sort_dir_param("},{"line_number":169,"context_line":"                    sort_dir)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if offset is not None:"},{"line_number":172,"context_line":"            query_params[\u0027offset\u0027] \u003d offset"},{"line_number":173,"context_line":"        query_params \u003d utils.unicode_key_value_to_string(query_params)"},{"line_number":174,"context_line":"        # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_d7b25b94","line":171,"updated":"2018-01-09 03:32:05.000000000","message":"I just realized that when offset is 0, the url list should still be valid without the \"offset\u003d0\" parameter, that is:\n\"xxx?offset\u003d0\" and \"xxx\" should be both right.\n\nWould you please explain why \"offset\u003d0\" should be included? Thanks.","commit_id":"8ccddbb3c5b5f030dc009803968cb532b80d5bb1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a54d67209f2709556351326d940e062d0ca3ea09","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                query_params[\u0027sort_dir\u0027] \u003d self._format_sort_dir_param("},{"line_number":169,"context_line":"                    sort_dir)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if offset is not None:"},{"line_number":172,"context_line":"            query_params[\u0027offset\u0027] \u003d offset"},{"line_number":173,"context_line":"        query_params \u003d utils.unicode_key_value_to_string(query_params)"},{"line_number":174,"context_line":"        # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_c68f4b2c","line":171,"in_reply_to":"9f91af0f_d7b25b94","updated":"2018-01-23 21:48:01.000000000","message":"Zhao is correct. Said another way, the way it was didn\u0027t matter, because either way is valid and results in the same query. Because asking for offset\u003d0 is functionally the same as not asking for any offset.","commit_id":"8ccddbb3c5b5f030dc009803968cb532b80d5bb1"}]}