)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e329e5d60d81647d8f3cc348320ea5f49a4b3826","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate to keystoneauth identity cli opts."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is inspired by NovaClient."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e"},{"line_number":12,"context_line":"Co-Authored-By: David Hu \u003cdavid.hu@hp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_df74a038","line":9,"updated":"2018-01-09 16:17:01.000000000","message":"It would be good to describe what this change does.","commit_id":"c9c4c0a66aba588da513831674bc1582f3d2f572"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e329e5d60d81647d8f3cc348320ea5f49a4b3826","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-Authored-By: David Hu \u003cdavid.hu@hp.com\u003e"},{"line_number":13,"context_line":"Co-Authored-By: Monty Taylor \u003cmordred@inaugust.com\u003e"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1742052"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I3c5141eeddd3747ff542e95b04e4848470ad9508"},{"line_number":18,"context_line":"Signed-off-by: Zhao Chao \u003czhaochao1984@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_3f7cac1d","line":15,"updated":"2018-01-09 16:17:01.000000000","message":"Please use bug 1734945.","commit_id":"c9c4c0a66aba588da513831674bc1582f3d2f572"}],"cinderclient/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c0fe880381b6ac706523f04bb5658229542af41b","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        return parser"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _append_global_identity_args(self, parser):"},{"line_number":241,"context_line":"        # Migrate to keystoneauth1 cli opts. This is inspired by novaclient."},{"line_number":242,"context_line":"        # Thanks to: Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e,"},{"line_number":243,"context_line":"        # David Hu \u003cdavid.hu@hp.com\u003e, Monty Taylor \u003cmordred@inaugust.com\u003e"},{"line_number":244,"context_line":"        loading.register_session_argparse_arguments(parser)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Use \"password\" auth plugin as default and keep the explicit"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_048c2f34","line":243,"range":{"start_line":241,"start_character":0,"end_line":243,"end_character":73},"updated":"2018-01-16 10:33:54.000000000","message":"-1: This comment adds no value to our code base.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9b2876b5e278548907100cedd4d95c23a601d4f0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        return parser"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _append_global_identity_args(self, parser):"},{"line_number":241,"context_line":"        # Migrate to keystoneauth1 cli opts. This is inspired by novaclient."},{"line_number":242,"context_line":"        # Thanks to: Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e,"},{"line_number":243,"context_line":"        # David Hu \u003cdavid.hu@hp.com\u003e, Monty Taylor \u003cmordred@inaugust.com\u003e"},{"line_number":244,"context_line":"        loading.register_session_argparse_arguments(parser)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Use \"password\" auth plugin as default and keep the explicit"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_c5239ebc","line":243,"range":{"start_line":241,"start_character":0,"end_line":243,"end_character":73},"in_reply_to":"7f96bb07_048c2f34","updated":"2018-01-16 14:27:57.000000000","message":"Right, as this is the same content as commit message, I\u0027ll remove it.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c0fe880381b6ac706523f04bb5658229542af41b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            \u0027--os_auth_strategy\u0027,"},{"line_number":263,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Move auth_system and auth_type here from get_base_parser,"},{"line_number":266,"context_line":"        # because auth_type argument will be added by keystoneauth."},{"line_number":267,"context_line":"        parser.set_defaults(os_auth_type\u003d(utils.env(\u0027OS_AUTH_TYPE\u0027) or"},{"line_number":268,"context_line":"                                          utils.env(\u0027OS_AUTH_SYSTEM\u0027)))"},{"line_number":269,"context_line":"        parser.add_argument(\u0027--os_auth_type\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_846eff2c","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":67},"updated":"2018-01-16 10:33:54.000000000","message":"nit: It may be clearer if we just mention \"Change os_auth_type default defined by register_session_argparse_arguments to be backward compatible with OS_AUTH_SYSTEM\"","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9b2876b5e278548907100cedd4d95c23a601d4f0","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            \u0027--os_auth_strategy\u0027,"},{"line_number":263,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Move auth_system and auth_type here from get_base_parser,"},{"line_number":266,"context_line":"        # because auth_type argument will be added by keystoneauth."},{"line_number":267,"context_line":"        parser.set_defaults(os_auth_type\u003d(utils.env(\u0027OS_AUTH_TYPE\u0027) or"},{"line_number":268,"context_line":"                                          utils.env(\u0027OS_AUTH_SYSTEM\u0027)))"},{"line_number":269,"context_line":"        parser.add_argument(\u0027--os_auth_type\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_5033cef6","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":67},"in_reply_to":"7f96bb07_846eff2c","updated":"2018-01-16 14:27:57.000000000","message":"Thx, this is better, as also mentions what\u0027s going to be done below.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c0fe880381b6ac706523f04bb5658229542af41b","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        # Move auth_system and auth_type here from get_base_parser,"},{"line_number":266,"context_line":"        # because auth_type argument will be added by keystoneauth."},{"line_number":267,"context_line":"        parser.set_defaults(os_auth_type\u003d(utils.env(\u0027OS_AUTH_TYPE\u0027) or"},{"line_number":268,"context_line":"                                          utils.env(\u0027OS_AUTH_SYSTEM\u0027)))"},{"line_number":269,"context_line":"        parser.add_argument(\u0027--os_auth_type\u0027,"},{"line_number":270,"context_line":"                            help\u003dargparse.SUPPRESS)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_e4ba636c","line":268,"range":{"start_line":268,"start_character":57,"end_line":268,"end_character":58},"updated":"2018-01-16 10:33:54.000000000","message":"-1: Since we are going to use this same value of os-auth-system we should use a variable, and probably use the short form `utils.env(\u0027OS_AUTH_TYPE\u0027, \u0027OS_AUTH_SYSTEM\u0027)`\n\nOn a related note, with this code we don\u0027t support OS_AUTH_PLUGIN which is a keystoneauth1 supporte env variable, but if we pass `default\u003dutils.env(\u0027OS_AUTH_SYSTEM\u0027)` to `register_session_argparse_arguments` we will support the 3 env variables.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9b2876b5e278548907100cedd4d95c23a601d4f0","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        # Move auth_system and auth_type here from get_base_parser,"},{"line_number":266,"context_line":"        # because auth_type argument will be added by keystoneauth."},{"line_number":267,"context_line":"        parser.set_defaults(os_auth_type\u003d(utils.env(\u0027OS_AUTH_TYPE\u0027) or"},{"line_number":268,"context_line":"                                          utils.env(\u0027OS_AUTH_SYSTEM\u0027)))"},{"line_number":269,"context_line":"        parser.add_argument(\u0027--os_auth_type\u0027,"},{"line_number":270,"context_line":"                            help\u003dargparse.SUPPRESS)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_96238e56","line":268,"range":{"start_line":268,"start_character":57,"end_line":268,"end_character":58},"in_reply_to":"7f96bb07_e4ba636c","updated":"2018-01-16 14:27:57.000000000","message":"I\u0027ll go with a temporary variable to hold this value.\n\nThanks for pointing out supporting os-auth-plugin. I found we cannot just pass `default\u003dutils.env(\u0027OS_AUTH_SYSETM\u0027)` to `register_session_argparse_arguments`, because although OS_AUTH_PLUGIN will work in this way, but \u0027--os-auth-plugin\u0027 fails as we are not passing argv to keystoneauth1, and then keystoneauth1 cannot tell get the right auth plugin. To make this patch simple, I\u0027ll override os_auth_type default value to either OS_AUTY_TYPE or OS_AUTH_PLUGIN or OS_AUTH_SYSTEM instead.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c0fe880381b6ac706523f04bb5658229542af41b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                            metavar\u003d\u0027\u003cos-auth-system\u003e\u0027,"},{"line_number":274,"context_line":"                            dest\u003d\u0027os_auth_type\u0027,"},{"line_number":275,"context_line":"                            default\u003d(utils.env(\u0027OS_AUTH_TYPE\u0027) or"},{"line_number":276,"context_line":"                                     utils.env(\u0027OS_AUTH_SYSTEM\u0027)),"},{"line_number":277,"context_line":"                            help\u003d_(\u0027DEPRECATED! Use --os-auth-type. \u0027"},{"line_number":278,"context_line":"                                   \u0027Defaults to env[OS_AUTH_SYSTEM].\u0027))"},{"line_number":279,"context_line":"        parser.add_argument(\u0027--os_auth_system\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_8426ffcd","line":276,"updated":"2018-01-16 10:33:54.000000000","message":"-1: We either use a variable generated on L267 or if we go with the second options to support OS_AUTH_PLUGIN we set this to:\n\n default\u003dparser.get_default(\u0027os_auth_type\u0027),","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9b2876b5e278548907100cedd4d95c23a601d4f0","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                            metavar\u003d\u0027\u003cos-auth-system\u003e\u0027,"},{"line_number":274,"context_line":"                            dest\u003d\u0027os_auth_type\u0027,"},{"line_number":275,"context_line":"                            default\u003d(utils.env(\u0027OS_AUTH_TYPE\u0027) or"},{"line_number":276,"context_line":"                                     utils.env(\u0027OS_AUTH_SYSTEM\u0027)),"},{"line_number":277,"context_line":"                            help\u003d_(\u0027DEPRECATED! Use --os-auth-type. \u0027"},{"line_number":278,"context_line":"                                   \u0027Defaults to env[OS_AUTH_SYSTEM].\u0027))"},{"line_number":279,"context_line":"        parser.add_argument(\u0027--os_auth_system\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_d6b35609","line":276,"in_reply_to":"7f96bb07_8426ffcd","updated":"2018-01-16 14:27:57.000000000","message":"See the above reply, thanks.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c0fe880381b6ac706523f04bb5658229542af41b","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # tenant_name is deprecated by project_name in keystoneauth"},{"line_number":293,"context_line":"        parser.set_defaults(os_project_name\u003dutils.env(\u0027OS_TENANT_NAME\u0027,"},{"line_number":294,"context_line":"                                                      \u0027OS_PROJECT_NAME\u0027,"},{"line_number":295,"context_line":"                                                      \u0027CINDER_PROJECT_ID\u0027))"},{"line_number":296,"context_line":"        parser.add_argument(\u0027--os_tenant_name\u0027,"},{"line_number":297,"context_line":"                            dest\u003d\u0027os_project_name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_9f3f2cb3","line":294,"updated":"2018-01-16 10:33:54.000000000","message":"?: Shouldn\u0027t we give priority to OS_PROJECT_NAME over the others?","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9b2876b5e278548907100cedd4d95c23a601d4f0","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # tenant_name is deprecated by project_name in keystoneauth"},{"line_number":293,"context_line":"        parser.set_defaults(os_project_name\u003dutils.env(\u0027OS_TENANT_NAME\u0027,"},{"line_number":294,"context_line":"                                                      \u0027OS_PROJECT_NAME\u0027,"},{"line_number":295,"context_line":"                                                      \u0027CINDER_PROJECT_ID\u0027))"},{"line_number":296,"context_line":"        parser.add_argument(\u0027--os_tenant_name\u0027,"},{"line_number":297,"context_line":"                            dest\u003d\u0027os_project_name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_b6ceca7f","line":294,"in_reply_to":"7f96bb07_9f3f2cb3","updated":"2018-01-16 14:27:57.000000000","message":"done","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c0fe880381b6ac706523f04bb5658229542af41b","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            \u0027--os_project_name\u0027,"},{"line_number":301,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # tenant_id is deprecated by project_id in keystoneauth"},{"line_number":304,"context_line":"        parser.set_defaults(os_project_id\u003dutils.env(\u0027OS_TENANT_ID\u0027,"},{"line_number":305,"context_line":"                                                    \u0027OS_PROJECT_ID\u0027,"},{"line_number":306,"context_line":"                                                    \u0027CINDER_TENANT_ID\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_1f547cfe","line":303,"updated":"2018-01-16 10:33:54.000000000","message":"?: Shouldn\u0027t we give priority to OS_PROJECT_ID over the others?","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9b2876b5e278548907100cedd4d95c23a601d4f0","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            \u0027--os_project_name\u0027,"},{"line_number":301,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # tenant_id is deprecated by project_id in keystoneauth"},{"line_number":304,"context_line":"        parser.set_defaults(os_project_id\u003dutils.env(\u0027OS_TENANT_ID\u0027,"},{"line_number":305,"context_line":"                                                    \u0027OS_PROJECT_ID\u0027,"},{"line_number":306,"context_line":"                                                    \u0027CINDER_TENANT_ID\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_76c4c25f","line":303,"in_reply_to":"7f96bb07_1f547cfe","updated":"2018-01-16 14:27:57.000000000","message":"done.","commit_id":"6688e345e302b7998ec1f171fbb6b03afe0fc728"}]}