)]}'
{"id":"openstack%2Fpython-cinderclient~535486","triplet_id":"openstack%2Fpython-cinderclient~master~I31cfab9f647af5f2ef3363116cdd1adbad3b772a","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1680444","hashtags":[],"change_id":"I31cfab9f647af5f2ef3363116cdd1adbad3b772a","subject":"Removes unicode response for \"cinder get-capabilities\"","status":"ABANDONED","created":"2018-01-18 21:26:16.000000000","updated":"2018-01-24 11:13:46.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3993a63264553631870e3e0e7f0a0677b1bf1fea","_number":535486,"virtual_id_number":535486,"owner":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":1,"date":"2018-01-19 04:56:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"date":"2018-01-23 16:44:32.000000000","_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"disliked":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":-1,"date":"2018-01-23 11:26:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-2,"date":"2018-01-19 15:32:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-18 21:26:32.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2018-01-19 04:56:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-19 15:32:21.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2018-01-23 11:26:21.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"3067724aaceb78d06c8a8ed562446d662e001199","author":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"date":"2018-01-18 21:26:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4845cdd3d78d72146b0b4e795da866cd484e789f","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2018-01-18 21:26:32.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"e6630de50b2e3e09e0ebe1d634f1c96b20d48813","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 23:11:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/86/535486/1/check/openstack-tox-pep8/5a436e2/ : FAILURE in 4m 25s\n- openstack-tox-py27 http://logs.openstack.org/86/535486/1/check/openstack-tox-py27/e5d4135/ : SUCCESS in 5m 37s\n- openstack-tox-py35 http://logs.openstack.org/86/535486/1/check/openstack-tox-py35/fceeee3/ : SUCCESS in 5m 17s\n- build-openstack-sphinx-docs http://logs.openstack.org/86/535486/1/check/build-openstack-sphinx-docs/2056fbd/html/ : SUCCESS in 4m 07s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/86/535486/1/check/legacy-tempest-dsvm-neutron-src/fcac61c/ : SUCCESS in 1h 28m 11s\n- openstack-tox-pylint http://logs.openstack.org/86/535486/1/check/openstack-tox-pylint/4dbbfdf/ : SUCCESS in 4m 33s (non-voting)\n- cinderclient-dsvm-functional http://logs.openstack.org/86/535486/1/check/cinderclient-dsvm-functional/f797204/ : SUCCESS in 25m 43s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/86/535486/1/check/cinderclient-dsvm-functional-identity-v3-only/3b04dee/ : SUCCESS in 27m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a5f9c4d663dcc3f638255ab74f3f9ee6c9d9484b","author":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"date":"2018-01-19 03:41:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"66acf17711a61c54ec90c5ccde4f4178acc2a673","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-19 04:56:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/86/535486/2/check/openstack-tox-pep8/e6b0dcc/ : SUCCESS in 4m 19s\n- openstack-tox-py27 http://logs.openstack.org/86/535486/2/check/openstack-tox-py27/dbdf825/ : SUCCESS in 4m 52s\n- openstack-tox-py35 http://logs.openstack.org/86/535486/2/check/openstack-tox-py35/e164380/ : SUCCESS in 4m 36s\n- build-openstack-sphinx-docs http://logs.openstack.org/86/535486/2/check/build-openstack-sphinx-docs/0bd4bbd/html/ : SUCCESS in 3m 44s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/86/535486/2/check/legacy-tempest-dsvm-neutron-src/8675572/ : SUCCESS in 1h 10m 00s\n- openstack-tox-pylint http://logs.openstack.org/86/535486/2/check/openstack-tox-pylint/2acca41/ : SUCCESS in 3m 43s (non-voting)\n- cinderclient-dsvm-functional http://logs.openstack.org/86/535486/2/check/cinderclient-dsvm-functional/c7dc944/ : SUCCESS in 27m 43s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/86/535486/2/check/cinderclient-dsvm-functional-identity-v3-only/156a212/ : SUCCESS in 31m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"148d1b4497142abbef132baad3f82ff6d766fe4f","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2018-01-19 15:32:21.000000000","message":"Patch Set 2: Code-Review-2\n\nI don\u0027t understand why you are making another patch here instead of just updating the original.  Can you please do that instead?","accounts_in_message":[],"_revision_number":2},{"id":"60c3a19216590f9ebd36d2865cdfd61e2658dd4b","author":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"date":"2018-01-20 19:28:04.000000000","message":"Patch Set 2:\n\n\u003e I don\u0027t understand why you are making another patch here instead of\n \u003e just updating the original.  Can you please do that instead?\n\nSorry, I am a newbie to Gerrit review process and I got to know later that I could use the same commit point of the different owner from Gerrit to continue patching. Will improvise :).  Please check I have submitted the patch for original review.","accounts_in_message":[],"_revision_number":2},{"id":"407b103ad9e022726997dc5f4512126f5cf223df","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-01-23 11:26:21.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThis patch should be abandoned.","accounts_in_message":[],"_revision_number":2},{"id":"be7806d8eab26733b7715da5b4e24ac4e39d63f9","author":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"date":"2018-01-23 16:44:32.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nSure, will abandon it.","accounts_in_message":[],"_revision_number":2},{"id":"bf4885a2fa88d3a061694989471f345cf6e2af60","author":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"date":"2018-01-24 11:13:46.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"38477969cf351eb831cca383992d0cb684111844","revisions":{"86e47787bf84a48a5d3d8d5079db9b8ae2574831":{"kind":"REWORK","_number":1,"created":"2018-01-18 21:26:16.000000000","uploader":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"ref":"refs/changes/86/535486/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/86/535486/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/1"}}},"commit":{"parents":[{"commit":"0a323eaf942869439edc05a89c6cc226033bbe6c","subject":"Merge \"Support for reporting backend state in service list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0a323eaf942869439edc05a89c6cc226033bbe6c"}]}],"author":{"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","date":"2018-01-18 20:25:10.000000000","tz":330},"committer":{"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","date":"2018-01-18 21:23:53.000000000","tz":330},"subject":"Removes unicode response for \"cinder get-capabilities\"","message":"Removes unicode response for \"cinder get-capabilities\"\n\nThis is a patch for existing change referred at https://review.openstack.org/454159,\nAdded formatters\u003dsorted(prop.keys()) as suggested by the reviewer, to avoid tying server\nknowledge to the client and also any update on the server side would easily reflect here.\n\nCloses-bug: #1680444\n\nChange-Id: I31cfab9f647af5f2ef3363116cdd1adbad3b772a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/86e47787bf84a48a5d3d8d5079db9b8ae2574831"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/86e47787bf84a48a5d3d8d5079db9b8ae2574831"}]},"branch":"refs/heads/master"},"38477969cf351eb831cca383992d0cb684111844":{"kind":"REWORK","_number":2,"created":"2018-01-19 03:41:39.000000000","uploader":{"_account_id":27311,"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","username":"abijithanadagouda"},"ref":"refs/changes/86/535486/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/86/535486/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/86/535486/2"}}},"commit":{"parents":[{"commit":"0a323eaf942869439edc05a89c6cc226033bbe6c","subject":"Merge \"Support for reporting backend state in service list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0a323eaf942869439edc05a89c6cc226033bbe6c"}]}],"author":{"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","date":"2018-01-18 20:25:10.000000000","tz":330},"committer":{"name":"Abijitha Nadagouda","email":"abijitha.nadagouda@tatacommunications.com","date":"2018-01-19 03:38:28.000000000","tz":330},"subject":"Removes unicode response for \"cinder get-capabilities\"","message":"Removes unicode response for \"cinder get-capabilities\"\n\nThis is a patch for existing change referred at https://review.openstack.org/454159,\nAdded formatters\u003dsorted(prop.keys()) as suggested by the reviewer, to avoid tying server\nknowledge to the client and also any update on the server side would easily reflect here.\n\nFixed PEP8 style.\n\nCloses-bug: #1680444\n\nChange-Id: I31cfab9f647af5f2ef3363116cdd1adbad3b772a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/38477969cf351eb831cca383992d0cb684111844"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/38477969cf351eb831cca383992d0cb684111844"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
