)]}'
{"id":"openstack%2Fpython-cinderclient~553936","triplet_id":"openstack%2Fpython-cinderclient~master~I0cbaa862532e174fbc07a231eaf2453c99111ff5","project":"openstack/python-cinderclient","branch":"master","topic":"endpoint-override","hashtags":[],"change_id":"I0cbaa862532e174fbc07a231eaf2453c99111ff5","subject":"Rename bypass_url to endpoint_override","status":"ABANDONED","created":"2018-03-17 04:40:57.000000000","updated":"2020-04-03 13:07:30.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2a3d7e4b11099d9eefd1f04e665e47f945bc4082","_number":553936,"virtual_id_number":553936,"owner":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2018-03-17 07:08:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"date":"2018-07-26 23:57:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":-1,"date":"2018-03-19 18:54:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2018-03-20 14:43:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-17 07:08:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-03-19 18:54:22.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2018-03-20 14:43:35.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2018-07-26 23:57:43.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"3f1f31fe420ef26ba58f4c51f11c9e8eaa333c9c","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2018-03-17 04:40:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a4c70b2b61dc33f962af68842ab96d5859ffdb87","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2018-03-17 05:25:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9e370ff85a1d8b1628d3c4c774ab62ff90e5fb6d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-17 07:08:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/36/553936/2/check/openstack-tox-pep8/c5ca40b/ : SUCCESS in 2m 21s\n- openstack-tox-py27 http://logs.openstack.org/36/553936/2/check/openstack-tox-py27/470733d/ : SUCCESS in 3m 15s\n- openstack-tox-py35 http://logs.openstack.org/36/553936/2/check/openstack-tox-py35/2622621/ : SUCCESS in 2m 37s\n- build-openstack-sphinx-docs http://logs.openstack.org/36/553936/2/check/build-openstack-sphinx-docs/b69e78d/html/ : SUCCESS in 2m 13s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/36/553936/2/check/legacy-tempest-dsvm-neutron-src/9b915c4/ : SUCCESS in 1h 37m 54s\n- openstack-tox-pylint http://logs.openstack.org/36/553936/2/check/openstack-tox-pylint/86e46d6/ : SUCCESS in 3m 01s (non-voting)\n- cinderclient-dsvm-functional http://logs.openstack.org/36/553936/2/check/cinderclient-dsvm-functional/02a2392/ : SUCCESS in 24m 35s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/36/553936/2/check/cinderclient-dsvm-functional-identity-v3-only/37a248d/ : SUCCESS in 26m 18s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"90237a59a165c7b76dc1281e800d394cc8aac602","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2018-03-19 18:54:22.000000000","message":"Patch Set 2: Code-Review-1\n\nIt makes code backward-incompatible. Please, follow the deprecation policy [1] and add release notes for this patch.\n\n[1] https://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html#requirements","accounts_in_message":[],"_revision_number":2},{"id":"5ca37f8fd821c758e2523d05af0d4b1cf3bb09de","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-23 16:15:00.000000000","message":"Patch Set 2:\n\nSome forward looking guy already deprecated the user facing side of this over a year ago:\n\n60f92db7049b4f66e5198b86bfecc1029b6cdccd\n\n:)","accounts_in_message":[],"_revision_number":2},{"id":"29f86ee97eac9bdb8727718e0b187b3cc25a0b86","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-23 16:16:34.000000000","message":"Patch Set 2: Code-Review+2\n\nThis looks good to me. Was going to update to remove the deprecated options, but I think there are some other deprecated things that should be included with that that are maybe outside the scope of this patch.","accounts_in_message":[],"_revision_number":2},{"id":"660f8b6dd56141b6268dd8c55b744cd182ea83d2","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-26 23:46:53.000000000","message":"Removed Code-Review+2 by Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"64958c2cbc8e710d0abc4d7dfe4a840809671689","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-26 23:57:43.000000000","message":"Patch Set 2:\n\nThis should probably have a release note with something under the \"Upgrade\" section stating that this has been changed.\n\nThough something similar now has been brought up in another review that we are changing the library API for this call. It looks like the CLI options were deprecated, but I don\u0027t think we ever had anything warning that the API call would change. It may be better, though definitely not as clean, to leave the kwarg name the same, but pass it on using the new name to make the call to Cinder.","accounts_in_message":[],"_revision_number":2},{"id":"044f33858f7896a729dd393dd5befdc325ad1ab5","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-04-03 13:07:30.000000000","message":"Abandoned\n\nSuperseded by https://review.opendev.org/#/c/714572/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6931bea8a43502ac90508af361205a44f0830955","revisions":{"495238d5775185867922aae4217f2698d09f8542":{"kind":"REWORK","_number":1,"created":"2018-03-17 04:40:57.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/36/553936/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/36/553936/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/1"}}},"commit":{"parents":[{"commit":"df68d53fc59273ea89f33ed191a3cc1a311231e5","subject":"Add bindep.txt for system packages","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/df68d53fc59273ea89f33ed191a3cc1a311231e5"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2018-03-16 22:14:18.000000000","tz":-420},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2018-03-17 04:39:36.000000000","tz":-420},"subject":"Rename bypass_url to endpoint_override","message":"Rename bypass_url to endpoint_override\n\nkeystoneauth expects an \u0027endpoint_override\u0027 argument to set an endpoint\nwith its noauth plugin or to override the catalog when creating a\nsession. The \u0027bypass_url\u0027 variable name has been replaced with\n\u0027endpoint_override\u0027 where a SessionClient is created to allow users to\nexplicitly provide a cinder endpoint and everywhere else it was used for\nconsistency.\n\nChange-Id: I0cbaa862532e174fbc07a231eaf2453c99111ff5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/495238d5775185867922aae4217f2698d09f8542"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/495238d5775185867922aae4217f2698d09f8542"}]},"branch":"refs/heads/master"},"6931bea8a43502ac90508af361205a44f0830955":{"kind":"REWORK","_number":2,"created":"2018-03-17 05:25:01.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/36/553936/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/36/553936/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/36/553936/2"}}},"commit":{"parents":[{"commit":"df68d53fc59273ea89f33ed191a3cc1a311231e5","subject":"Add bindep.txt for system packages","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/df68d53fc59273ea89f33ed191a3cc1a311231e5"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2018-03-16 22:14:18.000000000","tz":-420},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2018-03-17 05:24:53.000000000","tz":-420},"subject":"Rename bypass_url to endpoint_override","message":"Rename bypass_url to endpoint_override\n\nkeystoneauth expects an \u0027endpoint_override\u0027 argument to set an endpoint\nwith its noauth plugin or to override the catalog when creating a\nsession. The \u0027bypass_url\u0027 variable name has been replaced with\n\u0027endpoint_override\u0027 where a SessionClient is created to allow users to\nexplicitly provide a cinder endpoint and everywhere else it was used for\nconsistency.\n\nChange-Id: I0cbaa862532e174fbc07a231eaf2453c99111ff5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6931bea8a43502ac90508af361205a44f0830955"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6931bea8a43502ac90508af361205a44f0830955"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}