)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"566780d443ccde590619a6d53d17224227496e7e","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"           choices\u003d(\u0027Volume\u0027, \u0027Snapshot\u0027),"},{"line_number":1082,"context_line":"           help\u003d\u0027Type of resource to cleanup.\u0027)"},{"line_number":1083,"context_line":"@utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,"},{"line_number":1084,"context_line":"           help\u003d\u0027Service id. Default\u003dNone.\u0027)"},{"line_number":1085,"context_line":"def do_work_cleanup(cs, args):"},{"line_number":1086,"context_line":"    \"\"\"Request cleanup of services with optional filtering.\"\"\""},{"line_number":1087,"context_line":"    filters \u003d dict(cluster_name\u003dargs.cluster, host\u003dargs.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7318bc74","line":1084,"range":{"start_line":1084,"start_character":17,"end_line":1084,"end_character":27},"updated":"2018-05-18 07:47:12.000000000","message":"-1: Explicitly mention that this refers to the service id field in the DB, not the uuid of the service to avoid confusion.","commit_id":"8a8885a5aef9413b3e400b0d6e6d1ccab22545e8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e12bf5a369cf7dd6364c54f4849ff03b13e89723","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"           choices\u003d(\u0027Volume\u0027, \u0027Snapshot\u0027),"},{"line_number":1082,"context_line":"           help\u003d\u0027Type of resource to cleanup.\u0027)"},{"line_number":1083,"context_line":"@utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,"},{"line_number":1084,"context_line":"           help\u003d\u0027The service id field is from the DB, not the uuid of the\u0027"},{"line_number":1085,"context_line":"                \u0027 service. Default\u003dNone.\u0027)"},{"line_number":1086,"context_line":"def do_work_cleanup(cs, args):"},{"line_number":1087,"context_line":"    \"\"\"Request cleanup of services with optional filtering.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_66cbf749","line":1084,"range":{"start_line":1084,"start_character":38,"end_line":1084,"end_character":41},"updated":"2018-05-21 08:49:26.000000000","message":"nit: Remove the \"is\"","commit_id":"50a84eff015a8c24e6fdec60906f9bd24ddd8345"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e12bf5a369cf7dd6364c54f4849ff03b13e89723","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"           help\u003d\u0027Type of resource to cleanup.\u0027)"},{"line_number":1083,"context_line":"@utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,"},{"line_number":1084,"context_line":"           help\u003d\u0027The service id field is from the DB, not the uuid of the\u0027"},{"line_number":1085,"context_line":"                \u0027 service. Default\u003dNone.\u0027)"},{"line_number":1086,"context_line":"def do_work_cleanup(cs, args):"},{"line_number":1087,"context_line":"    \"\"\"Request cleanup of services with optional filtering.\"\"\""},{"line_number":1088,"context_line":"    filters \u003d dict(cluster_name\u003dargs.cluster, host\u003dargs.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_463efb29","line":1085,"updated":"2018-05-21 08:49:26.000000000","message":"-1: Sorry, I missed in the previous review that this should be an int, not a string, so we need to add `type\u003dint`","commit_id":"50a84eff015a8c24e6fdec60906f9bd24ddd8345"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"22d68c5089dd85f5bbc608293978bb7121927116","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"           choices\u003d(\u0027Volume\u0027, \u0027Snapshot\u0027),"},{"line_number":1082,"context_line":"           help\u003d\u0027Type of resource to cleanup.\u0027)"},{"line_number":1083,"context_line":"@utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,"},{"line_number":1084,"context_line":"           help\u003d\u0027The service id field is from the DB, not the uuid of the\u0027"},{"line_number":1085,"context_line":"                \u0027 service. Default\u003dNone.\u0027)"},{"line_number":1086,"context_line":"def do_work_cleanup(cs, args):"},{"line_number":1087,"context_line":"    \"\"\"Request cleanup of services with optional filtering.\"\"\""},{"line_number":1088,"context_line":"    filters \u003d dict(cluster_name\u003dargs.cluster, host\u003dargs.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0621e3fb","line":1085,"range":{"start_line":1084,"start_character":17,"end_line":1085,"end_character":25},"updated":"2018-05-21 08:55:22.000000000","message":"This is still not clear enough","commit_id":"50a84eff015a8c24e6fdec60906f9bd24ddd8345"},{"author":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"change_message_id":"eee919813fec00e29e45ccdfdde86b4529aece39","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"           choices\u003d(\u0027Volume\u0027, \u0027Snapshot\u0027),"},{"line_number":1082,"context_line":"           help\u003d\u0027Type of resource to cleanup.\u0027)"},{"line_number":1083,"context_line":"@utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,"},{"line_number":1084,"context_line":"           help\u003d\u0027The service id field is from the DB, not the uuid of the\u0027"},{"line_number":1085,"context_line":"                \u0027 service. Default\u003dNone.\u0027)"},{"line_number":1086,"context_line":"def do_work_cleanup(cs, args):"},{"line_number":1087,"context_line":"    \"\"\"Request cleanup of services with optional filtering.\"\"\""},{"line_number":1088,"context_line":"    filters \u003d dict(cluster_name\u003dargs.cluster, host\u003dargs.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e986f865","line":1085,"range":{"start_line":1084,"start_character":17,"end_line":1085,"end_character":25},"in_reply_to":"5f7c97a3_0621e3fb","updated":"2018-05-21 09:20:02.000000000","message":"Could you give me some addvice.","commit_id":"50a84eff015a8c24e6fdec60906f9bd24ddd8345"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f9c3f906c4fc233384b2468cddf1f17fa1a7985e","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"           help\u003d\u0027Type of resource to cleanup.\u0027)"},{"line_number":1083,"context_line":"@utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,"},{"line_number":1084,"context_line":"           help\u003d\u0027The service id field from the DB, not the uuid of the\u0027"},{"line_number":1085,"context_line":"                \u0027 service. type\u003dint. Default\u003dNone.\u0027)"},{"line_number":1086,"context_line":"def do_work_cleanup(cs, args):"},{"line_number":1087,"context_line":"    \"\"\"Request cleanup of services with optional filtering.\"\"\""},{"line_number":1088,"context_line":"    filters \u003d dict(cluster_name\u003dargs.cluster, host\u003dargs.host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c4f2d606","line":1085,"range":{"start_line":1085,"start_character":25,"end_line":1085,"end_character":51},"updated":"2018-05-24 07:50:32.000000000","message":"-1: Again, sorry for missing this, but the type and default parameters should be parameters to utils.arg:\n\n @utils.arg(\u0027--service-id\u0027,metavar\u003d\u0027\u003cservice-id\u003e\u0027, default\u003dNone,\n            help\u003d\u0027The service id field from the DB, not the uuid of the\u0027\n                 \u0027 service. Default\u003dNone.\u0027, type\u003dint, Default\u003dNone)","commit_id":"adb294d7ba75ec78dd2c88d42836fc7119bbcdb7"}]}