)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"f0183d1e13e8a8a2f90bd8a1552e4a70b5be83af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since backup restore function internally calls create volume"},{"line_number":10,"context_line":"and create volume contains --availability-zone parameter,"},{"line_number":11,"context_line":"backup restore should also have --availability-zone parameter"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes Bug : #1749888"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie3af6caf0df3a51f9470992b7b57e3ad8e16fca7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_09f67d90","line":12,"updated":"2018-06-11 10:15:04.000000000","message":"I suggest to add dependency on following patch\nhttps://review.openstack.org/#/c/574178/","commit_id":"4416b784c16fd92541678dac3373ddfe2d8b1545"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"183502adcc03b2d3482c6a36f7b5dc6c9466b7f8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and create volume contains --availability-zone parameter,"},{"line_number":11,"context_line":"backup restore should also have --availability-zone parameter"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes Bug : #1749888"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie3af6caf0df3a51f9470992b7b57e3ad8e16fca7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_203b35d1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"updated":"2018-06-12 05:09:32.000000000","message":"Yes agree with Sheel Rana either you can add Related-Bug or dependency here.","commit_id":"4416b784c16fd92541678dac3373ddfe2d8b1545"}],"cinderclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"f0183d1e13e8a8a2f90bd8a1552e4a70b5be83af","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        self.run_command(\u0027backup-restore 1234 --name restore_vol \u0027"},{"line_number":451,"context_line":"                         \u0027--availability-zone nova\u0027)"},{"line_number":452,"context_line":"        expected \u003d {\u0027restore\u0027: {\u0027volume_id\u0027: None, \u0027name\u0027: \u0027restore_vol\u0027,"},{"line_number":453,"context_line":"                                \u0027availability_zone\u0027: \u0027nova\u0027}}"},{"line_number":454,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/backups/1234/restore\u0027,"},{"line_number":455,"context_line":"                           body\u003dexpected)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e9cf8154","line":453,"range":{"start_line":453,"start_character":29,"end_line":453,"end_character":59},"updated":"2018-06-11 10:15:04.000000000","message":"I doubt this test case should pass if existing volume\u0027s availability zone is not \u0027nova\u0027 by default.\n\nIf user specifies volume name/id parameter, then availability zone will never be used in cinder code to update the existing volume\u0027s availability zone as per patch proposed here:\nhttps://review.openstack.org/#/c/574178/1/cinder/backup/api.py","commit_id":"4416b784c16fd92541678dac3373ddfe2d8b1545"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ae723079cf451017482ced18438ac39a52d63dbc","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        self.run_command(\u0027backup-restore 1234 --name restore_vol \u0027"},{"line_number":451,"context_line":"                         \u0027--availability-zone nova\u0027)"},{"line_number":452,"context_line":"        expected \u003d {\u0027restore\u0027: {\u0027volume_id\u0027: None, \u0027name\u0027: \u0027restore_vol\u0027,"},{"line_number":453,"context_line":"                                \u0027availability_zone\u0027: \u0027nova\u0027}}"},{"line_number":454,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/backups/1234/restore\u0027,"},{"line_number":455,"context_line":"                           body\u003dexpected)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_09b92b14","line":453,"range":{"start_line":453,"start_character":29,"end_line":453,"end_character":59},"in_reply_to":"5f7c97a3_e9cf8154","updated":"2018-06-15 10:37:23.000000000","message":"so availability_zone and volume name are mutually exclusive parameters, yes, volume_id overrides availability_zone.\n\nAs per this test \nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/tests/unit/v2/test_shell.py#L101\n\nnot passing availability_zone and asserting it to None is the correct way to run this case.","commit_id":"4416b784c16fd92541678dac3373ddfe2d8b1545"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"f0183d1e13e8a8a2f90bd8a1552e4a70b5be83af","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":1355,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":1356,"context_line":"           default\u003dNone,"},{"line_number":1357,"context_line":"           help\u003d\u0027Availability zone for volume. Default\u003dNone.\u0027)"},{"line_number":1358,"context_line":"def do_backup_restore(cs, args):"},{"line_number":1359,"context_line":"    \"\"\"Restores a backup.\"\"\""},{"line_number":1360,"context_line":"    vol \u003d args.volume or args.volume_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_293c9990","line":1357,"range":{"start_line":1357,"start_character":0,"end_line":1357,"end_character":62},"updated":"2018-06-11 10:15:04.000000000","message":"Availability-zone will come into picture only if new volume is being created for restore operation.\n\nIf existing volume is used for restore operation(volume id/volume/name param is specified in CLI), existing volume\u0027s availability zone will not be updated.\n\nSo, It\u0027s good to make volume_id/vol/name override availability zone param.\nOR\nmention in help\n\"If volume already exists or volume-id/volume/name is specified in params, volume\u0027s availability-zone will not be changed.\"","commit_id":"4416b784c16fd92541678dac3373ddfe2d8b1545"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ae723079cf451017482ced18438ac39a52d63dbc","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":1355,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":1356,"context_line":"           default\u003dNone,"},{"line_number":1357,"context_line":"           help\u003d\u0027Availability zone for volume. Default\u003dNone.\u0027)"},{"line_number":1358,"context_line":"def do_backup_restore(cs, args):"},{"line_number":1359,"context_line":"    \"\"\"Restores a backup.\"\"\""},{"line_number":1360,"context_line":"    vol \u003d args.volume or args.volume_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_89ebfb76","line":1357,"range":{"start_line":1357,"start_character":0,"end_line":1357,"end_character":62},"in_reply_to":"5f7c97a3_293c9990","updated":"2018-06-15 10:37:23.000000000","message":"i have seen cases when a parameter is passed but overridden by another so i will prefer changing the help section","commit_id":"4416b784c16fd92541678dac3373ddfe2d8b1545"}]}