)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7cdfe24bcf1dd3284b35b54e6e123c5cd0d6b1cf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since the method base.ManagerWithFind.findall has been modified by adding"},{"line_number":10,"context_line":"the the search_opts for all tenants support, the parameter search_opts should"},{"line_number":11,"context_line":"also be added to all the manager classes, which can be called whithin this"},{"line_number":12,"context_line":"method. volumetypemanager does not have this parameter forits method list(),"},{"line_number":13,"context_line":"Adding **kwargs will resolve this issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixed Bug1252665."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Bwpg%3D","line":12,"updated":"2013-11-20 15:18:53.000000000","message":"Please correct this typo.","commit_id":"3fb4f472b7d2010bc4850a1b1f42d7150b7dce50"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7cdfe24bcf1dd3284b35b54e6e123c5cd0d6b1cf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"method. volumetypemanager does not have this parameter forits method list(),"},{"line_number":13,"context_line":"Adding **kwargs will resolve this issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixed Bug1252665."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I526500625f1b5483cb5d88ea15e6ac8485a66ae3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Bwpc%3D","line":15,"updated":"2013-11-20 15:18:53.000000000","message":"Closes-Bug: 1252665","commit_id":"3fb4f472b7d2010bc4850a1b1f42d7150b7dce50"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"0b19db77f770036da9dc767070d3a0d71960d0d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add **kwargs into the method list() for VolumeTypeManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the method base.ManagerWithFind.findall has been modified by"},{"line_number":10,"context_line":"adding the the search_opts for all tenants support, the parameter"},{"line_number":11,"context_line":"search_opts should also be added to all the manager classes, which"},{"line_number":12,"context_line":"can be called whithin this method. volumetypemanager does not have"},{"line_number":13,"context_line":"this parameter for its method list(). Adding **kwargs will resolve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F%2Bttg%3D","line":10,"updated":"2013-11-21 06:58:13.000000000","message":"Why two \u0027the\u0027?","commit_id":"18b3e6e79e7afcc3f69a4c84e4c78e249ef77c6d"}],"cinderclient/v1/volume_types.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0af01fe6a2d37186104e3342a91f6c19bdf2b084","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":"    resource_class \u003d VolumeType"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def list(self, **kwargs):"},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        Get a list of all volume types."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BtdM%3D","line":83,"updated":"2013-11-21 08:36:40.000000000","message":"same opinion as v2 list() method change.","commit_id":"6c0b953937f0c1c7ab70a65baf1f2f54b55a97a9"}],"cinderclient/v2/volume_types.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0af01fe6a2d37186104e3342a91f6c19bdf2b084","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \"\"\"Manage :class:`VolumeType` resources.\"\"\""},{"line_number":71,"context_line":"    resource_class \u003d VolumeType"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def list(self, **kwargs):"},{"line_number":74,"context_line":"        \"\"\"Get a list of all volume types."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :rtype: list of :class:`VolumeType`."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BtdQ%3D","line":73,"updated":"2013-11-21 08:36:40.000000000","message":"I\u0027d prefer you explicitly add \u0027search_opts\u003dNone\u0027 to list() method here instead of a wide-open **kwargs, although this parameter is not used right now.","commit_id":"6c0b953937f0c1c7ab70a65baf1f2f54b55a97a9"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"01a743334ed5a3c542fd311cb3e1f7823c81db5e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \"\"\"Manage :class:`VolumeType` resources.\"\"\""},{"line_number":71,"context_line":"    resource_class \u003d VolumeType"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def list(self, **kwargs):"},{"line_number":74,"context_line":"        \"\"\"Get a list of all volume types."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :rtype: list of :class:`VolumeType`."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BpQA%3D","line":73,"in_reply_to":"AAAATn%2F%2BtdQ%3D","updated":"2013-11-22 02:59:15.000000000","message":"I thought about adding search_opts\u003dNone before. Guessing it is limited, I extend the range by **kwargs, because if we call this method with new keys other than search_opts, the same issue will rise too.","commit_id":"6c0b953937f0c1c7ab70a65baf1f2f54b55a97a9"}]}