)]}'
{"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71f6373f743d6cdb41cdc71bfeab40788b90b70d","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    )"},{"line_number":679,"context_line":"    @ddt.unpack"},{"line_number":680,"context_line":"    def test_group_create_from_src(self, grp_snap_id, src_grp_id, src):"},{"line_number":681,"context_line":"        if grp_snap_id is None:"},{"line_number":682,"context_line":"            expected \u003d {\u0027create-from-src\u0027: {\u0027name\u0027: \u0027test-1\u0027,"},{"line_number":683,"context_line":"                                            \u0027description\u0027: \u0027test-1-desc\u0027,"},{"line_number":684,"context_line":"                                            \u0027source_group_id\u0027: src_grp_id}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_281db876","line":681,"updated":"2018-06-19 15:43:48.000000000","message":"I think it would be cleaner and less duplication to do:\n\nexpected \u003d {\u0027create-from-src\u0027: {\u0027name\u0027: \u0027test-1\u0027, \u0027description\u0027: \u0027test-1-desc\u0027}\n\nif grp_snap_id:\n    expected[\u0027create-from-src\u0027][\u0027group_snapshot_id\u0027] \u003d grp_snap_id\nelse if src_grp:\n    expected[\u0027create-from-src\u0027][\u0027source_group_id\u0027] \u003d src_grp","commit_id":"c324fb67af698c524becd0f2eb362975e02e86ea"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7115e55e801c5666689b0ba98dc9928dc2e058d9","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    )"},{"line_number":679,"context_line":"    @ddt.unpack"},{"line_number":680,"context_line":"    def test_group_create_from_src(self, grp_snap_id, src_grp_id, src):"},{"line_number":681,"context_line":"        if grp_snap_id is None:"},{"line_number":682,"context_line":"            expected \u003d {\u0027create-from-src\u0027: {\u0027name\u0027: \u0027test-1\u0027,"},{"line_number":683,"context_line":"                                            \u0027description\u0027: \u0027test-1-desc\u0027,"},{"line_number":684,"context_line":"                                            \u0027source_group_id\u0027: src_grp_id}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1b127f63","line":681,"in_reply_to":"5f7c97a3_281db876","updated":"2018-06-20 01:10:06.000000000","message":"thanks, Sean, it\u0027s better.","commit_id":"c324fb67af698c524becd0f2eb362975e02e86ea"}],"cinderclient/v3/groups.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71f6373f743d6cdb41cdc71bfeab40788b90b70d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # NOTE(wanghao): According the API schema in cinder side, client"},{"line_number":116,"context_line":"        # should NOT specify the group_snapshot_id and source_group_id at"},{"line_number":117,"context_line":"        # same time, even one of them is None."},{"line_number":118,"context_line":"        if group_snapshot_id is None:"},{"line_number":119,"context_line":"            create_key \u003d \u0027source_group_id\u0027"},{"line_number":120,"context_line":"            create_value \u003d source_group_id"},{"line_number":121,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4306d71e","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":36},"updated":"2018-06-19 15:43:48.000000000","message":"I\u0027d rather check for the value being set and then use it rather than checking if it is not set and assuming the other value will be set.","commit_id":"c324fb67af698c524becd0f2eb362975e02e86ea"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7115e55e801c5666689b0ba98dc9928dc2e058d9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # NOTE(wanghao): According the API schema in cinder side, client"},{"line_number":116,"context_line":"        # should NOT specify the group_snapshot_id and source_group_id at"},{"line_number":117,"context_line":"        # same time, even one of them is None."},{"line_number":118,"context_line":"        if group_snapshot_id is None:"},{"line_number":119,"context_line":"            create_key \u003d \u0027source_group_id\u0027"},{"line_number":120,"context_line":"            create_value \u003d source_group_id"},{"line_number":121,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b62e028a","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":36},"in_reply_to":"5f7c97a3_4306d71e","updated":"2018-06-20 01:10:06.000000000","message":"sure","commit_id":"c324fb67af698c524becd0f2eb362975e02e86ea"}]}