)]}'
{"cinderclient/v3/volume_types.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c8a770540de68d6b1751a5150bf8fb1d4b6141a9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if not search_opts:"},{"line_number":91,"context_line":"            search_opts \u003d dict()"},{"line_number":92,"context_line":"        # Need to keep backwards compatibility with is_public usage"},{"line_number":93,"context_line":"        is_public \u003d \u0027\u0027"},{"line_number":94,"context_line":"        if not is_public:"},{"line_number":95,"context_line":"            is_public \u003d \u0027\u0026is_public\u003dNone\u0027"},{"line_number":96,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d3ffe763","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":22},"updated":"2018-06-21 13:31:36.000000000","message":"Isn\u0027t is public always going to be none because of this?","commit_id":"9674abd794e87aa5c144187fe38063e054825b3a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5f576ed537f0c827781649c729a3d810f9d73c68","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if not search_opts:"},{"line_number":91,"context_line":"            search_opts \u003d dict()"},{"line_number":92,"context_line":"        # Need to keep backwards compatibility with is_public usage"},{"line_number":93,"context_line":"        is_public \u003d \u0027\u0027"},{"line_number":94,"context_line":"        if not is_public:"},{"line_number":95,"context_line":"            is_public \u003d \u0027\u0026is_public\u003dNone\u0027"},{"line_number":96,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1336beb5","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":22},"in_reply_to":"5f7c97a3_d3ffe763","updated":"2018-06-21 14:04:48.000000000","message":"Doh, helps if I pick unique variable names I suppose!","commit_id":"9674abd794e87aa5c144187fe38063e054825b3a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"85e466c8b694cf05f10927900be333ca48e0afd7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        if not search_opts:"},{"line_number":93,"context_line":"            search_opts \u003d dict()"},{"line_number":94,"context_line":"        query_string \u003d \"?%s\" % parse.urlencode("},{"line_number":95,"context_line":"            search_opts) if search_opts else \u0027\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Need to keep backwards compatibility with is_public usage"},{"line_number":98,"context_line":"        public \u003d \u0027\u0026\u0027 if search_opts else \u0027?\u0027"},{"line_number":99,"context_line":"        public +\u003d \u0027is_public\u003d%s\u0027 % is_public"},{"line_number":100,"context_line":"        return self._list(\"/types%s%s\" % (query_string, public),"},{"line_number":101,"context_line":"                          \"volume_types\")"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_15b0cbfc","line":99,"range":{"start_line":94,"start_character":0,"end_line":99,"end_character":44},"updated":"2018-06-22 15:24:04.000000000","message":"I just finished my own fix for this, and here is the code I came up with (I thinkit\u0027s more straightforward).\n\n        # Always include \u0027is_public\u0027 in the query string, even when the                                                                               \n        # value is None. If it isn\u0027t included then cinder will assume                                                                                 \n        # you want is_public\u003dTrue, which negatively affects the results.                                                                              \n        search_opts.update({\"is_public\": is_public})\n\n        query_string \u003d \"?%s\" % parse.urlencode(search_opts)","commit_id":"37f8b2fe091d4b452902e8758d6e6c6083db2889"}]}