)]}'
{"id":"openstack%2Fpython-cinderclient~578045","triplet_id":"openstack%2Fpython-cinderclient~master~I937c6ac2f6e254c438ee2f36eb6c291f62c0f411","project":"openstack/python-cinderclient","branch":"master","topic":"nova-cinderclient-split-logging","hashtags":[],"change_id":"I937c6ac2f6e254c438ee2f36eb6c291f62c0f411","subject":"Remove initialization of logger if logger is None","status":"MERGED","created":"2018-06-26 09:20:08.000000000","updated":"2018-07-03 19:15:25.000000000","submitted":"2018-07-03 19:15:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"578045-1530645325431-e388b4a9","meta_rev_id":"6c3d60fb15527f26de5847e361230f7bcc5cbaff","_number":578045,"virtual_id_number":578045,"owner":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":2,"date":"2018-07-03 19:15:25.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2018-07-03 12:23:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-07-03 17:40:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2018-07-03 09:27:49.000000000","_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-07-03 17:40:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"date":"2018-07-03 09:27:40.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-03 09:27:40.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2018-07-03 09:27:49.000000000","updated_by":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"reviewer":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"state":"REVIEWER"},{"updated":"2018-07-03 12:23:47.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2018-07-03 17:40:46.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2018-07-03 19:15:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ca98e58e4c3fbafb7c00ced971986ef741566943","author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"date":"2018-06-26 09:20:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"572ef8fae2c46feaf0eabf694bc1e3d10f1feaef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 11:11:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/45/578045/1/check/openstack-tox-pep8/0a56831/ : SUCCESS in 4m 15s\n- openstack-tox-py27 http://logs.openstack.org/45/578045/1/check/openstack-tox-py27/d6fd80f/ : SUCCESS in 3m 56s\n- openstack-tox-py35 http://logs.openstack.org/45/578045/1/check/openstack-tox-py35/2271b58/ : SUCCESS in 3m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/45/578045/1/check/build-openstack-sphinx-docs/51c0936/html/ : SUCCESS in 4m 07s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/578045/1/check/legacy-tempest-dsvm-neutron-src/6f8a10a/ : SUCCESS in 1h 26m 09s\n- openstack-tox-pylint http://logs.openstack.org/45/578045/1/check/openstack-tox-pylint/9f1d71a/ : SUCCESS in 4m 00s (non-voting)\n- cinderclient-dsvm-functional http://logs.openstack.org/45/578045/1/check/cinderclient-dsvm-functional/1941f4b/ : SUCCESS in 26m 19s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/45/578045/1/check/cinderclient-dsvm-functional-identity-v3-only/4b2d38d/ : SUCCESS in 31m 36s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/45/578045/1/check/openstack-tox-lower-constraints/96f670b/ : SUCCESS in 4m 30s","accounts_in_message":[],"_revision_number":1},{"id":"62e504a944f2cfa6499401d5fa0b72e678c15a9a","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-03 12:23:47.000000000","message":"Patch Set 1: Code-Review+2\n\nSeems like this should actually be fixed by making sure the logger is never None, but we really shouldn\u0027t ever be initializing the logger from within library code.","accounts_in_message":[],"_revision_number":1},{"id":"d1627c87d924a5840497100ec09d894d1f822db3","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2018-07-03 17:40:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"da478f854662c1ea89168f58b4add17730f57817","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-03 17:40:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c6eeb81003429fec3602974ecacc276cbf7b0a08","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-03 19:15:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"4f2f07aa08f54545505bdb4b09f76718c19446e6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-03 19:15:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/45/578045/1/gate/openstack-tox-pep8/5299e8e/ : SUCCESS in 3m 03s\n- openstack-tox-py27 http://logs.openstack.org/45/578045/1/gate/openstack-tox-py27/75ba506/ : SUCCESS in 3m 27s\n- openstack-tox-py35 http://logs.openstack.org/45/578045/1/gate/openstack-tox-py35/44d88dc/ : SUCCESS in 3m 26s\n- build-openstack-sphinx-docs http://logs.openstack.org/45/578045/1/gate/build-openstack-sphinx-docs/d620aca/html/ : SUCCESS in 4m 55s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/578045/1/gate/legacy-tempest-dsvm-neutron-src/916a550/ : SUCCESS in 1h 27m 09s\n- openstack-tox-lower-constraints http://logs.openstack.org/45/578045/1/gate/openstack-tox-lower-constraints/0909729/ : SUCCESS in 3m 16s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ebb3b675ade348f52d3e0260bda3c0df843108c9","revisions":{"ebb3b675ade348f52d3e0260bda3c0df843108c9":{"kind":"REWORK","_number":1,"created":"2018-06-26 09:20:08.000000000","uploader":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"ref":"refs/changes/45/578045/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/45/578045/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/45/578045/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/45/578045/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/45/578045/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/45/578045/1"}}},"commit":{"parents":[{"commit":"35b99baf6e0da5b13fa72b50d7a20ff1944776de","subject":"Merge \"update the value of OS_AUTH_URL and OS_VOLUME_API_VERSION\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/35b99baf6e0da5b13fa72b50d7a20ff1944776de"}]}],"author":{"name":"Neha Alhat","email":"neha.alhat@nttdata.com","date":"2018-06-06 09:44:23.000000000","tz":330},"committer":{"name":"Neha Alhat","email":"neha.alhat@nttdata.com","date":"2018-06-26 09:16:30.000000000","tz":330},"subject":"Remove initialization of logger if logger is None","message":"Remove initialization of logger if logger is None\n\nIf default_log_level\u003dkeystoneauth\u003dWARN is enabled in nova.conf,\nthen these log messages [1][2][3] are logged using cinderclient.v3.client\nlogger name instead of keystoneauth.session. This is because cinderclient\ninitializes logger if not passed by nova and since debug\u003dTrue is set in\nnova.conf it’s uses root logger log level.\n\nThis patch removes initialization of logger code to ensure log\nmessages[1][2][3] are logged only when keystoneauth\u003dDEBUG is enabled\nin nova.conf. This will also enable us to consume split_logger config\noption [4] when enabled in nova without making any additional changes\nin client code.\n\n[1] REQ: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@391\n[2] RESP: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@422\n[3] RESP BODY: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@454\n[4] https://review.openstack.org/#/c/568878/\n\nChange-Id: I937c6ac2f6e254c438ee2f36eb6c291f62c0f411\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/ebb3b675ade348f52d3e0260bda3c0df843108c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/ebb3b675ade348f52d3e0260bda3c0df843108c9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}