)]}'
{"id":"openstack%2Fpython-cinderclient~587363","triplet_id":"openstack%2Fpython-cinderclient~master~I46dce6df6876db1adc2020025c01430f63717018","project":"openstack/python-cinderclient","branch":"master","topic":"fix_unecessary_params","hashtags":[],"change_id":"I46dce6df6876db1adc2020025c01430f63717018","subject":"Revert \"Remove unnecessary parameters from volume create APIs\"","status":"ABANDONED","created":"2018-07-31 09:40:55.000000000","updated":"2018-09-04 16:28:37.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9163d8ed336d6f290e1889d33cc01c479f22f053","_number":587363,"virtual_id_number":587363,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},{"date":"2018-07-31 17:20:47.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":-1,"date":"2018-07-31 11:43:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":-2,"date":"2018-07-31 15:27:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-31 09:40:55.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2018-07-31 09:40:55.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2018-07-31 09:40:55.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2018-07-31 09:40:55.000000000","updated_by":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"reviewer":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"state":"REVIEWER"},{"updated":"2018-07-31 09:40:55.000000000","updated_by":{"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},"reviewer":{"_account_id":24645,"name":"Pooja Jadhav","email":"pooja.jadhav@nttdata.com","username":"poojajadhav"},"state":"REVIEWER"},{"updated":"2018-07-31 09:40:55.000000000","updated_by":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"reviewer":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"state":"REVIEWER"},{"updated":"2018-07-31 11:43:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-31 15:27:17.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"4681c55130b5f6c7d96434c69830baed0231ad0d","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-07-31 09:40:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4508e5b62aa81daecf333ca6a0fb28fa8f68460a","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-07-31 09:42:31.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0e251bdc36ce73ea488aafa6c60948d11a629c1c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-31 11:43:03.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/63/587363/2/check/openstack-tox-pep8/1a1550f/ : FAILURE in 4m 11s\n- openstack-tox-py27 http://logs.openstack.org/63/587363/2/check/openstack-tox-py27/6901a1b/ : FAILURE in 4m 04s\n- openstack-tox-py35 http://logs.openstack.org/63/587363/2/check/openstack-tox-py35/c911689/ : FAILURE in 3m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/63/587363/2/check/build-openstack-sphinx-docs/48d9b0f/html/ : SUCCESS in 3m 01s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/63/587363/2/check/legacy-tempest-dsvm-neutron-src/ea5e0a0/ : FAILURE in 1h 20m 15s\n- openstack-tox-pylint http://logs.openstack.org/63/587363/2/check/openstack-tox-pylint/a5f38ea/ : FAILURE in 5m 32s (non-voting)\n- cinderclient-dsvm-functional http://logs.openstack.org/63/587363/2/check/cinderclient-dsvm-functional/5027c81/ : FAILURE in 28m 05s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/63/587363/2/check/cinderclient-dsvm-functional-identity-v3-only/bbd25e1/ : FAILURE in 28m 05s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/63/587363/2/check/openstack-tox-lower-constraints/7dfd069/ : FAILURE in 5m 02s","accounts_in_message":[],"_revision_number":2},{"id":"78568a7a175cd5fbaa08b48cab2fe0b39f3681af","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-31 15:27:17.000000000","message":"Patch Set 2: Code-Review-2\n\nYes, this was done in a backwards incompatible way. That is why the release bumped the major version number.\n\nThis will not be reverted. Consumers of this code need to be updated. These were deprecated for a long time and have followed policy, and they are now gone.\n\nThanks for pointing out the api-ref. That needs to be fixed yet.","accounts_in_message":[],"_revision_number":2},{"id":"9584df31aaf730ed3ee479e73621b49f9f53df5c","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-07-31 17:20:47.000000000","message":"Patch Set 2:\n\n@Sean: I did not want to actually revert the change, I just found this way is more informative + requires less attention than mail bug bigger than IRC.\n\nplease, update openstackclient code at least :)\nas for the rally, we already have a fix.","accounts_in_message":[],"_revision_number":2},{"id":"b9e502c8184d5dbf151c257f05cc1d445372ad30","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-09-04 16:28:37.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0940e4d24b46eb2238572af680a98ec3cc0991a6","revisions":{"6e4df4a85720ffc27dd344f2439bd0c3559d8c38":{"kind":"REWORK","_number":1,"created":"2018-07-31 09:40:55.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/63/587363/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/63/587363/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/1"}}},"commit":{"parents":[{"commit":"8d566689001a442c2312e366acc167af88888fd3","subject":"Remove unnecessary parameters from volume create APIs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8d566689001a442c2312e366acc167af88888fd3"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-07-31 09:40:55.000000000","tz":0},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-07-31 09:40:55.000000000","tz":0},"subject":"Revert \"Remove unnecessary parameters from volume create APIs\"","message":"Revert \"Remove unnecessary parameters from volume create APIs\"\n\nThe original change is done in a backward incompatible way. It is not how we are doing things in OpenStack community.\n\nAs a first step, we need to provide deprecation messages (see novaclient as an example[1]), check who can be affected (using codeseach for example) and after several cycles - remove.\n\nAffected by the original change:\n- rally gates are broken (easy to fix, but anyway)\n- openstackclient [2]\n\nAlso, it worce to mention that official API reference for V2 still propose to use source_replica [3]. \n\n[1] - https://github.com/openstack/python-novaclient/blob/11.0.0/novaclient/client.py#L297-L328\n[2] - https://github.com/openstack/python-openstackclient/blob/3.16.0/openstackclient/volume/v2/volume.py#L230\n[3] - https://developer.openstack.org/api-ref/block-storage/v2/index.html#volumes-volumes\n\nThis reverts commit 8d566689001a442c2312e366acc167af88888fd3.\n\nChange-Id: I46dce6df6876db1adc2020025c01430f63717018\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6e4df4a85720ffc27dd344f2439bd0c3559d8c38"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6e4df4a85720ffc27dd344f2439bd0c3559d8c38"}]},"branch":"refs/heads/master"},"0940e4d24b46eb2238572af680a98ec3cc0991a6":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-07-31 09:42:31.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/63/587363/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/63/587363/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/63/587363/2"}}},"commit":{"parents":[{"commit":"8d566689001a442c2312e366acc167af88888fd3","subject":"Remove unnecessary parameters from volume create APIs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8d566689001a442c2312e366acc167af88888fd3"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-07-31 09:40:55.000000000","tz":0},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-07-31 09:42:27.000000000","tz":0},"subject":"Revert \"Remove unnecessary parameters from volume create APIs\"","message":"Revert \"Remove unnecessary parameters from volume create APIs\"\n\nThe original change is done in a backward incompatible way.\n\nAs a first step, we need to provide deprecation messages (see novaclient\nas an example[1]), check who can be affected (using codeseach for\nexample) and after several cycles - remove.\n\nAffected by the original change:\n- rally gates are broken (easy to fix, but anyway)\n- openstackclient [2]\n\nAlso, it worce to mention that official API reference for V2 still\npropose to use source_replica [3].\n\n[1] - https://github.com/openstack/python-novaclient/blob/11.0.0/novaclient/client.py#L297-L328\n[2] - https://github.com/openstack/python-openstackclient/blob/3.16.0/openstackclient/volume/v2/volume.py#L230\n[3] - https://developer.openstack.org/api-ref/block-storage/v2/index.html#volumes-volumes\n\nThis reverts commit 8d566689001a442c2312e366acc167af88888fd3.\n\nChange-Id: I46dce6df6876db1adc2020025c01430f63717018\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0940e4d24b46eb2238572af680a98ec3cc0991a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0940e4d24b46eb2238572af680a98ec3cc0991a6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}