)]}'
{"id":"openstack%2Fpython-cinderclient~587610","triplet_id":"openstack%2Fpython-cinderclient~master~I1e024229234760be2892dc2aad65159a13e708d0","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1696780","hashtags":[],"change_id":"I1e024229234760be2892dc2aad65159a13e708d0","subject":"optional parameter should be passed only once","status":"ABANDONED","created":"2018-07-31 19:46:45.000000000","updated":"2019-08-27 05:26:49.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"656db0b3c0feae3cd66d5dbdb2c22fad06e42708","_number":587610,"virtual_id_number":587610,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2018-07-31 21:43:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2018-10-23 16:51:31.000000000","_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":-1,"date":"2019-05-03 16:00:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":-1,"date":"2018-08-13 09:51:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-31 21:43:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-08-13 09:51:34.000000000","updated_by":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"reviewer":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"state":"REVIEWER"},{"updated":"2019-05-03 16:00:24.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"}],"messages":[{"id":"fd696e0459ce28a66097e6a4e0a404434198ef35","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-07-31 19:46:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0c4d3d5569365e7e856cf713f8bc78dd7497f50b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-31 21:43:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/10/587610/1/check/openstack-tox-pep8/c292a7e/ : SUCCESS in 3m 06s\n- openstack-tox-py27 http://logs.openstack.org/10/587610/1/check/openstack-tox-py27/8679ffd/ : SUCCESS in 3m 31s\n- openstack-tox-py35 http://logs.openstack.org/10/587610/1/check/openstack-tox-py35/de6fff2/ : SUCCESS in 3m 26s\n- build-openstack-sphinx-docs http://logs.openstack.org/10/587610/1/check/build-openstack-sphinx-docs/e7cdfe6/html/ : SUCCESS in 3m 32s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/10/587610/1/check/legacy-tempest-dsvm-neutron-src/e63de9c/ : SUCCESS in 1h 31m 58s\n- openstack-tox-pylint http://logs.openstack.org/10/587610/1/check/openstack-tox-pylint/5699923/ : FAILURE in 7m 39s (non-voting)\n- cinderclient-dsvm-functional http://logs.openstack.org/10/587610/1/check/cinderclient-dsvm-functional/d995817/ : FAILURE in 27m 36s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/10/587610/1/check/cinderclient-dsvm-functional-identity-v3-only/fae0cb0/ : FAILURE in 31m 58s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/10/587610/1/check/openstack-tox-lower-constraints/447d705/ : SUCCESS in 3m 43s","accounts_in_message":[],"_revision_number":1},{"id":"dfaaf1a457e1290c2c12affd7c971b2519233abf","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2018-08-01 13:37:52.000000000","message":"Patch Set 1: Code-Review-2\n\nIt doesn\u0027t make sense to fix this by restricting the behavior in the CLI -- it\u0027s reasonable to pass in multiple filters and the client should be able to handle that.","accounts_in_message":[],"_revision_number":1},{"id":"22e4f12108ab4274f3b95bd2a160aae0fe888afa","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-08-01 14:52:04.000000000","message":"Patch Set 1:\n\n\u003e It doesn\u0027t make sense to fix this by restricting the behavior in\n \u003e the CLI -- it\u0027s reasonable to pass in multiple filters and the\n \u003e client should be able to handle that.\n\nThanks for the review Eric.\nI have made these changes keeping in mind the following points :\n* Some optional arguments when passed multiple times causes unexpected output Eg : cinder list --name X --name Y and cinder list --name Y --name X have ambiguous results and provides volume list for name\u003dlast argument passed (skips the first occourence)\n* According to Gorka\u0027s comment on the bug, optional arguments that aren\u0027t ready to be accepted multiple times can be restricted (like positional args) rather than providing handler for each of them individually.\n\nMaybe we can add handler for some specified arguments?\nCorrect me if i\u0027m wrong anywhere.","accounts_in_message":[],"_revision_number":1},{"id":"bf14fa0a5c4b7d6fae238369b5432ccf05a05306","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2018-08-13 09:51:34.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cf74452d3c724ed122c57f63d9d0d2ba23d1b739","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2018-10-23 15:37:30.000000000","message":"Patch Set 1:\n\nThis approach is pretty interesting, and may be the right way to go, but I think we also need something like AppendStore that can combine dict key/value pairs etc.  This would be needed to actually fix the bug I wrote (which this patch doesn\u0027t really do yet).\n\nI also think we will need to, at least at first, do this only in the v2/v3 shells.  Adding checks like this to the v1 shell is bound to cause compatibility problems for users that have scripted against the cinder CLI.","accounts_in_message":[],"_revision_number":1},{"id":"5fa15c569a732afe3558a89873eb9b456fcc46fd","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-10-23 16:51:31.000000000","message":"Patch Set 1:\n\n\u003e This approach is pretty interesting, and may be the right way to\n \u003e go, but I think we also need something like AppendStore that can\n \u003e combine dict key/value pairs etc.  This would be needed to actually\n \u003e fix the bug I wrote (which this patch doesn\u0027t really do yet).\n \u003e \n \u003e I also think we will need to, at least at first, do this only in\n \u003e the v2/v3 shells.  Adding checks like this to the v1 shell is bound\n \u003e to cause compatibility problems for users that have scripted\n \u003e against the cinder CLI.\n\nThanks for the suggestions Eric.\nI think we would need a list of param with which the AppendStore will work (will restrict for the ambigous params)","accounts_in_message":[],"_revision_number":1},{"id":"315d0accd8b1377c6b0de801a9b3116c8321350a","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-05-03 16:00:24.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"082dd04a5f07267124e1f25b4b15f0a429231089","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-05-03 16:00:33.000000000","message":"Patch Set 1:\n\nWill be updated per PTG discussion","accounts_in_message":[],"_revision_number":1},{"id":"531db6e9f8349444a6ede1d922e3af51de668c11","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-08-27 05:26:49.000000000","message":"Abandoned\n\nNew implementation\nhttps://review.opendev.org/#/c/678523/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e948b9ac2792872a7f10ca979d1634d83312b64b","revisions":{"e948b9ac2792872a7f10ca979d1634d83312b64b":{"kind":"REWORK","_number":1,"created":"2018-07-31 19:46:45.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/10/587610/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/10/587610/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/10/587610/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/10/587610/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/10/587610/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/10/587610/1"}}},"commit":{"parents":[{"commit":"e76c4958ea779a44f2d0351616c94b627aebe0fe","subject":"Merge \"Reflect multiattach deprecation in help text\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e76c4958ea779a44f2d0351616c94b627aebe0fe"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-07-31 19:36:09.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-07-31 19:46:41.000000000","tz":0},"subject":"optional parameter should be passed only once","message":"optional parameter should be passed only once\n\ncinder CLI doesn\u0027t restrict using optional parameters\nmultiple times in a single command which can result in\nunexpected output.\nEg : cinder list --sort name --sort id\nadding custom action parameter to valid arguments\nrestricts the multiple usage of optional parameter\n\nChange-Id: I1e024229234760be2892dc2aad65159a13e708d0\nCloses-Bug: #1696780\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e948b9ac2792872a7f10ca979d1634d83312b64b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e948b9ac2792872a7f10ca979d1634d83312b64b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}