)]}'
{"cinderclient/v3/volume_transfers.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"374f490474163b9d859456bec0fc129583704e50","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            detail \u003d \"/detail\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if self.api_version.matches(\u00273.55\u0027):"},{"line_number":80,"context_line":"            return self._list(\"/volume-transfers%s%s\" % (detail, query_string),"},{"line_number":81,"context_line":"                              \"transfers\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return self._list(\"/os-volume-transfer%s%s\" % (detail, query_string),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bfcb6551","line":80,"updated":"2018-08-07 15:46:52.000000000","message":"is this missing a / after volume-transfers and before the %s%s ?","commit_id":"b3f3cafd1eb15cba181edff1067dc91ce56bf451"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e05de5fc905bc5cc83732db9c32457503ba729b0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            detail \u003d \"/detail\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if self.api_version.matches(\u00273.55\u0027):"},{"line_number":80,"context_line":"            return self._list(\"/volume-transfers%s%s\" % (detail, query_string),"},{"line_number":81,"context_line":"                              \"transfers\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return self._list(\"/os-volume-transfer%s%s\" % (detail, query_string),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9173fd15","line":80,"in_reply_to":"3f79a3b5_bfcb6551","updated":"2018-08-07 16:23:54.000000000","message":"No, detail has a leading / and utils.build_query_param will add the \u0027?\u0027 query character if needed:\n\nhttps://github.com/openstack/python-cinderclient/blob/460229c6099719dec0d027f798f9c751b8ec7e44/cinderclient/utils.py#L219\n\nThis matches the existing implementation from the v2 client:\n\nhttps://github.com/openstack/python-cinderclient/blob/460229c6099719dec0d027f798f9c751b8ec7e44/cinderclient/v2/volume_transfers.py#L80\n\nThis just duplicates that and switches the endpoint depending if it is our new microversion endpoint or the existing api/contrib version.","commit_id":"b3f3cafd1eb15cba181edff1067dc91ce56bf451"}]}