)]}'
{"id":"openstack%2Fpython-cinderclient~59813","triplet_id":"openstack%2Fpython-cinderclient~master~I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1267168","hashtags":[],"change_id":"I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2","subject":"Require ctrl_location for encryption-type-create","status":"MERGED","created":"2013-12-03 19:34:11.000000000","updated":"2014-02-13 03:34:18.000000000","submitted":"2014-02-13 03:34:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a1b59d25cb92334513dbce43bd06ec8519b1fb2","_number":59813,"virtual_id_number":59813,"owner":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":0,"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2014-02-13 03:34:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"recommended":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"all":[{"value":0,"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":1,"date":"2014-02-12 19:49:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-02-12 19:39:07.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},{"value":2,"date":"2014-02-12 20:10:59.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"all":[{"value":0,"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":0,"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-02-12 19:39:07.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},{"value":1,"date":"2014-02-12 20:10:59.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":0,"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-03 21:39:35.000000000","updated_by":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"reviewer":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"state":"REVIEWER"},{"updated":"2013-12-03 21:39:51.000000000","updated_by":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"reviewer":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"state":"REVIEWER"},{"updated":"2013-12-03 21:39:59.000000000","updated_by":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"reviewer":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"state":"REVIEWER"},{"updated":"2014-01-28 16:57:46.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2014-01-28 21:56:42.000000000","updated_by":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"reviewer":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"state":"REVIEWER"},{"updated":"2014-02-05 19:35:25.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2014-02-12 18:29:36.000000000","updated_by":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"reviewer":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"state":"REVIEWER"},{"updated":"2014-02-12 19:39:07.000000000","updated_by":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"reviewer":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"state":"REVIEWER"},{"updated":"2014-02-12 19:49:16.000000000","updated_by":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"reviewer":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"state":"REVIEWER"},{"updated":"2014-02-12 20:10:59.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2014-02-13 03:34:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bcf717dcd1edec38a9ab3356122de440097c3ddc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 21:05:13.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/1/check/gate-python-cinderclient-pep8/d57505a : SUCCESS in 38s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/1/check/gate-python-cinderclient-docs/4a6de14/doc/build/html/ : SUCCESS in 34s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/1/check/gate-python-cinderclient-python26/dfbd08c : SUCCESS in 57s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/1/check/gate-python-cinderclient-python27/ae6177c : SUCCESS in 59s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/1/check/gate-python-cinderclient-python33/81e7e17 : SUCCESS in 4m 12s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/1/check/gate-python-cinderclient-pypy/37c9fa8 : SUCCESS in 1m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/1/check/check-tempest-dsvm-full/ba650ea : SUCCESS in 50m 21s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/1/check/check-tempest-dsvm-postgres-full/fff80b5 : SUCCESS in 43m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/1/check/check-tempest-dsvm-neutron/ef76805 : SUCCESS in 37m 35s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/1/check/gate-tempest-dsvm-large-ops/4c397c4 : SUCCESS in 14m 29s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/1/check/gate-tempest-dsvm-neutron-large-ops/19068d7 : SUCCESS in 23m 10s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/1/check/check-grenade-dsvm/1f5d21f : SUCCESS in 34m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"199e8872c80f5aaf6c7665fe897af1f838ebe370","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2013-12-03 21:48:11.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"89944bff04e201d0c7368d2c6a0fc8d85f9ab286","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2013-12-03 21:52:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"99ac923d36dbc8c03bf4ac313f4585702a4b514a","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-03 21:52:34.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"96b8c06594ceee11b14f9ce6031c2bf424c32fa3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 22:46:39.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-pep8/db4688b : SUCCESS in 41s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/2/check/gate-python-cinderclient-docs/7bcffa1/doc/build/html/ : SUCCESS in 45s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-python26/c2a9753 : SUCCESS in 53s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-python27/c746eb8 : SUCCESS in 54s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-python33/704c040 : SUCCESS in 4m 10s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-pypy/f2b6c9d : SUCCESS in 1m 35s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/2/check/check-tempest-dsvm-full/9f1af3d : SUCCESS in 54m 08s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/2/check/check-tempest-dsvm-postgres-full/a58c326 : SUCCESS in 52m 45s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/2/check/check-tempest-dsvm-neutron/a85b80a : SUCCESS in 34m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/2/check/gate-tempest-dsvm-large-ops/499de31 : SUCCESS in 13m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/2/check/gate-tempest-dsvm-neutron-large-ops/a27bfbc : SUCCESS in 17m 06s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/2/check/check-grenade-dsvm/bab25a8 : SUCCESS in 33m 07s\n","accounts_in_message":[],"_revision_number":2},{"id":"4379aae4d7ea89d50ff3f560d9b8db646ac61880","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2013-12-04 03:49:21.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"703fd7fc98e62b5756eef2c7f72ffb64bd5ef5a1","author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"date":"2013-12-17 14:26:34.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"5dfd0b6062bd7d2a29224382c25aac7eaa0fee6f","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2013-12-18 09:44:01.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nPlease open a bug for this and update index.rst with the change","accounts_in_message":[],"_revision_number":2},{"id":"ef8199e9fb7047f867835be06d2a3d623b47b46c","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-12-26 06:03:26.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"8f64fc47ac15c7b0443ad127154f25afc36a6d71","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-12-26 06:03:26.000000000","message":"Patch Set 2:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"2f9ae53da6b1c9efbf97f4d0611d520b342b2f08","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-06 14:52:44.000000000","message":"Patch Set 2: Restored","accounts_in_message":[],"_revision_number":2},{"id":"578429a3d08bdac3241b520d11b7fc423b269998","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-06 17:34:17.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-pep8/b34afb9 : SUCCESS in 1m 19s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/2/check/gate-python-cinderclient-docs/4a61d87/doc/build/html/ : SUCCESS in 46s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-python26/daa99b8 : SUCCESS in 1m 14s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-python27/bcfe5f6 : SUCCESS in 47s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-python33/949cb69 : SUCCESS in 4m 03s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/2/check/gate-python-cinderclient-pypy/6847893 : SUCCESS in 1m 47s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/2/check/check-tempest-dsvm-full/67f6d7d : SUCCESS in 39m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/2/check/check-tempest-dsvm-postgres-full/28bca1a : SUCCESS in 43m 00s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/2/check/check-tempest-dsvm-neutron/7104708 : SUCCESS in 56m 28s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/2/check/gate-tempest-dsvm-large-ops/19a213f : SUCCESS in 17m 07s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/2/check/gate-tempest-dsvm-neutron-large-ops/9db8116 : SUCCESS in 18m 24s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/2/check/check-grenade-dsvm/d2cf71a : SUCCESS in 27m 55s\n","accounts_in_message":[],"_revision_number":2},{"id":"4b624baed8d0748fc7e566ca29841c7706ebb62a","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-09 19:37:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ae7276a6d6ac5e6fa0d18858ca96f8128766a021","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-09 19:38:30.000000000","message":"Patch Set 3:\n\n@Avishay - Done","accounts_in_message":[],"_revision_number":3},{"id":"157ccd7930d1581f97fcc316990c229c50f6689a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 21:00:29.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/3/check/gate-python-cinderclient-pep8/e68d141 : SUCCESS in 43s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/3/check/gate-python-cinderclient-docs/f57df58/doc/build/html/ : SUCCESS in 46s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/3/check/gate-python-cinderclient-python26/9836a99 : SUCCESS in 53s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/3/check/gate-python-cinderclient-python27/ef1eb22 : SUCCESS in 56s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/3/check/gate-python-cinderclient-python33/f8ba6d0 : SUCCESS in 4m 03s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/3/check/gate-python-cinderclient-pypy/7b399ac : SUCCESS in 1m 49s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/3/check/check-tempest-dsvm-full/0559a6a : SUCCESS in 57m 43s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/3/check/check-tempest-dsvm-postgres-full/cbca173 : SUCCESS in 44m 29s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/3/check/check-tempest-dsvm-neutron/2af41e4 : SUCCESS in 35m 01s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/3/check/gate-tempest-dsvm-large-ops/c745102 : SUCCESS in 15m 16s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/3/check/gate-tempest-dsvm-neutron-large-ops/fa6a297 : SUCCESS in 15m 35s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/3/check/check-grenade-dsvm/307b253 : SUCCESS in 29m 35s\n","accounts_in_message":[],"_revision_number":3},{"id":"c10c28caf9a9cad59653f17227930f477af999cd","author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"date":"2014-01-14 19:40:00.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7e7aa2dadaed5163e57a4eec20f27e0aa22b65f7","author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"date":"2014-01-16 14:44:12.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"4bab6c68e740a2915ee9e514a1b2b4f5390f7618","author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"date":"2014-01-17 23:19:18.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"32cdd93bb74d41086522ad30b5c888ba36fb4318","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2014-01-20 06:37:38.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nCouple questions:\nSeems this changes the default behaviors that we\u0027ve already released (taking what was an optional param and making it required), that can wreak havoc to existing installs.  We\u0027d need some strong justification (that should be summarized in the commit message) as to why we\u0027re switching the behavior of an existing API call like this.\n\nAlso, V1 is pretty much crit bug-fixes only at this point, so I\u0027m especially leery about changing that one.","accounts_in_message":[],"_revision_number":3},{"id":"ddcee36c87f6b667eaf568c32f2ee83d1fbf38e5","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-20 14:35:16.000000000","message":"Patch Set 3:\n\n@John Griffith - I can update the commit to add the following information in, as it is not immediately obvious as it is currently written.\n\nThis patch is a bug fix and does change original functionality regarding the \u0027control_location\u0027 parameter. As encryption-type-create is currently implemented, the command will fail if \u0027control_location\u0027 is not supplied at invocation. There is no script or operating procedure that will currently work if the argument is omitted. Making it a required argument removes the need for the \u0027--control_location\u0027 tag; otherwise the command works exactly as before.\n\nAn alternative to making \u0027control_location\u0027 a required parameter would be to provide a default value (i.e., \u0027front-end\u0027) when \u0027control_location\u0027 is not specified. The cinder extension requirements would be met and current invocation patterns would be preserved. However, this masks the fact that \u0027control_location\u0027 really is a required parameter. I thought making the change explicit was a better approach for maintainability, but modifying this patch to use a default value would mean less pain in the short term.\n\nRegarding V1, I understand. Since this is a bug fix, I wanted to include it. However, if this is not deemed critical I can remove support.","accounts_in_message":[],"_revision_number":3},{"id":"2040060457f98336be50010b39f2bd994403154d","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-28 06:03:18.000000000","message":"Patch Set 3:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"fef233c45c26178b330443cdeefcc22524e10a7b","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-28 06:03:18.000000000","message":"Patch Set 3: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"679a9acc952e460e36239b2387d67569671e4086","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-28 15:39:05.000000000","message":"Patch Set 3: Restored","accounts_in_message":[],"_revision_number":3},{"id":"261a8a3f5c00b2eb0ed957413484e7b2085e8696","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 15:39:12.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"8a27f39af7ffede536623012285f128f7758caa6","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-28 16:23:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5c0643e83bb85ee84156a36bf8c39443cb5ee408","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 17:28:18.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-pep8/f72f914 : SUCCESS in 31s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/4/check/gate-python-cinderclient-docs/4e85320/doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python26/aaadac7 : SUCCESS in 50s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python27/449f41c : SUCCESS in 1m 24s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python33/c2495ed : SUCCESS in 4m 11s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-pypy/19022a6 : SUCCESS in 1m 54s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-full/f0d14b4 : FAILURE in 51m 47s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-postgres-full/51804de : SUCCESS in 50m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-neutron/ff4b3f2 : SUCCESS in 47m 10s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/4/check/gate-tempest-dsvm-large-ops/d5688ed : SUCCESS in 11m 23s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/4/check/gate-tempest-dsvm-neutron-large-ops/69c2f2d : SUCCESS in 12m 32s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/4/check/check-grenade-dsvm/ee2b54e : SUCCESS in 28m 56s\n","accounts_in_message":[],"_revision_number":4},{"id":"7b7d3edacd336db357c2bf5e4b8580c5e359914e","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-28 17:34:57.000000000","message":"Patch Set 4:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1258848\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1258848\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1258848","accounts_in_message":[],"_revision_number":4},{"id":"bea52ea7dd735ea30296cd88ed52048c7845982d","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-28 17:49:24.000000000","message":"Patch Set 4:\n\nrecheck bug 1258848","accounts_in_message":[],"_revision_number":4},{"id":"9f0c618b7bc53d1716e069d2453e375afc82e628","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 19:28:02.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-pep8/6b59373 : SUCCESS in 49s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/4/check/gate-python-cinderclient-docs/5f65ba0/doc/build/html/ : SUCCESS in 55s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python26/1e959bf : SUCCESS in 1m 01s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python27/86a7575 : SUCCESS in 1m 14s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python33/22e2df1 : SUCCESS in 4m 06s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-pypy/4147688 : SUCCESS in 1m 52s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-full/73a29b6 : FAILURE in 1h 27m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-postgres-full/083f9e9 : SUCCESS in 52m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-neutron/6457d95 : SUCCESS in 30m 37s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/4/check/gate-tempest-dsvm-large-ops/224661f : SUCCESS in 13m 21s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/4/check/gate-tempest-dsvm-neutron-large-ops/7790b94 : SUCCESS in 13m 08s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/4/check/check-grenade-dsvm/b66c5c8 : SUCCESS in 41m 41s\n","accounts_in_message":[],"_revision_number":4},{"id":"d4cb51a85bec29ca16b59154fb7baf7fad79952f","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-28 19:31:07.000000000","message":"Patch Set 4:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1254890\n- https://bugs.launchpad.net/bugs/1258848\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1254890\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1254890","accounts_in_message":[],"_revision_number":4},{"id":"f05040b980467caffdfeadd82b244cacaf6ad5ae","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-01-28 20:38:12.000000000","message":"Patch Set 4:\n\nrecheck bug 1254890","accounts_in_message":[],"_revision_number":4},{"id":"2631a81122c8db181aa609f2a03795061fe8e41b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 21:50:55.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-pep8/5e63691 : SUCCESS in 48s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/4/check/gate-python-cinderclient-docs/6f0b2e5/doc/build/html/ : SUCCESS in 52s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python26/29776a6 : SUCCESS in 44s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python27/0fd6ec2 : SUCCESS in 1m 04s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-python33/f1a0d51 : SUCCESS in 4m 09s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/4/check/gate-python-cinderclient-pypy/e78def0 : SUCCESS in 1m 55s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-full/75ec666 : SUCCESS in 55m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-postgres-full/885244a : SUCCESS in 59m 23s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/4/check/check-tempest-dsvm-neutron/811453a : SUCCESS in 30m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/4/check/gate-tempest-dsvm-large-ops/c45fe6e : SUCCESS in 13m 29s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/4/check/gate-tempest-dsvm-neutron-large-ops/887bb5f : SUCCESS in 14m 28s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/4/check/check-grenade-dsvm/e1a699c : SUCCESS in 29m 26s\n","accounts_in_message":[],"_revision_number":4},{"id":"e904b821983365473aaedf939f3e0b5d4e98d36d","author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"date":"2014-01-28 21:56:42.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"a6228006dbf941d6bd3c86fa81eed7d1f4b9a620","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2014-01-28 23:38:59.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"7be641b47f9f71b6ef1299244e79a3627ed5ce61","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2014-01-29 08:43:18.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nI think backward compatibility is a concern here.  You should probably deprecate the optional arg but still accept it, and add the required arg.","accounts_in_message":[],"_revision_number":4},{"id":"3627f7e905dfaa09313d855f60ca771c5f584cfc","author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"date":"2014-01-29 13:08:24.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n@Avishay: The existing optional argument should be required: if it is omitted, then the request will be rejected by the encrypted volume type API extension. Deprecating the existing option doesn\u0027t make sense unless a required option with a different name is introduced -- is that what you\u0027re suggesting?\n\nIf seems clearest and most efficient to break backward compatibility because 1) omitting the argument will result in a failure from the aforementioned API extension, 2) the error message will be clearer (i.e., \"control_location is a required parameter\"), and 3) there\u0027s no reason to make an API request that will always fail. Peter included more information and an alternative solution in his original response to John Griffith.","accounts_in_message":[],"_revision_number":4},{"id":"f4716c44eab67173f1e9b60ba7aec007442cff28","author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"date":"2014-01-30 15:12:54.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"91bd5976a73de2d667271ec7b7b95c1eb24d84e3","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-02-05 16:47:31.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ee9f0f3c1eb26b89771ce4f8cfd550a36ca73ea2","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2014-02-05 17:49:16.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"e8d180223153373548174feb3a5715d9fe001f39","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-05 17:52:14.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-pep8/e2a6e55 : SUCCESS in 50s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/5/check/gate-python-cinderclient-docs/ff58aca/doc/build/html/ : SUCCESS in 52s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python26/f50e679 : SUCCESS in 57s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python27/b53f37a : SUCCESS in 54s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python33/3790e69 : SUCCESS in 4m 18s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-pypy/198f8b9 : SUCCESS in 1m 59s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/59813/5/check/check-devstack-dsvm-cells/5a7623d : SUCCESS in 11m 22s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-full/05c3a77 : SUCCESS in 59m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-postgres-full/99e8c85 : SUCCESS in 54m 07s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-neutron/ac3b225 : SUCCESS in 34m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/5/check/gate-tempest-dsvm-large-ops/2ee6566 : SUCCESS in 13m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/5/check/gate-tempest-dsvm-neutron-large-ops/80ff7e0 : SUCCESS in 13m 09s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/5/check/check-grenade-dsvm/d210bd9 : SUCCESS in 32m 35s\n","accounts_in_message":[],"_revision_number":5},{"id":"bc57037085e2365f93c73b914c7c48309c041a18","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2014-02-05 19:35:25.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"e94ba9a734897c0ee1f7bb697dd16887a30fe646","author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"date":"2014-02-05 21:14:00.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"2589a63299f3f868efe6a7442837f7d93c9c8183","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 18:09:44.000000000","message":"Patch Set 5: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"737678d41a92d4153d6f566d2d1ad0d7f7c00c91","author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"date":"2014-02-10 18:09:44.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"27b7f236373878f460418a249ce3110296e5f79a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 19:43:33.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-pep8/9012331 : SUCCESS in 1m 33s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/5/check/gate-python-cinderclient-docs/42cbc47/doc/build/html/ : SUCCESS in 1m 36s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python26/b12c2fe : SUCCESS in 1m 27s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python27/5f12d11 : SUCCESS in 1m 40s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python33/72edc30 : FAILURE in 1m 12s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-pypy/83f8664 : SUCCESS in 2m 50s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/59813/5/check/check-devstack-dsvm-cells/0b79d7f : SUCCESS in 11m 08s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-full/0194941 : SUCCESS in 48m 59s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-postgres-full/87bc33c : SUCCESS in 48m 24s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-neutron/374be98 : SUCCESS in 31m 30s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/5/check/gate-tempest-dsvm-large-ops/fbdbb38 : SUCCESS in 13m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/5/check/gate-tempest-dsvm-neutron-large-ops/1f8b5c5 : SUCCESS in 14m 14s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/5/check/check-grenade-dsvm/474e810 : SUCCESS in 34m 54s\n","accounts_in_message":[],"_revision_number":5},{"id":"920b305843d4ff1b0e43b51de22f34ca9137d998","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-02-10 20:15:14.000000000","message":"Patch Set 5:\n\nrecheck bug 1278564","accounts_in_message":[],"_revision_number":5},{"id":"dd6be07fb2a3489461790be514fa884c128f8421","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 20:15:15.000000000","message":"Patch Set 5: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"f2efbf553add3a225525dc8eaf392696db723d5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 21:31:51.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-pep8/04c1e79 : SUCCESS in 41s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/5/check/gate-python-cinderclient-docs/ab0519a/doc/build/html/ : SUCCESS in 49s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python26/bfbbe39 : SUCCESS in 1m 05s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python27/3f15875 : SUCCESS in 57s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-python33/0ee5744 : FAILURE in 25s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/5/check/gate-python-cinderclient-pypy/6fcfa65 : SUCCESS in 2m 00s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/59813/5/check/check-devstack-dsvm-cells/01203fa : SUCCESS in 15m 50s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-full/3da027d : SUCCESS in 1h 01m 52s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-postgres-full/f150d0d : SUCCESS in 59m 35s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/5/check/check-tempest-dsvm-neutron/bac93d8 : SUCCESS in 30m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/5/check/gate-tempest-dsvm-large-ops/e53168e : SUCCESS in 13m 10s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/5/check/gate-tempest-dsvm-neutron-large-ops/9facd47 : SUCCESS in 18m 33s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/5/check/check-grenade-dsvm/96f2688 : SUCCESS in 31m 18s\n","accounts_in_message":[],"_revision_number":5},{"id":"f50db8e468b424371b7525aaf4d59df9369a118a","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-02-11 13:44:53.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"6627f9c3cfaa48603f6ba35041b048e468379ee5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-11 13:45:00.000000000","message":"Patch Set 6:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"df700c6bfb746263da873a53c484e52dcfa80774","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-02-11 13:45:11.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":6},{"id":"4233905dde36b006a39b2ee868561c97c2d9a8e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-11 14:34:17.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-pep8/206ba84 : SUCCESS in 57s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/6/check/gate-python-cinderclient-docs/af1da5d/doc/build/html/ : SUCCESS in 53s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-python26/ccb581d : SUCCESS in 51s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-python27/bc9e6d0 : SUCCESS in 55s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-python33/80a6bff : FAILURE in 27s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-pypy/5878899 : SUCCESS in 1m 59s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/59813/6/check/check-devstack-dsvm-cells/03de059 : SUCCESS in 10m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/6/check/check-tempest-dsvm-full/e531e4e : SUCCESS in 48m 04s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/6/check/check-tempest-dsvm-postgres-full/342afcc : SUCCESS in 38m 17s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/6/check/check-tempest-dsvm-neutron/eb35d34 : SUCCESS in 32m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/6/check/gate-tempest-dsvm-large-ops/5cfbc14 : SUCCESS in 11m 21s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/6/check/gate-tempest-dsvm-neutron-large-ops/f170972 : SUCCESS in 15m 55s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/6/check/check-grenade-dsvm/a48f8bc : SUCCESS in 35m 14s\n","accounts_in_message":[],"_revision_number":6},{"id":"2b25dd7777f7d85b06643666365e0183fa7e7fb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-11 19:07:46.000000000","message":"Patch Set 6: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"b98cef906efbc77de3f2d523036477b1e6a486d9","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2014-02-11 19:07:46.000000000","message":"Patch Set 6:\n\nrecheck bug 1278564","accounts_in_message":[],"_revision_number":6},{"id":"2f068309b34cd2cece3eba2316299a34090a9766","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-11 19:57:45.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-pep8/585eb08 : SUCCESS in 49s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/6/check/gate-python-cinderclient-docs/1af5830/doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-python26/3122708 : SUCCESS in 58s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-python27/23e32b9 : SUCCESS in 1m 01s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-python33/dfec52b : SUCCESS in 4m 17s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/6/check/gate-python-cinderclient-pypy/4bceb0f : SUCCESS in 2m 01s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/59813/6/check/check-devstack-dsvm-cells/e053d0e : SUCCESS in 10m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/6/check/check-tempest-dsvm-full/403fcdf : SUCCESS in 49m 32s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/6/check/check-tempest-dsvm-postgres-full/ccff2af : SUCCESS in 48m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/6/check/check-tempest-dsvm-neutron/54bb91b : SUCCESS in 30m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/6/check/gate-tempest-dsvm-large-ops/0210190 : SUCCESS in 11m 58s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/6/check/gate-tempest-dsvm-neutron-large-ops/b8100db : SUCCESS in 14m 30s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/6/check/check-grenade-dsvm/3914171 : SUCCESS in 29m 53s\n","accounts_in_message":[],"_revision_number":6},{"id":"6d275325176e23689b6bc8c800c8d0ef27103c57","author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"date":"2014-02-12 18:29:36.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\nLooks like only the commit message is different between patch set 5 and patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"8a8deadeb0b139df84d2329eda71c04e3e8993d6","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2014-02-12 19:38:52.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b23425fdfd5e2d7f69456626a9eb0afdc2179e59","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2014-02-12 19:39:07.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\nUpdated index.rst","accounts_in_message":[],"_revision_number":7},{"id":"4f6905738d426aff262b5c3355d5e918d948957d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-12 19:40:18.000000000","message":"Patch Set 7:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"e96e0bd9e138b09c91706d5afa0a886d75dffa60","author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"date":"2014-02-12 19:49:16.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"dbc9a9eaa938a2fc8d7b0e65133c4cc447047d2f","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2014-02-12 20:10:59.000000000","message":"Patch Set 7: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":7},{"id":"a7cd4fed07143a5876b7906af7ccbd7821458ffe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-12 20:11:00.000000000","message":"Patch Set 7:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"3d16823ec0098d3d2348cb0aa336d9963053789b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-12 21:00:15.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/7/check/gate-python-cinderclient-pep8/7a7c125 : SUCCESS in 41s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/7/check/gate-python-cinderclient-docs/0bae04a/doc/build/html/ : SUCCESS in 51s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/7/check/gate-python-cinderclient-python26/3ca33c4 : SUCCESS in 1m 14s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/7/check/gate-python-cinderclient-python27/342b68f : SUCCESS in 45s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/7/check/gate-python-cinderclient-python33/aa8dbb3 : SUCCESS in 4m 13s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/7/check/gate-python-cinderclient-pypy/5279568 : SUCCESS in 2m 02s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/59813/7/check/check-devstack-dsvm-cells/dba3cce : SUCCESS in 13m 05s\n- check-tempest-dsvm-full http://logs.openstack.org/13/59813/7/check/check-tempest-dsvm-full/6bc4b89 : SUCCESS in 39m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/7/check/check-tempest-dsvm-postgres-full/91dc1f3 : SUCCESS in 57m 41s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/59813/7/check/check-tempest-dsvm-neutron/afd694a : SUCCESS in 38m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/7/check/gate-tempest-dsvm-large-ops/1f18090 : SUCCESS in 17m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/7/check/gate-tempest-dsvm-neutron-large-ops/cf34d9b : SUCCESS in 17m 51s\n- check-grenade-dsvm http://logs.openstack.org/13/59813/7/check/check-grenade-dsvm/baf06fa : SUCCESS in 34m 30s\n","accounts_in_message":[],"_revision_number":7},{"id":"9d25167071d2d1737600fec408a75f14ba505c71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 03:34:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7},{"id":"1d50b91dc97f1e6d86b9c9476a8f7ba9ea7e691f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 03:34:18.000000000","message":"Patch Set 7: Verified\n\nBuild succeeded.\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/13/59813/7/gate/gate-python-cinderclient-docs/e366370/doc/build/html/ : SUCCESS in 55s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/13/59813/7/gate/gate-python-cinderclient-pep8/8b3a226 : SUCCESS in 51s\n- gate-python-cinderclient-python26 http://logs.openstack.org/13/59813/7/gate/gate-python-cinderclient-python26/2c6a34f : SUCCESS in 1m 03s\n- gate-python-cinderclient-python27 http://logs.openstack.org/13/59813/7/gate/gate-python-cinderclient-python27/4b751d5 : SUCCESS in 51s\n- gate-python-cinderclient-python33 http://logs.openstack.org/13/59813/7/gate/gate-python-cinderclient-python33/3aa12cd : SUCCESS in 4m 12s\n- gate-python-cinderclient-pypy http://logs.openstack.org/13/59813/7/gate/gate-python-cinderclient-pypy/a540131 : SUCCESS in 2m 01s\n- gate-devstack-dsvm-cells http://logs.openstack.org/13/59813/7/gate/gate-devstack-dsvm-cells/194e13c : SUCCESS in 11m 33s\n- gate-tempest-dsvm-full http://logs.openstack.org/13/59813/7/gate/gate-tempest-dsvm-full/64e9e6e : SUCCESS in 46m 37s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/13/59813/7/gate/gate-tempest-dsvm-postgres-full/2e7dada : SUCCESS in 43m 48s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/13/59813/7/gate/gate-tempest-dsvm-neutron/c7d162c : SUCCESS in 29m 45s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/59813/7/gate/gate-tempest-dsvm-large-ops/80029c8 : SUCCESS in 14m 07s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/59813/7/gate/gate-tempest-dsvm-neutron-large-ops/bfde30f : SUCCESS in 13m 09s\n- gate-grenade-dsvm http://logs.openstack.org/13/59813/7/gate/gate-grenade-dsvm/7d6899f : SUCCESS in 33m 26s\n","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"6fd8d8e12e7788e7f5b85bc3b8ef2f6ee2eb7714","revisions":{"a7225c8b94b438b6464aea5bcd188f5ac4bd6b81":{"kind":"REWORK","_number":1,"created":"2013-12-03 19:34:11.000000000","uploader":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"ref":"refs/changes/13/59813/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/1"}}},"commit":{"parents":[{"commit":"1aa375ae43ef212ed7bd0487d3d3267e1b931978","subject":"Merge \"Add assert to delete multiple test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1aa375ae43ef212ed7bd0487d3d3267e1b931978"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2013-12-03 19:19:23.000000000","tz":-300},"committer":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2013-12-03 19:19:23.000000000","tz":-300},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis modification changes the control_location argument for the\nencryption-type-create command, turning it into a required parameter.\nThe control_location indicates which service will conduct the volume\nencryption for the encryption-type under consideration; valid options\nare \u0027front-end\u0027 (i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The\nchange from optional to required parameter matches the expectations\nof the volume encryption type cinder API extension. For further\ndiscussion and information, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a7225c8b94b438b6464aea5bcd188f5ac4bd6b81"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a7225c8b94b438b6464aea5bcd188f5ac4bd6b81"}]},"branch":"refs/heads/master"},"d159ce9e53653d24dc3cf9cf476e01fe414ad156":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-12-03 21:52:29.000000000","uploader":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"ref":"refs/changes/13/59813/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/2"}}},"commit":{"parents":[{"commit":"1aa375ae43ef212ed7bd0487d3d3267e1b931978","subject":"Merge \"Add assert to delete multiple test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1aa375ae43ef212ed7bd0487d3d3267e1b931978"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2013-12-03 19:19:23.000000000","tz":-300},"committer":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2013-12-03 21:49:14.000000000","tz":-300},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis modification changes the control_location argument for the\nencryption-type-create command, turning it into a required parameter.\nThe control_location indicates which service will conduct the volume\nencryption for the encryption-type under consideration; valid options\nare \u0027front-end\u0027 (i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The\nchange from optional to required parameter matches the expectations\nof the volume encryption type cinder API extension. For further\ndiscussion and information, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\nDocImpact\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d159ce9e53653d24dc3cf9cf476e01fe414ad156"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d159ce9e53653d24dc3cf9cf476e01fe414ad156"}]},"branch":"refs/heads/master"},"f10037e795e2e2529010b6e51a224893d8c2ab7d":{"kind":"REWORK","_number":3,"created":"2014-01-09 19:37:56.000000000","uploader":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"ref":"refs/changes/13/59813/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/3"}}},"commit":{"parents":[{"commit":"2d155ecb07d1fa1f8c64948b34b4ca12c40c6c2e","subject":"Merge \"Updates .gitignore\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2d155ecb07d1fa1f8c64948b34b4ca12c40c6c2e"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-01-09 19:30:46.000000000","tz":-300},"committer":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-01-09 19:30:46.000000000","tz":-300},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis modification changes the control_location argument for the\nencryption-type-create command, turning it into a required parameter.\nThe control_location indicates which service will conduct the volume\nencryption for the encryption-type under consideration; valid options\nare \u0027front-end\u0027 (i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The\nchange from optional to required parameter matches the expectations\nof the volume encryption type cinder API extension. For further\ndiscussion and information, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\nCloses-Bug: #1267168\nDocImpact\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f10037e795e2e2529010b6e51a224893d8c2ab7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f10037e795e2e2529010b6e51a224893d8c2ab7d"}]},"branch":"refs/heads/master"},"9e6be97e949fbf78d90230fdd4049b9d0a587cf5":{"kind":"REWORK","_number":4,"created":"2014-01-28 16:23:56.000000000","uploader":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"ref":"refs/changes/13/59813/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/4"}}},"commit":{"parents":[{"commit":"306d451bc7fc6c33c4aa222582be76c43d835866","subject":"Add shell tests for snapshot_delete","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/306d451bc7fc6c33c4aa222582be76c43d835866"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-01-28 16:16:17.000000000","tz":-300},"committer":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-01-28 16:16:17.000000000","tz":-300},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis bug fix addresses bug #1267168, changing the optional\ncontrol_location argument for the encryption-type-create command into\na required parameter. Prior to this fix, any invocation of\nencryption-type-create that omits the control_location parameter will\nfail. The parameter indicates which service will conduct the volume\nencryption for the encryption-type under consideration; valid options\nare \u0027front-end\u0027 (i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The\nchange from optional to required parameter matches the expectations\nof the volume encryption type cinder API extension. For prior\ndiscussion and information, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\nCloses-Bug: #1267168\nDocImpact\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9e6be97e949fbf78d90230fdd4049b9d0a587cf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9e6be97e949fbf78d90230fdd4049b9d0a587cf5"}]},"branch":"refs/heads/master"},"d73f71e9db0b5efbbc1f932dd028f9a58c525163":{"kind":"REWORK","_number":5,"created":"2014-02-05 16:47:31.000000000","uploader":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"ref":"refs/changes/13/59813/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/5"}}},"commit":{"parents":[{"commit":"4273bbefb91d380f626de3dbf858dd214a5f48de","subject":"Fix typos in cinderclient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4273bbefb91d380f626de3dbf858dd214a5f48de"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-02-05 16:42:32.000000000","tz":-300},"committer":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-02-05 16:47:31.000000000","tz":-300},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis bug fix addresses bug #1267168, adding a default value to the\noptional control_location parameter for the encryption-type-create\ncommand. Prior to this fix, any invocation of encryption-type-create\nthat omitted the control_location parameter would fail. The parameter\nindicates which service will conduct the volume encryption for the\nencryption-type under consideration; valid options are \u0027front-end\u0027\n(i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The change from optional\nto required parameter matches the expectations of the volume\nencryption type cinder API extension. For prior discussion and\ninformation, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\nCloses-Bug: #1267168\nDocImpact\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d73f71e9db0b5efbbc1f932dd028f9a58c525163"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d73f71e9db0b5efbbc1f932dd028f9a58c525163"}]},"branch":"refs/heads/master"},"9955440e57a072bb612ff264662fc365ea2cbc44":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2014-02-11 13:44:53.000000000","uploader":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"ref":"refs/changes/13/59813/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/6"}}},"commit":{"parents":[{"commit":"4273bbefb91d380f626de3dbf858dd214a5f48de","subject":"Fix typos in cinderclient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4273bbefb91d380f626de3dbf858dd214a5f48de"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-02-11 13:36:41.000000000","tz":-300},"committer":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-02-11 13:36:41.000000000","tz":-300},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis bug fix addresses bug #1267168, adding a default value to the\noptional control_location parameter for the encryption-type-create\ncommand. Prior to this fix, any invocation of encryption-type-create\nthat omitted the control_location parameter would fail. The failure\narose from the expectations of the cinder volume encryption type\nAPI extension, which expects to always receive a value for the\ncontrol_location on encryption type creation.\n\ncontrol_location indicates which service will conduct the volume\nencryption for the encryption-type under consideration; valid options\nare \u0027front-end\u0027 (i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The new\ndefault value is \u0027front-end\u0027 and is used whenever control_location\nis omitted from encryption-type-create invocation. For prior\ndiscussion and information, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\nCloses-Bug: #1267168\nDocImpact\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9955440e57a072bb612ff264662fc365ea2cbc44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9955440e57a072bb612ff264662fc365ea2cbc44"}]},"branch":"refs/heads/master"},"6fd8d8e12e7788e7f5b85bc3b8ef2f6ee2eb7714":{"kind":"REWORK","_number":7,"created":"2014-02-12 19:38:52.000000000","uploader":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"ref":"refs/changes/13/59813/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/13/59813/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/13/59813/7"}}},"commit":{"parents":[{"commit":"7914e46b03614dde9ae4604cfe35b283d3a55253","subject":"Remove tox locale overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7914e46b03614dde9ae4604cfe35b283d3a55253"}]}],"author":{"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","date":"2014-02-11 13:36:41.000000000","tz":-300},"committer":{"name":"Avishay Traeger","email":"avishay@il.ibm.com","date":"2014-02-12 19:38:41.000000000","tz":120},"subject":"Require ctrl_location for encryption-type-create","message":"Require ctrl_location for encryption-type-create\n\nThis bug fix addresses bug #1267168, adding a default value to the\noptional control_location parameter for the encryption-type-create\ncommand. Prior to this fix, any invocation of encryption-type-create\nthat omitted the control_location parameter would fail. The failure\narose from the expectations of the cinder volume encryption type\nAPI extension, which expects to always receive a value for the\ncontrol_location on encryption type creation.\n\ncontrol_location indicates which service will conduct the volume\nencryption for the encryption-type under consideration; valid options\nare \u0027front-end\u0027 (i.e., nova) and \u0027back-end\u0027 (i.e., cinder). The new\ndefault value is \u0027front-end\u0027 and is used whenever control_location\nis omitted from encryption-type-create invocation. For prior\ndiscussion and information, see the abandoned patch below:\n\nhttps://review.openstack.org/#/c/58303/\n\nblueprint encrypt-cinder-volumes\nhttps://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes\n\nChange-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2\nCloses-Bug: #1267168\nDocImpact\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6fd8d8e12e7788e7f5b85bc3b8ef2f6ee2eb7714"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6fd8d8e12e7788e7f5b85bc3b8ef2f6ee2eb7714"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}