)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7e589212b1b8ffbc10ffbf84dd4734c1e78d74c0","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/606346"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Implements: blueprint add-volume-re-image-api"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I37c254d4caf2f416e456ff6a78b5a4df4e08a176"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"c668b5e0_577f6c8a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":18},"updated":"2022-02-24 16:27:05.000000000","message":"Better to mark as \"Implements\" since this completes the cinderclient work.","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ce6320fe99c8fff8888afa4fd98f999d994c336","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/606346"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Implements: blueprint add-volume-re-image-api"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I37c254d4caf2f416e456ff6a78b5a4df4e08a176"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"597f674b_f01cea42","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":18},"in_reply_to":"c668b5e0_577f6c8a","updated":"2022-02-24 17:41:54.000000000","message":"Done","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4e6de07c39bea410a285b5146b8e713831acc02a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"74f00767_f8f86788","updated":"2022-02-17 08:07:09.000000000","message":"recheck","commit_id":"5de69119a922e554c03fa0404a19246390b25c43"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c53773660183ea003244683b86319e4bebc1e6b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2737016e_38e6bdbe","updated":"2022-02-17 10:12:31.000000000","message":"recheck","commit_id":"5cf12a845ce8d4f44d31d0a2f3ced07a020a8d0d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf605f9209d668876c6850a0930328d643bbd0a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9c8c9ebe_13c456a3","updated":"2022-02-17 15:05:53.000000000","message":"recheck","commit_id":"5cf12a845ce8d4f44d31d0a2f3ced07a020a8d0d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99ab968bc6f001557c1b28e71c67edb0d0b1372d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"37d86711_e40f337a","updated":"2022-02-24 00:06:16.000000000","message":"Code looks fine, though for completeness it\u0027s probably worth adding tests for when reimage-reserved is True.\n\nAs you know, the destructive nature of this feature worries me, so I think you should handle the --reimage-reserved option slightly differently (see comment inline).  Also, suggestion inline for revising the release note.","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d2c0ac52003eb8c715ee07098dfac28247c86a04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6ed1be03_93d6907a","updated":"2022-02-24 02:00:45.000000000","message":"Forgot to vote.","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e3f50ed95a728ab2ad46d6fd66f0055e8fa8b352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"309f8c73_5793d96e","in_reply_to":"37d86711_e40f337a","updated":"2022-02-24 10:43:22.000000000","message":"Added test with --reimage-reserved parameter","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e3f50ed95a728ab2ad46d6fd66f0055e8fa8b352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"06e4e360_29af07b0","updated":"2022-02-24 10:43:22.000000000","message":"Thanks Brian","commit_id":"87d413ed1b1010eb1d33f84d15625a4472aab5b0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7e589212b1b8ffbc10ffbf84dd4734c1e78d74c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cefe3d30_4f40966d","updated":"2022-02-24 16:27:05.000000000","message":"Referring to \"new image\" seems confusing for the help text for this feature since it isn\u0027t creating images, etc.","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3ef671c6d0ca08a49c8be7e3ffacd33b606790cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ddbd4290_8761be8e","updated":"2022-02-24 14:49:50.000000000","message":"Revisions look good to me.  Comment inline about the argument handling, but I don\u0027t think we need to do anything about it.","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b3951eb3e03867451215af6e88413d76d38e4a70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4019fe78_f7ef249e","updated":"2022-02-24 17:11:52.000000000","message":"Some suggestions to address Eric\u0027s concerns noted inline.","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ce6320fe99c8fff8888afa4fd98f999d994c336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"186097cc_5f3f1a5e","updated":"2022-02-24 17:41:54.000000000","message":"Thanks Brian and Eric","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d2b0566b50609e647cde2026173d015dcf5afa3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"af970131_9e220d7a","updated":"2022-02-24 17:45:20.000000000","message":"Removed Depends-On as the cinder dependency has merged","commit_id":"12075cb71067563f60de929e61f79eae33b2c2ec"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7511713ce225a11c7766b5687447dc6a96c88b32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"94158e02_aa4a95a2","updated":"2022-02-24 19:28:59.000000000","message":"Revisions LGTM.","commit_id":"12075cb71067563f60de929e61f79eae33b2c2ec"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0125a13b3891be7ed90b8fa32832316f8574f3b1","unresolved":false,"context_lines":[{"line_number":2444,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2445,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2446,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2447,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":2448,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2449,"context_line":"           const\u003dTrue,"},{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_811b5d1a","line":2447,"range":{"start_line":2447,"start_character":14,"end_line":2447,"end_character":19},"updated":"2018-10-11 09:08:13.000000000","message":"and this parameter still have some argument, so we need change it after spec approved.","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cfd045da516480ed0af103fd688c306f5c5860f","unresolved":false,"context_lines":[{"line_number":2444,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2445,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2446,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2447,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":2448,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2449,"context_line":"           const\u003dTrue,"},{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4cbf7c5f","line":2447,"range":{"start_line":2447,"start_character":14,"end_line":2447,"end_character":19},"in_reply_to":"3f79a3b5_811b5d1a","updated":"2018-10-15 08:54:04.000000000","message":"Done","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0125a13b3891be7ed90b8fa32832316f8574f3b1","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":2451,"context_line":"           default\u003dFalse,"},{"line_number":2452,"context_line":"           help\u003d\u0027Enables or disables reimage \u0027"},{"line_number":2453,"context_line":"           \u0027a volume that is attached to an instance. \u0027"},{"line_number":2454,"context_line":"           \u0027Default\u003dFalse.\u0027)"},{"line_number":2455,"context_line":"def do_reimage(cs, args):"},{"line_number":2456,"context_line":"    \"\"\"Reimages a volume\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c10cf5ec","line":2453,"range":{"start_line":2453,"start_character":26,"end_line":2453,"end_character":53},"updated":"2018-10-11 09:08:13.000000000","message":"include in-use and reserverd","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cfd045da516480ed0af103fd688c306f5c5860f","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":2451,"context_line":"           default\u003dFalse,"},{"line_number":2452,"context_line":"           help\u003d\u0027Enables or disables reimage \u0027"},{"line_number":2453,"context_line":"           \u0027a volume that is attached to an instance. \u0027"},{"line_number":2454,"context_line":"           \u0027Default\u003dFalse.\u0027)"},{"line_number":2455,"context_line":"def do_reimage(cs, args):"},{"line_number":2456,"context_line":"    \"\"\"Reimages a volume\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_acaf3029","line":2453,"range":{"start_line":2453,"start_character":26,"end_line":2453,"end_character":53},"in_reply_to":"3f79a3b5_c10cf5ec","updated":"2018-10-15 08:54:04.000000000","message":"Done","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0125a13b3891be7ed90b8fa32832316f8574f3b1","unresolved":false,"context_lines":[{"line_number":2456,"context_line":"    \"\"\"Reimages a volume\"\"\""},{"line_number":2457,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2458,"context_line":"    volume.reimage(args.image_id, args.force)"},{"line_number":2459,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_41e6a515","line":2459,"updated":"2018-10-11 09:08:13.000000000","message":"redundant line?","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cfd045da516480ed0af103fd688c306f5c5860f","unresolved":false,"context_lines":[{"line_number":2456,"context_line":"    \"\"\"Reimages a volume\"\"\""},{"line_number":2457,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2458,"context_line":"    volume.reimage(args.image_id, args.force)"},{"line_number":2459,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ccaaac18","line":2459,"in_reply_to":"3f79a3b5_41e6a515","updated":"2018-10-15 08:54:04.000000000","message":"removed","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"285795a81e7c262c92a47a7db7e5471f26c40f8c","unresolved":false,"context_lines":[{"line_number":2437,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":2438,"context_line":"    utils.print_dict(info)"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":""},{"line_number":2441,"context_line":"@utils.arg(\u0027volume\u0027,"},{"line_number":2442,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":2443,"context_line":"           help\u003d\u0027Name or ID of volume to reimage\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_67698621","line":2440,"updated":"2018-12-05 03:19:31.000000000","message":"@api_versions.wraps(\u00273.56\u0027)","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37bae8604f4c60c0ad9d955f23b4db10e2fbd581","unresolved":false,"context_lines":[{"line_number":2437,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":2438,"context_line":"    utils.print_dict(info)"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":""},{"line_number":2441,"context_line":"@utils.arg(\u0027volume\u0027,"},{"line_number":2442,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":2443,"context_line":"           help\u003d\u0027Name or ID of volume to reimage\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_194b205d","line":2440,"in_reply_to":"3f79a3b5_67698621","updated":"2018-12-07 05:30:43.000000000","message":"Done in VolumeManager","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"285795a81e7c262c92a47a7db7e5471f26c40f8c","unresolved":false,"context_lines":[{"line_number":2444,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2445,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2446,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2447,"context_line":"@utils.arg(\u0027--ignore-in-use\u0027,"},{"line_number":2448,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2449,"context_line":"           const\u003dTrue,"},{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_275dce7a","line":2447,"range":{"start_line":2447,"start_character":12,"end_line":2447,"end_character":27},"updated":"2018-12-05 03:19:31.000000000","message":"--ignore-reserved","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37bae8604f4c60c0ad9d955f23b4db10e2fbd581","unresolved":false,"context_lines":[{"line_number":2444,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2445,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2446,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2447,"context_line":"@utils.arg(\u0027--ignore-in-use\u0027,"},{"line_number":2448,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2449,"context_line":"           const\u003dTrue,"},{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_39505c08","line":2447,"range":{"start_line":2447,"start_character":12,"end_line":2447,"end_character":27},"in_reply_to":"3f79a3b5_275dce7a","updated":"2018-12-07 05:30:43.000000000","message":"Done","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"285795a81e7c262c92a47a7db7e5471f26c40f8c","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":2451,"context_line":"           default\u003dFalse,"},{"line_number":2452,"context_line":"           help\u003d\u0027Enables or disables reimage for \u0027"},{"line_number":2453,"context_line":"           \u0027a volume that is in attached/in-use/reserved state. \u0027"},{"line_number":2454,"context_line":"           \u0027Default\u003dFalse.\u0027)"},{"line_number":2455,"context_line":"def do_reimage(cs, args):"},{"line_number":2456,"context_line":"    \"\"\"Reimages a volume\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_874dc2c7","line":2453,"range":{"start_line":2453,"start_character":32,"end_line":2453,"end_character":56},"updated":"2018-12-05 03:19:31.000000000","message":"need update","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37bae8604f4c60c0ad9d955f23b4db10e2fbd581","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":2451,"context_line":"           default\u003dFalse,"},{"line_number":2452,"context_line":"           help\u003d\u0027Enables or disables reimage for \u0027"},{"line_number":2453,"context_line":"           \u0027a volume that is in attached/in-use/reserved state. \u0027"},{"line_number":2454,"context_line":"           \u0027Default\u003dFalse.\u0027)"},{"line_number":2455,"context_line":"def do_reimage(cs, args):"},{"line_number":2456,"context_line":"    \"\"\"Reimages a volume\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d93848cd","line":2453,"range":{"start_line":2453,"start_character":32,"end_line":2453,"end_character":56},"in_reply_to":"3f79a3b5_874dc2c7","updated":"2018-12-07 05:30:43.000000000","message":"Done","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99ab968bc6f001557c1b28e71c67edb0d0b1372d","unresolved":true,"context_lines":[{"line_number":2867,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2868,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2869,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2870,"context_line":"@utils.arg(\u0027--reimage-reserved\u0027,"},{"line_number":2871,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2872,"context_line":"           const\u003dTrue,"},{"line_number":2873,"context_line":"           nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"f4bcc51e_58e6ff35","line":2870,"range":{"start_line":2870,"start_character":14,"end_line":2870,"end_character":30},"updated":"2022-02-24 00:06:16.000000000","message":"This is \u0027ignore-reserved\u0027 in the spec, so don\u0027t forget to go back and update the spec.  (I think it makes sense to have the same structure in the client as in the API, so I think you took the correct approach here.)","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e3f50ed95a728ab2ad46d6fd66f0055e8fa8b352","unresolved":false,"context_lines":[{"line_number":2867,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2868,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2869,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2870,"context_line":"@utils.arg(\u0027--reimage-reserved\u0027,"},{"line_number":2871,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2872,"context_line":"           const\u003dTrue,"},{"line_number":2873,"context_line":"           nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"821f4c6a_6b4e96d8","line":2870,"range":{"start_line":2870,"start_character":14,"end_line":2870,"end_character":30},"in_reply_to":"f4bcc51e_58e6ff35","updated":"2022-02-24 10:43:22.000000000","message":"Ack","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99ab968bc6f001557c1b28e71c67edb0d0b1372d","unresolved":true,"context_lines":[{"line_number":2874,"context_line":"           default\u003dFalse,"},{"line_number":2875,"context_line":"           help\u003d\u0027Enables or disables reimage for a volume that is in \u0027"},{"line_number":2876,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2877,"context_line":"                \u0027status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2878,"context_line":"def do_reimage(cs, args):"},{"line_number":2879,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2880,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"b5179840_3869fade","line":2877,"range":{"start_line":2877,"start_character":42,"end_line":2877,"end_character":55},"updated":"2022-02-24 00:06:16.000000000","message":"-1: We don\u0027t want \"regular\" users to re-image reserved volumes, so let\u0027s not make it easy for them.  Also, there\u0027s an ambiguity about what \"Default\u003dFalse\" means.  What I mean is, the current help output is:\n\n  usage: cinder reimage [--reimage-reserved [\u003cTrue|False\u003e]] \u003cvolume\u003e \u003cimage-id\u003e\n\n  Rebuilds a volume with specified new image\n\n  Positional Arguments:\n    \u003cvolume\u003e              Name or ID of volume to reimage\n    \u003cimage-id\u003e            The new image id.\n\n  Optional Arguments:\n    --reimage-reserved [\u003cTrue|False\u003e]\n                          Enables or disables reimage for a volume that is in\n                          reserved state otherwise only volumes in \"available\"\n                          status may be re-imaged. Default\u003dFalse.\n\nSo you can make this call:\n\n  cinder reimage --reimage-reserved cd42b779-2e10-4... f51f4929-1ef9-4...\n\nThis is the same as \"--reimage-reserved True\"; the default\u003dFalse only applies if you don\u0027t include the option at all.  So I think the help text is not clear about what happens if you leave the optional True|False out.\n\nMy suggestion is to remove the nargs and const parameters and thereby require the user to explicitly specify either True or False when the --reimage-reserved option is used.","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"be4b281b6455440381c0d2d992c89c2b5f835dab","unresolved":false,"context_lines":[{"line_number":2874,"context_line":"           default\u003dFalse,"},{"line_number":2875,"context_line":"           help\u003d\u0027Enables or disables reimage for a volume that is in \u0027"},{"line_number":2876,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2877,"context_line":"                \u0027status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2878,"context_line":"def do_reimage(cs, args):"},{"line_number":2879,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2880,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5e7637b5_2be0ec7e","line":2877,"range":{"start_line":2877,"start_character":42,"end_line":2877,"end_character":55},"in_reply_to":"07c6958a_a6344be8","updated":"2022-02-24 11:15:44.000000000","message":"now it fails if we don\u0027t pass True/False value\n\n| 81fd4884-772f-4c05-8e67-2444d263e707 | reserved  | boot_vol | 1    | True           | ceph        | true     |             |\n\nstack@devstack-VirtualBox:~/python-cinderclient$ cinder reimage --reimage-reserved 81fd4884-772f-4c05-8e67-2444d263e707 e71ca3fb-ed97-47d5-b61f-29dec0f07d8e\nusage: cinder reimage [--reimage-reserved \u003cTrue|False\u003e] \u003cvolume\u003e \u003cimage-id\u003e\nerror: the following arguments are required: \u003cimage-id\u003e\nTry \u0027cinder help reimage\u0027 for more information.\n\nAlso fails if --reimage-reserved is False (at API layer)\n\nstack@devstack-VirtualBox:~/python-cinderclient$ cinder reimage --reimage-reserved False 81fd4884-772f-4c05-8e67-2444d263e707 e71ca3fb-ed97-47d5-b61f-29dec0f07d8e\nERROR: Invalid volume: Volume 81fd4884-772f-4c05-8e67-2444d263e707 status must be available or error, but current status is reserved. (HTTP 400) (Request-ID: req-d48534f3-d6bf-4a38-ace6-eca56cd01871)\n\nWorks if --reimage-reserved is True\n\nstack@devstack-VirtualBox:~/python-cinderclient$ cinder reimage --reimage-reserved True 81fd4884-772f-4c05-8e67-2444d263e707 e71ca3fb-ed97-47d5-b61f-29dec0f07d8e\n\nDEBUG cinder.volume.manager [req-308b3e7b-75c5-49e5-ae32-142dcd410698 req-8dac91ec-9ac9-4758-8347-6bc8b500440a admin None] Re-image e71ca3fb-ed97-47d5-b61f-29dec0f07d8e to volume 81fd4884-772f-4c05-8e67-2444d263e707 successfully. {{(pid\u003d10342) reimage /opt/stack/cinder/cinder/volume/manager.py:5324}}","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ce6320fe99c8fff8888afa4fd98f999d994c336","unresolved":false,"context_lines":[{"line_number":2874,"context_line":"           default\u003dFalse,"},{"line_number":2875,"context_line":"           help\u003d\u0027Enables or disables reimage for a volume that is in \u0027"},{"line_number":2876,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2877,"context_line":"                \u0027status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2878,"context_line":"def do_reimage(cs, args):"},{"line_number":2879,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2880,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3c924c4b_b9dfb26d","line":2877,"range":{"start_line":2877,"start_character":42,"end_line":2877,"end_character":55},"in_reply_to":"3ef01ad0_297aaa1e","updated":"2022-02-24 17:41:54.000000000","message":"Ack","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3ef671c6d0ca08a49c8be7e3ffacd33b606790cc","unresolved":true,"context_lines":[{"line_number":2874,"context_line":"           default\u003dFalse,"},{"line_number":2875,"context_line":"           help\u003d\u0027Enables or disables reimage for a volume that is in \u0027"},{"line_number":2876,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2877,"context_line":"                \u0027status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2878,"context_line":"def do_reimage(cs, args):"},{"line_number":2879,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2880,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ef01ad0_297aaa1e","line":2877,"range":{"start_line":2877,"start_character":42,"end_line":2877,"end_character":55},"in_reply_to":"5e7637b5_2be0ec7e","updated":"2022-02-24 14:49:50.000000000","message":"The --reimage-reserved is eating the volume-id as its parameter, so that\u0027s why the message is slightly misleading (\"error: the following arguments are required: \u003cimage-id\u003e\").  But you also have the \"usage\" sentence that clearly shows that you need True or False as an argument, so I don\u0027t think we need to worry about it.\n\nAlso, the current code will allow you to make a call like this:\n\n  cinder reimage --reimage-reserved Whatever volume1 image1\n\nThe call will be made to cinder and will be rejected by the schema validation, so I think we don\u0027t need to harden this now.","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e3f50ed95a728ab2ad46d6fd66f0055e8fa8b352","unresolved":false,"context_lines":[{"line_number":2874,"context_line":"           default\u003dFalse,"},{"line_number":2875,"context_line":"           help\u003d\u0027Enables or disables reimage for a volume that is in \u0027"},{"line_number":2876,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2877,"context_line":"                \u0027status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2878,"context_line":"def do_reimage(cs, args):"},{"line_number":2879,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2880,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"07c6958a_a6344be8","line":2877,"range":{"start_line":2877,"start_character":42,"end_line":2877,"end_character":55},"in_reply_to":"b5179840_3869fade","updated":"2022-02-24 10:43:22.000000000","message":"Done","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7e589212b1b8ffbc10ffbf84dd4734c1e78d74c0","unresolved":true,"context_lines":[{"line_number":2866,"context_line":"           help\u003d\u0027Name or ID of volume to reimage\u0027)"},{"line_number":2867,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2868,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2869,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2870,"context_line":"@utils.arg(\u0027--reimage-reserved\u0027,"},{"line_number":2871,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2872,"context_line":"           default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":13,"id":"d998188c_eba46bdd","line":2869,"range":{"start_line":2869,"start_character":21,"end_line":2869,"end_character":24},"updated":"2022-02-24 16:27:05.000000000","message":"Why \"new\"?","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ce6320fe99c8fff8888afa4fd98f999d994c336","unresolved":false,"context_lines":[{"line_number":2866,"context_line":"           help\u003d\u0027Name or ID of volume to reimage\u0027)"},{"line_number":2867,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2868,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2869,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2870,"context_line":"@utils.arg(\u0027--reimage-reserved\u0027,"},{"line_number":2871,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2872,"context_line":"           default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":13,"id":"c93c259a_25c47e30","line":2869,"range":{"start_line":2869,"start_character":21,"end_line":2869,"end_character":24},"in_reply_to":"8df8689d_ca5a3f77","updated":"2022-02-24 17:41:54.000000000","message":"Done","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b3951eb3e03867451215af6e88413d76d38e4a70","unresolved":true,"context_lines":[{"line_number":2866,"context_line":"           help\u003d\u0027Name or ID of volume to reimage\u0027)"},{"line_number":2867,"context_line":"@utils.arg(\u0027image_id\u0027,"},{"line_number":2868,"context_line":"           metavar\u003d\u0027\u003cimage-id\u003e\u0027,"},{"line_number":2869,"context_line":"           help\u003d\u0027The new image id.\u0027)"},{"line_number":2870,"context_line":"@utils.arg(\u0027--reimage-reserved\u0027,"},{"line_number":2871,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2872,"context_line":"           default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":13,"id":"8df8689d_ca5a3f77","line":2869,"range":{"start_line":2869,"start_character":21,"end_line":2869,"end_character":24},"in_reply_to":"d998188c_eba46bdd","updated":"2022-02-24 17:11:52.000000000","message":"How about:\n\n  help\u003d\u0027The image id of the image that will be used to reimage the volume.\"","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b3951eb3e03867451215af6e88413d76d38e4a70","unresolved":true,"context_lines":[{"line_number":2874,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2875,"context_line":"                \u0027 or \"error\" status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2876,"context_line":"def do_reimage(cs, args):"},{"line_number":2877,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2878,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2879,"context_line":"    volume.reimage(args.image_id, args.reimage_reserved)"}],"source_content_type":"text/x-python","patch_set":13,"id":"8a32fb04_c41d11f3","line":2877,"range":{"start_line":2877,"start_character":7,"end_line":2877,"end_character":49},"updated":"2022-02-24 17:11:52.000000000","message":"How about:\n\n  Rebuilds a volume, overwriting all content with the specified image","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ce6320fe99c8fff8888afa4fd98f999d994c336","unresolved":false,"context_lines":[{"line_number":2874,"context_line":"                \u0027reserved state otherwise only volumes in \"available\" \u0027"},{"line_number":2875,"context_line":"                \u0027 or \"error\" status may be re-imaged. Default\u003dFalse.\u0027)"},{"line_number":2876,"context_line":"def do_reimage(cs, args):"},{"line_number":2877,"context_line":"    \"\"\"Rebuilds a volume with specified new image\"\"\""},{"line_number":2878,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2879,"context_line":"    volume.reimage(args.image_id, args.reimage_reserved)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dd5b8294_58ea0e4e","line":2877,"range":{"start_line":2877,"start_character":7,"end_line":2877,"end_character":49},"in_reply_to":"8a32fb04_c41d11f3","updated":"2022-02-24 17:41:54.000000000","message":"Done","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"}],"cinderclient/v3/volumes.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0125a13b3891be7ed90b8fa32832316f8574f3b1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        :param volume: Volume to reimage."},{"line_number":295,"context_line":"        :param force: Boolean to enables or disables upload of a volume that"},{"line_number":296,"context_line":"                      is attached to an instance."},{"line_number":297,"context_line":"        :param image_name: The new image name."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":300,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_619f2151","line":297,"range":{"start_line":297,"start_character":15,"end_line":297,"end_character":25},"updated":"2018-10-11 09:08:13.000000000","message":"typo: image_id","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cfd045da516480ed0af103fd688c306f5c5860f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        :param volume: Volume to reimage."},{"line_number":295,"context_line":"        :param force: Boolean to enables or disables upload of a volume that"},{"line_number":296,"context_line":"                      is attached to an instance."},{"line_number":297,"context_line":"        :param image_name: The new image name."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":300,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8ca03438","line":297,"range":{"start_line":297,"start_character":15,"end_line":297,"end_character":25},"in_reply_to":"3f79a3b5_619f2151","updated":"2018-10-15 08:54:04.000000000","message":"Done","commit_id":"7a5677452202da7887579bbc24e2ad3db3faa858"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"285795a81e7c262c92a47a7db7e5471f26c40f8c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":300,"context_line":"                            volume,"},{"line_number":301,"context_line":"                            {\u0027image_id\u0027: image_id,"},{"line_number":302,"context_line":"                             \u0027ignore_in_use\u0027: ignore_in_use})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_07bf7279","line":302,"range":{"start_line":302,"start_character":30,"end_line":302,"end_character":43},"updated":"2018-12-05 03:19:31.000000000","message":"ditto","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37bae8604f4c60c0ad9d955f23b4db10e2fbd581","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":300,"context_line":"                            volume,"},{"line_number":301,"context_line":"                            {\u0027image_id\u0027: image_id,"},{"line_number":302,"context_line":"                             \u0027ignore_in_use\u0027: ignore_in_use})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f93504d4","line":302,"range":{"start_line":302,"start_character":30,"end_line":302,"end_character":43},"in_reply_to":"3f79a3b5_07bf7279","updated":"2018-12-07 05:30:43.000000000","message":"Done","commit_id":"47f70afaa40ef196acd04c4758def3e5c676fced"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7e589212b1b8ffbc10ffbf84dd4734c1e78d74c0","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        :param reimage_reserved: Boolean to enable or disable reimage"},{"line_number":299,"context_line":"            of a volume that is in \u0027reserved\u0027 state otherwise only"},{"line_number":300,"context_line":"            volumes in \u0027available\u0027 status may be re-imaged."},{"line_number":301,"context_line":"        :param image_id: The new image id."},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":304,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":13,"id":"6ef4c196_a1ebd5e1","line":301,"range":{"start_line":301,"start_character":29,"end_line":301,"end_character":32},"updated":"2022-02-24 16:27:05.000000000","message":"Why \"new\"?","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ce6320fe99c8fff8888afa4fd98f999d994c336","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        :param reimage_reserved: Boolean to enable or disable reimage"},{"line_number":299,"context_line":"            of a volume that is in \u0027reserved\u0027 state otherwise only"},{"line_number":300,"context_line":"            volumes in \u0027available\u0027 status may be re-imaged."},{"line_number":301,"context_line":"        :param image_id: The new image id."},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":304,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":13,"id":"81fc5cff_467616da","line":301,"range":{"start_line":301,"start_character":29,"end_line":301,"end_character":32},"in_reply_to":"1ac74449_dbbff4da","updated":"2022-02-24 17:41:54.000000000","message":"Done","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b3951eb3e03867451215af6e88413d76d38e4a70","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        :param reimage_reserved: Boolean to enable or disable reimage"},{"line_number":299,"context_line":"            of a volume that is in \u0027reserved\u0027 state otherwise only"},{"line_number":300,"context_line":"            volumes in \u0027available\u0027 status may be re-imaged."},{"line_number":301,"context_line":"        :param image_id: The new image id."},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        return self._action(\u0027os-reimage\u0027,"},{"line_number":304,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac74449_dbbff4da","line":301,"range":{"start_line":301,"start_character":29,"end_line":301,"end_character":32},"in_reply_to":"6ef4c196_a1ebd5e1","updated":"2022-02-24 17:11:52.000000000","message":"Rajat: I think you can just delete the \u0027new\u0027 and the description still makes sense.","commit_id":"0e65ae7b71d58e2302f83819b657246cc48ecd0f"}],"releasenotes/notes/reimage-volume-fea3a1178662e65a.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99ab968bc6f001557c1b28e71c67edb0d0b1372d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``cinder reimage`` command and related python API binding has been"},{"line_number":5,"context_line":"    added which allows changing the image in a volume and then rebuild the"},{"line_number":6,"context_line":"    volume. This requires microversion 3.68 or greater."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ad5fd30b_7260f205","line":6,"range":{"start_line":5,"start_character":23,"end_line":6,"end_character":55},"updated":"2022-02-24 00:06:16.000000000","message":"\"a user to replace the current content of a specified volume with the data of a specified image supplied by the Image service (Glance).  (Note that this is a destructive action, that is, all data currently contained in the volume is destroyed when the volume is re-imaged.)  This feature requires Block Storage API microversion 3.68 or greater.\"","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e3f50ed95a728ab2ad46d6fd66f0055e8fa8b352","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``cinder reimage`` command and related python API binding has been"},{"line_number":5,"context_line":"    added which allows changing the image in a volume and then rebuild the"},{"line_number":6,"context_line":"    volume. This requires microversion 3.68 or greater."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df406245_0b7f761e","line":6,"range":{"start_line":5,"start_character":23,"end_line":6,"end_character":55},"in_reply_to":"ad5fd30b_7260f205","updated":"2022-02-24 10:43:22.000000000","message":"Done","commit_id":"76dd784a44a21bc3c351f3428015c3dd87f0b2fa"}]}