)]}'
{"cinderclient/api_versions.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cc6ae608b95c5e93d94a7d28994d72303ffc5565","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# key is a deprecated version and value is an alternative version."},{"line_number":30,"context_line":"DEPRECATED_VERSIONS \u003d {\"2\": \"3\"}"},{"line_number":31,"context_line":"DEPRECATED_VERSION \u003d \"2.0\""},{"line_number":32,"context_line":"MAX_VERSION \u003d \"3.52\""},{"line_number":33,"context_line":"MIN_VERSION \u003d \"3.0\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_bb28c085","line":30,"updated":"2019-03-26 16:11:09.000000000","message":"Not sure why 3 was added as deprecated here. That\u0027s not right, it should just be 2 now.","commit_id":"c3f43743fb2102c6b2277500462e3c6e6f803813"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8d93589b4942353798dd118c2bf4cc0a18cadfe0","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# key is a deprecated version and value is an alternative version."},{"line_number":30,"context_line":"DEPRECATED_VERSIONS \u003d {\"2\": \"3\"}"},{"line_number":31,"context_line":"DEPRECATED_VERSION \u003d \"2.0\""},{"line_number":32,"context_line":"MAX_VERSION \u003d \"3.52\""},{"line_number":33,"context_line":"MIN_VERSION \u003d \"3.0\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_1b447446","line":30,"in_reply_to":"5fc1f717_bb28c085","updated":"2019-03-26 16:12:29.000000000","message":"Oh, read too quickly and it\u0027s been too long since I did this. This is mapping the deprecated 2 to 3, not a list. So this is right.","commit_id":"c3f43743fb2102c6b2277500462e3c6e6f803813"}],"cinderclient/client.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c2dcd9b3b6c6330a7c0eabb114671a9296854245","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":80,"context_line":"              the server"},{"line_number":81,"context_line":"    \"\"\""},{"line_number":82,"context_line":"    min_version \u003d \"2.0\""},{"line_number":83,"context_line":"    current_version \u003d \"2.0\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    logger \u003d logging.getLogger(__name__)"},{"line_number":86,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_a46e62fd","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":27},"updated":"2019-03-26 15:31:17.000000000","message":"would be great if we can update these to 3.0","commit_id":"c3f43743fb2102c6b2277500462e3c6e6f803813"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f79bf1e4e2defe7cd16921653eb938bded23aeb6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":80,"context_line":"              the server"},{"line_number":81,"context_line":"    \"\"\""},{"line_number":82,"context_line":"    min_version \u003d \"2.0\""},{"line_number":83,"context_line":"    current_version \u003d \"2.0\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    logger \u003d logging.getLogger(__name__)"},{"line_number":86,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_d86832f6","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":27},"in_reply_to":"5fc1f717_78a1fef6","updated":"2019-03-26 16:07:58.000000000","message":"Agreed for server. could you also clarify why we have MIN_VERSION of client as 3.0 here[1]?\n[1] https://review.openstack.org/#/c/609439/2/cinderclient/api_versions.py@33","commit_id":"c3f43743fb2102c6b2277500462e3c6e6f803813"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a5fc32121ef254af4279656e17b739c692d34af4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":80,"context_line":"              the server"},{"line_number":81,"context_line":"    \"\"\""},{"line_number":82,"context_line":"    min_version \u003d \"2.0\""},{"line_number":83,"context_line":"    current_version \u003d \"2.0\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    logger \u003d logging.getLogger(__name__)"},{"line_number":86,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_78a1fef6","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":27},"in_reply_to":"5fc1f717_a46e62fd","updated":"2019-03-26 15:40:29.000000000","message":"current_version should probably be updated, by min_version is still accurate for v2.","commit_id":"c3f43743fb2102c6b2277500462e3c6e6f803813"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"dda36594236e87a3ed86bd0c4bd92b1ed6f42c93","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        vtype, args.project_id)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"def do_endpoints(cs, args):"},{"line_number":927,"context_line":"    \"\"\"Discovers endpoints registered by authentication service.\"\"\""},{"line_number":928,"context_line":"    warnings.warn("},{"line_number":929,"context_line":"        \"``cinder endpoints`` is deprecated, use ``openstack catalog list`` \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_8ba732a8","side":"PARENT","line":926,"updated":"2019-04-02 16:25:14.000000000","message":"Please, remove cinderclient.tests.functional.test_readonly_cli.CinderClientReadOnlyTests.test_endpoints too","commit_id":"bfcda5000e01716b9c0eef206a893e45fc8d8be5"}]}