)]}'
{"id":"openstack%2Fpython-cinderclient~613660","triplet_id":"openstack%2Fpython-cinderclient~master~I56cb20a7c8885c101826d4fe28c315de02b6ecb8","project":"openstack/python-cinderclient","branch":"master","topic":"noqa","hashtags":[],"change_id":"I56cb20a7c8885c101826d4fe28c315de02b6ecb8","subject":"Fix incorrect use of flake8:noqa","status":"MERGED","created":"2018-10-26 18:29:29.000000000","updated":"2018-10-30 15:12:53.000000000","submitted":"2018-10-30 15:12:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"613660-1540912373973-62f707ab","meta_rev_id":"b1eb0cf0be4f4aa670a4d1a42dd4e2535e5caf6e","_number":613660,"virtual_id_number":613660,"owner":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-10-30 13:19:26.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2018-10-30 15:12:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-10-30 13:35:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":2,"date":"2018-10-26 18:44:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-10-30 13:35:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-26 18:44:56.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2018-10-30 13:35:24.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2018-10-30 15:12:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2df3dfa3b2d0c0e67e6fb7fab3bc5d0b097f6af0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-10-26 18:29:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f1cf4288293126397d85a0f77bace9366a0c91b6","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2018-10-26 18:44:56.000000000","message":"Patch Set 1: Code-Review+2\n\nGood catch.  Looks good to me.  Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"a56c27666856cf36abe11d964a3493d50e6c563d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-27 01:07:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/60/613660/1/check/tempest-full/ceabb04/ : SUCCESS in 1h 35m 27s\n- tempest-full-py3 http://logs.openstack.org/60/613660/1/check/tempest-full-py3/6c59755/ : SUCCESS in 1h 43m 49s\n- openstack-tox-cover http://logs.openstack.org/60/613660/1/check/openstack-tox-cover/1d2db67/cover/ : SUCCESS in 3m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/60/613660/1/check/openstack-tox-lower-constraints/7b53833/ : SUCCESS in 3m 50s\n- openstack-tox-pep8 http://logs.openstack.org/60/613660/1/check/openstack-tox-pep8/1aa692f/ : SUCCESS in 3m 41s\n- openstack-tox-py27 http://logs.openstack.org/60/613660/1/check/openstack-tox-py27/ae8d28d/ : SUCCESS in 3m 38s\n- openstack-tox-py35 http://logs.openstack.org/60/613660/1/check/openstack-tox-py35/165c7c0/ : SUCCESS in 3m 28s\n- openstack-tox-py36 http://logs.openstack.org/60/613660/1/check/openstack-tox-py36/4748111/ : SUCCESS in 3m 11s\n- openstack-tox-docs http://logs.openstack.org/60/613660/1/check/openstack-tox-docs/13506ba/html/ : SUCCESS in 3m 12s\n- cinderclient-dsvm-functional http://logs.openstack.org/60/613660/1/check/cinderclient-dsvm-functional/b57e7c8/ : SUCCESS in 24m 27s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/60/613660/1/check/cinderclient-dsvm-functional-identity-v3-only/3664207/ : FAILURE in 32m 32s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/60/613660/1/check/openstack-tox-pylint/5346a25/ : FAILURE in 5m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"34d6ce12a87db1a3b4013b6507a86b91f30f3c48","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2018-10-30 12:43:53.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nopenstack-tox-pylint is still failing.  looks like # noqa is ignored","accounts_in_message":[],"_revision_number":1},{"id":"347b0ede24734f81c6eec07f735c3aa2148a22a4","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-10-30 13:19:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b234b162ef77f33636ee82ddcb42fcbf94db8c73","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2018-10-30 13:35:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a378d54b826fbf1d2cf6dc19245db3e0536d8f09","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-30 13:36:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9598d21e6873baecdb3df529a9907984fe85429d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-30 15:12:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/60/613660/1/gate/tempest-full/07e3972/ : SUCCESS in 1h 28m 33s\n- tempest-full-py3 http://logs.openstack.org/60/613660/1/gate/tempest-full-py3/cc1b68c/ : SUCCESS in 1h 27m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/60/613660/1/gate/openstack-tox-lower-constraints/5c7318c/ : SUCCESS in 5m 03s\n- openstack-tox-pep8 http://logs.openstack.org/60/613660/1/gate/openstack-tox-pep8/8283a61/ : SUCCESS in 3m 15s\n- openstack-tox-py27 http://logs.openstack.org/60/613660/1/gate/openstack-tox-py27/3dafc0d/ : SUCCESS in 3m 14s\n- openstack-tox-py35 http://logs.openstack.org/60/613660/1/gate/openstack-tox-py35/073b0ca/ : SUCCESS in 3m 33s\n- openstack-tox-py36 http://logs.openstack.org/60/613660/1/gate/openstack-tox-py36/1e984d0/ : SUCCESS in 3m 04s\n- openstack-tox-docs http://logs.openstack.org/60/613660/1/gate/openstack-tox-docs/ce1d02a/html/ : SUCCESS in 3m 24s","accounts_in_message":[],"_revision_number":1},{"id":"7a336230da92a834c8c038885d298b80870cff06","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-30 15:12:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e26b64c1a397ed1c3c01c2ead7420c88cfd1c43a","revisions":{"e26b64c1a397ed1c3c01c2ead7420c88cfd1c43a":{"kind":"REWORK","_number":1,"created":"2018-10-26 18:29:29.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/60/613660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/60/613660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/60/613660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/60/613660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/60/613660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/60/613660/1"}}},"commit":{"parents":[{"commit":"3b954791e4ebbaa1ed0721a441698f9acb56c7d2","subject":"Don\u0027t quote {posargs} in tox.ini","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3b954791e4ebbaa1ed0721a441698f9acb56c7d2"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2018-10-26 18:26:29.000000000","tz":-300},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2018-10-26 18:26:29.000000000","tz":-300},"subject":"Fix incorrect use of flake8:noqa","message":"Fix incorrect use of flake8:noqa\n\nAdding the comment flake8:noqa in a file will skip linting the entire\nfile. Most of the time, the intent was just to skip individual lines to\nhandle exception cases.\n\nThis gets rid of the \"flake8:\" prefix where it was used incorrectly and\nfixes a few legitimate errors that were being hidden by the entire file\nbeing skipped.\n\nThe behavior is change in flake8 to handle this better, which will\nresult in pep8 job failures if these are not fixes first. See more\ninformation in the 3.6.0 release notes:\n\nhttp://flake8.pycqa.org/en/latest/release-notes/3.6.0.html#features\n\nChange-Id: I56cb20a7c8885c101826d4fe28c315de02b6ecb8\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e26b64c1a397ed1c3c01c2ead7420c88cfd1c43a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e26b64c1a397ed1c3c01c2ead7420c88cfd1c43a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}