)]}'
{"id":"openstack%2Fpython-cinderclient~615694","triplet_id":"openstack%2Fpython-cinderclient~master~I6f653f10249992196abb04e05c54df5fb244b182","project":"openstack/python-cinderclient","branch":"master","topic":"completion_cache-fipsfix","hashtags":[],"change_id":"I6f653f10249992196abb04e05c54df5fb244b182","subject":"Change cache uniqifier from using md5 to sha-1","status":"MERGED","created":"2018-11-05 23:56:43.000000000","updated":"2018-12-05 20:30:43.000000000","submitted":"2018-12-05 20:30:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"615694-1544041843719-03b03b2d","meta_rev_id":"dd1ae60c1101f75d5c99f751dd7c8c37d664a8aa","_number":615694,"virtual_id_number":615694,"owner":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2018-12-05 20:30:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2018-12-05 18:33:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"value":2,"date":"2018-12-05 15:54:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-12-05 18:14:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2018-12-05 18:33:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-12-05 15:54:13.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2018-12-05 18:14:08.000000000","updated_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"reviewer":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"state":"REVIEWER"},{"updated":"2018-12-05 18:33:23.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2018-12-05 20:30:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e012cf3c74c928e08ebdaaf7ccaa1544cbd380f1","author":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"date":"2018-11-05 23:56:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d1d077d3131cb51a8c0fcd3f17e29adc3aaa88c3","author":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"date":"2018-11-06 00:07:53.000000000","message":"Patch Set 1:\n\nI put SHA-1 here due to the length of output, but it might be worthwhile just to make the change to SHA256 now instead of likely needing modification over the next year or two when regulations catch up to SHA-1\u0027s known collisions. Thoughts?","accounts_in_message":[],"_revision_number":1},{"id":"84270eb1a329ca7bcf9125539496397a994d81d6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-06 01:38:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/94/615694/1/check/tempest-full/4061f1c/ : SUCCESS in 1h 34m 59s\n- tempest-full-py3 http://logs.openstack.org/94/615694/1/check/tempest-full-py3/c3946df/ : SUCCESS in 1h 25m 22s\n- openstack-tox-cover http://logs.openstack.org/94/615694/1/check/openstack-tox-cover/cb7cbe6/cover/ : SUCCESS in 4m 08s\n- openstack-tox-lower-constraints http://logs.openstack.org/94/615694/1/check/openstack-tox-lower-constraints/ed75eb1/ : SUCCESS in 3m 31s\n- openstack-tox-pep8 http://logs.openstack.org/94/615694/1/check/openstack-tox-pep8/4fa1405/ : SUCCESS in 2m 57s\n- openstack-tox-py27 http://logs.openstack.org/94/615694/1/check/openstack-tox-py27/66050dc/ : SUCCESS in 3m 32s\n- openstack-tox-py35 http://logs.openstack.org/94/615694/1/check/openstack-tox-py35/83ffb8e/ : SUCCESS in 3m 52s\n- openstack-tox-py36 http://logs.openstack.org/94/615694/1/check/openstack-tox-py36/d6709f9/ : SUCCESS in 4m 03s\n- openstack-tox-docs http://logs.openstack.org/94/615694/1/check/openstack-tox-docs/ccfbb89/html/ : SUCCESS in 3m 11s\n- cinderclient-dsvm-functional http://logs.openstack.org/94/615694/1/check/cinderclient-dsvm-functional/91c4f38/ : SUCCESS in 24m 22s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/94/615694/1/check/cinderclient-dsvm-functional-identity-v3-only/52a208b/ : FAILURE in 30m 38s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/94/615694/1/check/openstack-tox-pylint/1f7a197/ : SUCCESS in 5m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2f3d477c653fa5fd5f41bed66cbec7a437975da3","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-11-26 15:54:31.000000000","message":"Patch Set 1: Code-Review+2\n\nNot backwards compatible, but I think that\u0027s not an issue in this case. SHA1 should be fine. If/when things change, there will likely be more work to do anyway.","accounts_in_message":[],"_revision_number":1},{"id":"c860c163ad12460a79f7bd74f03e94d3fc09a64b","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2018-11-27 19:15:49.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nLooks good otherwise.  Also note the related patch:\n    https://review.openstack.org/#/c/612529/","accounts_in_message":[],"_revision_number":1},{"id":"b13daf6978e849c1505a35261e9c09308dbd30fd","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2018-12-05 15:54:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8cb6e62920037e294e64fe0767008103e46b7388","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2018-12-05 15:54:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7083a4721d83b4a129cc9c6b9869f1352d7a1f36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 17:57:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/94/615694/2/check/tempest-full/a8c3ea1/ : SUCCESS in 1h 53m 10s\n- tempest-full-py3 http://logs.openstack.org/94/615694/2/check/tempest-full-py3/1ab73d1/ : SUCCESS in 1h 31m 56s\n- openstack-tox-cover http://logs.openstack.org/94/615694/2/check/openstack-tox-cover/4a68aa3/cover/ : SUCCESS in 4m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/94/615694/2/check/openstack-tox-lower-constraints/35d55f6/ : SUCCESS in 7m 15s\n- openstack-tox-pep8 http://logs.openstack.org/94/615694/2/check/openstack-tox-pep8/11e9421/ : SUCCESS in 4m 31s\n- openstack-tox-py27 http://logs.openstack.org/94/615694/2/check/openstack-tox-py27/5256d31/ : SUCCESS in 4m 00s\n- openstack-tox-py35 http://logs.openstack.org/94/615694/2/check/openstack-tox-py35/37df68d/ : SUCCESS in 4m 07s\n- openstack-tox-py36 http://logs.openstack.org/94/615694/2/check/openstack-tox-py36/0a2bf02/ : SUCCESS in 3m 54s\n- openstack-tox-docs http://logs.openstack.org/94/615694/2/check/openstack-tox-docs/1c5c71b/html/ : SUCCESS in 3m 27s\n- cinderclient-dsvm-functional http://logs.openstack.org/94/615694/2/check/cinderclient-dsvm-functional/eeb8488/ : SUCCESS in 31m 49s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/94/615694/2/check/cinderclient-dsvm-functional-identity-v3-only/3a9d44f/ : FAILURE in 33m 33s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/94/615694/2/check/openstack-tox-pylint/b88590f/ : SUCCESS in 7m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c646d091d43327cd785ce8bb8a3211101426d9dc","author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"date":"2018-12-05 18:14:08.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, but someone else must approve.","accounts_in_message":[],"_revision_number":2},{"id":"87295719362ecdb501e9db801cdb9c1c6dd14cf2","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-12-05 18:33:23.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"01abfe700bd4f63899c4d30107f57cc6a0ad1162","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 18:34:59.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c024b7b3485f81c2f22e07d99ceee1cb97db6147","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 20:30:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/94/615694/2/gate/tempest-full/a259db0/ : SUCCESS in 1h 47m 23s\n- tempest-full-py3 http://logs.openstack.org/94/615694/2/gate/tempest-full-py3/6d5cdd7/ : SUCCESS in 1h 45m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/94/615694/2/gate/openstack-tox-lower-constraints/3913942/ : SUCCESS in 4m 33s\n- openstack-tox-pep8 http://logs.openstack.org/94/615694/2/gate/openstack-tox-pep8/1576bb5/ : SUCCESS in 4m 19s\n- openstack-tox-py27 http://logs.openstack.org/94/615694/2/gate/openstack-tox-py27/9ff1bd9/ : SUCCESS in 3m 48s\n- openstack-tox-py35 http://logs.openstack.org/94/615694/2/gate/openstack-tox-py35/c9d4584/ : SUCCESS in 4m 55s\n- openstack-tox-py36 http://logs.openstack.org/94/615694/2/gate/openstack-tox-py36/78f286a/ : SUCCESS in 3m 54s\n- openstack-tox-docs http://logs.openstack.org/94/615694/2/gate/openstack-tox-docs/bd219b1/html/ : SUCCESS in 4m 02s","accounts_in_message":[],"_revision_number":2},{"id":"f7bde995d5cebe1d3589325feb00f48586cd1a20","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 20:30:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4cf62cf31f3fcc0d00ce4daa291be6003ab331ed","revisions":{"1a8b3811c54e2ffcf34bc28dde10761bcab4f66b":{"kind":"REWORK","_number":1,"created":"2018-11-05 23:56:43.000000000","uploader":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"ref":"refs/changes/94/615694/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/94/615694/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/1"}}},"commit":{"parents":[{"commit":"e26b64c1a397ed1c3c01c2ead7420c88cfd1c43a","subject":"Fix incorrect use of flake8:noqa","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e26b64c1a397ed1c3c01c2ead7420c88cfd1c43a"}]}],"author":{"name":"Joshua Cornutt","email":"jcornutt@gmail.com","date":"2018-11-05 23:53:02.000000000","tz":-300},"committer":{"name":"Joshua Cornutt","email":"jcornutt@gmail.com","date":"2018-11-05 23:56:42.000000000","tz":-300},"subject":"Change cache uniqifier from using md5 to sha-1","message":"Change cache uniqifier from using md5 to sha-1\n\nFIPS 140-2 does not allow MD5 use for most purposes and systems\nin \"FIPS mode\" (fips\u003d1 kernel flag) will cause software using\nMD5 from popular libraries to fail.\n\nChange-Id: I6f653f10249992196abb04e05c54df5fb244b182\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1a8b3811c54e2ffcf34bc28dde10761bcab4f66b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1a8b3811c54e2ffcf34bc28dde10761bcab4f66b"}]},"branch":"refs/heads/master"},"4cf62cf31f3fcc0d00ce4daa291be6003ab331ed":{"kind":"REWORK","_number":2,"created":"2018-12-05 15:54:01.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/94/615694/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/94/615694/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/94/615694/2"}}},"commit":{"parents":[{"commit":"7cb50b4c4a05494650da334de346345af0bfb953","subject":"Merge \"Change openstack-dev to openstack-discuss\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7cb50b4c4a05494650da334de346345af0bfb953"}]}],"author":{"name":"Joshua Cornutt","email":"jcornutt@gmail.com","date":"2018-11-05 23:53:02.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2018-12-05 15:51:42.000000000","tz":-300},"subject":"Change cache uniqifier from using md5 to sha-1","message":"Change cache uniqifier from using md5 to sha-1\n\nFIPS 140-2 does not allow MD5 use for most purposes and systems\nin \"FIPS mode\" (fips\u003d1 kernel flag) will cause software using\nMD5 from popular libraries to fail.\n\nAlso change the default cache dir to use ~/.cache/\n\nChange-Id: I6f653f10249992196abb04e05c54df5fb244b182\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4cf62cf31f3fcc0d00ce4daa291be6003ab331ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4cf62cf31f3fcc0d00ce4daa291be6003ab331ed"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}