)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"70b0e279500d289c38986a8353d7cdb55ec21287","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"def do_group_list(cs, args):"},{"line_number":1306,"context_line":"    \"\"\"Lists all groups.\"\"\""},{"line_number":1307,"context_line":"    if args.all_tenants is not None:"},{"line_number":1308,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: args.all_tenants}"},{"line_number":1309,"context_line":"    else:"},{"line_number":1310,"context_line":"        search_opts \u003d {}"},{"line_number":1311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_8123ef55","line":1308,"range":{"start_line":1308,"start_character":8,"end_line":1308,"end_character":55},"updated":"2019-02-15 15:09:44.000000000","message":"You can just always use this definition of search_opts like some other methods do.  Since the value is passed in as None when it isn\u0027t requested, the search_opt isn\u0027t applied.","commit_id":"6db0b92ad5e2d1d5d358e9f26025019d3ccebc1d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3bc54190689ee3aff2fc32e38804c1bba60eece9","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"def do_group_list(cs, args):"},{"line_number":1306,"context_line":"    \"\"\"Lists all groups.\"\"\""},{"line_number":1307,"context_line":"    if args.all_tenants is not None:"},{"line_number":1308,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: args.all_tenants}"},{"line_number":1309,"context_line":"    else:"},{"line_number":1310,"context_line":"        search_opts \u003d {}"},{"line_number":1311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_ab67db24","line":1308,"range":{"start_line":1308,"start_character":8,"end_line":1308,"end_character":55},"in_reply_to":"9fdfeff1_8123ef55","updated":"2019-02-17 19:20:59.000000000","message":"Oh, i missed that None values were being processed in groups.py file.\nDone","commit_id":"6db0b92ad5e2d1d5d358e9f26025019d3ccebc1d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3a765a3dbbdb3eca02661bfe5ce782f306c3a8ef","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":1292,"context_line":"           type\u003dint,"},{"line_number":1293,"context_line":"           const\u003d1,"},{"line_number":1294,"context_line":"           default\u003dutils.env(\u0027ALL_TENANTS\u0027, default\u003dNone),"},{"line_number":1295,"context_line":"           help\u003d\u0027Shows details for all tenants. Admin only.\u0027)"},{"line_number":1296,"context_line":"@utils.arg(\u0027--filters\u0027,"},{"line_number":1297,"context_line":"           type\u003dsix.text_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_39e7c1ae","line":1294,"updated":"2019-02-18 02:20:11.000000000","message":"I don\u0027t think default should be set to None.  It should be 0.  If you take a look of other \"do_xx_list\" function in this file, default of all_tenants is set to 0.\n\nI think we may need to make a change like this:\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L370\n\nBy the way, do_group_snapshot_list probably have the same issue as do_group_list.","commit_id":"2731092a77cfa74d47cceffae4138a81b4fca2d7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dcc3e68db52e7d722bd6ed8a5733357f472bb406","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":1292,"context_line":"           type\u003dint,"},{"line_number":1293,"context_line":"           const\u003d1,"},{"line_number":1294,"context_line":"           default\u003dutils.env(\u0027ALL_TENANTS\u0027, default\u003dNone),"},{"line_number":1295,"context_line":"           help\u003d\u0027Shows details for all tenants. Admin only.\u0027)"},{"line_number":1296,"context_line":"@utils.arg(\u0027--filters\u0027,"},{"line_number":1297,"context_line":"           type\u003dsix.text_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_b46098d0","line":1294,"in_reply_to":"9fdfeff1_39e7c1ae","updated":"2019-02-18 03:16:15.000000000","message":"The current implementation of the client discards all boolean parameters set to 0, this decision shouldn\u0027t be done by the client as the user may willingly pass the parameter as 0.\nThis needs to be corrected for other commands as well.","commit_id":"2731092a77cfa74d47cceffae4138a81b4fca2d7"}]}