)]}'
{"id":"openstack%2Fpython-cinderclient~627359","triplet_id":"openstack%2Fpython-cinderclient~master~Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1808621","hashtags":[],"change_id":"Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0","subject":"Fix: cinder group-list not working with non-admin user","status":"MERGED","created":"2018-12-26 07:37:48.000000000","updated":"2019-02-25 23:09:27.000000000","submitted":"2019-02-25 23:09:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"627359-1551136167970-6cf9cfd8","meta_rev_id":"16a4278988bda93d1cf25e906859164fe02e8489","_number":627359,"virtual_id_number":627359,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2019-02-25 23:09:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-02-25 21:31:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":1,"date":"2019-02-20 04:13:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":2,"date":"2019-02-19 15:51:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2019-02-25 21:31:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-13 16:38:11.000000000","updated_by":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"reviewer":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"state":"REVIEWER"},{"updated":"2019-02-13 16:43:40.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-02-19 15:51:08.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-02-20 04:13:16.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2019-02-25 21:31:10.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-02-25 23:09:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d677be0551028b7375fbeb220f635c9df7ded488","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-12-26 07:37:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"373140a5455510193bcc7cc5e3c7183f119d1b45","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-12-26 07:48:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cb5e5816252414e833af0346ffbad394cdf04403","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-26 09:23:08.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full http://logs.openstack.org/59/627359/2/check/tempest-full/912bd86/ : SUCCESS in 1h 28m 51s\n- tempest-full-py3 http://logs.openstack.org/59/627359/2/check/tempest-full-py3/f666801/ : SUCCESS in 1h 15m 39s\n- openstack-tox-cover http://logs.openstack.org/59/627359/2/check/openstack-tox-cover/7873334/ : FAILURE in 2m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/2/check/openstack-tox-lower-constraints/7045d61/ : FAILURE in 2m 52s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/2/check/openstack-tox-pep8/9186534/ : SUCCESS in 2m 27s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/2/check/openstack-tox-py27/41b1df4/ : FAILURE in 2m 33s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/2/check/openstack-tox-py35/ba11b96/ : FAILURE in 2m 30s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/2/check/openstack-tox-py36/ec0b0ab/ : FAILURE in 2m 35s\n- openstack-tox-docs http://logs.openstack.org/59/627359/2/check/openstack-tox-docs/2cba7f0/html/ : SUCCESS in 2m 08s\n- cinderclient-dsvm-functional http://logs.openstack.org/59/627359/2/check/cinderclient-dsvm-functional/b712492/ : FAILURE in 31m 46s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/59/627359/2/check/cinderclient-dsvm-functional-identity-v3-only/e7850d4/ : SUCCESS in 32m 06s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/59/627359/2/check/openstack-tox-pylint/ed78257/ : SUCCESS in 5m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7a681e8b0aa48652605dea7cdb7fe6b2c635c51f","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-12-26 10:15:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e739b1e93a7ef9fb9db329841c498b2a55df1fa0","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2018-12-26 10:18:05.000000000","message":"Patch Set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"c27200e02471b2a02bdd6192676199e5f8918634","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-26 11:39:16.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/59/627359/4/check/tempest-full/7aed11c/ : SUCCESS in 1h 18m 52s\n- tempest-full-py3 http://logs.openstack.org/59/627359/4/check/tempest-full-py3/894a3e8/ : SUCCESS in 1h 15m 53s\n- openstack-tox-cover http://logs.openstack.org/59/627359/4/check/openstack-tox-cover/f5aff48/cover/ : SUCCESS in 2m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/4/check/openstack-tox-lower-constraints/d3f192c/ : SUCCESS in 3m 02s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/4/check/openstack-tox-pep8/7524b17/ : SUCCESS in 2m 38s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/4/check/openstack-tox-py27/4106997/ : SUCCESS in 2m 38s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/4/check/openstack-tox-py35/fffe322/ : SUCCESS in 3m 04s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/4/check/openstack-tox-py36/bc3c3b8/ : SUCCESS in 2m 51s\n- openstack-tox-docs http://logs.openstack.org/59/627359/4/check/openstack-tox-docs/159a3f9/html/ : SUCCESS in 2m 28s\n- cinderclient-dsvm-functional http://logs.openstack.org/59/627359/4/check/cinderclient-dsvm-functional/1e54dd3/ : SUCCESS in 24m 36s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/59/627359/4/check/cinderclient-dsvm-functional-identity-v3-only/d015138/ : SUCCESS in 24m 24s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/59/627359/4/check/openstack-tox-pylint/66f64c1/ : SUCCESS in 4m 29s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"342f38a32feb651604bec8e5dd2532cfae078a10","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-02-06 20:47:04.000000000","message":"Patch Set 4: Code-Review+2\n\nLooks like a good change.","accounts_in_message":[],"_revision_number":4},{"id":"9975e11b3c31d1443813a2eaa405f3fd74e6a3fb","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-02-13 15:09:09.000000000","message":"Patch Set 4: Code-Review-1\n\nI\u0027m not sure this change produces the correct behavior.  It\u0027s good that it makes \"cinder group-list\" work, but it also removes the all-tenants arg when running \"cinder group-list --all-tenants 0\".  Shouldn\u0027t that one still add the parameter and fail if the server does not allow that parameter?\n\nMaybe the policy of rejecting \"all_tenants\u003d0\" on the server side is just incorrect?","accounts_in_message":[],"_revision_number":4},{"id":"a711c179935afabb0acd2fe38b682b1054657bf5","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-13 16:00:14.000000000","message":"Patch Set 4:\n\n\u003e I\u0027m not sure this change produces the correct behavior.  It\u0027s good\n \u003e that it makes \"cinder group-list\" work, but it also removes the\n \u003e all-tenants arg when running \"cinder group-list --all-tenants 0\". \n \u003e Shouldn\u0027t that one still add the parameter and fail if the server\n \u003e does not allow that parameter?\n \u003e \n \u003e Maybe the policy of rejecting \"all_tenants\u003d0\" on the server side is\n \u003e just incorrect?\n\nHi Eric,\nThe server doesn\u0027t has a specific check for all_tenants with respect to admin and non-admin, it just checks the filters with respect to resources.\nIf the user is admin, it allows all filters[1], when it\u0027s a non-admin it checks it against the resource_filters file [2] [3].\nRejection on server side is a general message and not specific for non-admins requesting all-tenants list.\nAlso the same approach of building url is followed in other resources (volumes, snapshots, attachments) listing.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/common.py#L410\n[2] https://github.com/openstack/cinder/blob/master/cinder/api/common.py#L420\n[3] https://github.com/openstack/cinder/blob/master/etc/cinder/resource_filters.json","accounts_in_message":[],"_revision_number":4},{"id":"6bc3d1f9d69133c40cba666857dd441e81e92aef","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-02-13 16:43:40.000000000","message":"Patch Set 4: -Code-Review\n\nRemoving my +2 as it appears there is more discussion required.","accounts_in_message":[],"_revision_number":4},{"id":"5f59e5dac46785abd380dce64ba8ceaad8da21b6","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-13 19:10:01.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"e6f07c17203cadcfaf4f56e5db3f9f51b0325522","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-13 21:11:27.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/59/627359/5/check/tempest-full/3bd21b5/ : SUCCESS in 1h 55m 40s\n- tempest-full-py3 http://logs.openstack.org/59/627359/5/check/tempest-full-py3/a539b04/ : SUCCESS in 1h 49m 05s\n- openstack-tox-cover http://logs.openstack.org/59/627359/5/check/openstack-tox-cover/c7466cb/cover/ : SUCCESS in 4m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/5/check/openstack-tox-lower-constraints/ce10c81/ : SUCCESS in 4m 53s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/5/check/openstack-tox-pep8/ac8a16a/ : SUCCESS in 4m 31s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/5/check/openstack-tox-py27/59f1e9d/ : SUCCESS in 3m 40s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/5/check/openstack-tox-py35/7ca9162/ : SUCCESS in 4m 00s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/5/check/openstack-tox-py36/d9bf67e/ : SUCCESS in 4m 11s\n- openstack-tox-docs http://logs.openstack.org/59/627359/5/check/openstack-tox-docs/e885c78/html/ : SUCCESS in 3m 01s\n- cinderclient-dsvm-functional http://logs.openstack.org/59/627359/5/check/cinderclient-dsvm-functional/c805dbb/ : FAILURE in 29m 18s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/59/627359/5/check/openstack-tox-pylint/355fb83/ : SUCCESS in 5m 44s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"70b0e279500d289c38986a8353d7cdb55ec21287","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-02-15 15:09:44.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"1087cad69e5b91c0d72e976fbf24564814344e13","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-17 19:19:42.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"3bc54190689ee3aff2fc32e38804c1bba60eece9","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-17 19:20:59.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nThanks for the review Eric.","accounts_in_message":[],"_revision_number":5},{"id":"6c1965ad9afaa1d115c3eb9335e73bc2f1046787","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-17 20:58:48.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/59/627359/6/check/tempest-full/655fb8d/ : SUCCESS in 1h 33m 28s\n- tempest-full-py3 http://logs.openstack.org/59/627359/6/check/tempest-full-py3/990e2df/ : SUCCESS in 1h 23m 58s\n- openstack-tox-cover http://logs.openstack.org/59/627359/6/check/openstack-tox-cover/79c83cb/cover/ : SUCCESS in 3m 15s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/6/check/openstack-tox-lower-constraints/26f36a7/ : SUCCESS in 2m 53s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/6/check/openstack-tox-pep8/1139f20/ : SUCCESS in 3m 04s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/6/check/openstack-tox-py27/7b6a6f8/ : SUCCESS in 2m 43s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/6/check/openstack-tox-py35/572dcd9/ : SUCCESS in 2m 52s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/6/check/openstack-tox-py36/f191f63/ : SUCCESS in 2m 28s\n- openstack-tox-docs http://logs.openstack.org/59/627359/6/check/openstack-tox-docs/18f67f4/html/ : SUCCESS in 2m 39s\n- cinderclient-dsvm-functional http://logs.openstack.org/59/627359/6/check/cinderclient-dsvm-functional/41d1157/ : SUCCESS in 28m 38s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/59/627359/6/check/openstack-tox-pylint/4f72ccc/ : SUCCESS in 5m 19s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"3a765a3dbbdb3eca02661bfe5ce782f306c3a8ef","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2019-02-18 02:20:11.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)\n\nPlease see my comments.  Thanks.","accounts_in_message":[],"_revision_number":6},{"id":"dcc3e68db52e7d722bd6ed8a5733357f472bb406","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-18 03:16:15.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nHi Xing,\nThanks for the review.\nThis functionality was thoroughly discussed with Eric and Sean at the cinder channel[1] and cinder meeting [2].\nYou can check previous patchsets and reviews that implement the solution you proposed but was termed as a bug in the client.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2019-02-13.log.html#t2019-02-13T16:01:58\n[2] http://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2019-02-13.log.html#t2019-02-13T16:31:03","accounts_in_message":[],"_revision_number":6},{"id":"1fbcf23d8960bbb6580755966c6b79e1b40e0d5e","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2019-02-18 03:38:52.000000000","message":"Patch Set 6:\n\nCan this be fixed?  Can we differentiate between a 0 value vs val is not set? \n https://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L143-L145","accounts_in_message":[],"_revision_number":6},{"id":"bfabc0ca046aac854c7ca1b8ea5e9de6fa420b75","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-18 03:44:53.000000000","message":"Patch Set 6:\n\n\u003e Can this be fixed?  Can we differentiate between a 0 value vs val\n \u003e is not set?\n \u003e https://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L143-L145\n\nWe\u0027re currently avoiding the use of _build_list_url function (as used in my previous solution proposed) and using build_query_param [1] instead.\n\n[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/utils.py#L217-L218","accounts_in_message":[],"_revision_number":6},{"id":"311f30b5c48bb2d6c97dd2001b04e7bcd806d513","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-18 05:03:06.000000000","message":"Patch Set 7: Published edit on patch set 6.","accounts_in_message":[],"_revision_number":7},{"id":"e2817190cb677eabbf2f24cd0c212cfb56d16ba2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-18 06:45:23.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full http://logs.openstack.org/59/627359/7/check/tempest-full/28b70f5/ : SUCCESS in 1h 35m 57s\n- tempest-full-py3 http://logs.openstack.org/59/627359/7/check/tempest-full-py3/194796c/ : SUCCESS in 1h 17m 47s\n- openstack-tox-cover http://logs.openstack.org/59/627359/7/check/openstack-tox-cover/01557f7/ : FAILURE in 3m 12s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/7/check/openstack-tox-lower-constraints/efa6873/ : FAILURE in 2m 49s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/7/check/openstack-tox-pep8/93b6dfb/ : SUCCESS in 2m 35s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/7/check/openstack-tox-py27/3962c96/ : FAILURE in 2m 22s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/7/check/openstack-tox-py35/837141c/ : FAILURE in 2m 49s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/7/check/openstack-tox-py36/7de2181/ : FAILURE in 2m 20s\n- openstack-tox-docs http://logs.openstack.org/59/627359/7/check/openstack-tox-docs/0abbafd/html/ : SUCCESS in 2m 08s\n- cinderclient-dsvm-functional http://logs.openstack.org/59/627359/7/check/cinderclient-dsvm-functional/13b0ec8/ : SUCCESS in 22m 48s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/59/627359/7/check/openstack-tox-pylint/63281c4/ : SUCCESS in 5m 03s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"772360152d82c219941f722cb2f9dc9c9f85c07b","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-18 09:04:51.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"cef9d0323c4d77038b10ae703ad14bcb4e735e74","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-18 10:48:47.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/59/627359/8/check/tempest-full/6b22ec6/ : SUCCESS in 1h 37m 33s\n- tempest-full-py3 http://logs.openstack.org/59/627359/8/check/tempest-full-py3/cdedbc5/ : SUCCESS in 1h 37m 31s\n- openstack-tox-cover http://logs.openstack.org/59/627359/8/check/openstack-tox-cover/ab44dc2/cover/ : SUCCESS in 3m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/8/check/openstack-tox-lower-constraints/b7ce07c/ : SUCCESS in 3m 39s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/8/check/openstack-tox-pep8/83c05d9/ : SUCCESS in 3m 17s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/8/check/openstack-tox-py27/5cb24d4/ : SUCCESS in 3m 43s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/8/check/openstack-tox-py35/6d2effb/ : SUCCESS in 3m 15s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/8/check/openstack-tox-py36/1ad104a/ : SUCCESS in 3m 27s\n- openstack-tox-docs http://logs.openstack.org/59/627359/8/check/openstack-tox-docs/e1ae33d/html/ : SUCCESS in 2m 55s\n- cinderclient-dsvm-functional http://logs.openstack.org/59/627359/8/check/cinderclient-dsvm-functional/02a2f52/ : SUCCESS in 26m 14s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/59/627359/8/check/openstack-tox-pylint/a3eaebb/ : SUCCESS in 5m 17s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"88a712853468994c59394ba6597d8b26da6599a8","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-02-19 15:51:08.000000000","message":"Patch Set 8: Code-Review+2","accounts_in_message":[],"_revision_number":8},{"id":"04029a0dbf229a2bd9e45ce0cbcc484b07bc9a65","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2019-02-20 04:13:16.000000000","message":"Patch Set 8: Code-Review+1","accounts_in_message":[],"_revision_number":8},{"id":"3c8290242e56b50b5ecc71948efc25663823e7a0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-02-25 20:16:12.000000000","message":"Patch Set 8:\n\nI\u0027m not sure I followed all of the discussion in IRC, but didn\u0027t we decide this should be fixed on the service side and not be a client side workaround?","accounts_in_message":[],"_revision_number":8},{"id":"7a115e34ae4a89c0a64bf730aeda106dfb577737","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-02-25 21:25:16.000000000","message":"Patch Set 8:\n\nWe should fix the server as well, but the client shouldn\u0027t send this parameter when it isn\u0027t requested.  (Which is what this patch fixes.)","accounts_in_message":[],"_revision_number":8},{"id":"00e6bdd99378ff48f8dd01d113b3d92d76e40d6e","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-02-25 21:31:10.000000000","message":"Patch Set 8: Code-Review+2 Workflow+1\n\nOK, that sounds like a good plan.","accounts_in_message":[],"_revision_number":8},{"id":"f2dad5c9f369eac5416673a9227c75b1e7b74c1a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 21:31:23.000000000","message":"Patch Set 8: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":8},{"id":"402c0e2863f52539a77de0e8f35e339e76f5aeac","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 23:09:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":8},{"id":"4ea18b85ec813488df313a426a124a5fc2e8575f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 23:09:27.000000000","message":"Patch Set 8: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/59/627359/8/gate/tempest-full/90cc1e0/ : SUCCESS in 1h 28m 58s\n- tempest-full-py3 http://logs.openstack.org/59/627359/8/gate/tempest-full-py3/2942d3b/ : SUCCESS in 1h 31m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/627359/8/gate/openstack-tox-lower-constraints/90fe4ab/ : SUCCESS in 3m 51s\n- openstack-tox-pep8 http://logs.openstack.org/59/627359/8/gate/openstack-tox-pep8/67fb141/ : SUCCESS in 2m 58s\n- openstack-tox-py27 http://logs.openstack.org/59/627359/8/gate/openstack-tox-py27/6b055b2/ : SUCCESS in 2m 58s\n- openstack-tox-py35 http://logs.openstack.org/59/627359/8/gate/openstack-tox-py35/a5a7dbb/ : SUCCESS in 3m 24s\n- openstack-tox-py36 http://logs.openstack.org/59/627359/8/gate/openstack-tox-py36/59f28fe/ : SUCCESS in 2m 44s\n- openstack-tox-py37 http://logs.openstack.org/59/627359/8/gate/openstack-tox-py37/729d210/ : SUCCESS in 3m 38s\n- openstack-tox-docs http://logs.openstack.org/59/627359/8/gate/openstack-tox-docs/c21c047/html/ : SUCCESS in 2m 34s","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"532aef0c738edc937dbfa1b54efd8d7773af2204","revisions":{"274f2cf8d1177bafe99655981e8db9e22305a329":{"kind":"REWORK","_number":1,"created":"2018-12-26 07:37:48.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/1"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:37:44.000000000","tz":0},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenant parameter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThe \u0027_build_list_url\u0027 function (used in volumes and snapshots list)\nthat ignores the False/0 values from search_opts isn\u0027t used in group list.\nThis patch replaces the manual building of url in group list with\n\u0027_build_list_url\u0027 function.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/274f2cf8d1177bafe99655981e8db9e22305a329"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/274f2cf8d1177bafe99655981e8db9e22305a329"}]},"branch":"refs/heads/master"},"90c6412f4b9091b910c51e6f6393ff16bf7664fb":{"kind":"REWORK","_number":2,"created":"2018-12-26 07:48:36.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/2"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:48:17.000000000","tz":0},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenant parameter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThe \u0027_build_list_url\u0027 function (used in volumes and snapshots list)\nthat ignores the False/0 values from search_opts isn\u0027t used in group list.\nThis patch replaces the manual building of url in group list with\n\u0027_build_list_url\u0027 function.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/90c6412f4b9091b910c51e6f6393ff16bf7664fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/90c6412f4b9091b910c51e6f6393ff16bf7664fb"}]},"branch":"refs/heads/master"},"9822b2ea5fa3156a3b642a5e05025aa958b1a1a8":{"kind":"REWORK","_number":3,"created":"2018-12-26 10:15:17.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/3"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 10:15:02.000000000","tz":0},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenant parameter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThe \u0027_build_list_url\u0027 function (used in volumes and snapshots list)\nthat ignores the False/0 values from search_opts isn\u0027t used in group list.\nThis patch replaces the manual building of url in group list with\n\u0027_build_list_url\u0027 function.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9822b2ea5fa3156a3b642a5e05025aa958b1a1a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9822b2ea5fa3156a3b642a5e05025aa958b1a1a8"}]},"branch":"refs/heads/master"},"9ca88806658616f81da674b6e2f18586fb68d33f":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2018-12-26 10:18:05.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/4"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2018-12-26 10:17:31.000000000","tz":0},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenant parameter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThe \u0027_build_list_url\u0027 function (used in volumes and snapshots list)\nthat ignores the False/0 values from search_opts isn\u0027t used in group\nlist.\nThis patch replaces the manual building of url in group list with\n\u0027_build_list_url\u0027 function.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\nCloses-Bug: #1808622\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9ca88806658616f81da674b6e2f18586fb68d33f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9ca88806658616f81da674b6e2f18586fb68d33f"}]},"branch":"refs/heads/master"},"6db0b92ad5e2d1d5d358e9f26025019d3ccebc1d":{"kind":"REWORK","_number":5,"created":"2019-02-13 19:10:01.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/5"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-02-13 19:09:57.000000000","tz":330},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenants filter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThis patch only allows adding of all_tenants when specified\nmanually by user.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\nCloses-Bug: #1808622\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6db0b92ad5e2d1d5d358e9f26025019d3ccebc1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6db0b92ad5e2d1d5d358e9f26025019d3ccebc1d"}]},"branch":"refs/heads/master"},"2731092a77cfa74d47cceffae4138a81b4fca2d7":{"kind":"REWORK","_number":6,"created":"2019-02-17 19:19:42.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/6"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-02-17 19:19:26.000000000","tz":330},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenants filter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThis patch only allows adding of all_tenants when specified\nmanually by user.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\nCloses-Bug: #1808622\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2731092a77cfa74d47cceffae4138a81b4fca2d7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2731092a77cfa74d47cceffae4138a81b4fca2d7"}]},"branch":"refs/heads/master"},"d14f46cca9d43470cf903422fe4d16076714419b":{"kind":"REWORK","_number":7,"created":"2019-02-18 05:03:06.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/7"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2019-02-18 05:02:57.000000000","tz":0},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenants filter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThis patch only allows adding of all_tenants when specified\nmanually by user.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\nCloses-Bug: #1808622\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d14f46cca9d43470cf903422fe4d16076714419b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d14f46cca9d43470cf903422fe4d16076714419b"}]},"branch":"refs/heads/master"},"532aef0c738edc937dbfa1b54efd8d7773af2204":{"kind":"REWORK","_number":8,"created":"2019-02-18 09:04:51.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/59/627359/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/59/627359/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/59/627359/8"}}},"commit":{"parents":[{"commit":"3c143d95b3b270f77bf9fa55c16ae06505fe107c","subject":"Merge \"Re-enable shell UUID completion cache\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3c143d95b3b270f77bf9fa55c16ae06505fe107c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-02-18 09:04:35.000000000","tz":330},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenants filter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThis patch only allows adding of all_tenants when specified\nmanually by user.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\nCloses-Bug: #1808622\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/532aef0c738edc937dbfa1b54efd8d7773af2204"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/532aef0c738edc937dbfa1b54efd8d7773af2204"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}