)]}'
{"id":"openstack%2Fpython-cinderclient~634022","triplet_id":"openstack%2Fpython-cinderclient~master~I20f6c5471ffefe5524a4d48c967e2e8db53233f1","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1813967","hashtags":[],"change_id":"I20f6c5471ffefe5524a4d48c967e2e8db53233f1","subject":"Fix max version handling for help output","status":"MERGED","created":"2019-01-30 18:25:34.000000000","updated":"2019-05-21 09:11:12.000000000","submitted":"2019-02-06 16:05:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"634022-1549469139571-2fd0b8c4","meta_rev_id":"a084e1b8dedb7e14919498c5af3a5dc11ded197c","_number":634022,"virtual_id_number":634022,"owner":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-02-06 13:12:26.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":2,"date":"2019-02-06 16:05:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-02-05 20:29:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":2,"date":"2019-02-06 13:56:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":1,"date":"2019-02-06 13:56:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-05-21 09:11:12.000000000","post_submit":true,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-05 20:29:42.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-02-06 13:56:24.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2019-02-06 16:05:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-21 09:11:12.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"}],"messages":[{"id":"788d3ccf8fa96e27ecd42a1fb43be3ab9cc1daba","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-01-30 18:25:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e8cf65ba3b504b9b968b474d5dea4a1a01c10803","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-30 20:29:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full http://logs.openstack.org/22/634022/1/check/tempest-full/1aa1fdf/ : SUCCESS in 1h 56m 13s\n- tempest-full-py3 http://logs.openstack.org/22/634022/1/check/tempest-full-py3/1f41ce0/ : SUCCESS in 1h 39m 26s\n- openstack-tox-cover http://logs.openstack.org/22/634022/1/check/openstack-tox-cover/3c38fe3/cover/ : SUCCESS in 3m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/634022/1/check/openstack-tox-lower-constraints/f41a752/ : SUCCESS in 3m 44s\n- openstack-tox-pep8 http://logs.openstack.org/22/634022/1/check/openstack-tox-pep8/21c0f7e/ : FAILURE in 2m 53s\n- openstack-tox-py27 http://logs.openstack.org/22/634022/1/check/openstack-tox-py27/d1249a5/ : SUCCESS in 3m 37s\n- openstack-tox-py35 http://logs.openstack.org/22/634022/1/check/openstack-tox-py35/29e52e7/ : SUCCESS in 5m 01s\n- openstack-tox-py36 http://logs.openstack.org/22/634022/1/check/openstack-tox-py36/834de2d/ : SUCCESS in 3m 16s\n- openstack-tox-docs http://logs.openstack.org/22/634022/1/check/openstack-tox-docs/1e6a3cc/html/ : SUCCESS in 3m 18s\n- cinderclient-dsvm-functional http://logs.openstack.org/22/634022/1/check/cinderclient-dsvm-functional/116fb57/ : SUCCESS in 25m 22s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/22/634022/1/check/cinderclient-dsvm-functional-identity-v3-only/2d02877/ : SUCCESS in 29m 28s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/22/634022/1/check/openstack-tox-pylint/d0d5325/ : SUCCESS in 5m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"699d646329e6833fb8bb2b1c34b6242469e07ccc","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-01-31 01:00:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7659e5e18e3738cf3127ac808c6196c204b643d7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-31 02:42:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/22/634022/2/check/tempest-full/550f7be/ : SUCCESS in 1h 32m 27s\n- tempest-full-py3 http://logs.openstack.org/22/634022/2/check/tempest-full-py3/34a8dc1/ : SUCCESS in 1h 24m 59s\n- openstack-tox-cover http://logs.openstack.org/22/634022/2/check/openstack-tox-cover/2fce58f/cover/ : SUCCESS in 5m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/634022/2/check/openstack-tox-lower-constraints/13ab1e1/ : SUCCESS in 5m 04s\n- openstack-tox-pep8 http://logs.openstack.org/22/634022/2/check/openstack-tox-pep8/c7e4264/ : SUCCESS in 3m 46s\n- openstack-tox-py27 http://logs.openstack.org/22/634022/2/check/openstack-tox-py27/616a0b7/ : SUCCESS in 3m 16s\n- openstack-tox-py35 http://logs.openstack.org/22/634022/2/check/openstack-tox-py35/3e94704/ : SUCCESS in 3m 46s\n- openstack-tox-py36 http://logs.openstack.org/22/634022/2/check/openstack-tox-py36/dd1dd3a/ : SUCCESS in 3m 47s\n- openstack-tox-docs http://logs.openstack.org/22/634022/2/check/openstack-tox-docs/78ae6c3/html/ : SUCCESS in 3m 47s\n- cinderclient-dsvm-functional http://logs.openstack.org/22/634022/2/check/cinderclient-dsvm-functional/d235ac5/ : SUCCESS in 27m 05s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/22/634022/2/check/cinderclient-dsvm-functional-identity-v3-only/5694538/ : SUCCESS in 28m 08s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/22/634022/2/check/openstack-tox-pylint/3725959/ : SUCCESS in 5m 40s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"84e9327821e2ad2769eb13eefcbf19bfff6347a0","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-02-05 20:29:42.000000000","message":"Patch Set 2: Code-Review+2\n\nWe should get this merged.","accounts_in_message":[],"_revision_number":2},{"id":"2713ccf7f4d2855a462cd4cfcc8ea4d5eceec49e","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-06 13:01:04.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nHi Sean,\n\nCould you elaborate more on why we need to show the latest MV functionality in help.","accounts_in_message":[],"_revision_number":2},{"id":"f5f2b2fe20a83e7c39e1b1365822b21f237621af","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-02-06 13:12:26.000000000","message":"Patch Set 2:\n\nThis has been an ongoing issue that we planned on addressing several releases ago but never did.\n\nThe problem is that it is not obvious to an end user that there were commands available that were not being shown in the help output. This led to a lot of confusion. They would only see all options by setting the microversion environment variable or specifying it on the command line.\n\nSince the help output states what microversion is needed in the help text, it is considered better to show all possible options in the help output so they can discover that they can use a given microversion to use one of those commands. This matches the behavior in Nova as well.","accounts_in_message":[],"_revision_number":2},{"id":"ef25621bc14ececb93e5642ed6c686c392abfeb7","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-02-06 13:56:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n\u003e This has been an ongoing issue that we planned on addressing\n \u003e several releases ago but never did.\n \u003e \n \u003e The problem is that it is not obvious to an end user that there\n \u003e were commands available that were not being shown in the help\n \u003e output. This led to a lot of confusion. They would only see all\n \u003e options by setting the microversion environment variable or\n \u003e specifying it on the command line.\n \u003e \n \u003e Since the help output states what microversion is needed in the\n \u003e help text, it is considered better to show all possible options in\n \u003e the help output so they can discover that they can use a given\n \u003e microversion to use one of those commands. This matches the\n \u003e behavior in Nova as well.\n\nThanks for the usecase.\nLooks good and important to merge.","accounts_in_message":[],"_revision_number":2},{"id":"db51f3fca711eddb9ba290220bf72e1f9758a6e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-06 13:56:36.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ce2f2dc47e87f0d723a1d4a1bfc834568b415431","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-06 16:05:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"33677b66b040739cf0e2ab3032a496490a442af2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-06 16:05:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/22/634022/2/gate/tempest-full/38ad873/ : SUCCESS in 1h 53m 58s\n- tempest-full-py3 http://logs.openstack.org/22/634022/2/gate/tempest-full-py3/e131ad0/ : SUCCESS in 1h 36m 16s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/634022/2/gate/openstack-tox-lower-constraints/af77703/ : SUCCESS in 4m 58s\n- openstack-tox-pep8 http://logs.openstack.org/22/634022/2/gate/openstack-tox-pep8/e4c2e60/ : SUCCESS in 4m 04s\n- openstack-tox-py27 http://logs.openstack.org/22/634022/2/gate/openstack-tox-py27/21cbf0f/ : SUCCESS in 4m 45s\n- openstack-tox-py35 http://logs.openstack.org/22/634022/2/gate/openstack-tox-py35/94883f6/ : SUCCESS in 4m 36s\n- openstack-tox-py36 http://logs.openstack.org/22/634022/2/gate/openstack-tox-py36/c7b1de9/ : SUCCESS in 4m 02s\n- openstack-tox-docs http://logs.openstack.org/22/634022/2/gate/openstack-tox-docs/83855f9/html/ : SUCCESS in 3m 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bccbd510a77843824b8187e15c4d8df9c2dfa55e","revisions":{"9dcf2b61b807f09041f648492d2fc995185c3b6f":{"kind":"REWORK","_number":1,"created":"2019-01-30 18:25:34.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/22/634022/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/22/634022/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/1"}}},"commit":{"parents":[{"commit":"cca017218af8874b135a39958a4b1551abaf5830","subject":"Merge \"Remove i18n.enable_lazy() translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cca017218af8874b135a39958a4b1551abaf5830"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-01-30 18:20:26.000000000","tz":-360},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-01-30 18:20:26.000000000","tz":-360},"subject":"Fix max version handling for help output","message":"Fix max version handling for help output\n\nCommit fefe331f218d73ba6d1d7acf81b5eb02609c953e incorrectly set the\ndefault API version to the max the client knew about in order to get the\nfull help output, including all microversioned commands.\n\nThe original intent was to have help print out information for all\nversions, but still require the user to specify a version if they wanted\nto use any microversioned version of an API. The code accidentally made\nit so all commands would request the max version the client knew about.\nThis meant an unspecified request would get the newer functionality\nrather than the default v3 functionality, and also meant the client\ncould request a microversion higher than what the server knew about,\nresulting in an unexpected error being returned.\n\nTo keep the originally intended functionality, but keep all help output,\nthis only uses the max API version for the help command unless the user\nspecifies otherwise.\n\nCloses-bug: #1813967\n\nChange-Id: I20f6c5471ffefe5524a4d48c967e2e8db53233f1\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9dcf2b61b807f09041f648492d2fc995185c3b6f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9dcf2b61b807f09041f648492d2fc995185c3b6f"}]},"branch":"refs/heads/master"},"bccbd510a77843824b8187e15c4d8df9c2dfa55e":{"kind":"REWORK","_number":2,"created":"2019-01-31 01:00:57.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/22/634022/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/22/634022/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/22/634022/2"}}},"commit":{"parents":[{"commit":"cca017218af8874b135a39958a4b1551abaf5830","subject":"Merge \"Remove i18n.enable_lazy() translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cca017218af8874b135a39958a4b1551abaf5830"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-01-30 18:20:26.000000000","tz":-360},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-01-31 01:00:51.000000000","tz":-360},"subject":"Fix max version handling for help output","message":"Fix max version handling for help output\n\nCommit fefe331f218d73ba6d1d7acf81b5eb02609c953e incorrectly set the\ndefault API version to the max the client knew about in order to get the\nfull help output, including all microversioned commands.\n\nThe original intent was to have help print out information for all\nversions, but still require the user to specify a version if they wanted\nto use any microversioned version of an API. The code accidentally made\nit so all commands would request the max version the client knew about.\nThis meant an unspecified request would get the newer functionality\nrather than the default v3 functionality, and also meant the client\ncould request a microversion higher than what the server knew about,\nresulting in an unexpected error being returned.\n\nTo keep the originally intended functionality, but keep all help output,\nthis only uses the max API version for the help command unless the user\nspecifies otherwise.\n\nCloses-bug: #1813967\n\nChange-Id: I20f6c5471ffefe5524a4d48c967e2e8db53233f1\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/bccbd510a77843824b8187e15c4d8df9c2dfa55e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/bccbd510a77843824b8187e15c4d8df9c2dfa55e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}