)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc6fd69dffe7909e417f5fabeaaf23020bf593d5","unresolved":false,"context_lines":[{"line_number":522,"context_line":"           metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":523,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":524,"context_line":"           type\u003dint,"},{"line_number":525,"context_line":"           action\u003dCheckSizeArgForCreate,  # noqa"},{"line_number":526,"context_line":"           help\u003d\u0027Size of volume, in GiBs. (Required unless \u0027"},{"line_number":527,"context_line":"                \u0027snapshot-id/source-volid/backup-id is specified).\u0027)"},{"line_number":528,"context_line":"@utils.arg(\u0027--consisgroup-id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3bf5b2cb","line":525,"updated":"2019-11-12 19:31:45.000000000","message":"Would be better to just import this rather than #noqa it.","commit_id":"af0f8d4f008f395e432540a887fe105f363a69af"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cd5c4c9c7ef49ec6a0ff402f0e743e3340082d38","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from cinderclient import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from cinderclient.v2.shell import *  # noqa"},{"line_number":34,"context_line":"from cinderclient.v2.shell import CheckSizeArgForCreate"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"FILTER_DEPRECATED \u003d (\"This option is deprecated and will be removed in \""},{"line_number":37,"context_line":"                     \"newer release. Please use \u0027--filters\u0027 option which \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d61c73c3","line":34,"updated":"2019-10-30 15:55:15.000000000","message":"Shouldn\u0027t be importing classes, only modules. But I don\u0027t see why we would need to do this anyway since the previous line imports *.","commit_id":"e2436b310f294992857f22a6d52ede03e36b99b1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"018d5c36758a18b378b7dfbe1e0e7edff8859eae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from cinderclient import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from cinderclient.v2.shell import *  # noqa"},{"line_number":34,"context_line":"from cinderclient.v2.shell import CheckSizeArgForCreate"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"FILTER_DEPRECATED \u003d (\"This option is deprecated and will be removed in \""},{"line_number":37,"context_line":"                     \"newer release. Please use \u0027--filters\u0027 option which \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_02e23ba1","line":34,"in_reply_to":"3fa7e38b_226657bd","updated":"2019-11-12 20:12:40.000000000","message":"The tradeoff here is that it would be good to be able to use a more modern version of hacking to check new patches.  The line above is ugly, but I\u0027m willing to let it through for now.  Another option would be to turn off F405, but since this is apparently the only place it\u0027s finding a problem, I think that would be overkill.  We\u0027ll be refactoring this anyway when we stop supporting v2 in the client, which should be happening soon-ish.","commit_id":"e2436b310f294992857f22a6d52ede03e36b99b1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc6fd69dffe7909e417f5fabeaaf23020bf593d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from cinderclient import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from cinderclient.v2.shell import *  # noqa"},{"line_number":34,"context_line":"from cinderclient.v2.shell import CheckSizeArgForCreate"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"FILTER_DEPRECATED \u003d (\"This option is deprecated and will be removed in \""},{"line_number":37,"context_line":"                     \"newer release. Please use \u0027--filters\u0027 option which \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_226657bd","line":34,"in_reply_to":"3fa7e38b_d61c73c3","updated":"2019-11-12 19:31:45.000000000","message":"Because without it, you get:\n    ./cinderclient/v3/shell.py:542:19: F405 CheckSizeArgForCreate may be undefined, or defined from star imports: cinderclient.v2.shell\n           action\u003dCheckSizeArgForCreate,\n\nfrom \"tox -e pep8\".\n\nThis is the simplest way to get this to work without redoing the whole \"import *\" thing which is already messy and marked with \"# noqa\".","commit_id":"e2436b310f294992857f22a6d52ede03e36b99b1"}]}