)]}'
{"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fac0b23cfe895043972711e9f98965fb7e81c347","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def test_group_type_list_public_private(self):"},{"line_number":579,"context_line":"        self.run_command(\u0027--os-volume-api-version 3.52 group-type-list\u0027)"},{"line_number":580,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/group_types?is_public\u003dNone\u0027)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def test_group_type_show(self):"},{"line_number":583,"context_line":"        self.run_command(\u0027--os-volume-api-version 3.11 \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fce034c_7938933c","line":580,"range":{"start_line":580,"start_character":47,"end_line":580,"end_character":62},"updated":"2019-04-15 14:40:27.000000000","message":"This arg shouldn\u0027t be sent if the shell command didn\u0027t request an is_public filter.","commit_id":"6a498163e2b0cf1256743d84200a99f840dc9135"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0f5ad1bd724b6b035bbb653d10cfb58e2e4edcc8","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def test_group_type_list_public_private(self):"},{"line_number":579,"context_line":"        self.run_command(\u0027--os-volume-api-version 3.52 group-type-list\u0027)"},{"line_number":580,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/group_types?is_public\u003dNone\u0027)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def test_group_type_show(self):"},{"line_number":583,"context_line":"        self.run_command(\u0027--os-volume-api-version 3.11 \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fce034c_c0140051","line":580,"range":{"start_line":580,"start_character":47,"end_line":580,"end_character":62},"in_reply_to":"3fce034c_7938933c","updated":"2019-04-17 07:55:51.000000000","message":"This is done to preserve the default functionality of returning both public+private types\nwithout it, only public types will be returned","commit_id":"6a498163e2b0cf1256743d84200a99f840dc9135"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8c8be2463c3cb4282ae92af333d5319ffe5c4c5c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":61,"context_line":"@utils.arg(\u0027--is-public\u0027,"},{"line_number":62,"context_line":"           metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":63,"context_line":"           help\u003d\u0027View public, private or both volume types\u0027)"},{"line_number":64,"context_line":"def do_type_list(cs, args):"},{"line_number":65,"context_line":"    \"\"\"Lists available \u0027volume types\u0027."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_06feb537","line":63,"range":{"start_line":63,"start_character":38,"end_line":63,"end_character":45},"updated":"2019-03-22 14:08:42.000000000","message":"Huh? What are the semantics? If you don\u0027t specify it, you get private volume types, and if you do, you get public volume types? How do you get both? The help here isn\u0027t helpful.","commit_id":"0b08f84f3019bc23da2979128b5c66f61f312856"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24ccca3347a3aef1632567fa083e65a59de8e33b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":61,"context_line":"@utils.arg(\u0027--is-public\u0027,"},{"line_number":62,"context_line":"           metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":63,"context_line":"           help\u003d\u0027View public, private or both volume types\u0027)"},{"line_number":64,"context_line":"def do_type_list(cs, args):"},{"line_number":65,"context_line":"    \"\"\"Lists available \u0027volume types\u0027."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_61dc4318","line":63,"range":{"start_line":63,"start_character":38,"end_line":63,"end_character":45},"in_reply_to":"5fc1f717_01c0df7b","updated":"2019-03-22 14:33:48.000000000","message":"Then you should have shell tests for using those 3 values. Does the user pass --is-public True/False/None? Document it and test it.","commit_id":"0b08f84f3019bc23da2979128b5c66f61f312856"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f279697fdd8477371a33500c32a9ac0b404cfdff","unresolved":false,"context_lines":[{"line_number":60,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":61,"context_line":"@utils.arg(\u0027--is-public\u0027,"},{"line_number":62,"context_line":"           metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":63,"context_line":"           help\u003d\u0027View public, private or both volume types\u0027)"},{"line_number":64,"context_line":"def do_type_list(cs, args):"},{"line_number":65,"context_line":"    \"\"\"Lists available \u0027volume types\u0027."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_01c0df7b","line":63,"range":{"start_line":63,"start_character":38,"end_line":63,"end_character":45},"in_reply_to":"5fc1f717_06feb537","updated":"2019-03-22 14:30:59.000000000","message":"There are 3 options, True/False/None, the details are described here[1].\nI will add the default value here as None in the next PS.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/v2/types.py#L72-L74","commit_id":"0b08f84f3019bc23da2979128b5c66f61f312856"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8d05f27d3812e612a61948981fadb9bb440be243","unresolved":false,"context_lines":[{"line_number":58,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":59,"context_line":"           default\u003dNone,"},{"line_number":60,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":61,"context_line":"@utils.arg(\u0027--is-public\u0027,"},{"line_number":62,"context_line":"           metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":63,"context_line":"           default\u003dNone,"},{"line_number":64,"context_line":"           help\u003d\u0027View public(True), private(False) \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_b32cd34a","line":61,"updated":"2019-04-03 14:44:44.000000000","message":"Should this actually be a new argument?  Why can\u0027t --filters handle is_public?","commit_id":"d3837057be996582b24de9d760b4c13f45e458b6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3806ed95fac4aca8a829c3ddf5b79fe475817105","unresolved":false,"context_lines":[{"line_number":58,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":59,"context_line":"           default\u003dNone,"},{"line_number":60,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":61,"context_line":"@utils.arg(\u0027--is-public\u0027,"},{"line_number":62,"context_line":"           metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":63,"context_line":"           default\u003dNone,"},{"line_number":64,"context_line":"           help\u003d\u0027View public(True), private(False) \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_75ab5c87","line":61,"in_reply_to":"5fc1f717_333d432c","updated":"2019-04-08 15:46:55.000000000","message":"Also, why is the arg \"--is-public\" instead of \"--public\"?\n\nNo other search options that exist for \"list\" have used \"--is\" as a prefix, why complicate that here?  This seems likely to just trip up users.","commit_id":"d3837057be996582b24de9d760b4c13f45e458b6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5668dda4e3dea8bbf4217e5ffd2b0eba51c4fd63","unresolved":false,"context_lines":[{"line_number":58,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":59,"context_line":"           default\u003dNone,"},{"line_number":60,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":61,"context_line":"@utils.arg(\u0027--is-public\u0027,"},{"line_number":62,"context_line":"           metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":63,"context_line":"           default\u003dNone,"},{"line_number":64,"context_line":"           help\u003d\u0027View public(True), private(False) \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_333d432c","line":61,"in_reply_to":"5fc1f717_b32cd34a","updated":"2019-04-04 15:59:18.000000000","message":"Two reasons for me adding it as a new arg :\n1) to maintain consistency with other volume_type commands[1]\n2) it would require MV \u003e\u003d 3.52, but IMO this arg should be available with other vol type (create, update) commands.\n\n[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/shell.py#L835-L838","commit_id":"d3837057be996582b24de9d760b4c13f45e458b6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8d05f27d3812e612a61948981fadb9bb440be243","unresolved":false,"context_lines":[{"line_number":63,"context_line":"           default\u003dNone,"},{"line_number":64,"context_line":"           help\u003d\u0027View public(True), private(False) \u0027"},{"line_number":65,"context_line":"                \u0027or both(None) volume types. \u0027"},{"line_number":66,"context_line":"                \u0027Default\u003dNone\u0027)"},{"line_number":67,"context_line":"def do_type_list(cs, args):"},{"line_number":68,"context_line":"    \"\"\"Lists available \u0027volume types\u0027."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_1367e7b9","line":66,"updated":"2019-04-03 14:44:44.000000000","message":"Since the arg is called \"--is-public\", shouldn\u0027t it behave like --is-public True if you just add \"--is-public\" with no second argument?","commit_id":"d3837057be996582b24de9d760b4c13f45e458b6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5668dda4e3dea8bbf4217e5ffd2b0eba51c4fd63","unresolved":false,"context_lines":[{"line_number":63,"context_line":"           default\u003dNone,"},{"line_number":64,"context_line":"           help\u003d\u0027View public(True), private(False) \u0027"},{"line_number":65,"context_line":"                \u0027or both(None) volume types. \u0027"},{"line_number":66,"context_line":"                \u0027Default\u003dNone\u0027)"},{"line_number":67,"context_line":"def do_type_list(cs, args):"},{"line_number":68,"context_line":"    \"\"\"Lists available \u0027volume types\u0027."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_41081990","line":66,"in_reply_to":"5fc1f717_1367e7b9","updated":"2019-04-04 15:59:18.000000000","message":"As is_public\u003dNone was the default functionality[1] before, I haven\u0027t modified it.\n\n[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/tests/unit/v2/test_types.py#L28-L29","commit_id":"d3837057be996582b24de9d760b4c13f45e458b6"}]}