)]}'
{"id":"openstack%2Fpython-cinderclient~641698","triplet_id":"openstack%2Fpython-cinderclient~master~I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15","project":"openstack/python-cinderclient","branch":"master","topic":"641698","hashtags":[],"change_id":"I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15","subject":"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option","status":"MERGED","created":"2019-03-07 15:31:07.000000000","updated":"2019-08-21 11:15:47.000000000","submitted":"2019-08-21 11:13:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"641698-1566385998178-462ff7de","meta_rev_id":"b0f0cc3c19cca40db34b0eb3b50fe80281a2230d","_number":641698,"virtual_id_number":641698,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-21 11:13:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"date":"2019-04-17 07:55:51.000000000","_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-27 00:35:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":2,"date":"2019-08-21 09:21:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"date":"2019-05-03 16:12:26.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":1,"date":"2019-08-21 09:21:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-22 14:07:34.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-03-25 11:10:29.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2019-04-09 15:16:25.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-05-03 16:12:26.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-06-27 00:35:56.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-08-21 09:21:30.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2019-08-21 11:13:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f7309621d145c4d0e1d84e3923b7c9f69dbf9354","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-03-07 15:31:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f65bc7c1d2826b008cbbc93a6c2d6afc2059e9c4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-07 17:14:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/98/641698/1/check/tempest-full/39eca5d/ : SUCCESS in 1h 41m 40s\n- tempest-full-py3 http://logs.openstack.org/98/641698/1/check/tempest-full-py3/ef7ca35/ : SUCCESS in 1h 25m 08s\n- openstack-tox-cover http://logs.openstack.org/98/641698/1/check/openstack-tox-cover/b16baff/cover/ : SUCCESS in 4m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/641698/1/check/openstack-tox-lower-constraints/e59855a/ : SUCCESS in 4m 49s\n- openstack-tox-pep8 http://logs.openstack.org/98/641698/1/check/openstack-tox-pep8/9a7c7c0/ : SUCCESS in 3m 24s\n- openstack-tox-py27 http://logs.openstack.org/98/641698/1/check/openstack-tox-py27/5bcea54/ : SUCCESS in 5m 50s\n- openstack-tox-py36 http://logs.openstack.org/98/641698/1/check/openstack-tox-py36/6ff07d3/ : SUCCESS in 4m 23s\n- openstack-tox-py37 http://logs.openstack.org/98/641698/1/check/openstack-tox-py37/ef2a2bc/ : SUCCESS in 4m 31s\n- openstack-tox-docs http://logs.openstack.org/98/641698/1/check/openstack-tox-docs/15e3300/html/ : SUCCESS in 3m 41s\n- cinderclient-dsvm-functional http://logs.openstack.org/98/641698/1/check/cinderclient-dsvm-functional/ded73a4/ : SUCCESS in 34m 10s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/98/641698/1/check/openstack-tox-pylint/0781846/ : SUCCESS in 7m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"09bd5255e9893dbbe29d3c4419d20891cf990ff5","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-03-22 14:06:55.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks for fixing this.","accounts_in_message":[],"_revision_number":1},{"id":"bb6d392dd7c5c76d3daeb7885a054e0f5719bf78","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:07:34.000000000","message":"Patch Set 1: Code-Review-1\n\nNo unit test?","accounts_in_message":[],"_revision_number":1},{"id":"f65b115cbe2ad4073f503a3523ae121669a3dad6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:07:42.000000000","message":"Patch Set 1:\n\nNo release note mentioning that there is a new option?","accounts_in_message":[],"_revision_number":1},{"id":"8c8be2463c3cb4282ae92af333d5319ffe5c4c5c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:08:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f279697fdd8477371a33500c32a9ac0b404cfdff","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-03-22 14:30:59.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nHi Matt,\n\nThis is a fairly old option that exists in cinder API since a long time but wasn\u0027t included in the client.\nThe test exists for it here[1], i guess it needs to be modified to be appended in the command (next PS)\nDoes it still need a releasenote?\n[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/tests/unit/v2/test_shell.py#L668","accounts_in_message":[],"_revision_number":1},{"id":"24ccca3347a3aef1632567fa083e65a59de8e33b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:33:48.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e This is a fairly old option that exists in cinder API since a long time but wasn\u0027t included in the client.\n\nWell that sucks, and it\u0027s good to fix it finally on master, but that doesn\u0027t mean it\u0027s something that is appropriate to backport to stable branches.","accounts_in_message":[],"_revision_number":1},{"id":"ca6c17c6aa830f1fab08fdd8ecb92114ca777676","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-03-25 09:36:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7dd22d0a3403dfb4fa582703729478973090bc4c","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-03-25 11:10:29.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"c72a1de1854430c169c7ddb2e78746cad340bde9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-25 11:14:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/98/641698/2/check/tempest-full/c273f34/ : SUCCESS in 1h 36m 16s\n- tempest-full-py3 http://logs.openstack.org/98/641698/2/check/tempest-full-py3/4656ed4/ : SUCCESS in 1h 23m 38s\n- openstack-tox-cover http://logs.openstack.org/98/641698/2/check/openstack-tox-cover/25a2db7/cover/ : SUCCESS in 4m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/641698/2/check/openstack-tox-lower-constraints/a4bba23/ : SUCCESS in 3m 48s\n- openstack-tox-pep8 http://logs.openstack.org/98/641698/2/check/openstack-tox-pep8/cf9f83c/ : SUCCESS in 2m 30s\n- openstack-tox-py27 http://logs.openstack.org/98/641698/2/check/openstack-tox-py27/f051b41/ : SUCCESS in 3m 22s\n- openstack-tox-py36 http://logs.openstack.org/98/641698/2/check/openstack-tox-py36/7f22ed6/ : SUCCESS in 3m 14s\n- openstack-tox-py37 http://logs.openstack.org/98/641698/2/check/openstack-tox-py37/3754b06/ : SUCCESS in 3m 35s\n- openstack-tox-docs http://logs.openstack.org/98/641698/2/check/openstack-tox-docs/bff8da1/html/ : SUCCESS in 2m 53s\n- build-openstack-releasenotes http://logs.openstack.org/98/641698/2/check/build-openstack-releasenotes/d6fc4a7/html/ : SUCCESS in 2m 32s\n- cinderclient-dsvm-functional http://logs.openstack.org/98/641698/2/check/cinderclient-dsvm-functional/b8d1798/ : SUCCESS in 33m 20s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/98/641698/2/check/openstack-tox-pylint/a553d48/ : SUCCESS in 5m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8cd6ecd8560acc2f02ba5c675cd7f9e77f5d83fc","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-03-26 15:27:54.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027m not sure this actually works.\n\nhttp://paste.openstack.org/raw/748405/","accounts_in_message":[],"_revision_number":2},{"id":"d9cb7a70232a3e069284f6011bb7b7df6af4aa6c","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-03-26 17:23:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1eba4f64dbf12c0d156ba571ce14f65c7afe1849","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-03-26 17:23:45.000000000","message":"Patch Set 3:\n\n\u003e I\u0027m not sure this actually works.\n \u003e \n \u003e http://paste.openstack.org/raw/748405/\n\nMissed the str to bool conversion, fixed.","accounts_in_message":[],"_revision_number":3},{"id":"49c75992ea2d580b1e85d1b2d99a4da0af55e4ae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 19:22:21.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/98/641698/3/check/tempest-full/29c5a2d/ : SUCCESS in 1h 53m 05s\n- tempest-full-py3 http://logs.openstack.org/98/641698/3/check/tempest-full-py3/09e4d80/ : SUCCESS in 1h 21m 43s\n- openstack-tox-cover http://logs.openstack.org/98/641698/3/check/openstack-tox-cover/ff9df0f/cover/ : SUCCESS in 4m 16s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/641698/3/check/openstack-tox-lower-constraints/b39b418/ : SUCCESS in 5m 08s\n- openstack-tox-pep8 http://logs.openstack.org/98/641698/3/check/openstack-tox-pep8/f4428dd/ : SUCCESS in 3m 31s\n- openstack-tox-py27 http://logs.openstack.org/98/641698/3/check/openstack-tox-py27/5ac33b6/ : SUCCESS in 3m 01s\n- openstack-tox-py36 http://logs.openstack.org/98/641698/3/check/openstack-tox-py36/f1c922f/ : SUCCESS in 4m 09s\n- openstack-tox-py37 http://logs.openstack.org/98/641698/3/check/openstack-tox-py37/8d6c0db/ : SUCCESS in 4m 02s\n- openstack-tox-docs http://logs.openstack.org/98/641698/3/check/openstack-tox-docs/696638b/html/ : SUCCESS in 2m 52s\n- build-openstack-releasenotes http://logs.openstack.org/98/641698/3/check/build-openstack-releasenotes/ad38cdc/html/ : SUCCESS in 2m 57s\n- cinderclient-dsvm-functional http://logs.openstack.org/98/641698/3/check/cinderclient-dsvm-functional/a5a661e/ : SUCCESS in 32m 25s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/98/641698/3/check/openstack-tox-pylint/b5ca12c/ : SUCCESS in 5m 22s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"be6ccbb63b99ffea17c02039ca4bf6838a1899f0","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-04-02 15:09:15.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8d05f27d3812e612a61948981fadb9bb440be243","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-03 14:44:44.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"5668dda4e3dea8bbf4217e5ffd2b0eba51c4fd63","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-04-04 15:59:18.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nHi Eric,\nPlease find my response inline.","accounts_in_message":[],"_revision_number":3},{"id":"265f669048eb7d5a57efd0e3a7441cd8daeaa650","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-08 15:44:46.000000000","message":"Patch Set 3:\n\nMaintaining consistency between list and create doesn\u0027t really make sense here.  list has filters, create needs options for users to indicate what they want to create...\n\nIs it possible to search for \"is_public\" via the filter mechanism?","accounts_in_message":[],"_revision_number":3},{"id":"3806ed95fac4aca8a829c3ddf5b79fe475817105","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-08 15:46:55.000000000","message":"Patch Set 3: Code-Review-2\n\n(1 comment)\n\nLet\u0027s stare at the design of this a bit more closely before landing it.","accounts_in_message":[],"_revision_number":3},{"id":"84c447f5205864e0e8202724eb9bbec4b66039a3","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-04-09 15:16:25.000000000","message":"Patch Set 3: Code-Review-1\n\nI\u0027m glad that you\u0027re extending this functionality into the client, but I agree with Eric that we should take a bit more time to think about what it looks like to a user.\n\nReference [1] in your commit message describes is_public as \"Filter the volume type by public visibility.\".   I\u0027d suggest using --visibility as the option and let it take a value from {\u0027public\u0027, \u0027private\u0027, \u0027all\u0027} with the default being \u0027all\u0027.  Having \u0027--is-public None\u0027 as a way to display all volumes is really counterintuitive.  (I realize that you don\u0027t need to include --is-public at all to get everything, but take a look at the help text -- IMO it\u0027s really ugly.)\n\nIf you don\u0027t like that, my next suggestion is to use \u0027--public\u0027 and \u0027--private\u0027 with no values as the args.  No need for a default, if they\u0027re left out you get all as you do now; how including both would behave would depend on how you describe the option (that is, \u0027include only public volumes\u0027 --\u003e both is an error, vs. \u0027include public volumes\u0027 --\u003e both would mean all).","accounts_in_message":[],"_revision_number":3},{"id":"863e384951a922fcf4c6a5ac26a748fe51cf8855","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-04-09 15:28:40.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3},{"id":"c5392b1cf2a5462a4d5c8dc2afc744afc3ea4d20","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-04-09 15:39:37.000000000","message":"Patch Set 3: Workflow-1\n\nI tried to keep the code change minimal with keeping the most consistency with API and previous client code to make this work but since this patch seems to be getting lots of different suggestions, i\u0027ve added it to the weekly meeting agenda to be further discussed and concluded as to what should be the exact default functionality, arg name etc.","accounts_in_message":[],"_revision_number":3},{"id":"1547b98bcebc37c6b4884e403e77429b05d0a3c8","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-04-15 08:35:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2a95246a811ef0ac1f0af5b241b7a95f71e5c936","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-04-15 08:36:27.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":5},{"id":"8d81a84b019510135490c85667482471b9a2c77e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-15 10:28:13.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/98/641698/5/check/tempest-full/4ef75a1/ : SUCCESS in 1h 38m 38s\n- tempest-full-py3 http://logs.openstack.org/98/641698/5/check/tempest-full-py3/428efdc/ : SUCCESS in 1h 45m 15s\n- openstack-tox-cover http://logs.openstack.org/98/641698/5/check/openstack-tox-cover/95dee57/cover/ : SUCCESS in 3m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/641698/5/check/openstack-tox-lower-constraints/431b049/ : SUCCESS in 3m 42s\n- openstack-tox-pep8 http://logs.openstack.org/98/641698/5/check/openstack-tox-pep8/c6877d1/ : SUCCESS in 2m 48s\n- openstack-tox-py27 http://logs.openstack.org/98/641698/5/check/openstack-tox-py27/23e2d19/ : SUCCESS in 3m 35s\n- openstack-tox-py36 http://logs.openstack.org/98/641698/5/check/openstack-tox-py36/0796287/ : SUCCESS in 3m 32s\n- openstack-tox-py37 http://logs.openstack.org/98/641698/5/check/openstack-tox-py37/7895017/ : SUCCESS in 3m 38s\n- openstack-tox-docs http://logs.openstack.org/98/641698/5/check/openstack-tox-docs/11009cd/html/ : SUCCESS in 2m 47s\n- build-openstack-releasenotes http://logs.openstack.org/98/641698/5/check/build-openstack-releasenotes/7b364b4/html/ : SUCCESS in 2m 36s\n- cinderclient-dsvm-functional http://logs.openstack.org/98/641698/5/check/cinderclient-dsvm-functional/b4fba07/ : SUCCESS in 28m 47s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/98/641698/5/check/openstack-tox-pylint/4df319d/ : SUCCESS in 5m 20s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"fac0b23cfe895043972711e9f98965fb7e81c347","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-15 14:40:27.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"0f5ad1bd724b6b035bbb653d10cfb58e2e4edcc8","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-04-17 07:55:51.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"7a5203e670954722a7581b405ec04e7b0df84f82","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-05-03 16:12:26.000000000","message":"Patch Set 5: -Code-Review","accounts_in_message":[],"_revision_number":5},{"id":"b774af1f32fa80aa4ccd5a92f21c0a522aa99283","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-06-27 00:35:56.000000000","message":"Patch Set 5: Code-Review+2\n\nI am still ok with this I think.","accounts_in_message":[],"_revision_number":5},{"id":"310ac6f283f427a705777431ecfb2abb97cce10b","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-08-21 09:21:30.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"bad49fd6caba91c050d7aa73578837ca333f20ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 09:21:42.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"0c77a60c7136ba77462e2db91a895d4402fff006","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 11:13:17.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/ac96b566ecb647dbb83fa0106dbc5f74 : SUCCESS in 1h 46m 01s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/38c702beaf0d4f30854a7184dae07aa3 : SUCCESS in 1h 40m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/db1442b83ac4491a96e5e26ba247880f : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1631b237b3974c79bc0f8336f7e8e488 : SUCCESS in 3m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/cc8647c2a2304cfa8597a1e151cad328 : SUCCESS in 4m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a847e0dbe9ed47849fcc3da88163d6a5 : SUCCESS in 3m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0464009647614cb99fc251feccc2d7a0 : SUCCESS in 4m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3ae6b279e40042d39ff93643f5c6dfd9 : SUCCESS in 4m 25s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/101085dcf1a04bb1b728f315d67ff371 : SUCCESS in 3m 10s","accounts_in_message":[],"_revision_number":5},{"id":"e97e6f2985e3c4fce6508f219531977018748004","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 11:13:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"5139aceeb440675601e020202aab27ddaec7874b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 11:15:47.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4fe7724d70744a11b98c72fb1f7860a4 : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"6a498163e2b0cf1256743d84200a99f840dc9135","revisions":{"0b08f84f3019bc23da2979128b5c66f61f312856":{"kind":"REWORK","_number":1,"created":"2019-03-07 15:31:07.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/98/641698/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/98/641698/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/1"}}},"commit":{"parents":[{"commit":"8de1f789c5e4eef10c6757f4f1a6415deb6433a3","subject":"Drop py35 jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8de1f789c5e4eef10c6757f4f1a6415deb6433a3"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-07 15:20:55.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-07 15:20:55.000000000","tz":330},"subject":"Add \u0027is_public\u0027 option for cinder type-list command","message":"Add \u0027is_public\u0027 option for cinder type-list command\n\n\u0027--is-public\u0027 is a valid argument for cinder type-list command[1]\nbut is missing in cinderclient.\nThis patch adds the support for it.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v3/?expanded\u003dlist-all-volume-types-detail#list-all-volume-types\n\nChange-Id: I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0b08f84f3019bc23da2979128b5c66f61f312856"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0b08f84f3019bc23da2979128b5c66f61f312856"}]},"branch":"refs/heads/master"},"9b2a459670ce9eb308ab67e9ccdcbb89f66b09ff":{"kind":"REWORK","_number":2,"created":"2019-03-25 09:36:27.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/98/641698/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/98/641698/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/2"}}},"commit":{"parents":[{"commit":"8de1f789c5e4eef10c6757f4f1a6415deb6433a3","subject":"Drop py35 jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8de1f789c5e4eef10c6757f4f1a6415deb6433a3"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-07 15:20:55.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-25 09:36:05.000000000","tz":330},"subject":"Add \u0027is_public\u0027 option for cinder type-list command","message":"Add \u0027is_public\u0027 option for cinder type-list command\n\n\u0027--is-public\u0027 is a valid argument for cinder type-list command[1]\nbut is missing in cinderclient.\nThis patch adds the support for it.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v3/?expanded\u003dlist-all-volume-types-detail#list-all-volume-types\n\nChange-Id: I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9b2a459670ce9eb308ab67e9ccdcbb89f66b09ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9b2a459670ce9eb308ab67e9ccdcbb89f66b09ff"}]},"branch":"refs/heads/master"},"d3837057be996582b24de9d760b4c13f45e458b6":{"kind":"REWORK","_number":3,"created":"2019-03-26 17:23:06.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/98/641698/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/98/641698/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/3"}}},"commit":{"parents":[{"commit":"8de1f789c5e4eef10c6757f4f1a6415deb6433a3","subject":"Drop py35 jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8de1f789c5e4eef10c6757f4f1a6415deb6433a3"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-07 15:20:55.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-26 17:21:22.000000000","tz":330},"subject":"Add \u0027is_public\u0027 option for cinder *type-list commands","message":"Add \u0027is_public\u0027 option for cinder *type-list commands\n\n\u0027--is-public\u0027 is a valid argument for cinder type-list command[1]\nand cinder group-type-list command but is missing in cinderclient.\nThis patch adds the support for it.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v3/?expanded\u003dlist-all-volume-types-detail#list-all-volume-types\n\nChange-Id: I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d3837057be996582b24de9d760b4c13f45e458b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d3837057be996582b24de9d760b4c13f45e458b6"}]},"branch":"refs/heads/master"},"9be7bcaef826672032385f7a642bbb0f9959303c":{"kind":"REWORK","_number":4,"created":"2019-04-15 08:35:36.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/98/641698/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/98/641698/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/4"}}},"commit":{"parents":[{"commit":"8de1f789c5e4eef10c6757f4f1a6415deb6433a3","subject":"Drop py35 jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8de1f789c5e4eef10c6757f4f1a6415deb6433a3"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-07 15:20:55.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-04-15 08:34:33.000000000","tz":330},"subject":"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option","message":"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option\n\n\u0027--is-public\u0027 is a valid argument for cinder type-list command[1]\nand cinder group-type-list command but is missing in cinderclient.\nThis patch adds the support for it.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v3/?expanded\u003dlist-all-volume-types-detail#list-all-volume-types\n\nChange-Id: I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9be7bcaef826672032385f7a642bbb0f9959303c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9be7bcaef826672032385f7a642bbb0f9959303c"}]},"branch":"refs/heads/master"},"6a498163e2b0cf1256743d84200a99f840dc9135":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2019-04-15 08:36:27.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/98/641698/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/98/641698/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/98/641698/5"}}},"commit":{"parents":[{"commit":"15295acb074a778674f2b92f45f8dd1e7ff5f60c","subject":"Merge \"Tests: Don\u0027t write bash-completion cache files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/15295acb074a778674f2b92f45f8dd1e7ff5f60c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-03-07 15:20:55.000000000","tz":330},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2019-04-15 08:36:27.000000000","tz":0},"subject":"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option","message":"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option\n\n\u0027--is-public\u0027 is a valid argument for cinder type-list command[1]\nand cinder group-type-list command but is missing in cinderclient.\nThis patch adds the support for it.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v3/?expanded\u003dlist-all-volume-types-detail#list-all-volume-types\n\nChange-Id: I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6a498163e2b0cf1256743d84200a99f840dc9135"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6a498163e2b0cf1256743d84200a99f840dc9135"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}