)]}'
{"id":"openstack%2Fpython-cinderclient~645571","triplet_id":"openstack%2Fpython-cinderclient~stable%2Fstein~I6f653f10249992196abb04e05c54df5fb244b182","project":"openstack/python-cinderclient","branch":"stable/stein","topic":"stein-ketchup","hashtags":[],"change_id":"I6f653f10249992196abb04e05c54df5fb244b182","subject":"Change cache uniqifier from using md5 to sha-1","status":"ABANDONED","created":"2019-03-22 13:32:28.000000000","updated":"2019-03-26 15:16:54.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"35015bc6b543ade733351854d4c0be1ba2a3f4c1","_number":645571,"virtual_id_number":645571,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-03-26 14:30:06.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2019-03-26 15:16:46.000000000","_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-03-22 14:14:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"value":-1,"date":"2019-03-22 15:05:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"date":"2019-03-26 14:24:41.000000000","_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-03-26 14:17:55.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-22 14:14:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-22 15:05:21.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-03-26 14:17:55.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-03-26 14:24:41.000000000","updated_by":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"reviewer":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"state":"REVIEWER"},{"updated":"2019-03-26 14:30:06.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"79cf8c9e93780d61f0efedc13a4834dfb4be8dd8","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-22 13:32:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d4ba4471730b28c01d3265daafcdd315419cb4f1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-22 14:14:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/71/645571/1/check/openstack-tox-cover/03837a0/cover/ : SUCCESS in 4m 41s\n- openstack-tox-lower-constraints http://logs.openstack.org/71/645571/1/check/openstack-tox-lower-constraints/45e0775/ : SUCCESS in 4m 48s\n- openstack-tox-pep8 http://logs.openstack.org/71/645571/1/check/openstack-tox-pep8/2f03343/ : SUCCESS in 3m 42s\n- openstack-tox-py27 http://logs.openstack.org/71/645571/1/check/openstack-tox-py27/29bc617/ : SUCCESS in 3m 32s\n- openstack-tox-py35 http://logs.openstack.org/71/645571/1/check/openstack-tox-py35/0606697/ : SUCCESS in 3m 44s\n- openstack-tox-py36 http://logs.openstack.org/71/645571/1/check/openstack-tox-py36/4826464/ : SUCCESS in 3m 19s\n- openstack-tox-docs http://logs.openstack.org/71/645571/1/check/openstack-tox-docs/664faad/html/ : SUCCESS in 3m 10s\n- cinderclient-dsvm-functional http://logs.openstack.org/71/645571/1/check/cinderclient-dsvm-functional/1256894/ : SUCCESS in 35m 17s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/71/645571/1/check/cinderclient-dsvm-functional-identity-v3-only/09bc36c/ : SUCCESS in 30m 40s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/71/645571/1/check/openstack-tox-pylint/4416241/ : SUCCESS in 5m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f2fe34a654acbff75e15c7904c84af6c7a92228c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 15:05:21.000000000","message":"Patch Set 1: Code-Review-1\n\nThis is pretty borderline for stable especially when there is no bug or release note, so I\u0027m going to be conservative and nack it.","accounts_in_message":[],"_revision_number":1},{"id":"4f1de5f5bd2768c6915837dc39a11b61c1b1f729","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-25 12:40:40.000000000","message":"Patch Set 1:\n\nThe default cache dir change is a dependency for https://review.openstack.org/645573","accounts_in_message":[],"_revision_number":1},{"id":"bf980f5180cde8263b115adf746119ce4b908ba7","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-03-26 14:18:47.000000000","message":"Patch Set 1:\n\nThis does seem a little risky to do now. Any way we can adapt the cache path patch to adjust for not having this change?","accounts_in_message":[],"_revision_number":1},{"id":"e6b15f0b310048a5aaaa8da636afbdea2a24f902","author":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"date":"2019-03-26 14:24:41.000000000","message":"Patch Set 1:\n\n\u003e This is pretty borderline for stable especially when there is no\n \u003e bug or release note, so I\u0027m going to be conservative and nack it.\n\nI can also propose a middle ground of detecting and using the lesser known \"usedforsecurity\u003dFalse\" parameter for the MD5 call. That would at least take care of RHEL and maybe some others without any impact to compatibility. Thoughts?","accounts_in_message":[],"_revision_number":1},{"id":"4049510ee6fc632ef393b4eca904cd398abfcffe","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-03-26 14:30:06.000000000","message":"Patch Set 1:\n\n\u003e \u003e This is pretty borderline for stable especially when there is no\n \u003e \u003e bug or release note, so I\u0027m going to be conservative and nack it.\n \u003e \n \u003e I can also propose a middle ground of detecting and using the\n \u003e lesser known \"usedforsecurity\u003dFalse\" parameter for the MD5 call.\n \u003e That would at least take care of RHEL and maybe some others without\n \u003e any impact to compatibility. Thoughts?\n\nThat seems like it would be safer. We did merge this to master, so as it is right now, we would need to merge that change to master and get it backported to stable/stein if we wanted to get it in a stable release.\n\nIf we can adjust the change that depends on this, then I think I would be more comfortable merging that to master and skipping stein. But if this is going to cause issues for stein on RHEL, that makes it a little more important to get backported.","accounts_in_message":[],"_revision_number":1},{"id":"2b6ea1c7683d23577dd3dfaa73d8b43239ffc8ea","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-26 15:16:46.000000000","message":"Patch Set 1:\n\nIf this patch doesn\u0027t go in, then the dependency does not need to go in either.  Consensus appears to be that this is not required for Stein, so I\u0027ll abandon both this and the dependency.","accounts_in_message":[],"_revision_number":1},{"id":"9ca18d84ab3a851865c9e5c142624f5bfb4bc4dd","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-26 15:16:54.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e6206efc6b9be9efb84d0fe7a5bb7f2540219b70","revisions":{"e6206efc6b9be9efb84d0fe7a5bb7f2540219b70":{"kind":"REWORK","_number":1,"created":"2019-03-22 13:32:28.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/71/645571/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/71/645571/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/645571/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/645571/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/645571/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/71/645571/1"}}},"commit":{"parents":[{"commit":"d1b01aa2bdc2b4ce3bc37106738def33e1916b03","subject":"Update UPPER_CONSTRAINTS_FILE for stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d1b01aa2bdc2b4ce3bc37106738def33e1916b03"}]}],"author":{"name":"Joshua Cornutt","email":"jcornutt@gmail.com","date":"2018-11-05 23:53:02.000000000","tz":-300},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2019-03-21 17:58:58.000000000","tz":-240},"subject":"Change cache uniqifier from using md5 to sha-1","message":"Change cache uniqifier from using md5 to sha-1\n\nFIPS 140-2 does not allow MD5 use for most purposes and systems\nin \"FIPS mode\" (fips\u003d1 kernel flag) will cause software using\nMD5 from popular libraries to fail.\n\nAlso change the default cache dir to use ~/.cache/\n\nChange-Id: I6f653f10249992196abb04e05c54df5fb244b182\n(cherry picked from commit 4cf62cf31f3fcc0d00ce4daa291be6003ab331ed)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e6206efc6b9be9efb84d0fe7a5bb7f2540219b70"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e6206efc6b9be9efb84d0fe7a5bb7f2540219b70"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}