)]}'
{"id":"openstack%2Fpython-cinderclient~645585","triplet_id":"openstack%2Fpython-cinderclient~stable%2Fstein~I20f6c5471ffefe5524a4d48c967e2e8db53233f1","project":"openstack/python-cinderclient","branch":"stable/stein","topic":"stein-ketchup","hashtags":[],"change_id":"I20f6c5471ffefe5524a4d48c967e2e8db53233f1","subject":"Fix max version handling for help output","status":"MERGED","created":"2019-03-22 13:42:46.000000000","updated":"2019-03-26 14:42:11.000000000","submitted":"2019-03-26 14:42:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"645585-1553611331617-28228be7","meta_rev_id":"be3cef9104c0ff673a767301b806c0d524b4b9a3","_number":645585,"virtual_id_number":645585,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-03-25 12:06:45.000000000","_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-03-26 14:42:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-03-26 14:27:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-03-26 14:14:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2019-03-26 14:27:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-22 14:05:42.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-03-26 14:14:46.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-03-26 14:27:07.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-03-26 14:42:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e030fd2f4c40dcbee95383cb98fd5e57391e0365","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-22 13:42:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bcaba7ff9477dadd9a0118248e0c369e7ad5d8fc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:05:42.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2659588b74d652541bfb47d416c9d6e724060d8d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:10:42.000000000","message":"Patch Set 1:\n\nRebase this on top of 381edcf49d59d3a0fd5bbcbf1c7329e3578ac39e.","accounts_in_message":[],"_revision_number":1},{"id":"de85bd072e43bf2422601263b292682b5a089426","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-22 14:22:26.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/85/645585/1/check/openstack-tox-cover/31d3b9c/cover/ : SUCCESS in 6m 04s\n- openstack-tox-lower-constraints http://logs.openstack.org/85/645585/1/check/openstack-tox-lower-constraints/2e0ac9d/ : SUCCESS in 4m 40s\n- openstack-tox-pep8 http://logs.openstack.org/85/645585/1/check/openstack-tox-pep8/d0919b5/ : FAILURE in 4m 07s\n- openstack-tox-py27 http://logs.openstack.org/85/645585/1/check/openstack-tox-py27/53e15d4/ : SUCCESS in 4m 14s\n- openstack-tox-py35 http://logs.openstack.org/85/645585/1/check/openstack-tox-py35/a3728d5/ : SUCCESS in 5m 41s\n- openstack-tox-py36 http://logs.openstack.org/85/645585/1/check/openstack-tox-py36/265594a/ : SUCCESS in 4m 32s\n- openstack-tox-docs http://logs.openstack.org/85/645585/1/check/openstack-tox-docs/6b628e8/html/ : SUCCESS in 4m 42s\n- cinderclient-dsvm-functional http://logs.openstack.org/85/645585/1/check/cinderclient-dsvm-functional/d8175de/ : SUCCESS in 33m 01s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/85/645585/1/check/cinderclient-dsvm-functional-identity-v3-only/6f56c04/ : SUCCESS in 31m 01s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/85/645585/1/check/openstack-tox-pylint/b120951/ : SUCCESS in 5m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c7e5f5a28b2f30c799dabb7e0f9da7d8e80b9871","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-25 12:06:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"75f7f6a1270a2f19ba0a4d1da6882dfb9209c892","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-25 12:06:45.000000000","message":"Patch Set 2:\n\nDepends on https://review.openstack.org/#/c/645566/","accounts_in_message":[],"_revision_number":2},{"id":"062d054a8b0599325e7d18ef071ad642d894d08d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-25 12:48:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/85/645585/2/check/openstack-tox-cover/be593c5/cover/ : SUCCESS in 3m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/85/645585/2/check/openstack-tox-lower-constraints/732fe18/ : SUCCESS in 4m 31s\n- openstack-tox-pep8 http://logs.openstack.org/85/645585/2/check/openstack-tox-pep8/970e744/ : SUCCESS in 3m 00s\n- openstack-tox-py27 http://logs.openstack.org/85/645585/2/check/openstack-tox-py27/d02b5bb/ : SUCCESS in 3m 00s\n- openstack-tox-py35 http://logs.openstack.org/85/645585/2/check/openstack-tox-py35/6af6772/ : SUCCESS in 3m 55s\n- openstack-tox-py36 http://logs.openstack.org/85/645585/2/check/openstack-tox-py36/77355d5/ : SUCCESS in 4m 15s\n- openstack-tox-docs http://logs.openstack.org/85/645585/2/check/openstack-tox-docs/8370bbf/html/ : SUCCESS in 2m 47s\n- cinderclient-dsvm-functional http://logs.openstack.org/85/645585/2/check/cinderclient-dsvm-functional/cd98b60/ : SUCCESS in 37m 37s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/85/645585/2/check/cinderclient-dsvm-functional-identity-v3-only/b16b13f/ : FAILURE in 25m 42s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/85/645585/2/check/openstack-tox-pylint/d4e333d/ : SUCCESS in 5m 40s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"41edddc0b5041edeaa1dd725c6b9cb01c373e90a","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-26 14:14:09.000000000","message":"Topic changed from bug/1813967 to stein-ketchup","accounts_in_message":[],"_revision_number":2},{"id":"28ee1977612b87461dbf2dde6f7d505edb216712","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-03-26 14:14:46.000000000","message":"Patch Set 2: Code-Review+2\n\nThis is a good fix to get in.  Thank you.","accounts_in_message":[],"_revision_number":2},{"id":"6a49b35267755eb474b1ff4a82c11171df6b2b22","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-03-26 14:27:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"2fd6e99f6acf1e838d570417f05994777e456216","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 14:27:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ea4a6931269d4d4c26d190f9f878a240abdb66a5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 14:42:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/85/645585/2/gate/openstack-tox-lower-constraints/c60b483/ : SUCCESS in 4m 50s\n- openstack-tox-pep8 http://logs.openstack.org/85/645585/2/gate/openstack-tox-pep8/7b59a36/ : SUCCESS in 4m 08s\n- openstack-tox-py27 http://logs.openstack.org/85/645585/2/gate/openstack-tox-py27/54b7189/ : SUCCESS in 3m 32s\n- openstack-tox-py35 http://logs.openstack.org/85/645585/2/gate/openstack-tox-py35/685ae6c/ : SUCCESS in 3m 33s\n- openstack-tox-py36 http://logs.openstack.org/85/645585/2/gate/openstack-tox-py36/7356fb2/ : SUCCESS in 3m 12s\n- openstack-tox-docs http://logs.openstack.org/85/645585/2/gate/openstack-tox-docs/ef89c1d/html/ : SUCCESS in 2m 34s","accounts_in_message":[],"_revision_number":2},{"id":"be3cef9104c0ff673a767301b806c0d524b4b9a3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 14:42:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"84d0e50ea30224221ec0436654ac5db94f8bfefe","revisions":{"fe6ebebdd167ba437f1a51f097ffa9c33b33095c":{"kind":"REWORK","_number":1,"created":"2019-03-22 13:42:46.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/85/645585/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/85/645585/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/1"}}},"commit":{"parents":[{"commit":"d1b01aa2bdc2b4ce3bc37106738def33e1916b03","subject":"Update UPPER_CONSTRAINTS_FILE for stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d1b01aa2bdc2b4ce3bc37106738def33e1916b03"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-01-30 18:20:26.000000000","tz":-360},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2019-03-21 21:05:19.000000000","tz":-240},"subject":"Fix max version handling for help output","message":"Fix max version handling for help output\n\nCommit fefe331f218d73ba6d1d7acf81b5eb02609c953e incorrectly set the\ndefault API version to the max the client knew about in order to get the\nfull help output, including all microversioned commands.\n\nThe original intent was to have help print out information for all\nversions, but still require the user to specify a version if they wanted\nto use any microversioned version of an API. The code accidentally made\nit so all commands would request the max version the client knew about.\nThis meant an unspecified request would get the newer functionality\nrather than the default v3 functionality, and also meant the client\ncould request a microversion higher than what the server knew about,\nresulting in an unexpected error being returned.\n\nTo keep the originally intended functionality, but keep all help output,\nthis only uses the max API version for the help command unless the user\nspecifies otherwise.\n\nCloses-bug: #1813967\n\nChange-Id: I20f6c5471ffefe5524a4d48c967e2e8db53233f1\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n(cherry picked from commit bccbd510a77843824b8187e15c4d8df9c2dfa55e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fe6ebebdd167ba437f1a51f097ffa9c33b33095c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fe6ebebdd167ba437f1a51f097ffa9c33b33095c"}]},"branch":"refs/heads/stable/stein"},"84d0e50ea30224221ec0436654ac5db94f8bfefe":{"kind":"REWORK","_number":2,"created":"2019-03-25 12:06:17.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/85/645585/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/85/645585/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/85/645585/2"}}},"commit":{"parents":[{"commit":"381edcf49d59d3a0fd5bbcbf1c7329e3578ac39e","subject":"Remove i18n.enable_lazy() translation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/381edcf49d59d3a0fd5bbcbf1c7329e3578ac39e"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-01-30 18:20:26.000000000","tz":-360},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2019-03-25 12:05:55.000000000","tz":-240},"subject":"Fix max version handling for help output","message":"Fix max version handling for help output\n\nCommit fefe331f218d73ba6d1d7acf81b5eb02609c953e incorrectly set the\ndefault API version to the max the client knew about in order to get the\nfull help output, including all microversioned commands.\n\nThe original intent was to have help print out information for all\nversions, but still require the user to specify a version if they wanted\nto use any microversioned version of an API. The code accidentally made\nit so all commands would request the max version the client knew about.\nThis meant an unspecified request would get the newer functionality\nrather than the default v3 functionality, and also meant the client\ncould request a microversion higher than what the server knew about,\nresulting in an unexpected error being returned.\n\nTo keep the originally intended functionality, but keep all help output,\nthis only uses the max API version for the help command unless the user\nspecifies otherwise.\n\nCloses-bug: #1813967\n\nChange-Id: I20f6c5471ffefe5524a4d48c967e2e8db53233f1\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n(cherry picked from commit bccbd510a77843824b8187e15c4d8df9c2dfa55e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/84d0e50ea30224221ec0436654ac5db94f8bfefe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/84d0e50ea30224221ec0436654ac5db94f8bfefe"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}