)]}'
{"id":"openstack%2Fpython-cinderclient~645588","triplet_id":"openstack%2Fpython-cinderclient~stable%2Fstein~Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0","project":"openstack/python-cinderclient","branch":"stable/stein","topic":"stein-ketchup","hashtags":[],"change_id":"Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0","subject":"Fix: cinder group-list not working with non-admin user","status":"MERGED","created":"2019-03-22 13:44:23.000000000","updated":"2019-03-26 14:34:30.000000000","submitted":"2019-03-26 14:34:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"645588-1553610870374-6ed09fe1","meta_rev_id":"11e0616fe0a1f9a938033209ef65f34d390dc5b6","_number":645588,"virtual_id_number":645588,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-03-26 14:34:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-03-26 14:24:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2019-03-22 14:01:26.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2019-03-26 14:24:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-03-22 13:44:23.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-22 13:44:23.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2019-03-22 14:01:26.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-03-26 14:24:35.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-03-26 14:34:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a65c26a2223ed55af3d64a21199131b0bb2a81d2","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-03-22 13:44:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"30209b3ecb75c3667c6fb1aa3321c27ed039f172","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-22 14:01:26.000000000","message":"Patch Set 1: Code-Review+2\n\nClean backport for a bug fix.","accounts_in_message":[],"_revision_number":1},{"id":"8ef82d48169d304c754c3f53cbc5bee19d4ca391","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-22 14:25:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/88/645588/1/check/openstack-tox-cover/1702262/cover/ : SUCCESS in 3m 22s\n- openstack-tox-lower-constraints http://logs.openstack.org/88/645588/1/check/openstack-tox-lower-constraints/1a8c600/ : SUCCESS in 3m 09s\n- openstack-tox-pep8 http://logs.openstack.org/88/645588/1/check/openstack-tox-pep8/d950e9c/ : SUCCESS in 3m 17s\n- openstack-tox-py27 http://logs.openstack.org/88/645588/1/check/openstack-tox-py27/8ba5faf/ : SUCCESS in 2m 46s\n- openstack-tox-py35 http://logs.openstack.org/88/645588/1/check/openstack-tox-py35/b80e781/ : SUCCESS in 3m 20s\n- openstack-tox-py36 http://logs.openstack.org/88/645588/1/check/openstack-tox-py36/43e0940/ : SUCCESS in 2m 51s\n- openstack-tox-docs http://logs.openstack.org/88/645588/1/check/openstack-tox-docs/e911c1b/html/ : SUCCESS in 3m 29s\n- cinderclient-dsvm-functional http://logs.openstack.org/88/645588/1/check/cinderclient-dsvm-functional/4a566ca/ : SUCCESS in 32m 42s (non-voting)\n- cinderclient-dsvm-functional-identity-v3-only http://logs.openstack.org/88/645588/1/check/cinderclient-dsvm-functional-identity-v3-only/4953180/ : SUCCESS in 32m 57s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/88/645588/1/check/openstack-tox-pylint/2f4395b/ : SUCCESS in 6m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"18362a99738b5ded7f36df5989ae04a39f493799","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-03-26 14:24:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"84aeddc2cf8e3e772ca7f583c01ef4e7c16206b3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 14:24:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a5498a77fa99d72a9b71cc08d761d482a0f7edf8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 14:34:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/88/645588/1/gate/openstack-tox-lower-constraints/d2bf2f5/ : SUCCESS in 3m 53s\n- openstack-tox-pep8 http://logs.openstack.org/88/645588/1/gate/openstack-tox-pep8/8ef8e44/ : SUCCESS in 3m 14s\n- openstack-tox-py27 http://logs.openstack.org/88/645588/1/gate/openstack-tox-py27/7653890/ : SUCCESS in 3m 43s\n- openstack-tox-py35 http://logs.openstack.org/88/645588/1/gate/openstack-tox-py35/086d1c8/ : SUCCESS in 3m 32s\n- openstack-tox-py36 http://logs.openstack.org/88/645588/1/gate/openstack-tox-py36/15d7b5d/ : SUCCESS in 3m 17s\n- openstack-tox-docs http://logs.openstack.org/88/645588/1/gate/openstack-tox-docs/45c2717/html/ : SUCCESS in 3m 13s","accounts_in_message":[],"_revision_number":1},{"id":"89a02a2d4107176db05ee65cf7d534ab815ab49d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 14:34:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"97997278d8de8d2f2a1acc9d9c6bfdbfb2856f28","revisions":{"97997278d8de8d2f2a1acc9d9c6bfdbfb2856f28":{"kind":"REWORK","_number":1,"created":"2019-03-22 13:44:23.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/88/645588/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/88/645588/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/88/645588/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/88/645588/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/88/645588/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/88/645588/1"}}},"commit":{"parents":[{"commit":"d1b01aa2bdc2b4ce3bc37106738def33e1916b03","subject":"Update UPPER_CONSTRAINTS_FILE for stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d1b01aa2bdc2b4ce3bc37106738def33e1916b03"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2018-12-26 07:26:10.000000000","tz":0},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2019-03-21 21:14:09.000000000","tz":-240},"subject":"Fix: cinder group-list not working with non-admin user","message":"Fix: cinder group-list not working with non-admin user\n\nThe all_tenants filter is passed to API when it\u0027s value is 0\n(when not specified) which shouldn\u0027t be the case.\nThis patch only allows adding of all_tenants when specified\nmanually by user.\n\nChange-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0\nCloses-Bug: #1808621\nCloses-Bug: #1808622\n(cherry picked from commit 532aef0c738edc937dbfa1b54efd8d7773af2204)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/97997278d8de8d2f2a1acc9d9c6bfdbfb2856f28"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/97997278d8de8d2f2a1acc9d9c6bfdbfb2856f28"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}