)]}'
{"cinderclient/tests/v1/test_shell.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":440,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":441,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":442,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":443,"context_line":"        self.run_command(cmd)"},{"line_number":444,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMQ%3D","line":442,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. No need to do a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":440,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":441,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":442,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":443,"context_line":"        self.run_command(cmd)"},{"line_number":444,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2I%3D","line":442,"in_reply_to":"AAAAUH%2F%2BbMQ%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":459,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":460,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":461,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" 1\""},{"line_number":462,"context_line":"        self.run_command(cmd)"},{"line_number":463,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMM%3D","line":461,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. No need to do a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":459,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":460,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":461,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" 1\""},{"line_number":462,"context_line":"        self.run_command(cmd)"},{"line_number":463,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2E%3D","line":461,"in_reply_to":"AAAAUH%2F%2BbMM%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":478,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":479,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":480,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true \""},{"line_number":481,"context_line":"        cmd \u003d cmd + \"--display-name vol 1\""},{"line_number":482,"context_line":"        self.run_command(cmd)"},{"line_number":483,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMI%3D","line":480,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. No need to do a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":478,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":479,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":480,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true \""},{"line_number":481,"context_line":"        cmd \u003d cmd + \"--display-name vol 1\""},{"line_number":482,"context_line":"        self.run_command(cmd)"},{"line_number":483,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba14%3D","line":480,"in_reply_to":"AAAAUH%2F%2BbMI%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":498,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":499,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":500,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true 1\""},{"line_number":501,"context_line":"        self.run_command(cmd)"},{"line_number":502,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbME%3D","line":500,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. No need to do a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":498,"context_line":"                    \u0027project_id\u0027: None,"},{"line_number":499,"context_line":"                    \u0027metadata\u0027: {}}}"},{"line_number":500,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true 1\""},{"line_number":501,"context_line":"        self.run_command(cmd)"},{"line_number":502,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba10%3D","line":500,"in_reply_to":"AAAAUH%2F%2BbME%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"}],"cinderclient/tests/v2/test_shell.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe85318ed39a9e3867b21c3945480038ecd8911a","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        cnt \u003d 3"},{"line_number":338,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":339,"context_line":"        self.run_command(cmd)"},{"line_number":340,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":341,"context_line":"                    \u0027availability_zone\u0027: None,"},{"line_number":342,"context_line":"                    \u0027source_volid\u0027: None,"},{"line_number":343,"context_line":"                    \u0027description\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp5c%3D","line":340,"updated":"2014-01-23 14:13:59.000000000","message":"As I mentioned in the code, I think it\u0027s confusing to just return the details of the last volume, rather than a summary, or all of them.","commit_id":"2b60e56d15abd78aa64a5df5c24076ded754f8fb"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes/1234/action\u0027, body\u003dexpected)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_create_volume(self):"},{"line_number":346,"context_line":"        cmd \u003d \"create --display-name vol 1\""},{"line_number":347,"context_line":"        self.run_command(cmd)"},{"line_number":348,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":349,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMA%3D","line":346,"updated":"2014-01-27 01:25:30.000000000","message":"Use --name instead. --display-name is deprecated in v2. Tests should encourage this as well.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes/1234/action\u0027, body\u003dexpected)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_create_volume(self):"},{"line_number":346,"context_line":"        cmd \u003d \"create --display-name vol 1\""},{"line_number":347,"context_line":"        self.run_command(cmd)"},{"line_number":348,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":349,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2w%3D","line":346,"in_reply_to":"AAAAUH%2F%2BbMA%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def test_create_volume_multi_format(self):"},{"line_number":384,"context_line":"        cmd \u003d \"create --multi-format true --display-name vol 1\""},{"line_number":385,"context_line":"        self.run_command(cmd)"},{"line_number":386,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":387,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbL8%3D","line":384,"updated":"2014-01-27 01:25:30.000000000","message":"Use --name instead. --display-name is deprecated in v2. Tests should encourage this as well.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def test_create_volume_multi_format(self):"},{"line_number":384,"context_line":"        cmd \u003d \"create --multi-format true --display-name vol 1\""},{"line_number":385,"context_line":"        self.run_command(cmd)"},{"line_number":386,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":387,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2s%3D","line":384,"in_reply_to":"AAAAUH%2F%2BbL8%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_create_multiple_volumes(self):"},{"line_number":422,"context_line":"        cnt \u003d 3"},{"line_number":423,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":424,"context_line":"        self.run_command(cmd)"},{"line_number":425,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbLw%3D","line":422,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three in cmd. There\u0027s no need to a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/volumes\u0027, body\u003dexpected)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_create_multiple_volumes(self):"},{"line_number":422,"context_line":"        cnt \u003d 3"},{"line_number":423,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":424,"context_line":"        self.run_command(cmd)"},{"line_number":425,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2o%3D","line":422,"in_reply_to":"AAAAUH%2F%2BbLw%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_create_multiple_volumes(self):"},{"line_number":422,"context_line":"        cnt \u003d 3"},{"line_number":423,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":424,"context_line":"        self.run_command(cmd)"},{"line_number":425,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":426,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbL4%3D","line":423,"updated":"2014-01-27 01:25:30.000000000","message":"Use --name instead. --display-name is deprecated in v2. Tests should encourage this as well.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_create_multiple_volumes(self):"},{"line_number":422,"context_line":"        cnt \u003d 3"},{"line_number":423,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --display-name vol 1\""},{"line_number":424,"context_line":"        self.run_command(cmd)"},{"line_number":425,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":426,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2k%3D","line":423,"in_reply_to":"AAAAUH%2F%2BbL4%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def test_create_multiple_volumes_without_name(self):"},{"line_number":442,"context_line":"        cnt \u003d 3"},{"line_number":443,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" 1\""},{"line_number":444,"context_line":"        self.run_command(cmd)"},{"line_number":445,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":446,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbLs%3D","line":443,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. there is no need to a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def test_create_multiple_volumes_without_name(self):"},{"line_number":442,"context_line":"        cnt \u003d 3"},{"line_number":443,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" 1\""},{"line_number":444,"context_line":"        self.run_command(cmd)"},{"line_number":445,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":446,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2g%3D","line":443,"in_reply_to":"AAAAUH%2F%2BbLs%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def test_create_multiple_volumes_multi_format(self):"},{"line_number":462,"context_line":"        cnt \u003d 3"},{"line_number":463,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true \""},{"line_number":464,"context_line":"        cmd \u003d cmd + \"--display-name vol 1\""},{"line_number":465,"context_line":"        self.run_command(cmd)"},{"line_number":466,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbLk%3D","line":463,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. there is no need to do a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def test_create_multiple_volumes_multi_format(self):"},{"line_number":462,"context_line":"        cnt \u003d 3"},{"line_number":463,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true \""},{"line_number":464,"context_line":"        cmd \u003d cmd + \"--display-name vol 1\""},{"line_number":465,"context_line":"        self.run_command(cmd)"},{"line_number":466,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2c%3D","line":463,"in_reply_to":"AAAAUH%2F%2BbLk%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def test_create_multiple_volumes_multi_format(self):"},{"line_number":462,"context_line":"        cnt \u003d 3"},{"line_number":463,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true \""},{"line_number":464,"context_line":"        cmd \u003d cmd + \"--display-name vol 1\""},{"line_number":465,"context_line":"        self.run_command(cmd)"},{"line_number":466,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":467,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbL0%3D","line":464,"updated":"2014-01-27 01:25:30.000000000","message":"Use --name instead. --display-name is deprecated in v2. Tests should encourage this as well.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def test_create_multiple_volumes_multi_format(self):"},{"line_number":462,"context_line":"        cnt \u003d 3"},{"line_number":463,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true \""},{"line_number":464,"context_line":"        cmd \u003d cmd + \"--display-name vol 1\""},{"line_number":465,"context_line":"        self.run_command(cmd)"},{"line_number":466,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":467,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2Y%3D","line":464,"in_reply_to":"AAAAUH%2F%2BbL0%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def test_create_multiple_volumes_multi_format_without_name(self):"},{"line_number":483,"context_line":"        cnt \u003d 3"},{"line_number":484,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true 1\""},{"line_number":485,"context_line":"        self.run_command(cmd)"},{"line_number":486,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":487,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbLg%3D","line":484,"updated":"2014-01-27 01:25:30.000000000","message":"just put in three. There is no need to do a conversion.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def test_create_multiple_volumes_multi_format_without_name(self):"},{"line_number":483,"context_line":"        cnt \u003d 3"},{"line_number":484,"context_line":"        cmd \u003d \"create --num-volumes \" + str(cnt) + \" --multi-format true 1\""},{"line_number":485,"context_line":"        self.run_command(cmd)"},{"line_number":486,"context_line":"        expected \u003d {\u0027volume\u0027: {\u0027status\u0027: \u0027creating\u0027,"},{"line_number":487,"context_line":"                    \u0027availability_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba2U%3D","line":484,"in_reply_to":"AAAAUH%2F%2BbLg%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"}],"cinderclient/tests/v2/test_volumes.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe85318ed39a9e3867b21c3945480038ecd8911a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_create_multiple_volumes(self):"},{"line_number":40,"context_line":"        cs.volumes.create(1, num_volumes\u003d2)"},{"line_number":41,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/volumes\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_attach(self):"},{"line_number":44,"context_line":"        v \u003d cs.volumes.get(\u00271234\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp5o%3D","line":41,"updated":"2014-01-23 14:13:59.000000000","message":"You can make this test stronger by passing the body\u003d parameter for the second call, and checking also calling assert_called_anytime with the body for the first call.","commit_id":"2b60e56d15abd78aa64a5df5c24076ded754f8fb"}],"cinderclient/v1/shell.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    \u0027--num-volumes\u0027,"},{"line_number":248,"context_line":"    metavar\u003d\u0027\u003cnum-volumes\u003e\u0027,"},{"line_number":249,"context_line":"    type\u003dint,"},{"line_number":250,"context_line":"    default\u003dNone,"},{"line_number":251,"context_line":"    help\u003d\u0027Create multiple volumes (Optional, Default\u003dNone)\u0027)"},{"line_number":252,"context_line":"@utils.arg(\u0027--multi-format\u0027,"},{"line_number":253,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbOg%3D","line":250,"updated":"2014-01-27 01:25:30.000000000","message":"Just make this default to one. Instead of checking None in other places, you can just have the code preform as normal with having to create one volume or multiple.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    \u0027--num-volumes\u0027,"},{"line_number":248,"context_line":"    metavar\u003d\u0027\u003cnum-volumes\u003e\u0027,"},{"line_number":249,"context_line":"    type\u003dint,"},{"line_number":250,"context_line":"    default\u003dNone,"},{"line_number":251,"context_line":"    help\u003d\u0027Create multiple volumes (Optional, Default\u003dNone)\u0027)"},{"line_number":252,"context_line":"@utils.arg(\u0027--multi-format\u0027,"},{"line_number":253,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba3g%3D","line":250,"in_reply_to":"AAAAUH%2F%2BbOg%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":253,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":254,"context_line":"           default\u003dFalse,"},{"line_number":255,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":256,"context_line":"                   \u0027after create , Default\u003dFalse)\u0027)"},{"line_number":257,"context_line":"@utils.arg("},{"line_number":258,"context_line":"    \u0027--availability-zone\u0027,"},{"line_number":259,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbOc%3D","line":256,"updated":"2014-01-27 01:25:30.000000000","message":"nit: don\u0027t think you meant to have a space between create and the comma.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":254,"context_line":"           default\u003dFalse,"},{"line_number":255,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":256,"context_line":"                   \u0027after create , Default\u003dFalse)\u0027)"},{"line_number":257,"context_line":"@utils.arg("},{"line_number":258,"context_line":"    \u0027--availability-zone\u0027,"},{"line_number":259,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba3c%3D","line":256,"in_reply_to":"AAAAUH%2F%2BbOc%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55f5213bd2f02a729729f6d54f311f85be759c76","unresolved":false,"context_lines":[{"line_number":253,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":254,"context_line":"           default\u003dFalse,"},{"line_number":255,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) creation output in\u0027"},{"line_number":256,"context_line":"           \u0027a table like cinder list rather than the default, verbose output.\u0027"},{"line_number":257,"context_line":"           \u0027Default\u003dFalse)\u0027)"},{"line_number":258,"context_line":"@utils.arg("},{"line_number":259,"context_line":"    \u0027--availability-zone\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BDXM%3D","line":256,"updated":"2014-01-30 16:41:31.000000000","message":"If you submit another patch I would change this slightly to:\n(Optional attribute to format volume(s) creation output in\u0027\n\u0027a table, like cinder list, rather than the default, verbose output.\u0027","commit_id":"03369a5ef0c29825a521ea481c2dff891c22c441"}],"cinderclient/v1/volumes.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    from urllib.parse import urlencode"},{"line_number":24,"context_line":"import six"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from six.moves import xrange"},{"line_number":27,"context_line":"from cinderclient import base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbN8%3D","line":26,"updated":"2014-01-27 01:25:30.000000000","message":"move this up with the import group above. http://docs.openstack.org/developer/hacking/#imports","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    from urllib.parse import urlencode"},{"line_number":24,"context_line":"import six"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from six.moves import xrange"},{"line_number":27,"context_line":"from cinderclient import base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba3w%3D","line":26,"in_reply_to":"AAAAUH%2F%2BbN8%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        volume_display_name \u003d display_name"},{"line_number":178,"context_line":"        if num_volumes is not None:"},{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":183,"context_line":"                                              \"--num-volumes.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbNo%3D","line":180,"updated":"2014-01-27 01:25:30.000000000","message":"Setting the arg to int and verifying it is an int is handled by argparse already.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        volume_display_name \u003d display_name"},{"line_number":178,"context_line":"        if num_volumes is not None:"},{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":183,"context_line":"                                              \"--num-volumes.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba1c%3D","line":180,"in_reply_to":"AAAAUH%2F%2BbNo%3D","updated":"2014-01-27 04:33:09.000000000","message":"I added this extra check for places where cinderclient is used as library not cli client. then num_volumes need to be checked.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":183,"context_line":"                                              \"--num-volumes.\")"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbN0%3D","line":182,"updated":"2014-01-27 01:25:30.000000000","message":"nit: remove extra space after for.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":183,"context_line":"                                              \"--num-volumes.\")"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba3s%3D","line":182,"in_reply_to":"AAAAUH%2F%2BbN0%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                              \"--num-volumes.\")"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        volumes \u003d []"},{"line_number":186,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":187,"context_line":"            if int(volume_count) \u003e 1 and display_name is not None:"},{"line_number":188,"context_line":"                display_name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":189,"context_line":"            body \u003d {\u0027volume\u0027: {\u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMg%3D","line":186,"updated":"2014-01-27 01:25:30.000000000","message":"volume_count is already an int.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                              \"--num-volumes.\")"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        volumes \u003d []"},{"line_number":186,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":187,"context_line":"            if int(volume_count) \u003e 1 and display_name is not None:"},{"line_number":188,"context_line":"                display_name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":189,"context_line":"            body \u003d {\u0027volume\u0027: {\u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba3o%3D","line":186,"in_reply_to":"AAAAUH%2F%2BbMg%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        volumes \u003d []"},{"line_number":186,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":187,"context_line":"            if int(volume_count) \u003e 1 and display_name is not None:"},{"line_number":188,"context_line":"                display_name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":189,"context_line":"            body \u003d {\u0027volume\u0027: {\u0027size\u0027: size,"},{"line_number":190,"context_line":"                               \u0027snapshot_id\u0027: snapshot_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMk%3D","line":187,"updated":"2014-01-27 01:25:30.000000000","message":"volume_count is already an int.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        volumes \u003d []"},{"line_number":186,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":187,"context_line":"            if int(volume_count) \u003e 1 and display_name is not None:"},{"line_number":188,"context_line":"                display_name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":189,"context_line":"            body \u003d {\u0027volume\u0027: {\u0027size\u0027: size,"},{"line_number":190,"context_line":"                               \u0027snapshot_id\u0027: snapshot_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba3k%3D","line":187,"in_reply_to":"AAAAUH%2F%2BbMk%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"871c530fe31bd0dc75ca2ed8912e724bf0cd589d","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                hints[key] \u003d value"},{"line_number":289,"context_line":"    #NOTE(N.S.): end of the taken piece"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    volume \u003d cs.volumes.create(args.size,"},{"line_number":292,"context_line":"                               args.snapshot_id,"},{"line_number":293,"context_line":"                               args.source_volid,"},{"line_number":294,"context_line":"                               args.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FwPA%3D","line":291,"updated":"2014-01-02 10:31:47.000000000","message":"volume returned from cs.volumes.create() is totally different when num-volumes \u003e1.","commit_id":"71034d3c83bdaa985dd8ee6d712ab88b123eeb0a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":240,"context_line":"@utils.arg(\u0027--num-volumes\u0027,"},{"line_number":241,"context_line":"           metavar\u003d\u0027\u003cnum-volumes\u003e\u0027,"},{"line_number":242,"context_line":"           type\u003dint,"},{"line_number":243,"context_line":"           default\u003dNone,"},{"line_number":244,"context_line":"           help\u003d\u0027Create multiple volumes (Optional, Default\u003dNone)\u0027)"},{"line_number":245,"context_line":"@utils.arg(\u0027--multi-format\u0027,"},{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbM0%3D","line":243,"updated":"2014-01-27 01:25:30.000000000","message":"Just make this default to one. Instead of checking None in other places, you can just have the code preform as normal with having to create one volume or multiple.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"@utils.arg(\u0027--num-volumes\u0027,"},{"line_number":241,"context_line":"           metavar\u003d\u0027\u003cnum-volumes\u003e\u0027,"},{"line_number":242,"context_line":"           type\u003dint,"},{"line_number":243,"context_line":"           default\u003dNone,"},{"line_number":244,"context_line":"           help\u003d\u0027Create multiple volumes (Optional, Default\u003dNone)\u0027)"},{"line_number":245,"context_line":"@utils.arg(\u0027--multi-format\u0027,"},{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba34%3D","line":243,"in_reply_to":"AAAAUH%2F%2BbM0%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":247,"context_line":"           default\u003dFalse,"},{"line_number":248,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":249,"context_line":"                   \u0027after create , Default\u003dFalse)\u0027)"},{"line_number":250,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":251,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":252,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMw%3D","line":249,"updated":"2014-01-27 01:25:30.000000000","message":"nit: don\u0027t think you meant to have a space between create and the comma.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":247,"context_line":"           default\u003dFalse,"},{"line_number":248,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":249,"context_line":"                   \u0027after create , Default\u003dFalse)\u0027)"},{"line_number":250,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":251,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":252,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba30%3D","line":249,"in_reply_to":"AAAAUH%2F%2BbMw%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"12aadac74543a8c9b35b8fa5b5c94de94340f13b","unresolved":false,"context_lines":[{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":247,"context_line":"           default\u003dFalse,"},{"line_number":248,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":249,"context_line":"                   \u0027after create, Default\u003dFalse)\u0027)"},{"line_number":250,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":251,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":252,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BJh8%3D","line":249,"updated":"2014-01-29 17:54:25.000000000","message":"This help text is confusing to me.  Do you mean \u0027Optional attribute to display created volume(s) output.\"","commit_id":"baa1fdced25004901bac1d4bd84ebda0f97908af"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8af42fd9ca4b3623a592ca1a8831c7e8901cd001","unresolved":false,"context_lines":[{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":247,"context_line":"           default\u003dFalse,"},{"line_number":248,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":249,"context_line":"                   \u0027after create, Default\u003dFalse)\u0027)"},{"line_number":250,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":251,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":252,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BI18%3D","line":249,"in_reply_to":"AAAAUH%2F%2BJh8%3D","updated":"2014-01-29 19:49:44.000000000","message":"I think a different name would be needed for the option.  Perhaps --pretty-print or something like that.  The make the help text be something like \"Optional attribute to format volume(s) creation output in a table like \u0027cinder list\u0027 rather than the default, verbose output.\"","commit_id":"baa1fdced25004901bac1d4bd84ebda0f97908af"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"12aadac74543a8c9b35b8fa5b5c94de94340f13b","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                                metadata\u003dvolume_metadata,"},{"line_number":308,"context_line":"                                scheduler_hints\u003dhints)"},{"line_number":309,"context_line":"    if args.num_volumes \u003d\u003d 1:"},{"line_number":310,"context_line":"        volumes \u003d [volumes]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    if strutils.bool_from_string(args.multi_format) is True:"},{"line_number":313,"context_line":"        utils.print_list(volumes, [\u0027ID\u0027, \u0027Status\u0027, \u0027Name\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BJcY%3D","line":310,"updated":"2014-01-29 17:54:25.000000000","message":"Seems like we need some bounds checking on args.num_volumes.  I.E. making sure it is 1 or more.  Not sure would would happen with negative values, etc.","commit_id":"baa1fdced25004901bac1d4bd84ebda0f97908af"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0bc3f5037bac9045eb175755688282f8630ea3ad","unresolved":false,"context_lines":[{"line_number":244,"context_line":"           help\u003d\u0027Create multiple volumes (Optional, Default\u003dNone)\u0027)"},{"line_number":245,"context_line":"@utils.arg(\u0027--multi-format\u0027,"},{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":247,"context_line":"           default\u003dFalse,"},{"line_number":248,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) output \u0027"},{"line_number":249,"context_line":"                   \u0027after create, Default\u003dFalse)\u0027)"},{"line_number":250,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BI0o%3D","line":247,"updated":"2014-01-29 19:52:55.000000000","message":"It\u0027s already known to be optional since it starts with \"--\".\n\nThis description should say something like \"Format volume(s) output into a single table\" or something.  (But let\u0027s decide on the name of the arg before that, which I think shouldn\u0027t be \"multi-format\".)","commit_id":"4d070302160bc01e783560ceebbb78ceb2adcebe"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55f5213bd2f02a729729f6d54f311f85be759c76","unresolved":false,"context_lines":[{"line_number":246,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":247,"context_line":"           default\u003dFalse,"},{"line_number":248,"context_line":"           help\u003d\u0027 (Optional attribute to format volume(s) creation output in\u0027"},{"line_number":249,"context_line":"           \u0027a table like cinder list rather than the default, verbose output.\u0027"},{"line_number":250,"context_line":"           \u0027Default\u003dFalse)\u0027)"},{"line_number":251,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"},{"line_number":252,"context_line":"           metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BDXA%3D","line":249,"updated":"2014-01-30 16:41:31.000000000","message":"If you submit another patch I would change this slightly to: (Optional attribute to format volume(s) creation output in\u0027 \u0027a table, like cinder list, rather than the default, verbose output.\u0027","commit_id":"03369a5ef0c29825a521ea481c2dff891c22c441"}],"cinderclient/v2/volumes.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"871c530fe31bd0dc75ca2ed8912e724bf0cd589d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                               \u0027scheduler_hints\u0027: scheduler_hints,"},{"line_number":203,"context_line":"                               }}"},{"line_number":204,"context_line":"            volume \u003d self._create(\u0027/volumes\u0027, body, \u0027volume\u0027)"},{"line_number":205,"context_line":"        return volume"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get(self, volume_id):"},{"line_number":208,"context_line":"        \"\"\"Get a volume."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FwPM%3D","line":205,"updated":"2014-01-02 10:31:47.000000000","message":"volume here is either the last of all requested volumes.","commit_id":"71034d3c83bdaa985dd8ee6d712ab88b123eeb0a"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe85318ed39a9e3867b21c3945480038ecd8911a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        volume_count \u003d 1"},{"line_number":174,"context_line":"        volume_display_name \u003d None"},{"line_number":175,"context_line":"        if num_volumes is not None:"},{"line_number":176,"context_line":"            volume_count \u003d num_volumes"},{"line_number":177,"context_line":"            if name is None:"},{"line_number":178,"context_line":"                volume_display_name \u003d time.strftime(\"%Y%m%d%H%M%S\","},{"line_number":179,"context_line":"                                                    time.gmtime())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp78%3D","line":176,"updated":"2014-01-23 14:13:59.000000000","message":"Check that num_volumes is an int that\u0027s greater than 0?","commit_id":"2b60e56d15abd78aa64a5df5c24076ded754f8fb"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe85318ed39a9e3867b21c3945480038ecd8911a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if num_volumes is not None:"},{"line_number":176,"context_line":"            volume_count \u003d num_volumes"},{"line_number":177,"context_line":"            if name is None:"},{"line_number":178,"context_line":"                volume_display_name \u003d time.strftime(\"%Y%m%d%H%M%S\","},{"line_number":179,"context_line":"                                                    time.gmtime())"},{"line_number":180,"context_line":"            else:"},{"line_number":181,"context_line":"                volume_display_name \u003d name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp64%3D","line":178,"updated":"2014-01-23 14:13:59.000000000","message":"I don\u0027t know about this...I think if no name is passed, all volumes should have no name.","commit_id":"2b60e56d15abd78aa64a5df5c24076ded754f8fb"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe85318ed39a9e3867b21c3945480038ecd8911a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            else:"},{"line_number":181,"context_line":"                volume_display_name \u003d name"},{"line_number":182,"context_line":"        else:"},{"line_number":183,"context_line":"            num_volumes \u003d 1"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        for x in range(1, int(volume_count) + 1):"},{"line_number":186,"context_line":"            if int(volume_count) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp8M%3D","line":183,"updated":"2014-01-23 14:13:59.000000000","message":"What\u0027s this for?","commit_id":"2b60e56d15abd78aa64a5df5c24076ded754f8fb"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe85318ed39a9e3867b21c3945480038ecd8911a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                               \u0027scheduler_hints\u0027: scheduler_hints,"},{"line_number":203,"context_line":"                               }}"},{"line_number":204,"context_line":"            volume \u003d self._create(\u0027/volumes\u0027, body, \u0027volume\u0027)"},{"line_number":205,"context_line":"        return volume"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get(self, volume_id):"},{"line_number":208,"context_line":"        \"\"\"Get a volume."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bp7U%3D","line":205,"updated":"2014-01-23 14:13:59.000000000","message":"Is it correct to return just the last volume?  I think a summary of IDs and successes/failures would make more sense.","commit_id":"2b60e56d15abd78aa64a5df5c24076ded754f8fb"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a077bc6506dfe7e7410aa2c10e9e50375f0c2655","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                              \"--num-volumes. \")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"},{"line_number":182,"context_line":"        for x in range(1, int(volume_count) + 1):"},{"line_number":183,"context_line":"            if int(volume_count) \u003e 1 and name is not None:"},{"line_number":184,"context_line":"                name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BdwU%3D","line":182,"updated":"2014-01-25 18:44:24.000000000","message":"There\u0027s work that\u0027s begun to modify range for PY3 compat, we should look at that now with new code rather than coming back and changing it later.","commit_id":"a89489abb02e524ca59cdcf444b3fe8783c773f2"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    from urllib.parse import urlencode"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from six.moves import xrange"},{"line_number":25,"context_line":"from cinderclient import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbNA%3D","line":24,"updated":"2014-01-27 01:25:30.000000000","message":"move this up with the import group above. http://docs.openstack.org/developer/hacking/#imports","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    from urllib.parse import urlencode"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from six.moves import xrange"},{"line_number":25,"context_line":"from cinderclient import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba4Y%3D","line":24,"in_reply_to":"AAAAUH%2F%2BbNA%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        volume_display_name \u003d name"},{"line_number":174,"context_line":"        if num_volumes is not None:"},{"line_number":175,"context_line":"            try:"},{"line_number":176,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":177,"context_line":"            except Exception:"},{"line_number":178,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":179,"context_line":"                                              \"--num-volumes. \")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbM8%3D","line":176,"updated":"2014-01-27 01:25:30.000000000","message":"Setting the arg to int and verifying it is an int is handled by argparse already.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        volume_display_name \u003d name"},{"line_number":174,"context_line":"        if num_volumes is not None:"},{"line_number":175,"context_line":"            try:"},{"line_number":176,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":177,"context_line":"            except Exception:"},{"line_number":178,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":179,"context_line":"                                              \"--num-volumes. \")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba4c%3D","line":176,"in_reply_to":"AAAAUH%2F%2BbM8%3D","updated":"2014-01-27 04:33:09.000000000","message":"I added this extra check for places where cinderclient is used as library not cli client. then num_volumes need to be checked.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            try:"},{"line_number":176,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":177,"context_line":"            except Exception:"},{"line_number":178,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":179,"context_line":"                                              \"--num-volumes. \")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbM4%3D","line":178,"updated":"2014-01-27 01:25:30.000000000","message":"nit: remove extra space after for.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            try:"},{"line_number":176,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":177,"context_line":"            except Exception:"},{"line_number":178,"context_line":"                raise exceptions.CommandError(\"Invalid integer value for  \""},{"line_number":179,"context_line":"                                              \"--num-volumes. \")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba4o%3D","line":178,"in_reply_to":"AAAAUH%2F%2BbM4%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                              \"--num-volumes. \")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"},{"line_number":182,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":183,"context_line":"            if int(volume_count) \u003e 1 and name is not None:"},{"line_number":184,"context_line":"                name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMo%3D","line":182,"updated":"2014-01-27 01:25:30.000000000","message":"volume_count is already an int.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                              \"--num-volumes. \")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"},{"line_number":182,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":183,"context_line":"            if int(volume_count) \u003e 1 and name is not None:"},{"line_number":184,"context_line":"                name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba4k%3D","line":182,"in_reply_to":"AAAAUH%2F%2BbMo%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"76bafab57b35ebd69ef3ab0fb2a7068d72eb3cf6","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"},{"line_number":182,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":183,"context_line":"            if int(volume_count) \u003e 1 and name is not None:"},{"line_number":184,"context_line":"                name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"            body \u003d {\u0027volume\u0027: {\u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BbMs%3D","line":183,"updated":"2014-01-27 01:25:30.000000000","message":"volume_count is already an int.","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"change_message_id":"2849fa7e6431806492c5c567666e8a3688032c1c","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        volumes \u003d []"},{"line_number":182,"context_line":"        for x in xrange(1, int(volume_count) + 1):"},{"line_number":183,"context_line":"            if int(volume_count) \u003e 1 and name is not None:"},{"line_number":184,"context_line":"                name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"            body \u003d {\u0027volume\u0027: {\u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Ba4g%3D","line":183,"in_reply_to":"AAAAUH%2F%2BbMs%3D","updated":"2014-01-27 04:33:09.000000000","message":"Done","commit_id":"54034db7e269a696fa7a92dea644659581027bbc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"12aadac74543a8c9b35b8fa5b5c94de94340f13b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                raise ValueError(\"Invalid integer value --num-volumes.\")"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        volumes \u003d []"},{"line_number":181,"context_line":"        for x in xrange(1, volume_count + 1):"},{"line_number":182,"context_line":"            if volume_count \u003e 1 and name is not None:"},{"line_number":183,"context_line":"                name \u003d volume_display_name + \"-\" + str(x)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BJeY%3D","line":181,"updated":"2014-01-29 17:54:25.000000000","message":"This doesn\u0027t seem right.  Should this just be xrange(1, volume_count) .  Otherwise, if the user inputs 3 they are going to get volume-1, volume-2, volume-3 and volume-4.","commit_id":"baa1fdced25004901bac1d4bd84ebda0f97908af"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"05cdc47f5b6413ea583740e1d851f790fed03bd6","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if num_volumes is not None:"},{"line_number":175,"context_line":"            try:"},{"line_number":176,"context_line":"                volume_count \u003d int(num_volumes)"},{"line_number":177,"context_line":"            except Exception:"},{"line_number":178,"context_line":"                raise ValueError(\"Invalid integer value --num-volumes.\")"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BIts%3D","line":177,"updated":"2014-01-29 20:09:17.000000000","message":"This should be except ValueError rather than Exception.","commit_id":"4d070302160bc01e783560ceebbb78ceb2adcebe"}]}